r19283@catbus: nickm | 2008-04-09 21:44:18 -0400

The optimist calls the glass half full.  The pessimist calls it half empty.  The engineer says it is twice as large as it needs to be.  In this case, the engineer says that the default smartlist size is twice as large as it needs to be and wouldn't it be nice to save half a megabyte with a one-line patch?


svn:r14341

ChangeLog

@@ -26,6 +26,8 @@ Changes in version 0.2.1.1-alpha - 2008-??-??
     - Make relay cells written on a connection count as non-padding when
       tracking how long a connection has been in use. Bugfix on
       0.2.0.1-alpha.  Spotted by lodger.
+    - Reduce the default smartlist size from 32 to 16; it turns out that
+      most smartlists hold around 8-12 elements tops.
 
   o Minor features:
     - Allow separate log levels to be configured for different logging

src/common/container.c

@@ -30,7 +30,7 @@ const char container_c_id[] =
 #include "ht.h"
 
 /** All newly allocated smartlists have this capacity. */
-#define SMARTLIST_DEFAULT_CAPACITY 32
+#define SMARTLIST_DEFAULT_CAPACITY 16
 
 /** Allocate and return an empty smartlist.
  */