nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-30 15:43:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean up a clangalyzer warning in directory_remove_invalid

Browse Source 
"At this point in the code, msg has been set to a string
constant. But the tor code checks that msg is not NULL, and the
redundant NULL check confuses the analyser[...] To avoid this
spurious warning, the patch initialises msg to NULL."

Patch from teor. another part of 13157.
This commit is contained in:
Nick Mathewson 2014-09-15 13:52:56 -04:00
parent 53a94c4b4b
commit 1dc0d26b50
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/or/dirserv.c
View File

@ -664,7 +664,7 @@ directory_remove_invalid(void)
smartlist_add_all(nodes, nodelist_get_list()); smartlist_add_all(nodes, nodelist_get_list());
SMARTLIST_FOREACH_BEGIN(nodes, node_t *, node) { SMARTLIST_FOREACH_BEGIN(nodes, node_t *, node) {
const char *msg; const char *msg = NULL;
routerinfo_t *ent = node->ri; routerinfo_t *ent = node->ri;
char description[NODE_DESC_BUF_LEN]; char description[NODE_DESC_BUF_LEN];
uint32_t r; uint32_t r;