nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 06:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential null pointer deref during dirvote

Browse Source 
Found by using clang's analyzer.
This commit is contained in:
Sebastian Hahn 2011-04-26 04:38:55 +02:00 committed by Nick Mathewson
parent 1827e60976
commit 1c668540fe
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
changes/dirvote_null_deref Normal file
View File

@ -0,0 +1,4 @@
o Minor bugfixes:
- Fix a potential null-pointer dereference while computing a consensus.
Bugfix on tor-0.2.0.3-alpha, found with the help of clang's analyzer.

6
src/or/dirvote.c
View File

@ -444,9 +444,9 @@ compute_routerstatus_consensus(smartlist_t *votes, int consensus_method,
if (cur && !compare_vote_rs(cur, rs)) {
++cur_n;
} else {
if (cur_n > most_n ||
(cur && cur_n == most_n &&
cur->status.published_on > most_published)) {
if (cur && (cur_n > most_n ||
(cur_n == most_n &&
cur->status.published_on > most_published))) {
most = cur;
most_n = cur_n;
most_published = cur->status.published_on;