Merge remote-tracking branch 'public/bug16013_025' into maint-0.2.6

This commit is contained in:
Nick Mathewson 2015-06-25 11:14:44 -04:00
commit 1c1d71fe1a
2 changed files with 17 additions and 0 deletions

5
changes/bug16013 Normal file
View File

@ -0,0 +1,5 @@
o Major bugfixes (hidden service, stability):
- Stop randomly crashing with an assertion failure when connecting to a
busy hidden service, or connecting to a hidden service while a NEWNYM
is in progress. Fixes bug 16013; bugfix on 0.1.0.1-rc.

View File

@ -2406,6 +2406,18 @@ connection_ap_handshake_attach_circuit(entry_connection_t *conn)
return 1;
}
/* At this point we need to re-check the state, since it's possible that
* our call to circuit_get_open_circ_or_launch() changed the connection's
* state from "CIRCUIT_WAIT" to "RENDDESC_WAIT" because we decided to
* re-fetch the descriptor.
*/
if (ENTRY_TO_CONN(conn)->state != AP_CONN_STATE_CIRCUIT_WAIT) {
log_info(LD_REND, "This connection is no longer ready to attach; its "
"state changed."
"(We probably have to re-fetch its descriptor.)");
return 0;
}
if (rendcirc && (rendcirc->base_.purpose ==
CIRCUIT_PURPOSE_C_REND_READY_INTRO_ACKED)) {
log_info(LD_REND,