connection_t kept the identity_pkey but all it did was store it and

free it. perhaps we don't need it after all?


svn:r6518
This commit is contained in:
Roger Dingledine 2006-05-30 06:23:44 +00:00
parent 9000a5aff1
commit 1bf0f99b66
3 changed files with 2 additions and 6 deletions

View File

@ -224,8 +224,6 @@ _connection_free(connection_t *conn)
} }
} }
if (conn->identity_pkey)
crypto_free_pk_env(conn->identity_pkey);
tor_free(conn->nickname); tor_free(conn->nickname);
tor_free(conn->socks_request); tor_free(conn->socks_request);
tor_free(conn->incoming_cmd); tor_free(conn->incoming_cmd);

View File

@ -319,7 +319,6 @@ connection_or_init_conn_from_router(connection_t *conn, routerinfo_t *router)
conn->addr = router->addr; conn->addr = router->addr;
conn->port = router->or_port; conn->port = router->or_port;
conn->receiver_bucket = conn->bandwidth = (int)options->BandwidthBurst; conn->receiver_bucket = conn->bandwidth = (int)options->BandwidthBurst;
conn->identity_pkey = crypto_pk_dup_key(router->identity_pkey);
connection_or_set_identity_digest(conn, router->cache_info.identity_digest); connection_or_set_identity_digest(conn, router->cache_info.identity_digest);
conn->nickname = tor_strdup(router->nickname); conn->nickname = tor_strdup(router->nickname);
tor_free(conn->address); tor_free(conn->address);

View File

@ -652,9 +652,8 @@ struct connection_t {
char *address; /**< FQDN (or IP) of the guy on the other end. char *address; /**< FQDN (or IP) of the guy on the other end.
* strdup into this, because free_connection frees it. * strdup into this, because free_connection frees it.
*/ */
crypto_pk_env_t *identity_pkey; /**< Public RSA key for the other side's char identity_digest[DIGEST_LEN]; /**< Hash of the public RSA key for
* signing key. */ * the other side's signing key. */
char identity_digest[DIGEST_LEN]; /**< Hash of identity_pkey */
char *nickname; /**< Nickname of OR on other side (if any). */ char *nickname; /**< Nickname of OR on other side (if any). */
/** Nickname of planned exit node -- used with .exit support. */ /** Nickname of planned exit node -- used with .exit support. */