From 1b25794a56654e115fa46ac9bfc6334753f6dda1 Mon Sep 17 00:00:00 2001 From: Roger Dingledine Date: Wed, 25 Feb 2004 06:57:57 +0000 Subject: [PATCH] bugfix: if the exit stream is pending on the resolve, and a destroy arrives, then the stream wasn't getting removed from the pending list. this may have been the lucky-bug. this commit may also not actually fix the bug. it's darn hard to reproduce. svn:r1122 --- src/or/connection.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/or/connection.c b/src/or/connection.c index 2644a60e65..7c51558d21 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -682,6 +682,10 @@ int connection_send_destroy(uint16_t circ_id, connection_t *conn) { if(!connection_speaks_cells(conn)) { log_fn(LOG_INFO,"CircID %d: At an edge. Marking connection for close.", circ_id); + if(conn->type == CONN_TYPE_EXIT && conn->state == EXIT_CONN_STATE_RESOLVING) { + log_fn(LOG_INFO,"...and informing resolver we don't want the answer anymore."); + dns_cancel_pending_resolve(conn->address, conn); + } if(connection_edge_end(conn, END_STREAM_REASON_DESTROY, conn->cpath_layer) < 0) log_fn(LOG_WARN,"1: I called connection_edge_end redundantly."); /* if they already sent a destroy, they know. XXX can just close? */