nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

practracker: replaces "overstrict" with "overbroad"

Browse Source 
I had the logic reversed here.
This commit is contained in:
Nick Mathewson 2019-08-01 09:35:33 -04:00
parent 3221dc1b32
commit 19536fd18d
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
changes/ticket30752
View File

@ -1,6 +1,6 @@
o Minor features (best practices tracker): o Minor features (best practices tracker):
- Give a warning rather than an error when a practracker exception is - Give a warning rather than an error when a practracker exception is
violated by a small amount; add a --list-overstrict option to violated by a small amount; add a --list-overbroad option to
practracker that lists exceptions that are stricter than they need to practracker that lists exceptions that are stricter than they need to
be, and provide an environment variable for disabling be, and provide an environment variable for disabling
practracker. Closes ticekt 30752. practracker. Closes ticekt 30752.

8
scripts/maint/practracker/practracker.py
View File

@ -153,7 +153,7 @@ def main(argv):
parser = argparse.ArgumentParser(prog=progname) parser = argparse.ArgumentParser(prog=progname)
parser.add_argument("--regen", action="store_true", parser.add_argument("--regen", action="store_true",
help="Regenerate the exceptions file") help="Regenerate the exceptions file")
parser.add_argument("--list-overstrict", action="store_true", parser.add_argument("--list-overbroad", action="store_true",
help="List over-strict exceptions") help="List over-strict exceptions")
parser.add_argument("--exceptions", parser.add_argument("--exceptions",
help="Override the location for the exceptions file") help="Override the location for the exceptions file")
@ -200,7 +200,7 @@ def main(argv):
# 2.1) Adjust the exceptions so that we warn only about small problems, # 2.1) Adjust the exceptions so that we warn only about small problems,
# and produce errors on big ones. # and produce errors on big ones.
if not (args.regen or args.list_overstrict or args.strict): if not (args.regen or args.list_overbroad or args.strict):
ProblemVault.set_tolerances(TOLERANCE_FNS) ProblemVault.set_tolerances(TOLERANCE_FNS)
# 3) Go through all the files and report problems if they are not exceptions # 3) Go through all the files and report problems if they are not exceptions
@ -234,10 +234,10 @@ variable.
""".format(found_new_issues, exceptions_file) """.format(found_new_issues, exceptions_file)
print(new_issues_str) print(new_issues_str)
if args.list_overstrict: if args.list_overbroad:
def k_fn(tup): def k_fn(tup):
return tup[0].key() return tup[0].key()
for (ex,p) in sorted(ProblemVault.list_overstrict_exceptions(), key=k_fn): for (ex,p) in sorted(ProblemVault.list_overbroad_exceptions(), key=k_fn):
if p is None: if p is None:
print(ex, "->", 0) print(ex, "->", 0)
else: else:

2
scripts/maint/practracker/problem.py
View File

@ -82,7 +82,7 @@ class ProblemVault(object):
return status return status
def list_overstrict_exceptions(self): def list_overbroad_exceptions(self):
"""Return an iterator of tuples containing (ex,prob) where ex is an """Return an iterator of tuples containing (ex,prob) where ex is an
exceptions in this vault that are stricter than it needs to be, and exceptions in this vault that are stricter than it needs to be, and
prob is the worst problem (if any) that it covered. prob is the worst problem (if any) that it covered.