nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 12:23:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

HEX_ERRNO_SIZE is no longer the correct upper limit for format_hex_number_sigsafe

Browse Source
This commit is contained in:
Nick Mathewson 2013-07-15 12:39:47 -04:00
parent 22977b7c1d
commit 18136afbbb
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/test/test_util.c
View File

@ -2634,7 +2634,7 @@ static void
test_util_format_hex_number(void *ptr) test_util_format_hex_number(void *ptr)
{ {
int i, len; int i, len;
char buf[HEX_ERRNO_SIZE + 1]; char buf[33];
const struct { const struct {
const char *str; const char *str;
unsigned int x; unsigned int x;
@ -2643,6 +2643,7 @@ test_util_format_hex_number(void *ptr)
{"1", 1}, {"1", 1},
{"273A", 0x273a}, {"273A", 0x273a},
{"FFFF", 0xffff}, {"FFFF", 0xffff},
#if UINT_MAX >= 0xffffffff #if UINT_MAX >= 0xffffffff
{"31BC421D", 0x31bc421d}, {"31BC421D", 0x31bc421d},
{"FFFFFFFF", 0xffffffff}, {"FFFFFFFF", 0xffffffff},
@ -2653,7 +2654,7 @@ test_util_format_hex_number(void *ptr)
(void)ptr; (void)ptr;
for (i = 0; test_data[i].str != NULL; ++i) { for (i = 0; test_data[i].str != NULL; ++i) {
len = format_hex_number_sigsafe(test_data[i].x, buf, HEX_ERRNO_SIZE); len = format_hex_number_sigsafe(test_data[i].x, buf, 32);
test_neq(len, 0); test_neq(len, 0);
buf[len] = '\0'; buf[len] = '\0';
test_streq(buf, test_data[i].str); test_streq(buf, test_data[i].str);