Merge remote-tracking branch 'tor-github/pr/727' into maint-0.3.5

This commit is contained in:
teor 2019-03-19 15:43:05 +10:00
commit 17e3eea685
No known key found for this signature in database
GPG Key ID: 10FEAA0E7075672A
2 changed files with 8 additions and 3 deletions

5
changes/bug29530_035 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (testing):
- Downgrade some LOG_ERR messages in the address/* tests to warnings.
The LOG_ERR messages were occurring when we had no configured network.
We were failing the unit tests, because we backported 28668 to 0.3.5.8,
but did not backport 29530. Fixes bug 29530; bugfix on 0.3.5.8.

View File

@ -744,7 +744,7 @@ test_address_get_if_addrs_list_internal(void *arg)
(void)arg; (void)arg;
results = get_interface_address_list(LOG_ERR, 1); results = get_interface_address_list(LOG_WARN, 1);
tt_ptr_op(results, OP_NE, NULL); tt_ptr_op(results, OP_NE, NULL);
/* When the network is down, a system might not have any non-local /* When the network is down, a system might not have any non-local
@ -775,7 +775,7 @@ test_address_get_if_addrs_list_no_internal(void *arg)
(void)arg; (void)arg;
results = get_interface_address_list(LOG_ERR, 0); results = get_interface_address_list(LOG_WARN, 0);
tt_ptr_op(results, OP_NE, NULL); tt_ptr_op(results, OP_NE, NULL);
/* Work even on systems with only internal IPv4 addresses */ /* Work even on systems with only internal IPv4 addresses */
@ -986,7 +986,7 @@ test_address_get_if_addrs(void *arg)
(void)arg; (void)arg;
rv = get_interface_address(LOG_ERR, &addr_h); rv = get_interface_address(LOG_WARN, &addr_h);
/* When the network is down, a system might not have any non-local /* When the network is down, a system might not have any non-local
* non-multicast IPv4 addresses, not even internal ones. * non-multicast IPv4 addresses, not even internal ones.