nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

guards_choose_dirguard(): replace one XXXX with another.

Browse Source 
I had been asking myself, "hey, doesn't the new code need to look at
this "info" parameter? The old code did!"  But it turns out that the
old code hasn't, since 05f7336624.

So instead of "support this!" the comment now says "we can remove
this!"
This commit is contained in:
Nick Mathewson 2016-11-30 07:51:40 -05:00
parent 9d065ecc3d
commit 17c3faa2e3
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/or/entrynodes.c
View File

@ -4779,7 +4779,13 @@ guards_choose_dirguard(dirinfo_type_t info,
if (get_options()->UseDeprecatedGuardAlgorithm) { if (get_options()->UseDeprecatedGuardAlgorithm) {
return choose_random_dirguard(info); return choose_random_dirguard(info);
} else { } else {
// XXXX prop271 look at info? /* XXXX prop271 We don't need to look at the dirinfo_type_t here,
* apparently. If you look at the old implementation, and you follow info
* downwards through choose_random_dirguard(), into
* choose_random_entry_impl(), into populate_live_entry_guards()... you
* find out that it isn't even used, and hasn't been since 0.2.7.1-alpha,
* when we realized that every Tor on the network would support
* microdescriptors. -NM */
const node_t *r = NULL; const node_t *r = NULL;
if (entry_guard_pick_for_circuit(get_guard_selection_info(), if (entry_guard_pick_for_circuit(get_guard_selection_info(),
&r, &r,