nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Do not leak the DNS server port structure.

Browse Source 
svn:r17680
This commit is contained in:
Nick Mathewson 2008-12-18 15:00:18 +00:00
parent 4911ec627b
commit 148e4e8837
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/or/eventdns.c
View File

@ -1598,9 +1598,9 @@ evdns_add_server_port(int socket, int is_tcp, evdns_request_callback_fn_type cb,
void void
evdns_close_server_port(struct evdns_server_port *port) evdns_close_server_port(struct evdns_server_port *port)
{ {
port->closing = 1;
if (--port->refcnt == 0) if (--port->refcnt == 0)
server_port_free(port); server_port_free(port);
port->closing = 1;
} }
/* exported function */ /* exported function */
@ -1943,7 +1943,8 @@ server_request_free(struct server_request *req)
return (0); return (0);
} }
/* Free all storage held by an evdns_server_port. Only called when */ /* Free all storage held by an evdns_server_port. Only called when the
* reference count is down to 0. */
static void static void
server_port_free(struct evdns_server_port *port) server_port_free(struct evdns_server_port *port)
{ {
@ -1956,8 +1957,8 @@ server_port_free(struct evdns_server_port *port)
} }
(void) event_del(&port->event); (void) event_del(&port->event);
CLEAR(&port->event); CLEAR(&port->event);
/* XXXX021 actually free the port? -NM */ CLEAR(port);
/* XXXX yes, and fix up evdns_close_server_port to dtrt. -NM */ free(port);
} }
/* exported function */ /* exported function */