Remove unnecessary non-fatal assertion.

This patch removes a call to `tor_assert_nonfatal()` if
`extend_info_from_node()` returns NULL. This is unnecessary as we
already handle the case where `info` is NULL in the next `if (!info) {
... }` block in the code.

See: tor#32666.
This commit is contained in:
Alexander Færøy 2021-01-19 16:59:13 +00:00
parent e5a0c739d4
commit 13cf964453
2 changed files with 3 additions and 1 deletions

3
changes/bug32666 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (onion services):
- Avoid a non-fatal assertion in certain edge-cases when establishing a
circuit to onion service. Fixes bug 32666; bugfix on 0.3.0.3-alpha.

View File

@ -2456,7 +2456,6 @@ onion_extend_cpath(origin_circuit_t *circ)
choose_good_middle_server(purpose, state, circ->cpath, cur_len);
if (r) {
info = extend_info_from_node(r, 0);
tor_assert_nonfatal(info);
}
}