nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 05:43:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Implement proposal 301-dont-vote-on-package-fingerprints.txt

Browse Source 
This commit adds a new consensus method which, when present, causes
authorities not to consider package fingerprints when computing a
consensus. It builds on earlier work which dropped support for putting
these lines into the votes.
This commit is contained in:
Nick Mathewson 2023-08-15 10:12:25 -04:00
parent 67bfb87dcb
commit 0cdd5a7900
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
changes/prop301 Normal file
View File

@ -0,0 +1,6 @@
o Removed features (directory authority):
- We include a new consensus method that removes support for
computing "package" lines in consensus documents. This feature was
never used, and support for
including it in our votes was removed in 0.4.2.1-alpha.
Finishes implementation of proposal 301.

6
src/feature/dirauth/dirvote.c
View File

@ -1631,7 +1631,11 @@ networkstatus_compute_consensus(smartlist_t *votes,
n_versioning_servers);
client_versions = compute_consensus_versions_list(combined_client_versions,
n_versioning_clients);
packages = compute_consensus_package_lines(votes);
if (consensus_method < MIN_METHOD_TO_OMIT_PACKAGE_FINGERPRINTS)
packages = tor_strdup("");
else
packages = compute_consensus_package_lines(votes);
SMARTLIST_FOREACH(combined_server_versions, char *, cp, tor_free(cp));
SMARTLIST_FOREACH(combined_client_versions, char *, cp, tor_free(cp));

8
src/feature/dirauth/dirvote.h
View File

@ -53,7 +53,7 @@
#define MIN_SUPPORTED_CONSENSUS_METHOD 28
/** The highest consensus method that we currently support. */
#define MAX_SUPPORTED_CONSENSUS_METHOD 33
#define MAX_SUPPORTED_CONSENSUS_METHOD 34
/**
* Lowest consensus method where microdescriptor lines are put in canonical
@ -80,6 +80,12 @@
*/
#define MIN_METHOD_TO_SUPPRESS_MD_PUBLISHED 33
/**
* Lowest (supported) consensus method for which we do not include
* any "package" lines.
**/
#define MIN_METHOD_TO_OMIT_PACKAGE_FINGERPRINTS 34
/** Default bandwidth to clip unmeasured bandwidths to using method >=
* MIN_METHOD_TO_CLIP_UNMEASURED_BW. (This is not a consensus method; do not
* get confused with the above macros.) */