nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 13:43:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

prop224 tests: Remove useless NULL check before circuit_free().

Browse Source 
Addresses coverity issue CID 1405130.
This commit is contained in:
George Kadianakis 2017-04-17 16:36:55 +03:00
parent a3ce303432
commit 0c39cefc52
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/test/test_circuitlist.c
View File

@ -388,6 +388,7 @@ test_hs_circuitmap_isolation(void *arg)
const uint8_t tok1[REND_TOKEN_LEN] = "bet i got some of th"; const uint8_t tok1[REND_TOKEN_LEN] = "bet i got some of th";
circ1 = or_circuit_new(0, NULL); circ1 = or_circuit_new(0, NULL);
tt_assert(circ1);
circ1->base_.purpose = CIRCUIT_PURPOSE_REND_POINT_WAITING; circ1->base_.purpose = CIRCUIT_PURPOSE_REND_POINT_WAITING;
/* check that circuitmap is empty right? */ /* check that circuitmap is empty right? */
@ -408,10 +409,13 @@ test_hs_circuitmap_isolation(void *arg)
const uint8_t tok2[REND_TOKEN_LEN] = "you dont know anythi"; const uint8_t tok2[REND_TOKEN_LEN] = "you dont know anythi";
circ2 = origin_circuit_new(); circ2 = origin_circuit_new();
tt_assert(circ2);
circ2->base_.purpose = CIRCUIT_PURPOSE_S_ESTABLISH_INTRO; circ2->base_.purpose = CIRCUIT_PURPOSE_S_ESTABLISH_INTRO;
circ3 = or_circuit_new(0, NULL); circ3 = or_circuit_new(0, NULL);
tt_assert(circ3);
circ3->base_.purpose = CIRCUIT_PURPOSE_INTRO_POINT; circ3->base_.purpose = CIRCUIT_PURPOSE_INTRO_POINT;
circ4 = origin_circuit_new(); circ4 = origin_circuit_new();
tt_assert(circ4);
circ4->base_.purpose = CIRCUIT_PURPOSE_S_ESTABLISH_INTRO; circ4->base_.purpose = CIRCUIT_PURPOSE_S_ESTABLISH_INTRO;
/* Register circ2 with tok2 as service-side intro v2 circ */ /* Register circ2 with tok2 as service-side intro v2 circ */
@ -437,14 +441,10 @@ test_hs_circuitmap_isolation(void *arg)
} }
done: done:
if (circ1) circuit_free(TO_CIRCUIT(circ1));
circuit_free(TO_CIRCUIT(circ1)); circuit_free(TO_CIRCUIT(circ2));
if (circ2) circuit_free(TO_CIRCUIT(circ3));
circuit_free(TO_CIRCUIT(circ2)); circuit_free(TO_CIRCUIT(circ4));
if (circ3)
circuit_free(TO_CIRCUIT(circ3));
if (circ4)
circuit_free(TO_CIRCUIT(circ4));
} }
struct testcase_t circuitlist_tests[] = { struct testcase_t circuitlist_tests[] = {