nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove check-cocci from check-local target.

Browse Source 
check-cocci is still a good idea -- perhaps as a cron job?  But
doing it as part of our regular tests has just been confusing,
especially to volunteers who shouldn't have to become coccinelle
experts in order to get their patches through our CI.

Closes #40030.
This commit is contained in:
Nick Mathewson 2020-07-13 09:24:26 -04:00
parent 3517d20322
commit 0acc3ae879
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Makefile.am
View File

@ -271,8 +271,7 @@ check-local: \
check-spaces \ check-spaces \
check-changes \ check-changes \
check-includes \ check-includes \
shellcheck \ shellcheck
check-cocci
need-chutney-path: need-chutney-path:
@if test ! -d "$$CHUTNEY_PATH"; then \ @if test ! -d "$$CHUTNEY_PATH"; then \

7
changes/ticket40030 Normal file
View File

@ -0,0 +1,7 @@
o Removed features:
- Our "check-local" test target no longer tries to use the Coccinelle
semantic patching tool parse all the C files. While it is a good idea
to try to make sure Coccinelle works on our C before we run a
Coccinelle patch, doing so on every test run has proven to be disruptive.
You can still run this tool manually with "make check-cocci". Closes
ticket 40030.