Fix memory leak in md-download logic

Also fix some microdesc comments

Fix for bug 2623
This commit is contained in:
Nick Mathewson 2011-02-24 09:47:33 -05:00
parent feaa0120d0
commit 0a6beb9368
2 changed files with 3 additions and 2 deletions

View File

@ -1957,6 +1957,7 @@ connection_dir_client_reached_eof(dir_connection_t *conn)
}
SMARTLIST_FOREACH(which, char *, cp, tor_free(cp));
smartlist_free(which);
smartlist_free(mds);
}
}

View File

@ -133,7 +133,7 @@ get_microdesc_cache(void)
* to allow, so we should reject any non-requested microdesc with a different
* digest, and alter the list to contain only the digests of those microdescs
* we didn't find.
* Return a list of the added microdescriptors. */
* Return a newly allocated list of the added microdescriptors, or NULL */
smartlist_t *
microdescs_add_to_cache(microdesc_cache_t *cache,
const char *s, const char *eos, saved_location_t where,
@ -181,7 +181,7 @@ microdescs_add_to_cache(microdesc_cache_t *cache,
}
/* As microdescs_add_to_cache, but takes a list of micrdescriptors instead of
* a string to encode. Frees any members of <b>descriptors</b> that it does
* a string to decode. Frees any members of <b>descriptors</b> that it does
* not add. */
smartlist_t *
microdescs_add_list_to_cache(microdesc_cache_t *cache,