Add note about handling INTRODUCE2 cells.

Also fix a check-spaces instance.
This commit is contained in:
George Kadianakis 2017-08-08 11:51:16 +03:00 committed by Nick Mathewson
parent ff249ee4a6
commit 0a0bbfe96f
2 changed files with 7 additions and 1 deletions

View File

@ -210,6 +210,11 @@ build_legacy_establish_intro(const char *circ_nonce, crypto_pk_t *enc_key,
* service and circuit which are used only for logging purposes. The resulting * service and circuit which are used only for logging purposes. The resulting
* parsed cell is put in cell_ptr_out. * parsed cell is put in cell_ptr_out.
* *
* This function only parses prop224 INTRODUCE2 cells even when the intro point
* is a legacy intro point. That's because intro points don't actually care
* about the contents of the introduce cell. Legacy INTRODUCE cells are only
* used by the legacy system now.
*
* Return 0 on success else a negative value and cell_ptr_out is untouched. */ * Return 0 on success else a negative value and cell_ptr_out is untouched. */
static int static int
parse_introduce2_cell(const hs_service_t *service, parse_introduce2_cell(const hs_service_t *service,

View File

@ -1114,7 +1114,8 @@ test_build_update_descriptors(void *arg)
ed25519_keypair_generate(&kp1, 0); ed25519_keypair_generate(&kp1, 0);
ri.cache_info.signing_key_cert = tor_malloc_zero(sizeof(tor_cert_t)); ri.cache_info.signing_key_cert = tor_malloc_zero(sizeof(tor_cert_t));
tt_assert(ri.cache_info.signing_key_cert); tt_assert(ri.cache_info.signing_key_cert);
ed25519_pubkey_copy(&ri.cache_info.signing_key_cert->signing_key, &kp1.pubkey); ed25519_pubkey_copy(&ri.cache_info.signing_key_cert->signing_key,
&kp1.pubkey);
nodelist_set_routerinfo(&ri, NULL); nodelist_set_routerinfo(&ri, NULL);
node = node_get_mutable_by_id(ri.cache_info.identity_digest); node = node_get_mutable_by_id(ri.cache_info.identity_digest);
tt_assert(node); tt_assert(node);