nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 21:23:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix two other cases of (buf + N > end) pattern

Browse Source 
Related to fix for 28202.
This commit is contained in:
Nick Mathewson 2018-10-25 09:08:02 -04:00
parent 368413a321
commit 0878bb961f
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/or/routerparse.c
View File

@ -5299,13 +5299,13 @@ find_start_of_next_microdesc(const char *s, const char *eos)
return NULL;
#define CHECK_LENGTH() STMT_BEGIN \
if (s+32 > eos) \
if (eos - s < 32) \
return NULL; \
STMT_END
#define NEXT_LINE() STMT_BEGIN \
s = memchr(s, '\n', eos-s); \
if (!s || s+1 >= eos) \
if (!s || eos - s <= 1) \
return NULL; \
s++; \
STMT_END
@ -5329,7 +5329,7 @@ find_start_of_next_microdesc(const char *s, const char *eos)
/* Okay, now we're pointed at the first line of the microdescriptor which is
not an annotation or onion-key. The next line that _is_ an annotation or
onion-key is the start of the next microdescriptor. */
while (s+32 < eos) {
while (eos - s > 32) {
if (*s == '@' || !strcmpstart(s, "onion-key"))
return s;
NEXT_LINE();
@ -6359,4 +6359,3 @@ routerparse_free_all(void)
{
dump_desc_fifo_cleanup();
}