nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

r12804@catbus: nickm | 2007-05-19 14:21:18 -0400

Browse Source 
Disable a blatantly incorrect control event with potential for memory corruption.


svn:r10219
This commit is contained in:
Nick Mathewson 2007-05-19 18:31:02 +00:00
parent 0a27b53252
commit 07199e3d09
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/or/dirserv.c
View File

@ -586,13 +586,19 @@ dirserv_add_descriptor(routerinfo_t *ri, const char **msg)
ri->nickname);
*msg = "Not replacing router descriptor; no information has changed since "
"the last one with this identity.";
routerinfo_free(ri);
control_event_or_authdir_new_descriptor("DROPPED", desc, *msg);
routerinfo_free(ri);
return 0;
}
if ((r = router_add_to_routerlist(ri, msg, 0, 0))<0) {
#if 0
/* XXXX020 reinstate this code, but remember that it can't actually
work, since it is NOT kosher to look at ri or desc after
add_to_routerlist, _unless_ the descriptor is accepted.
*/
if (r < -1) /* unless the routerinfo was fine, just out-of-date */
control_event_or_authdir_new_descriptor("REJECTED", desc, *msg);
#endif
return r == -1 ? 0 : -1;
} else {
smartlist_t *changed;