nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Check newconn, not conn, before marking newconn for close

Browse Source 
This fixes bug 2757.  It's a bugfix on 85da676108.
This commit is contained in:
Nick Mathewson 2011-03-14 18:52:15 -04:00
parent b97d9abd09
commit 06f026de66
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
changes/bug2757 Normal file
View File

@ -0,0 +1,6 @@
- Minor bugfixes
o Avoid a double-mark-for-free warning when failing to attach a
transparent proxy connection. (We thought we had fixed this in
0.2.2.23-alpha, but it turns out our fix was checking the wrong
connection.) Fixes bug 2757; bugfix on 0.1.2.1-alpha (the original
bug) and 0.2.2.23-alpha (the incorrect fix).

2
src/or/connection.c
View File

@ -1178,7 +1178,7 @@ connection_handle_listener_read(connection_t *conn, int new_type)
} }
if (connection_init_accepted_conn(newconn, conn->type) < 0) { if (connection_init_accepted_conn(newconn, conn->type) < 0) {
if (! conn->marked_for_close) if (! newconn->marked_for_close)
connection_mark_for_close(newconn); connection_mark_for_close(newconn);
return 0; return 0;
} }