add an XXX with a minor bug in dirserv_add_multiple_descriptors

This commit is contained in:
Roger Dingledine 2017-05-10 03:11:29 -04:00
parent 9f5b71a7ca
commit 0266c4ac81

View File

@ -571,6 +571,8 @@ dirserv_add_multiple_descriptors(const char *desc, uint8_t purpose,
!general ? router_purpose_to_string(purpose) : "",
!general ? "\n" : "")<0) {
*msg = "Couldn't format annotations";
/* XXX Not cool: we return -1 below, but (was_router_added_t)-1 is
* ROUTER_BAD_EI, which isn't what's gone wrong here. :( */
return -1;
}