nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 14:23:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix up size and sign issues in base32 code

Browse Source 
Fixes bug 2331.
This commit is contained in:
Nick Mathewson 2011-01-03 16:16:53 -05:00
parent f089804332
commit 0222228d64
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
changes/bug2331 Normal file
View File

@ -0,0 +1,6 @@
o Minor bugfixes:
- Add assertions to check for overflow in arguments to
base32_encode and base32_decode; fix a signed-unsigned
comparison there too. These bugs are actually reachable in Tor,
but it's good to prevent future errors too. Found by doorss.

10
src/common/crypto.c
View File

@ -2412,9 +2412,10 @@ digest256_from_base64(char *digest, const char *d64)
void void
base32_encode(char *dest, size_t destlen, const char *src, size_t srclen) base32_encode(char *dest, size_t destlen, const char *src, size_t srclen)
{ {
unsigned int i, bit, v, u; unsigned int i, v, u;
size_t nbits = srclen * 8; size_t nbits = srclen * 8, bit;
tor_assert(srclen < SIZE_T_CEILING/8);
tor_assert((nbits%5) == 0); /* We need an even multiple of 5 bits. */ tor_assert((nbits%5) == 0); /* We need an even multiple of 5 bits. */
tor_assert((nbits/5)+1 <= destlen); /* We need enough space. */ tor_assert((nbits/5)+1 <= destlen); /* We need enough space. */
tor_assert(destlen < SIZE_T_CEILING); tor_assert(destlen < SIZE_T_CEILING);
@ -2438,11 +2439,12 @@ base32_decode(char *dest, size_t destlen, const char *src, size_t srclen)
{ {
/* XXXX we might want to rewrite this along the lines of base64_decode, if /* XXXX we might want to rewrite this along the lines of base64_decode, if
* it ever shows up in the profile. */ * it ever shows up in the profile. */
unsigned int i, j, bit; unsigned int i, bit;
size_t nbits; size_t nbits, j;
char *tmp; char *tmp;
nbits = srclen * 5; nbits = srclen * 5;
tor_assert(srclen < SIZE_T_CEILING / 5);
tor_assert((nbits%8) == 0); /* We need an even multiple of 8 bits. */ tor_assert((nbits%8) == 0); /* We need an even multiple of 8 bits. */
tor_assert((nbits/8) <= destlen); /* We need enough space. */ tor_assert((nbits/8) <= destlen); /* We need enough space. */
tor_assert(destlen < SIZE_T_CEILING); tor_assert(destlen < SIZE_T_CEILING);