nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed of-by-one error in tor_inet_ntop

Browse Source 
The of-by-one error could lead to 1 byte buffer over runs IPv6 for addresses.
This commit is contained in:
Anders Sundman 2011-11-11 07:47:00 +01:00
parent f0589da0e3
commit 01e1dc0e62
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/common/compat.c
View File

@ -1632,7 +1632,7 @@ tor_inet_ntop(int af, const void *src, char *dst, size_t len)
addr->s6_addr[12], addr->s6_addr[13], addr->s6_addr[12], addr->s6_addr[13],
addr->s6_addr[14], addr->s6_addr[15]); addr->s6_addr[14], addr->s6_addr[15]);
} }
if (strlen(buf) > len) if ((strlen(buf) + 1) > len) /* +1 for \0 */
return NULL; return NULL;
strlcpy(dst, buf, len); strlcpy(dst, buf, len);
return dst; return dst;
@ -1673,7 +1673,7 @@ tor_inet_ntop(int af, const void *src, char *dst, size_t len)
} }
} }
*cp = '\0'; *cp = '\0';
if (strlen(buf) > len) if ((strlen(buf) + 1) > len) /* +1 for \0 */
return NULL; return NULL;
strlcpy(dst, buf, len); strlcpy(dst, buf, len);
return dst; return dst;