tor/changes/bug1384

  o Minor features:
    - Warn when the same option is provided more then once in a torrc file,
      on the command line, or in a single SETCONF statement, and option
      is one that only accepts a single value. Closes bug 1384.
Warn when encounter the same (non-list) option twice in the same place It's okay to get (say) a SocksPort line in the torrc, and then a SocksPort on the command line to override it, and then a SocksPort via a controller to override that. But if there are two occurrences of SocksPort in the torrc, or on the command line, or in a single SETCONF command, then the user is likely confused. Our old code would not help unconfuse the user, but would instead silently ignore all but the last occurrence. This patch changes the behavior so that if the some option is passed more than once to any torrc, command line, or SETCONF (each of which coincidentally corresponds to a call to config_assign()), and the option is not a type that allows multiple occurrences (LINELIST or LINELIST_X), then we can warn the user. This closes trac entry 1384. 2010-07-31 19:16:48 +02:00			`o Minor features:`
			`- Warn when the same option is provided more then once in a torrc file,`
			`on the command line, or in a single SETCONF statement, and option`
Fix a compile warning on OS X 10.6 Also update the changes file to contain a note on which bug was fixed by this. 2010-08-02 18:44:00 +02:00			`is one that only accepts a single value. Closes bug 1384.`
Warn when encounter the same (non-list) option twice in the same place It's okay to get (say) a SocksPort line in the torrc, and then a SocksPort on the command line to override it, and then a SocksPort via a controller to override that. But if there are two occurrences of SocksPort in the torrc, or on the command line, or in a single SETCONF command, then the user is likely confused. Our old code would not help unconfuse the user, but would instead silently ignore all but the last occurrence. This patch changes the behavior so that if the some option is passed more than once to any torrc, command line, or SETCONF (each of which coincidentally corresponds to a call to config_assign()), and the option is not a type that allows multiple occurrences (LINELIST or LINELIST_X), then we can warn the user. This closes trac entry 1384. 2010-07-31 19:16:48 +02:00