tor/changes/bug30001

  o Minor features (testing):
    - Use the approx_time() function when setting the "Expires" header
      in directory replies, to make them more testable. Needed for
      ticket 30001.
  o Minor bug fixes (testing):
    - Check the time in the "Expires" header with approx_time().
      Fixes bug 30001; bugfix on 0.4.0.4-rc.
30001: Fix a race condition in test_dir_handle_get.c Previously we used time(NULL) to set the Expires: header in our HTTP responses. This made the actual contents of that header untestable, since the unit tests have no good way to override time(), or to see what time() was at the exact moment of the call to time() in dircache.c. This gave us a race in dir_handle_get/status_vote_next_bandwidth, where the time() call in dircache.c got one value, and the call in the tests got another value. I'm applying our regular solution here: using approx_time() so that the value stays the same between the code and the test. Since approx_time() is updated on every event callback, we shouldn't be losing any accuracy here. Fixes bug 30001. Bug introduced in fb4a40c32c4a7e5; not in any released Tor. 2019-04-03 16:16:18 +02:00			`o Minor features (testing):`
			`- Use the approx_time() function when setting the "Expires" header`
			`in directory replies, to make them more testable. Needed for`
			`ticket 30001.`
changes: update the changes file for 30001 2019-04-17 04:34:33 +02:00			`o Minor bug fixes (testing):`
			`- Check the time in the "Expires" header with approx_time().`
			`Fixes bug 30001; bugfix on 0.4.0.4-rc.`