tor/changes/use_ssl_option_everywhere

  o Major bugfixes:
    - Fix SSL renegotiation behavior on OpenSSL versions that claim to
      be earlier than 0.9.8m, but which have in reality backported huge
      swaths of 0.9.8m or 0.9.8n renegotiation behavior.  Possibly fix
      for some cases of bug 1346.
Fix renegotiation on OpenSSL versions that backport RFC5746. Our code assumed that any version of OpenSSL before 0.9.8l could not possibly require SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION. This is so... except that many vendors have backported the flag from later versions of openssl when they backported the RFC5476 renegotiation feature. The new behavior is particularly annoying to detect. Previously, leaving SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION unset meant that clients would fail to renegotiate. People noticed that one fast! Now, OpenSSL's RFC5476 support means that clients will happily talk to any servers there are, but servers won't accept renegotiation requests from unpatched clients unless SSL_OP_ALLOW_etc is set. More fun: servers send back a "no renegotiation for you!" error, which unpatched clients respond to by stalling, and generally producing no useful error message. This might not be _the_ cause of bug 1346, but it is quite likely _a_ cause for bug 1346. 2010-04-13 20:58:30 +02:00			`o Major bugfixes:`
			`- Fix SSL renegotiation behavior on OpenSSL versions that claim to`
			`be earlier than 0.9.8m, but which have in reality backported huge`
			`swaths of 0.9.8m or 0.9.8n renegotiation behavior. Possibly fix`
			`for some cases of bug 1346.`