tor/changes/bug40673

  o Minor bugfixes (relay overload statistics):
    - Count total create cells vs dropped create cells properly, when
      assessing if our fraction of dropped cells is too high. We only
      count non-client circuits in the denominator, but we would include
      client circuits in the numerator, leading to surprising log lines
      claiming that we had dropped more than 100% of incoming create
      cells. Fixes bug 40673; bugfix on 0.4.7.1-alpha.
Properly compute cell-drop overload fraction Patch to address #40673. An additional check has been added to onion_pending_add() in order to ensure that we avoid counting create cells from clients. In the cpuworker.c assign_onionskin_to_cpuworker method if total_pending_tasks >= max_pending_tasks and channel_is_client(circ->p_chan) returns false then rep_hist_note_circuit_handshake_dropped() will be called and rep_hist_note_circuit_handshake_assigned() will not be called. This causes relays to run into errors due to the fact that the number of dropped packets exceeds the total number of assigned packets. To avoid this situation a check has been added to onion_pending_add() to ensure that these erroneous calls to rep_hist_note_circuit_handshake_dropped() are not made. See the #40673 ticket for the conversation with armadev about this issue. 2022-10-06 06:30:18 +02:00			`o Minor bugfixes (relay overload statistics):`
fix typo in #40673's changes file 2022-10-21 01:46:27 +02:00			`- Count total create cells vs dropped create cells properly, when`
Properly compute cell-drop overload fraction Patch to address #40673. An additional check has been added to onion_pending_add() in order to ensure that we avoid counting create cells from clients. In the cpuworker.c assign_onionskin_to_cpuworker method if total_pending_tasks >= max_pending_tasks and channel_is_client(circ->p_chan) returns false then rep_hist_note_circuit_handshake_dropped() will be called and rep_hist_note_circuit_handshake_assigned() will not be called. This causes relays to run into errors due to the fact that the number of dropped packets exceeds the total number of assigned packets. To avoid this situation a check has been added to onion_pending_add() to ensure that these erroneous calls to rep_hist_note_circuit_handshake_dropped() are not made. See the #40673 ticket for the conversation with armadev about this issue. 2022-10-06 06:30:18 +02:00			`assessing if our fraction of dropped cells is too high. We only`
			`count non-client circuits in the denominator, but we would include`
			`client circuits in the numerator, leading to surprising log lines`
			`claiming that we had dropped more than 100% of incoming create`
			`cells. Fixes bug 40673; bugfix on 0.4.7.1-alpha.`