tor/changes/smartlist_foreach

  o Code simplification and refactoring:
    - Do not use SMARTLIST_FOREACH for any loop whose body exceeds
      10 lines. Doing so in the past has led to hard-to-debug code.
      The new style is to use the SMARTLIST_FOREACH_{BEGIN,END} pair.
      Issue 6400.
    - Do not nest SMARTLIST_FOREACH blocks within one another. Any
      nested block ought to be using SMARTLIST_FOREACH_{BEGIN,END}.
      Issue 6400.
Change all SMARTLIST_FOREACH loops of >=10 lines to use BEGIN/END The SMARTLIST_FOREACH macro is more convenient than BEGIN/END when you have a nice short loop body, but using it for long bodies makes your preprocessor tell the compiler that all the code is on the same line. That causes grief, since compiler warnings and debugger lines will all refer to that one line. So, here's a new style rule: SMARTLIST_FOREACH blocks need to be short. 2012-07-17 15:33:38 +02:00			`o Code simplification and refactoring:`
Tweaks to 6400 changes file and docs as suggested by arma 2012-07-18 16:12:19 +02:00			`- Do not use SMARTLIST_FOREACH for any loop whose body exceeds`
			`10 lines. Doing so in the past has led to hard-to-debug code.`
Change all SMARTLIST_FOREACH loops of >=10 lines to use BEGIN/END The SMARTLIST_FOREACH macro is more convenient than BEGIN/END when you have a nice short loop body, but using it for long bodies makes your preprocessor tell the compiler that all the code is on the same line. That causes grief, since compiler warnings and debugger lines will all refer to that one line. So, here's a new style rule: SMARTLIST_FOREACH blocks need to be short. 2012-07-17 15:33:38 +02:00			`The new style is to use the SMARTLIST_FOREACH_{BEGIN,END} pair.`
Tweaks to 6400 changes file and docs as suggested by arma 2012-07-18 16:12:19 +02:00			`Issue 6400.`
			`- Do not nest SMARTLIST_FOREACH blocks within one another. Any`
			`nested block ought to be using SMARTLIST_FOREACH_{BEGIN,END}.`
			`Issue 6400.`