tor/changes/bug13698

  o Bugfixes:
	- When closing an introduction circuit that was opened in parallel, don't
	  mark it unreachable which can causes it to be removed from the rend cache
	  object thus not usable anymore.
Fix: don't report timeout when closing parallel intro points When closing parallel introduction points, the given reason (timeout) was actually changed to "no reason" thus when the circuit purpose was CIRCUIT_PURPOSE_C_INTRODUCE_ACK_WAIT, we were reporting an introduction point failure and flagging it "unreachable". After three times, that intro point gets removed from the rend cache object. In the case of CIRCUIT_PURPOSE_C_INTRODUCING, the intro point was flagged has "timed out" and thus not used until the connection to the HS is closed where that flag gets reset. This commit adds an internal circuit reason called END_CIRC_REASON_IP_NOW_REDUNDANT which tells the closing circuit mechanism to not report any intro point failure. This has been observed while opening hundreds of connections to an HS on different circuit for each connection. This fix makes this use case to work like a charm. Fixes #13698. Signed-off-by: David Goulet <dgoulet@ev0ke.net> 2014-11-10 20:38:53 +01:00			`o Bugfixes:`
			`- When closing an introduction circuit that was opened in parallel, don't`
			`mark it unreachable which can causes it to be removed from the rend cache`
			`object thus not usable anymore.`