tor/changes/bug20307

  o Minor bugfixes (circuit, hidden service)
    - When closing a circuit, the reason for doing so was assigned from an int
      value to a uint16_t which is quite a problem for negative values that are
      our internal reasons (ex: END_CIRC_REASON_IP_NOW_REDUNDANT). On the HS
      side, this was causing introduction points to be flagged as unusable
      because the reason wasn't the right one due to the bad conversion.
      Partially fixes bug 21056 and fixes bug 20307; Bugfix on 0.2.8.1-alpha.
circuit: Change close reasons from uint16_t to int When marking for close a circuit, the reason value, a integer, was assigned to a uint16_t converting any negative reasons (internal) to the wrong value. On the HS side, this was causing the client to flag introduction points to be unreachable as the internal reason was wrongfully converted to a positive 16bit value leading to flag 2 out of 3 intro points to be unreachable. Fixes #20307 and partially fixes #21056 Signed-off-by: David Goulet <dgoulet@torproject.org> 2016-12-22 18:37:42 +01:00			`o Minor bugfixes (circuit, hidden service)`
clean up grammar on bug20307 changes file pointed out by toralf on irc 2017-01-14 00:09:50 +01:00			`- When closing a circuit, the reason for doing so was assigned from an int`
			`value to a uint16_t which is quite a problem for negative values that are`
circuit: Change close reasons from uint16_t to int When marking for close a circuit, the reason value, a integer, was assigned to a uint16_t converting any negative reasons (internal) to the wrong value. On the HS side, this was causing the client to flag introduction points to be unreachable as the internal reason was wrongfully converted to a positive 16bit value leading to flag 2 out of 3 intro points to be unreachable. Fixes #20307 and partially fixes #21056 Signed-off-by: David Goulet <dgoulet@torproject.org> 2016-12-22 18:37:42 +01:00			`our internal reasons (ex: END_CIRC_REASON_IP_NOW_REDUNDANT). On the HS`
clean up grammar on bug20307 changes file pointed out by toralf on irc 2017-01-14 00:09:50 +01:00			`side, this was causing introduction points to be flagged as unusable`
circuit: Change close reasons from uint16_t to int When marking for close a circuit, the reason value, a integer, was assigned to a uint16_t converting any negative reasons (internal) to the wrong value. On the HS side, this was causing the client to flag introduction points to be unreachable as the internal reason was wrongfully converted to a positive 16bit value leading to flag 2 out of 3 intro points to be unreachable. Fixes #20307 and partially fixes #21056 Signed-off-by: David Goulet <dgoulet@torproject.org> 2016-12-22 18:37:42 +01:00			`because the reason wasn't the right one due to the bad conversion.`
clean up grammar on bug20307 changes file pointed out by toralf on irc 2017-01-14 00:09:50 +01:00			`Partially fixes bug 21056 and fixes bug 20307; Bugfix on 0.2.8.1-alpha.`