205c80427b
The Monero GUI code was calling `Monero::wallet::setPassword()` on every open/close for some reason, and the old `store_to()` code called `store_keys()` with `watch_only=false`, even for watch-only wallets. This caused a bug where the watch-only keys file got saved with with the JSON field `watch_only` set to 0, and after saving a watch-only wallet once, a user could never open it back up against because `load()` errored out. This never got brought up before this because you would have to change the file location of the watch-only wallet to see this bug, and I guess that didn't happen often, but calling the new `store_to()` function with the new `force_rewrite` parameter set to `true` triggers key restoring and the bug appeared. |
||
---|---|---|
.. | ||
api | ||
CMakeLists.txt | ||
message_store.cpp | ||
message_store.h | ||
message_transporter.cpp | ||
message_transporter.h | ||
node_rpc_proxy.cpp | ||
node_rpc_proxy.h | ||
ringdb.cpp | ||
ringdb.h | ||
wallet2.cpp | ||
wallet2.h | ||
wallet_args.cpp | ||
wallet_args.h | ||
wallet_errors.h | ||
wallet_light_rpc.h | ||
wallet_rpc_helpers.h | ||
wallet_rpc_payments.cpp | ||
wallet_rpc_server_commands_defs.h | ||
wallet_rpc_server_error_codes.h | ||
wallet_rpc_server.cpp | ||
wallet_rpc_server.h |