nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,792 Commits 10 Branches 68 Tags 223 MiB
d9cb50870d
Commit Graph

6124 Commits

Author SHA1 Message Date
Lev Sizov
928f4be953 Make null hash constants constexpr 
Simplify m_template initialization in miner
 2019-09-05 17:37:19 +02:00
moneromooo-monero
2ec455df1f
wallet: fix mismatch between two concepts of "balance" 
One considers the blockchain, while the other considers the
blockchain and some recent actions, such as a recently created
transaction which spend some outputs, but isn't yet mined.

Typically, the "balance" command wants the latter, to reflect
the recent action, but things like proving ownership wants
the former.

This fixes a crash in get_reserve_proof, where a preliminary
check and the main code used two concepts of "balance".
 2019-09-05 11:19:34 +00:00
moneromooo-monero
340774341f
wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments 
Much easier to work with than the raw unlock_time field
 2019-09-05 10:54:57 +00:00
moneromooo-monero
bc1144e98e
Fix IP address serialization on big endian 
IP addresses are stored in network byte order even on little
endian hosts
 2019-09-04 14:54:01 +00:00
moneromooo-monero
54fd97ae3f
slow-hash: fix CNv2+ on big endian 2019-09-04 14:53:59 +00:00
moneromooo-monero
4672b5cea9
db_lmdb: print percentages as percentages, not ratios 2019-09-04 14:53:59 +00:00
moneromooo-monero
d046ca1db0
difficulty: fix check_hash on big endian 2019-09-04 14:53:53 +00:00
luigi1111
a567e884b2
Merge pull request #5822 
839fc62 reject setting lookahead major or minor to 0 (moneromoo-monero)
 2019-09-04 09:39:07 -05:00
luigi1111
e4f11a68fe
Merge pull request #5819 
07cb087 blockchain: Fix alt chain generated coins overflow (iamamyth)
 2019-09-04 09:37:32 -05:00
luigi1111
902e4b6ebf
Merge pull request #5806 
69465e3 cryptonote_protocol: fix '--no-sync', ignore new blocks and txes (xiphon)
 2019-09-04 09:28:22 -05:00
luigi1111
0198b76217
Merge pull request #5799 
082730b daemon: automatic public nodes discovering and bootstrap daemon switching (xiphon)
 2019-09-04 09:27:02 -05:00
luigi1111
23547e6ed6
Merge pull request #5536 
1a367d6 simplewallet: lock console on inactivity (moneromooo-monero)
 2019-09-04 09:18:38 -05:00
Lev Sizov
4ad191ffa9 Removed unused boost/value_init header 2019-09-02 14:38:29 +02:00
Jesus Ramirez
2cd4fd8972 Changed the use of boost:value_initialized for C++ list initializer 2019-09-02 14:16:29 +02:00
luigi1111
98af2e954b
Merge pull request #5793 
bdfc63a Add ref-counted buffer byte_slice. Currently used for sending TCP data. (vtnerd)
3b24b1d Added support for 'noise' over I1P/Tor to mask Tx transmission. (vtnerd)
 2019-08-29 14:36:41 -05:00
stoffu
f380f69c69
simplewallet: warn if invalid default ring size is set and actually ignore the setting 2019-08-29 15:55:53 +09:00
moneromooo-monero
1a367d6a22
simplewallet: lock console on inactivity 2019-08-28 19:01:48 +00:00
moneromooo-monero
495a7e5b97
rpc: don't include an address in mining_status when not mining 
Best case is an address mined previously and it'll get returned,
worst case it was never initialized in the first place
 2019-08-28 16:02:37 +00:00
moneromooo-monero
83ca76435b
wallet_rpc_server: call deinit on exit 2019-08-28 15:59:33 +00:00
moneromooo-monero
1f1fff2679
daemon: print mining algorithm in mining_status even when not mining 2019-08-28 15:55:31 +00:00
moneromooo-monero
21f6c80fcd
rpc: move a leftover light wallet RPC out of daemon RPC 2019-08-28 15:51:28 +00:00
moneromooo-monero
19bfe7e5ab
simplewallet: fix warnings about useless std::move 2019-08-28 15:13:50 +00:00
moneromooo-monero
11f13da8b4
blockchain: fix logging bad number of blocks if first one fails 2019-08-28 14:53:29 +00:00
Tom Smeding
6bbc646e6f Fix bug in mempool get_transaction_stats histogram calculation 
The 98th percentile position in the agebytes map was incorrectly
calculated: it assumed the transactions in the mempool all have unique
timestamps at second-granularity. This commit fixes this by correctly
finding the right cumulative number of transactions in the map suffix.

This bug could lead to an out-of-bounds write in the rare case that
all transactions in the mempool were received (and added to the mempool)
at a rate of at least 50 transactions per second. (More specifically,
the number of *unique* receive_time values, which have second-
granularity, must be at most 2% of the number of transactions in the
mempool for this crash to trigger.) If this condition is satisfied, 'it'
points to *before* the agebytes map, 'delta' gets a nonsense value, and
the value of 'i' in the first stats.histo-filling loop will be out of
bounds of stats.histo.
 2019-08-28 16:46:31 +02:00
luigi1111
85014813cf
Merge pull request #5707 
3a0451a MLSAG speedup and additional checks (SarangNoether)
 2019-08-28 02:22:00 -05:00
Sarang Noether
3a0451a8be MLSAG speedup and additional checks 2019-08-27 16:22:44 -04:00
luigi1111
f68512e9e4
Merge pull request #5729 
7c894fc device_ledger: add paranoid buffer overflow check (moneromooo-monero)
f07524b device_ledger: fix uninitialized additional_key (moneromooo-monero)
 2019-08-27 15:19:47 -05:00
luigi1111
8f6f674753
Merge pull request #5609 
1dc3b1a wallet: add --extra-entropy command line flag (moneromooo-monero)
 2019-08-27 15:14:15 -05:00
luigi1111
3e80f44503
Merge pull request #5559 
33e91e1 wallet, rpc: add a release field to get_version (moneromooo-monero)
 2019-08-27 15:09:37 -05:00
xiphon
082730b6e5 daemon: automatic public nodes discovering and bootstrap daemon switching 2019-08-27 12:01:49 +00:00
moneromooo-monero
33e91e1a1e
wallet, rpc: add a release field to get_version 
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
 2019-08-26 19:28:25 +00:00
moneromooo-monero
f07524b56b
device_ledger: fix uninitialized additional_key 
Coverity 200185
 2019-08-26 12:50:29 +00:00
moneromooo-monero
7c894fc7fd
device_ledger: add paranoid buffer overflow check 
Coverity 200183
 2019-08-26 12:50:26 +00:00
moneromooo-monero
2cb22d4071
core: make the "update probably needed soon" message less scary 2019-08-26 07:56:55 +00:00
moneromooo-monero
c4da1a25c3
wallet2: fix unset_ring tx retrieval checks 2019-08-24 14:46:31 +00:00
moneromooo-monero
87d2f063af
simplewallet: moan harder about untrusted nodes 2019-08-24 12:36:10 +00:00
moneromooo-monero
b51f4cdcaf
daemon: add pruned and publicrpc flags to print_pl 2019-08-23 19:15:45 +00:00
moneromooo-monero
894cc81e83
wallet2: fix cold signing losing tx keys 2019-08-23 16:38:20 +00:00
xiphon
063eebbd43 daemon: implement 'set_bootstrap_daemon' command 2019-08-23 12:09:02 +00:00
moneromooo-monero
cae488dc9b
p2p: reject incoming connections to self 2019-08-22 17:08:29 +00:00
Tadeas Moravec
63186a01ce
Wallet: Option to export data to ASCII 
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.

Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).

Implements https://github.com/monero-project/monero/issues/2859
 2019-08-22 16:03:22 +02:00
stoffu
50813c103e
ringdb: fix bug in blackballing 2019-08-22 21:34:48 +09:00
stoffu
2425f27acd
blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test 2019-08-22 21:34:47 +09:00
stoffu
9f68669503
blockchain_blackball: add --historical-stat which prints historical stats of spent ratio 2019-08-22 21:34:40 +09:00
moneromooo-monero
1dc3b1a516
wallet: add --extra-entropy command line flag 
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
 2019-08-22 11:12:57 +00:00
luigi1111
cdfa2e58df
Merge pull request #5827 
30779de fix feature not introduced until boost 1.66 (jtgrassie)
 2019-08-21 15:54:10 -05:00
luigi1111
2be47ae02a
Merge pull request #5817 
50ec40e Increase max_dbs from 20 to 32 (hyc)
 2019-08-21 15:49:51 -05:00
luigi1111
7bdff6005f
Merge pull request #5815 
adc16d2 Fix check for disconnecting peers when syncing (jagerman)
 2019-08-21 15:48:09 -05:00
luigi1111
d8244eb39c
Merge pull request #5808 
5a91b83 simplewallet: add a few missing settings help text (stoffu)
ae7bf37 simplewallet: fix arg indexing bug in set_device_name (stoffu)
 2019-08-21 15:41:42 -05:00
luigi1111
0a42fddde4
Merge pull request #5807 
4b1df4e Fix for biased signature nonce (SarangNoether)
 2019-08-21 15:38:35 -05:00
luigi1111
28e0a28b96
Merge pull request #5800 
6ca033d hid_error() could return a null, which causes the program to crash with (TheQuantumPhysicist)
 2019-08-21 15:36:05 -05:00
luigi1111
11ab328ce3
Merge pull request #5778 
8703aa5 MMS: Use chans instead of normal addresses for auto-config (rbrunner7)
 2019-08-21 15:31:11 -05:00
luigi1111
eea0123de4
Merge pull request #5755 
7a3e458 improve tx_sanity_check clarification (vicsn)
 2019-08-21 15:23:58 -05:00
luigi1111
1bd3f1a1fb
Merge pull request #5750 
884df82 wallet: provide original address for outgoing transfers (xiphon)
 2019-08-21 15:20:51 -05:00
luigi1111
de30131abd
Merge pull request #5743 
65f29a8 simplewallet: add restore_height command (tobtoht)
 2019-08-21 15:17:26 -05:00
luigi1111
b488ee8188
Merge pull request #5742 
0d916a6 Fix incorrectly named binding for MMS send_signer_config command (tobtoht)
 2019-08-21 15:13:16 -05:00
luigi1111
9e8179ca84
Merge pull request #5740 
256d286 Minor formatting fix in help set command (tobtoht)
 2019-08-21 15:11:32 -05:00
luigi1111
8956e90c63
Merge pull request #5731 
c393e82 CryptonightR_JIT: fix return value on error (selene-kovri)
 2019-08-21 15:09:48 -05:00
luigi1111
65e937168e
Merge pull request #5722 
8be5fea simplewallet: optional all flag to export_outputs/export_key_images (moneromooo-monero)
 2019-08-21 15:08:10 -05:00
moneromooo-monero
e353e3d757
p2p: sanitize peer lists 
Also remove the delta time fixup, since we now ignore those
as they're attacker controlled
 2019-08-21 15:54:27 +00:00
moneromooo-monero
2e2653602f
p2p: move log away from global 
It was here while debugging, and I forgot to move it away
 2019-08-21 14:00:43 +00:00
rbrunner7
8703aa59db MMS: Use chans instead of normal addresses for auto-config 2019-08-20 19:55:31 +02:00
xiphon
26f7a26ee3 device: fix ledger requesting secret keys export twice 2019-08-20 16:08:09 +00:00
xiphon
289d21500c rpc: fix unitialized 'core_rpc_server::m_was_bootstrap_ever_used' 2019-08-20 15:08:48 +00:00
moneromooo-monero
5a4c6cc3a8
daemon: fix merge error removing the "never seen before" timestamp check 2019-08-20 12:48:55 +00:00
luigi1111
c9df9d683a
Merge pull request #5696 
fd60d05 daemon: fix print_pl only printing public zone peers (moneromooo-monero)
 2019-08-20 01:50:10 -05:00
Jethro Grassie
30779de39d
fix feature not introduced until boost 1.66 2019-08-20 01:06:59 -04:00
moneromooo-monero
fd60d05d5d
daemon: fix print_pl only printing public zone peers 2019-08-19 23:39:51 +00:00
luigi1111
4947f3bdba
Merge pull request #5636 
b712ae0 rpc: work around a GCC 7.4.0 (at least) bug (moneromooo-monero)
 2019-08-19 17:37:37 -05:00
luigi1111
56b98c7003
Merge pull request #5728 
6560bfa rpc: get_block_template add optional extra_nonce (jtgrassie)
 2019-08-19 17:33:08 -05:00
luigi1111
f205d28e96
Merge pull request #5727 
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
 2019-08-19 17:31:39 -05:00
luigi1111
4baec08d5c
Merge pull request #5725 
dc8b7a8 zmq: MacPorts latest fix (jtgrassie)
 2019-08-19 17:29:38 -05:00
luigi1111
1010a6503e
Merge pull request #5721 
c164f90 Remove unnecessary m_check_txin_table, fix const correctness (omartijn)
 2019-08-19 17:25:52 -05:00
luigi1111
1499caf596
Merge pull request #5720 
bcd2da7 miner: fix --bg-mining-enable description (moneromooo-monero)
 2019-08-19 17:18:04 -05:00
luigi1111
2da11baecc
Merge pull request #5718 
c8709fe wallet: do not print log settings when unset (moneromooo-monero)
7b18e83 unit_tests: check return values on test data parsing (moneromooo-monero)
 2019-08-19 17:17:11 -05:00
moneromooo-monero
d22dfb7594
blockchain: reject rct signatures in coinbase txes from v12 2019-08-19 16:43:53 +00:00
moneromooo-monero
555dc7c394
core: from v12, require consistent ring size for mixable txes 
We're supposed to have a fixed ring size now

Already checked by MLSAG verification, but here seems more intuitive
 2019-08-19 16:43:53 +00:00
moneromooo-monero
26072f1393
blockchain: forbid v1 coinbase from v12 2019-08-19 16:43:52 +00:00
moneromooo-monero
839fc6256b
reject setting lookahead major or minor to 0 2019-08-19 15:35:12 +00:00
iamamyth
07cb087e5d blockchain: Fix alt chain generated coins overflow 
Apply the overflow logic used for computing already_generated_coins in
the main chain to alternative chains.
 2019-08-18 17:26:58 -07:00
Howard Chu
50ec40ea16
Increase max_dbs from 20 to 32 
We've added a lot of new indices recently, and 20 isn't enough for them plus
new DBs opened during format migrations.
 2019-08-18 17:10:45 +01:00
luigi1111
459beb50d4
Merge pull request #5685 
a604241 simplewallet: don't ask about mining when running a command line (moneromooo-monero)
 2019-08-17 15:27:21 -05:00
luigi1111
12d08dcbf5
Merge pull request #5518 
def703a wallet_api: add multi destination tx support (selsta)
 2019-08-17 15:24:02 -05:00
Jason Rhinelander
adc16d2504 Fix check for disconnecting peers when syncing 
The check added here (in #5732/#5733) is supposed to disconnect behind
peers when the current node is syncing, but actually disconnects behind
peers always.

We are syncing when `target > our_height`, but the check here triggers
when `target > remote_height`, which is basically always true when the
preceding `m_core.have_block(hshd.top_id)` check is true.
 2019-08-16 21:16:33 -03:00
selsta
def703abec
wallet_api: add multi destination tx support 2019-08-16 16:23:12 +02:00
luigi1111
399a847cfc
Merge pull request #5689 
1db5357 rpc headers fix (malbit)
 2019-08-15 17:29:34 -05:00
luigi1111
017162b5b2
Merge pull request #5682 
3768db2 p2p: add a reference to Cao, Tong et al. for the last_seen changes (moneromooo-monero)
 2019-08-15 17:27:30 -05:00
luigi1111
8a0711f2f2
Merge pull request #5674 
fcbf7b3 p2p: propagate out peers limit to payload handler (moneromooo-monero)
098aadf p2p: close the right number of connections on setting max in/out peers (moneromooo-monero)
 2019-08-15 17:22:39 -05:00
luigi1111
6b6593dad9
Merge pull request #5673 
097cca5 wallet_api: catch getTxKey exception (ph4r05)
 2019-08-15 17:21:26 -05:00
luigi1111
1a259a1c70
Merge pull request #5672 
b2bfcab wallet2: fix change subaddress mixup when sending pre rct outputs (moneromooo-monero)
 2019-08-15 17:20:18 -05:00
luigi1111
739b02ef38
Merge pull request #5662 
64fb0f8 device: tx_key caching fixed, store recovered txkey (ph4r05)
 2019-08-15 17:19:12 -05:00
luigi1111
48229234a9
Merge pull request #5659 
6bb2797 daemon: print 128bit diff properly (stoffu)
 2019-08-15 17:17:36 -05:00
luigi1111
c5e926676a
Merge pull request #5656 
8ccc30b Fix --restore-date usage (hyc)
 2019-08-15 17:14:58 -05:00
luigi1111
df064eaa36
Merge pull request #5649 
a182df2 Bans for RPC connections (hyc)
 2019-08-15 17:10:49 -05:00
luigi1111
1167370239
Merge pull request #5637 
69f9420 core: do not complain about low block rate if disconnected (moneromooo-monero)
 2019-08-15 17:09:15 -05:00
Tom Smeding
7b9a420787 Replace std::random_shuffle with std::shuffle 
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.

A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.

[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
 2019-08-15 16:33:15 +02:00
luigi1111
0ba675622f
Merge pull request #5634 
1488109 rpc: fix get_transactions getting v1 txes from the txpool (moneromooo-monero)
 2019-08-14 15:35:24 -05:00
luigi1111
0e986a86d5
Merge pull request #5607 
52cd2fa rpc: implement get_public_nodes command (xiphon)
 2019-08-14 15:34:14 -05:00
luigi1111
564bb1da3a
Merge pull request #5525 
0605406 daemon: sort alt chains by height (moneromooo-monero)
4228ee0  daemon: add optional arguments to alt_chain_info (moneromooo-monero)
880ebfd daemon: add more chain specific info in alt_chain_info (moneromooo-monero)
 2019-08-14 15:31:52 -05:00
luigi1111
2258551ef9
Merge pull request #5487 
df83ed7 consensus: from v12, enforce >= 2 outputs (moneromooo-monero)
 2019-08-14 15:26:55 -05:00