Sarang Noether
3a0451a8be
MLSAG speedup and additional checks
2019-08-27 16:22:44 -04:00
luigi1111
e3de4aa68b
Merge pull request #5502
...
25a7cfd
add a few checks where it seems appropriate (moneromooo-monero)
1a66a86
remove unused code (moneromooo-monero)
2019-07-24 13:57:06 -05:00
moneromooo-monero
1387549e90
serialization: check stream good flag at the end
...
just in case
2019-06-14 08:47:23 +00:00
moneromooo-monero
1a66a86f94
remove unused code
2019-04-29 20:52:40 +00:00
Riccardo Spagni
ac8e2a7819
Merge pull request #5437
...
acb68dba
bulletproofs: cut down on keyV allocations (moneromooo-monero)
2019-04-16 22:44:00 +02:00
moneromooo-monero
acb68dbaa9
bulletproofs: cut down on keyV allocations
2019-04-13 22:37:08 +00:00
moneromooo-monero
93bb2f48f7
ringct: prevent use of full ringct signatures for more than one input
2019-04-11 19:44:06 +00:00
Riccardo Spagni
b8ab510f23
Merge pull request #5332
...
7c440915
Add get_tx_proof support, needed for new sanity check (cslashm)
98fdcb2a
Add support for V11 protocol with BulletProofV2 and short amount. New scheme key destination contrfol Fix dummy decryption in debug mode (cslashm)
3a981a33
Add application version compatibility check. (cslashm)
2019-04-01 17:35:12 +02:00
Riccardo Spagni
7ec799c542
Merge pull request #5287
...
1d14b3f0
ringct: fix capitalization for scaler mult (fuwa)
2019-04-01 17:19:32 +02:00
cslashm
98fdcb2aa5
Add support for V11 protocol with BulletProofV2 and short amount.
...
New scheme key destination contrfol
Fix dummy decryption in debug mode
2019-03-28 18:26:15 +01:00
fuwa
1d14b3f072
ringct: fix capitalization for scaler mult
2019-03-25 13:00:14 +08:00
binaryFate
1f2930ce0b
Update 2019 copyright
2019-03-05 22:05:34 +01:00
moneromooo-monero
ef93b0995c
various: remove unused variables
2019-03-04 22:24:49 +00:00
Riccardo Spagni
9d415495bf
Merge pull request #5082
...
1bc5f9fa
bulletproofs: speed up vector_power_sum (moneromooo-monero)
2019-03-04 21:18:53 +02:00
moneromooo-monero
b6534c40e6
ringct: remove unused senderPk from ecdhTuple
...
This was an early ringct field, which was never used in production
2019-01-22 23:17:42 +00:00
moneromooo-monero
7d37598158
ringct: the commitment mask is now deterministic
...
saves space in the tx and is safe
Found by knaccc
2019-01-22 23:17:39 +00:00
moneromooo-monero
99d946e619
ringct: encode 8 byte amount, saving 24 bytes per output
...
Found by knaccc
2019-01-22 23:17:31 +00:00
moneromooo-monero
cdc3ccec5f
ringct: save 3 bytes on bulletproof size
...
Found by luigi1111
2019-01-22 23:17:27 +00:00
moneromooo-monero
f931e16c6e
add a bulletproof version, new bulletproof type, and rct config
...
This makes it easier to modify the bulletproof format
2019-01-22 23:17:24 +00:00
moneromooo-monero
1bc5f9fa4b
bulletproofs: speed up vector_power_sum
...
found by sarang
2019-01-19 00:18:34 +00:00
Riccardo Spagni
5753d71922
Merge pull request #5050
...
07cb574c
ringct: remove duplicate rv.mixRing = mixRing; in genRctSimple (stoffu)
2019-01-18 19:02:01 +02:00
stoffu
07cb574ca4
ringct: remove duplicate rv.mixRing = mixRing; in genRctSimple
2019-01-08 11:51:35 +09:00
moneromooo-monero
aaafa8a946
ringct: avoid repeated point conversion
2018-12-12 12:48:10 +00:00
Riccardo Spagni
6bc0c7e685
Merge pull request #4927
...
6456cb41
Bulletproof: Initialize members in default construtor. (Tadeas Moravec)
2018-12-12 12:01:31 +02:00
Riccardo Spagni
e9aa886d9e
Merge pull request #4921
...
ac665418
ringct: fix dummy bulletproofs on ledger in fake mode (moneromooo-monero)
2018-12-12 11:59:56 +02:00
Riccardo Spagni
81418cb281
Merge pull request #4894
...
aee7a4e3
wallet_rpc_server: do not use RPC data if the call failed (moneromooo-monero)
1a0733e5
windows_service: fix memory leak (moneromooo-monero)
0dac3c64
unit_tests: do not rethrow a copy of an exception (moneromooo-monero)
5d9915ab
cryptonote: fix get_unit for non default settings (moneromooo-monero)
d4f50cb1
remove some unused code (moneromooo-monero)
61163971
a few minor (but easy) performance tweaks (moneromooo-monero)
30023074
tests: slow_memmem now returns size_t (moneromooo-monero)
2018-12-04 17:33:19 +02:00
Riccardo Spagni
6d1c2a9304
Merge pull request #4892
...
c28e3d2d
rctOps: add braces to suppress warnings (stoffu)
2018-12-04 17:32:42 +02:00
Riccardo Spagni
c00ac446fd
Merge pull request #4854
...
bd98e99c
Removed a lot of unnecessary includes (Martijn Otto)
2018-12-04 17:08:42 +02:00
Tadeas Moravec
6456cb415a
Bulletproof: Initialize members in default construtor.
...
Fixing a build warning on g++ 7.3.0
2018-12-01 13:03:32 +00:00
moneromooo-monero
ac665418f0
ringct: fix dummy bulletproofs on ledger in fake mode
...
Ledger does some basic checks on them
2018-11-30 13:33:29 +00:00
Riccardo Spagni
3e2abc9eaa
Merge pull request #4834
...
2c7195d8
bulletproofs: avoid std::vector allocations for slice (moneromooo-monero)
2018-11-26 20:30:15 +02:00
moneromooo-monero
611639710d
a few minor (but easy) performance tweaks
...
Found by codacy.com
2018-11-23 15:36:48 +00:00
stoffu
c28e3d2dae
rctOps: add braces to suppress warnings
2018-11-23 12:28:04 +09:00
Riccardo Spagni
0295055bcb
Merge pull request #4805
...
6a1062f5
bulletproofs: reserve vector memory when known in advance (moneromooo-monero)
2018-11-16 11:16:12 +02:00
Riccardo Spagni
cec336ecbc
Merge pull request #4804
...
00907c39
rct: speedup commit a little (moneromooo-monero)
2018-11-16 11:15:56 +02:00
Riccardo Spagni
46f989bc49
Merge pull request #4795
...
5d7c2316
rct: add a zeroCommit cache for common pre-rct case (moneromooo-monero)
2018-11-16 11:11:10 +02:00
Martijn Otto
bd98e99c80
Removed a lot of unnecessary includes
2018-11-15 17:29:34 +01:00
moneromooo-monero
2c7195d80c
bulletproofs: avoid std::vector allocations for slice
2018-11-09 19:58:11 +00:00
moneromooo-monero
6a1062f560
bulletproofs: reserve vector memory when known in advance
2018-11-05 14:32:32 +00:00
moneromooo-monero
00907c3987
rct: speedup commit a little
...
saves a conversion, and uses a double scalarmult instead of
two scalarmults
2018-11-05 14:25:11 +00:00
Riccardo Spagni
6d3d8635be
Merge pull request #4693
...
74fb3d88
multiexp: some minor speedups (moneromooo-monero)
a6d2e246
bulletproofs: only enable profiling on request (moneromooo-monero)
a110e6aa
multiexp: tune which variants to use for which number of points (moneromooo-monero)
8b476722
bulletproofs: speedup prover (moneromooo-monero)
6f9ae5b6
multiexp: handle pippenger multiexps with part precalc (moneromooo-monero)
10e5a927
bulletproofs: maintain -z4, -z5, and -y0 to avoid subtractions (moneromooo-monero)
8629a42c
bulletproofs: rework flow to use sarang's fast batch inversion code (moneromooo-monero)
fc9f7d9c
bulletproofs: merge multiexps as per sarang's new python code (moneromooo-monero)
4061960a
multiexp: pack the digits table when STRAUS_C is 4 (moneromooo-monero)
bf8e4b98
bulletproofs: some more minor speedup (moneromooo-monero)
c415df97
performance_tests: sc_check and ge_dsm_precomp (moneromooo-monero)
a281b950
bulletproofs: remove single value prover (moneromooo-monero)
484155d0
bulletproofs: some more speedup (moneromooo-monero)
a621d6c8
bulletproofs: random minor speedups (moneromooo-monero)
a49a1761
bulletproofs: shave off a lot of scalar muls from the g/h construction (moneromooo-monero)
4564a5d1
bulletproofs: speedup PROVE (moneromooo-monero)
2018-11-04 20:46:42 +02:00
moneromooo-monero
5d7c231604
rct: add a zeroCommit cache for common pre-rct case
...
This is called for every pre-rct output at blockchain sync time,
and a lot of them wil hit the cache, saving a scalarmult each.
2018-11-04 15:44:56 +00:00
Dusan Klinec
29ffb6bba8
device/trezor: trezor support added
2018-11-02 21:36:39 +01:00
moneromooo-monero
d6937e373b
ringct: use dummy bulletproofs when in fake mode, for speed
2018-10-23 21:03:18 +00:00
moneromooo-monero
74fb3d882c
multiexp: some minor speedups
2018-10-22 16:08:26 +00:00
moneromooo-monero
a6d2e246f3
bulletproofs: only enable profiling on request
2018-10-22 16:07:44 +00:00
moneromooo-monero
a110e6aa18
multiexp: tune which variants to use for which number of points
2018-10-22 16:07:44 +00:00
moneromooo-monero
8b4767221c
bulletproofs: speedup prover
2018-10-22 16:07:44 +00:00
moneromooo-monero
6f9ae5b6eb
multiexp: handle pippenger multiexps with part precalc
2018-10-22 16:07:44 +00:00
moneromooo-monero
10e5a92769
bulletproofs: maintain -z4, -z5, and -y0 to avoid subtractions
2018-10-22 16:07:44 +00:00
moneromooo-monero
8629a42cf6
bulletproofs: rework flow to use sarang's fast batch inversion code
2018-10-22 16:07:44 +00:00
moneromooo-monero
fc9f7d9c81
bulletproofs: merge multiexps as per sarang's new python code
2018-10-22 16:07:44 +00:00
moneromooo-monero
4061960a16
multiexp: pack the digits table when STRAUS_C is 4
...
Spotted by stoffu
2018-10-22 16:07:44 +00:00
moneromooo-monero
bf8e4b9870
bulletproofs: some more minor speedup
2018-10-22 16:07:44 +00:00
moneromooo-monero
a281b950bf
bulletproofs: remove single value prover
...
It is now expressed in terms of the array prover
2018-10-22 16:07:44 +00:00
moneromooo-monero
484155d043
bulletproofs: some more speedup
2018-10-22 16:07:44 +00:00
moneromooo-monero
a621d6c8b4
bulletproofs: random minor speedups
2018-10-22 16:07:44 +00:00
moneromooo-monero
a49a17618f
bulletproofs: shave off a lot of scalar muls from the g/h construction
2018-10-22 16:07:44 +00:00
moneromooo-monero
4564a5d17b
bulletproofs: speedup PROVE
2018-10-22 16:07:44 +00:00
moneromooo-monero
1dd5c73f62
bulletproofs: multiply points by 8 first thing in verification
...
instead of merging that with other scalar multiplications
where possible for speed, since this is not actually safe
2018-09-24 14:02:51 +00:00
Riccardo Spagni
4a652d6b52
Merge pull request #4379
...
607301bf
rct: avoid repeated unnecessary conversions when accummulating (moneromooo-monero)
2018-09-21 20:42:41 +02:00
moneromooo-monero
607301bf6d
rct: avoid repeated unnecessary conversions when accummulating
2018-09-14 10:18:01 +00:00
stoffu
67a56a9f8b
rctTypes: fix incorrect serialization
2018-09-12 20:33:10 +09:00
moneromooo-monero
8f418a6db0
bulletproofs: #include <openssl/bn.h>
...
Apparently needed for openssl 1.1.x
2018-09-11 13:38:34 +00:00
moneromooo-monero
2bf636503f
bulletproofs: speed up the latest changes a bit
2018-09-11 13:38:32 +00:00
moneromooo-monero
044dff5a30
bulletproofs: scale points by 8 to ensure subgroup validity
2018-09-11 13:38:31 +00:00
moneromooo-monero
c83012c476
bulletproofs: match aggregated verification to sarang's latest prototype
2018-09-11 13:38:30 +00:00
moneromooo-monero
463434d1f7
more comprehensive test for ge_p3 comparison to identity/point at infinity
...
Reported by QuarksLab.
2018-09-11 13:38:20 +00:00
moneromooo-monero
a129bbd944
multiexp: fix maxscalar off by one
...
Reported by QuarksLab.
2018-09-11 13:38:17 +00:00
moneromooo-monero
7ed496cc78
ringct: error out when hashToPoint* returns the point at infinity
...
Reported by QuarksLab.
2018-09-11 13:38:16 +00:00
moneromooo-monero
61632dc166
ringct: prevent a potential very large allocation
...
Reported by QuarksLab.
2018-09-11 13:38:14 +00:00
moneromooo-monero
0825e97436
multiexp: fix wrong Bos-Coster result for 1 non trivial input
...
Reported by QuarksLab.
2018-09-11 13:38:10 +00:00
moneromooo-monero
a1359ad43c
Check inputs to addKeys are in range
...
Reported by QuarksLab.
2018-09-11 13:38:09 +00:00
moneromooo-monero
fe0fa3b9c5
bulletproofs: reject x, y, z, or w[i] being zero
...
Also try again when we're generate a proof with those characteristics
Reported by QuarksLab.
2018-09-11 13:38:08 +00:00
moneromooo-monero
5ffb2ff9b7
v8: per byte fee, pad bulletproofs, fixed 11 ring size
2018-09-11 13:38:07 +00:00
moneromooo-monero
869b3bf824
bulletproofs: a few fixes from the Kudelski review
...
- fix integer overflow in n_bulletproof_amounts
- check input scalars are in range
- remove use of environment variable to tweak straus performance
- do not use implementation defined signed shift for signum
2018-09-11 13:38:05 +00:00
moneromooo-monero
c429176248
bulletproofs: reject points not in the main subgroup
2018-09-11 13:38:04 +00:00
moneromooo-monero
1569717718
bulletproofs: speed up a few multiplies using existing Hi cache
2018-09-11 13:38:03 +00:00
moneromooo-monero
0b05a0fa74
Add Pippenger cache and limit Straus cache size
2018-09-11 13:38:02 +00:00
moneromooo-monero
263431c486
Pippenger multiexp
...
Based on sarang's python code
2018-09-11 13:37:45 +00:00
moneromooo-monero
1ed0ed4de4
multiexp: cut down on memory allocations
2018-09-11 13:37:44 +00:00
moneromooo-monero
1b867e7f40
precalc the ge_p3 representation of H
2018-09-11 13:37:42 +00:00
moneromooo-monero
7e67c52fa2
Add a define for the max number of bulletproof multi-outputs
2018-09-11 13:37:38 +00:00
moneromooo-monero
2a8fcb421b
Bulletproof aggregated verification and tests
...
Also constrains bulletproofs to simple rct, for simplicity
2018-09-11 13:37:37 +00:00
moneromooo-monero
126196b017
multiexp: some speedups
...
- use a raw memory block to store cache
- use aligned memory
- use doubling API where appropriate
- calculate straus in bands
2018-09-11 13:37:35 +00:00
moneromooo-monero
bacf0a1e2f
bulletproofs: add aggregated verification
...
Ported from sarang's java code
2018-09-11 13:37:32 +00:00
moneromooo-monero
e895c3def1
make straus cached mode thread safe, and add tests for it
2018-09-11 13:37:31 +00:00
moneromooo-monero
7f48bf05d7
multiexp: bos coster now works for just one point
2018-09-11 13:37:30 +00:00
moneromooo-monero
9ce9f8caf6
bulletproofs: add multi output bulletproofs to rct
2018-09-11 13:37:28 +00:00
moneromooo-monero
939bc22332
add Straus multiexp
2018-09-11 13:37:25 +00:00
moneromooo-monero
9ff6e6a0a7
ringct: add bos coster multiexp
2018-09-11 13:37:24 +00:00
moneromooo-monero
e9164bb38b
bulletproofs: misc optimizations
...
Use double mults where possible, avoid conversions, simplify
2018-09-11 13:37:23 +00:00
moneromooo-monero
aacfd6e370
bulletproofs: multi-output bulletproofs
2018-09-11 13:37:17 +00:00
moneromooo-monero
7c8f95d3e2
ringct: make conversion functions return const refs
...
This might avoid unnecessary copies.
Reported by stoffu
2018-09-04 18:28:20 +00:00
luigi1111
5f1bbe3bce
Merge pull request #4268
...
1f2409e
Do memwipe for critical secret keys copied to rct::key (stoffu)
2018-09-04 13:16:04 -05:00
moneromooo-monero
d2e26c23f3
add and use constant time 32 byte equality function
2018-08-23 07:56:51 +00:00
luigi1111
a5d21be843
Merge pull request #4210
...
4616cf2
Fixed ZMQ-RPC for transactions and GET_BLOCKS_FAST (vtnerd)
2018-08-22 20:47:28 -05:00
stoffu
1f2409e9e2
Do memwipe for critical secret keys copied to rct::key
2018-08-16 22:26:30 +09:00
Lee Clagett
4616cf2641
Fixed ZMQ-RPC for transactions and GET_BLOCKS_FAST
2018-08-02 07:30:20 +00:00
luigi1111
3fde902394
Merge pull request #4097
...
61caab8
crypto: remove slight bias in key generation due to modulo (moneromooo-monero)
2018-07-27 14:23:54 -05:00