nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,276 Commits 10 Branches 68 Tags 223 MiB
b5573fc231
Commit Graph

1546 Commits

Author SHA1 Message Date
stoffu
b5573fc231
wallet2: resume processing when tx extra is partially broken 
Motivated by https://monero.stackexchange.com/questions/10483

Some exchanges appear to have customized the wallet software
in an inappropriate way, making the tx extra field partially
unreadable. PR #3716 changed the wallet behavior disallowing
such partially valid tx extra.

An example tx reported by the user is
e87c675a85f34ecac58a8846613d25062f1813e1023c552b705afad32b972c38
where the normal tx pubkey appears again with the aditional
tx pubkeys tag `04` which is inappropriate.
 2018-11-22 14:51:35 +09:00
Riccardo Spagni
056abf980e
Merge pull request #4801 
7ae36e91 wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed (stoffu)
 2018-11-16 11:13:09 +02:00
Riccardo Spagni
f9c60736b8
Merge pull request #4794 
e198b06e Fix: out_of_hashchain_bounds_error in refresh (Hasan Pekdemir)
 2018-11-16 11:10:20 +02:00
Riccardo Spagni
9aff9a5372
Merge pull request #4790 
177a9d76 wallet: warn if lockable memory limit is too low (moneromooo-monero)
 2018-11-16 11:08:07 +02:00
Riccardo Spagni
20bf9b93dd
Merge pull request #4789 
0afdb00b wallet2: fix print_ring printing double entries for transactions (moneromooo-monero)
 2018-11-16 11:07:40 +02:00
Riccardo Spagni
c8cc65f30a
Merge pull request #4788 
8f3963d2 wallet2: demote a few uninteresting recurring logs to TRACE (moneromooo-monero)
 2018-11-16 11:07:21 +02:00
Riccardo Spagni
4561119846
Merge pull request #4784 
1c04c21d wallet_rpc_server: include additional tx keys in sign_transfer response (stoffu)
 2018-11-16 11:05:31 +02:00
Riccardo Spagni
95d96d139d
Merge pull request #4764 
1598f01c wallet2: use padded bulletproofs for multisig signing (stoffu)
 2018-11-16 10:58:29 +02:00
Riccardo Spagni
33ad6fb4c1
Merge pull request #4761 
6e1282b6 wallet2: fix off by one in output picking (moneromooo-monero)
 2018-11-14 21:34:51 +02:00
Riccardo Spagni
59e8a4c306
Merge pull request #4753 
157054b8 hardfork: initialize current_fork_index in ctor (moneromooo-monero)
2362baf7 network_throttle: initialize m_last_sample_time in ctor (moneromooo-monero)
d9400f69 serializtion: add missing mainnet and stagenet fields for 0mq (moneromooo-monero)
cbe0122b wallet2: initialize amount to 0 in tx_scan_info_t ctor (moneromooo-monero)
 2018-11-14 21:33:02 +02:00
Riccardo Spagni
dd42b642ee
Merge pull request #4746 
f3019efe wallet-rpc: add on_restore_deterministic RPC call. (Hasan Pekdemir)
 2018-11-14 21:31:08 +02:00
Riccardo Spagni
8534f71eed
Merge pull request #4814 
840bf155 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation (xiphon)
 2018-11-07 15:02:56 +02:00
stoffu
ba2055a220
api/wallet: fix compile errors made in #4720 2018-11-07 15:12:24 +09:00
xiphon
840bf155a0 build: fix Ubuntu 16.04 (GCC 5.4.0) compilation 2018-11-06 21:45:00 +00:00
Riccardo Spagni
a9e03ebc6a
Merge pull request #4809 
1fd017cf Fix build of monero-gui by adding device_trezor to wallet_merged (buricl)
 2018-11-06 21:35:08 +02:00
Riccardo Spagni
a369a13928
Merge pull request #4743 
9335d5a2 wallet2: save ring in the ringdb once a tx is created (moneromooo-monero)
 2018-11-06 21:33:22 +02:00
Riccardo Spagni
d210d6fb45
Merge pull request #4738 
107f3398 wallet2: fix ring reuse breaking when using histogram (moneromooo-monero)
 2018-11-06 21:31:32 +02:00
Riccardo Spagni
164ba3ef1c
Merge pull request #4731 
f26ce08c wallet: add a non destructive blockchain rescan (moneromooo-monero)
 2018-11-06 21:30:12 +02:00
Riccardo Spagni
b789f7e10d
Merge pull request #4729 
e86af52e wallet2: rewrite keys file in a safer manner (Nathan Dorfman)
 2018-11-06 15:09:45 +02:00
Riccardo Spagni
1667d41064
Merge pull request #4728 
1f35de23 simplewallet: display locked/unlocked state in show_transfers (moneromooo-monero)
 2018-11-06 14:54:17 +02:00
buricl
1fd017cf77 Fix build of monero-gui by adding device_trezor to wallet_merged 2018-11-06 00:17:22 +01:00
moneromooo-monero
6e1282b600
wallet2: fix off by one in output picking 
and take into account wallet level minimum spend age
 2018-11-05 20:13:00 +00:00
stoffu
7ae36e91f6
wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed 
Followup on #4653
 2018-11-05 12:13:15 +09:00
moneromooo-monero
8d71b2b1b3
wallet2: only export necessary outputs and key images 
and disable annoying test that requires ridiculous amounts
of skullduggery every time some format changes
 2018-11-04 22:27:01 +00:00
moneromooo-monero
769ae42a7b
wallet2: faster output and key image import/export 2018-11-04 22:26:59 +00:00
Riccardo Spagni
7e2483e1d5
Merge pull request #4702 
70877b1d wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc (Paul Shapiro)
 2018-11-04 20:47:25 +02:00
Riccardo Spagni
ae919a1e15
Merge pull request #4691 
7f0dd094 wallet2: sanity check rct output distribution from the daemon (moneromooo-monero)
 2018-11-04 20:45:59 +02:00
Riccardo Spagni
0c7086bf7f
Merge pull request #4687 
6097472a Update ZMQ fee estimate and add ZMQ output distribution (Lee Clagett)
 2018-11-04 20:44:49 +02:00
Riccardo Spagni
d394c50f7b
Merge pull request #4686 
cf646e3a wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr (Paul Shapiro)
 2018-11-04 20:44:27 +02:00
Riccardo Spagni
9cf0e67978
Merge pull request #4685 
76681b9b wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args (Paul Shapiro)
 2018-11-04 20:44:00 +02:00
Hasan Pekdemir
e198b06e7a Fix: out_of_hashchain_bounds_error in refresh 
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
 2018-11-04 17:07:30 +01:00
moneromooo-monero
177a9d76f9
wallet: warn if lockable memory limit is too low 2018-11-03 20:09:28 +00:00
moneromooo-monero
f26ce08c8a
wallet: add a non destructive blockchain rescan 2018-11-03 15:04:37 +00:00
moneromooo-monero
8f3963d200
wallet2: demote a few uninteresting recurring logs to TRACE 2018-11-03 11:51:03 +00:00
moneromooo-monero
0afdb00b9d
wallet2: fix print_ring printing double entries for transactions 
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
 2018-11-03 11:50:38 +00:00
Dusan Klinec
29ffb6bba8
device/trezor: trezor support added 2018-11-02 21:36:39 +01:00
stoffu
1c04c21d6e
wallet_rpc_server: include additional tx keys in sign_transfer response 
Followup on #4552
 2018-11-02 21:42:02 +09:00
Riccardo Spagni
3ceeac50da
Merge pull request #4653 
ade369f9 Add RPC error code for non-deterministic wallet (Michał Sałaban)
 2018-11-01 22:33:20 +02:00
stoffu
1598f01caf
wallet2: use padded bulletproofs for multisig signing 
Analogous to #4540
 2018-10-31 20:01:25 +09:00
Hasan Pekdemir
f3019efe1b wallet-rpc: add on_restore_deterministic RPC call. 2018-10-29 18:19:42 +01:00
moneromooo-monero
cbe0122bf1
wallet2: initialize amount to 0 in tx_scan_info_t ctor 
It seems the more prudent thing to do here. It will not catch
attempts to use that value before it is initialized when using
ASAN or valgrind, but in a case where it does, it will have
smaller repercussions.

So it seems appropriate in this particular case.

Coverity 182498
 2018-10-29 16:22:55 +00:00
Nathan Dorfman
e86af52e2f wallet2: rewrite keys file in a safer manner 2018-10-28 09:58:54 -06:00
moneromooo-monero
9335d5a297
wallet2: save ring in the ringdb once a tx is created 
Even if it is never relayed, it ensures a daemon supplying
fake outs on demand will never be asked for a set with the
real input being the only intersecting member (only a problem
with people who trust their privacy to some stranger's node,
but it seems to be a massively common thing, even in Monero)
 2018-10-27 17:59:56 +00:00
moneromooo-monero
107f33985d
wallet2: fix ring reuse breaking when using histogram 2018-10-27 14:35:00 +00:00
Riccardo Spagni
fc06c5daf8
Merge pull request #4617 
3ffbec15 rpc: init m_rpc_version in Message ctor (moneromooo-monero)
bfa2dce1 rpc: remove unused ctors (moneromooo-monero)
7cc39845 account: init creation timestamp to 0 (moneromooo-monero)
32123789 wallet2: initialize some scalar fields in ctor where appropriate (moneromooo-monero)
4eca42b2 blockchain_db: initialize m_hardfork in ctor just in case (moneromooo-monero)
 2018-10-26 22:39:00 +02:00
Riccardo Spagni
148d14164e
Merge pull request #4615 
a7960542 WalletAPI: rescanBlockchain, rescanBlockchainAsync (mmitkevich)
 2018-10-26 22:38:41 +02:00
Riccardo Spagni
c761bee764
Merge pull request #4561 
04ddf02e Return appropriate RPC error code when key image signature check fails (Michał Sałaban)
 2018-10-26 22:33:35 +02:00
Riccardo Spagni
169e6e9074
Merge pull request #4552 
67e76aa0 wallet_rpc_server: optionally return tx keys in sign_transfer (moneromooo-monero)
 2018-10-26 22:32:34 +02:00
Riccardo Spagni
659cf52a61
Merge pull request #4539 
977fc1bc wallet_rpc_server: add describe_transfer RPC (moneromooo-monero)
 2018-10-26 22:20:57 +02:00
moneromooo-monero
1f35de2300
simplewallet: display locked/unlocked state in show_transfers 
it doesn't display the details, which are already displayed
in show_transfer
 2018-10-25 23:02:42 +00:00