Riccardo Spagni
dc7de3312f
Merge pull request #4779
...
233f00c6
2018-11-04 20:41:19 +02:00
Hasan Pekdemir
e198b06e7a
Fix: out_of_hashchain_bounds_error in refresh
...
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
2018-11-04 17:07:30 +01:00
moneromooo-monero
5d7c231604
rct: add a zeroCommit cache for common pre-rct case
...
This is called for every pre-rct output at blockchain sync time,
and a lot of them wil hit the cache, saving a scalarmult each.
2018-11-04 15:44:56 +00:00
moneromooo-monero
5808530f54
blockchain: remove unused output_scan_worker parameter
2018-11-04 13:23:05 +00:00
moneromooo-monero
1426209a10
blockchain: don't run threads if we have just one function to run
2018-11-04 13:23:02 +00:00
moneromooo-monero
6f7a5fd4f7
db_lmdb: slight speedup getting array data from the blockchain
2018-11-04 13:23:00 +00:00
stoffu
5d4f3df887
simplewallet: reorganize SCOPED_WALLET_UNLOCK a bit more
...
Followup on #4555
2018-11-04 10:51:14 +09:00
stoffu
5878fe95ce
simplewallet: don't skip asking for password when watch-only
2018-11-04 10:50:03 +09:00
moneromooo-monero
177a9d76f9
wallet: warn if lockable memory limit is too low
2018-11-03 20:09:28 +00:00
moneromooo-monero
f26ce08c8a
wallet: add a non destructive blockchain rescan
2018-11-03 15:04:37 +00:00
moneromooo-monero
8f3963d200
wallet2: demote a few uninteresting recurring logs to TRACE
2018-11-03 11:51:03 +00:00
moneromooo-monero
0afdb00b9d
wallet2: fix print_ring printing double entries for transactions
...
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
2018-11-03 11:50:38 +00:00
cryptochangements34
e61062b6f2
use current height - 1 for top block height in err msgs
2018-11-02 19:31:31 -04:00
Dusan Klinec
29ffb6bba8
device/trezor: trezor support added
2018-11-02 21:36:39 +01:00
stoffu
c22e85fe1a
simplewallet: remove redundant messages on daemon connection failure
...
try_connect_to_daemon with silent=false already prints failure message
2018-11-02 23:25:27 +09:00
stoffu
1c04c21d6e
wallet_rpc_server: include additional tx keys in sign_transfer response
...
Followup on #4552
2018-11-02 21:42:02 +09:00
moneromooo-monero
97cad7e979
db_lmdb: log which output was not found in get_output_key
2018-11-02 11:49:39 +00:00
xiphon
233f00c601
cryptonote_core: fix build error gcc 5.4.0 'sign-compare'
2018-11-01 22:57:08 +00:00
moneromooo-monero
71eb32a976
dns_utils: do not exit if DNS records are corrupt
2018-11-01 22:53:48 +00:00
moneromooo-monero
c17a1d431b
daemon: use msg_writer, not cout, to display information
2018-11-01 22:53:10 +00:00
moneromooo-monero
03fc731bf2
p2p: less frequent incoming connections check
2018-11-01 22:00:35 +00:00
Riccardo Spagni
9a4b15c631
Merge pull request #4664
...
61304151
2018-11-01 22:34:20 +02:00
Riccardo Spagni
7d05e6eab3
Merge pull request #4663
...
d6937e37
2018-11-01 22:34:02 +02:00
Riccardo Spagni
a0cd602e56
Merge pull request #4658
...
ca9b996d
2018-11-01 22:33:38 +02:00
Riccardo Spagni
3ceeac50da
Merge pull request #4653
...
ade369f9
2018-11-01 22:33:20 +02:00
Riccardo Spagni
fde24c80c2
Merge pull request #4648
...
a7bffead
2018-11-01 22:33:02 +02:00
Riccardo Spagni
e7a475e4e6
Merge pull request #4645
...
6f88c03d
2018-11-01 22:32:41 +02:00
Riccardo Spagni
4f7cdd90fd
Merge pull request #4639
...
ec301390
2018-11-01 22:24:11 +02:00
moneromooo-monero
99fbe1008b
db_lmdb: save some string copies for readonly db keys/values
2018-11-01 17:26:09 +00:00
moneromooo-monero
14a5c2068f
p2p: tone down "no incoming connections" warning to info if in peers is 0
...
Also add an info if not offline, since it weakens the network
2018-11-01 16:43:06 +00:00
moneromooo-monero
bf31447e9b
tx_pool: speed up take_tx for transactions from blocks
...
This happens for every historical tx when syncing, and the
unnecessary parsing is actually showing up on profile.
Since these are kept cached for just one block, this does
not increase memory usage after syncing.
2018-11-01 15:51:28 +00:00
moneromooo-monero
4f005a77c2
tx_pool: remove unnecessary get_transaction_hash
2018-11-01 15:51:24 +00:00
moneromooo-monero
593ef5981d
perf_timer: call reserve on new timer array
...
to avoid reallocations in the vast majority of the time
2018-11-01 15:51:22 +00:00
moneromooo-monero
6ecc99ad1f
core: avoid unnecessary tx/blob conversions
2018-11-01 15:51:19 +00:00
RaskaRuby
2bd46065ae
Expose limit-rate defaults from command line help
2018-10-31 14:47:20 -07:00
moneromooo-monero
cf552c752d
tx_pool: allow take_tx to work without m_txs_by_fee_and_receive_time
...
This should make it possible to have two daemons running on the
same database again.
2018-10-31 14:45:02 +00:00
moneromooo-monero
09dbd9cbbc
tx_pool: fix comment about transaction_prefix
...
It was leftover from a change that was undone before commit,
but the comment change was let through
2018-10-31 12:15:38 +00:00
stoffu
1598f01caf
wallet2: use padded bulletproofs for multisig signing
...
Analogous to #4540
2018-10-31 20:01:25 +09:00
xiphon
42d8d5085e
crypto: fix AES encryption on big endian
2018-10-31 03:13:55 +00:00
moneromooo-monero
db24a2e509
hash: fix hash_permutation on big endian
2018-10-29 22:26:44 +00:00
Hasan Pekdemir
f3019efe1b
wallet-rpc: add on_restore_deterministic RPC call.
2018-10-29 18:19:42 +01:00
moneromooo-monero
157054b840
hardfork: initialize current_fork_index in ctor
...
Also order init list to match actual runtime init order
Coverity 136605
2018-10-29 16:23:58 +00:00
moneromooo-monero
d9400f69eb
serializtion: add missing mainnet and stagenet fields for 0mq
...
Coverity 184940
2018-10-29 16:23:14 +00:00
moneromooo-monero
cbe0122bf1
wallet2: initialize amount to 0 in tx_scan_info_t ctor
...
It seems the more prudent thing to do here. It will not catch
attempts to use that value before it is initialized when using
ASAN or valgrind, but in a case where it does, it will have
smaller repercussions.
So it seems appropriate in this particular case.
Coverity 182498
2018-10-29 16:22:55 +00:00
Nathan Dorfman
e86af52e2f
wallet2: rewrite keys file in a safer manner
2018-10-28 09:58:54 -06:00
cryptochangements34
dad5bbfdf9
return message in stop_mining if mining never started
2018-10-28 09:50:33 -04:00
moneromooo-monero
b3e8677c70
cryptonote: use logging functions for errors, not std::cout
2018-10-27 18:07:55 +00:00
moneromooo-monero
9335d5a297
wallet2: save ring in the ringdb once a tx is created
...
Even if it is never relayed, it ensures a daemon supplying
fake outs on demand will never be asked for a set with the
real input being the only intersecting member (only a problem
with people who trust their privacy to some stranger's node,
but it seems to be a massively common thing, even in Monero)
2018-10-27 17:59:56 +00:00
moneromooo-monero
0a95cdaa80
blockchain_utilities: fix logs and cout output colliding
2018-10-27 17:40:01 +00:00
moneromooo-monero
107f33985d
wallet2: fix ring reuse breaking when using histogram
2018-10-27 14:35:00 +00:00
moneromooo-monero
73e504c139
rpc: adjust ring size error message now that too high is also possible
2018-10-27 11:16:28 +00:00
moneromooo-monero
a5ca7f4fb5
core: fix unmixable special case allowing ring size below 11
2018-10-27 11:16:25 +00:00
Riccardo Spagni
00a7d441d6
Merge pull request #4719
...
0aff4987
2018-10-26 22:41:43 +02:00
Riccardo Spagni
20d3605a54
Merge pull request #4700
...
3bb4b0d4
2018-10-26 22:41:21 +02:00
Riccardo Spagni
33d9d2b4c1
Merge pull request #4672
...
62f94e1b
2018-10-26 22:40:47 +02:00
Riccardo Spagni
fc06c5daf8
Merge pull request #4617
...
3ffbec15bfa2dce17cc39845321237894eca42b2
2018-10-26 22:39:00 +02:00
Riccardo Spagni
148d14164e
Merge pull request #4615
...
a7960542
2018-10-26 22:38:41 +02:00
Riccardo Spagni
ecc690a613
Merge pull request #4612
...
2d48861d
2018-10-26 22:38:03 +02:00
Riccardo Spagni
665ab1afbc
Merge pull request #4609
...
e54e5668
2018-10-26 22:36:54 +02:00
Riccardo Spagni
481d7ed147
Merge pull request #4604
...
0fbbb065
2018-10-26 22:35:50 +02:00
Riccardo Spagni
6fc7869eb5
Merge pull request #4586
...
e51c9787
2018-10-26 22:35:03 +02:00
Riccardo Spagni
c761bee764
Merge pull request #4561
...
04ddf02e
2018-10-26 22:33:35 +02:00
Riccardo Spagni
d6fb329653
Merge pull request #4555
...
68e9744d
2018-10-26 22:33:09 +02:00
Riccardo Spagni
169e6e9074
Merge pull request #4552
...
67e76aa0
2018-10-26 22:32:34 +02:00
Riccardo Spagni
b8a4e5b7a6
Merge pull request #4547
...
f2c2c47a
2018-10-26 22:31:37 +02:00
Riccardo Spagni
d7ff24c1e0
Merge pull request #4545
...
93a88d73
2018-10-26 22:30:40 +02:00
Riccardo Spagni
659cf52a61
Merge pull request #4539
...
977fc1bc
2018-10-26 22:20:57 +02:00
Riccardo Spagni
056a58d13f
Merge pull request #4536
...
fd62b6e7
2018-10-26 22:20:39 +02:00
Riccardo Spagni
557c17e206
Merge pull request #4408
...
341b3931
2018-10-26 22:18:41 +02:00
Riccardo Spagni
1c91963dcd
Merge pull request #4308
...
9907ea06
2018-10-26 22:18:28 +02:00
moneromooo-monero
1f35de2300
simplewallet: display locked/unlocked state in show_transfers
...
it doesn't display the details, which are already displayed
in show_transfer
2018-10-25 23:02:42 +00:00
moneromooo-monero
91eaea9c72
mnemonics: fix words_to_bytes on big endian
2018-10-25 20:23:17 +00:00
xiphon
ba0faae789
crypto: fixed groestl on big-endian platforms
2018-10-25 02:06:23 +00:00
moneromooo-monero
0aff49873c
rpc: fix build with older compilers
2018-10-24 20:36:58 +00:00
Pol Mauri
c4fbfd786a
Small function declaration cleanup in slow-hash.c
...
- These functions are declared twice in slow-hash.c. Remove one of the copies.
- The declarations have the wrong return type, should be void, not int.
Function definitions here: 1e74586ee9/src/crypto/aesb.c (L151-L180)
2018-10-23 23:19:52 -07:00
Lee Clagett
6097472a19
Update ZMQ fee estimate and add ZMQ output distribution
2018-10-23 23:46:31 -04:00
moneromooo-monero
d6937e373b
ringct: use dummy bulletproofs when in fake mode, for speed
2018-10-23 21:03:18 +00:00
Howard Chu
a43daebf57
Add stats utility
...
Report statistics from a blockchain DB
2018-10-23 19:43:31 +01:00
moneromooo-monero
61f83316b3
wallet2: extend fake out picks away from the gamma pick
...
in order to unbias selection from blocks with few txes
2018-10-23 09:06:47 +00:00
Paul Shapiro
70877b1d91
wallet2/create_transactions_2: removed obsolete '/ 1024' on min_fee calc
2018-10-22 18:51:45 -05:00
doy-lee
5a2e54a1cb
Fix prune using receive time as tx_weight
2018-10-23 10:03:45 +11:00
moneromooo-monero
3bb4b0d41f
miner: fix build with boost 1.69
2018-10-22 22:17:15 +00:00
moneromooo-monero
74fb3d882c
multiexp: some minor speedups
2018-10-22 16:08:26 +00:00
moneromooo-monero
a6d2e246f3
bulletproofs: only enable profiling on request
2018-10-22 16:07:44 +00:00
moneromooo-monero
a110e6aa18
multiexp: tune which variants to use for which number of points
2018-10-22 16:07:44 +00:00
moneromooo-monero
8b4767221c
bulletproofs: speedup prover
2018-10-22 16:07:44 +00:00
moneromooo-monero
6f9ae5b6eb
multiexp: handle pippenger multiexps with part precalc
2018-10-22 16:07:44 +00:00
moneromooo-monero
10e5a92769
bulletproofs: maintain -z4, -z5, and -y0 to avoid subtractions
2018-10-22 16:07:44 +00:00
moneromooo-monero
8629a42cf6
bulletproofs: rework flow to use sarang's fast batch inversion code
2018-10-22 16:07:44 +00:00
moneromooo-monero
fc9f7d9c81
bulletproofs: merge multiexps as per sarang's new python code
2018-10-22 16:07:44 +00:00
moneromooo-monero
4061960a16
multiexp: pack the digits table when STRAUS_C is 4
...
Spotted by stoffu
2018-10-22 16:07:44 +00:00
moneromooo-monero
bf8e4b9870
bulletproofs: some more minor speedup
2018-10-22 16:07:44 +00:00
moneromooo-monero
a281b950bf
bulletproofs: remove single value prover
...
It is now expressed in terms of the array prover
2018-10-22 16:07:44 +00:00
moneromooo-monero
484155d043
bulletproofs: some more speedup
2018-10-22 16:07:44 +00:00
moneromooo-monero
a621d6c8b4
bulletproofs: random minor speedups
2018-10-22 16:07:44 +00:00
moneromooo-monero
a49a17618f
bulletproofs: shave off a lot of scalar muls from the g/h construction
2018-10-22 16:07:44 +00:00
moneromooo-monero
4564a5d17b
bulletproofs: speedup PROVE
2018-10-22 16:07:44 +00:00
moneromooo-monero
cb4aafd27e
blockchain_utilities: simplify getting block blob from height
2018-10-22 16:04:28 +00:00
xiphon
ed36335c96
crypto: fixed incremental keccak API on big-endian platforms
2018-10-22 18:34:19 +03:00
moneromooo-monero
7f0dd094e7
wallet2: sanity check rct output distribution from the daemon
2018-10-22 14:01:46 +00:00
stoffu
e51c978770
rpc: fix wrongly formatted JSON for pruned tx
...
Fix for #4399 .
Also unifies code for serializing pruned tx to binary/json into one.
2018-10-22 10:52:40 +09:00
xiphon
fd62b6e79f
blocks: use auto-generated .c files instead of 'LD -r -b binary'
2018-10-22 01:12:00 +03:00
Paul Shapiro
4a003bb5a2
mnemonics/electrum-words/create_checksum_index(): updated to work with non fixed word list length mnemonic
2018-10-21 12:46:13 -05:00
Paul Shapiro
76681b9bda
wallet2/create_transactions_2: fixed typo in try_tx=true's estimate_fee args
2018-10-21 12:44:22 -05:00
Paul Shapiro
cf646e3afe
wallet2/create_transactions_2: removed extraneous shuffle before sort of unused_*_indices_per_subaddr
2018-10-21 12:43:31 -05:00
moneromooo-monero
3a85af403d
core: fix handle_incoming_tx* comment about return value
2018-10-21 17:09:21 +00:00
Riccardo Spagni
2287fb9fb4
Merge pull request #4524
...
f5f7c2ac
2018-10-20 20:40:56 +02:00
Riccardo Spagni
a145ae52b6
Merge pull request #4523
...
6ca00b6d
2018-10-20 20:40:36 +02:00
Riccardo Spagni
5c418c0522
Merge pull request #4522
...
a39c0358
2018-10-20 20:40:16 +02:00
Riccardo Spagni
ed4b953bb7
Merge pull request #4518
...
92a0827e
2018-10-20 20:39:36 +02:00
Riccardo Spagni
a38299801f
Merge pull request #4666
...
cf75ee72
2018-10-20 20:38:37 +02:00
Riccardo Spagni
9f34a3a29a
Merge pull request #4659
...
b916ca63
2018-10-20 20:37:54 +02:00
Riccardo Spagni
4cd8850fce
Merge pull request #4642
...
25d327e7825d836f
2018-10-20 20:37:28 +02:00
Riccardo Spagni
bdd32bc2b2
Merge pull request #4650
...
99cd6f96
2018-10-20 20:36:58 +02:00
Riccardo Spagni
93f2c13a39
Merge pull request #4637
...
c39e0a17
2018-10-20 20:36:33 +02:00
Riccardo Spagni
313f16e83c
Merge pull request #4635
...
776aefda#4592 and move bin2hex conversion to on_get_transaction_pool (stoffu)
2018-10-20 20:35:22 +02:00
Riccardo Spagni
fe0e426be4
Merge pull request #4629
...
c7743929
2018-10-20 20:34:15 +02:00
moneromooo-monero
62f94e1b9d
device_io_hid.cpp: fix copyright header
2018-10-20 10:31:27 +00:00
moneromooo-monero
cf75ee722a
blockchain: move two new verification errors to the verify category
...
Lest we get people get scared again
2018-10-19 21:11:12 +00:00
moneromooo-monero
61304151b4
db_lmdb: use MDB_MULTIPLE_NEXT where possible for some speedup
2018-10-19 16:47:29 +00:00
moneromooo-monero
b916ca63a8
rpc: fix output distribution caching ignoring chain changes
...
0 is placeholder for whole chain, so we should compare chain
height changes rather than chain-height-or-zero. Even this isn't
totally foolproof if a blocks are popped and the same number
added again, but it is much better as it prevents the data from
slowly going out of sync.
2018-10-19 09:22:35 +00:00
moneromooo-monero
ca9b996dcb
perf_timer: separate log categories based on caller categories
...
Also default to microseconds, for homogeneity
Makes it easier to enable what we need
2018-10-19 08:59:56 +00:00
moneromooo-monero
a7bffead9e
daemon: fix base fee stating /kB even when it is per byte
2018-10-19 08:39:33 +00:00
Michał Sałaban
ade369f96f
Add RPC error code for non-deterministic wallet
2018-10-18 23:14:06 +02:00
moneromooo-monero
99cd6f961a
Rename "blackball" for clarity
...
Apparently some people seem to think it's a censorship list...
2018-10-18 18:45:45 +00:00
xiphon
25d327e796
device: extended logging, refactored device selection code
2018-10-18 17:53:06 +03:00
Ted Moravec
6f88c03dfc
Simplewallet: update help text for show_transfers.
...
Describe the output format.
2018-10-18 09:14:15 +00:00
Ricardo de Vries
e54e5668a8
daemon: Show mining address
2018-10-18 10:45:42 +02:00
xiphon
825d836f9f
device: fixed Ledger Nano S device selection
2018-10-18 07:42:29 +03:00
stoffu
776aefdac1
tx_pool: revert #4592 and move bin2hex conversion to on_get_transaction_pool
2018-10-18 08:01:56 +09:00
Cactii1
ec3013903b
Update db_lmdb.cpp
2018-10-17 21:36:10 +02:00
moneromooo-monero
c39e0a1706
core: don't verify range proofs multiple times
2018-10-17 16:23:10 +00:00
moneromooo-monero
c774392985
spawn: close all file descriptors before execve
...
No need to give whatever we're calling access to what we use
2018-10-17 09:31:34 +00:00
moneromooo-monero
a69fc05a0c
util: close keys file lock on exec
2018-10-16 17:20:44 +00:00
Riccardo Spagni
5c85da5a73
Merge pull request #4610
...
9b6dd934
2018-10-16 18:25:14 +02:00
Riccardo Spagni
d4e4fac209
Merge pull request #4602
...
6f28667a
2018-10-16 18:23:44 +02:00
Riccardo Spagni
c5be5ca6b4
Merge pull request #4623
...
99d45a95
2018-10-16 18:23:30 +02:00
moneromooo-monero
99d45a9578
wallet_rpc_server: fix change_wallet_password RPC
2018-10-16 15:19:05 +00:00
Riccardo Spagni
e0a1d45d76
Merge pull request #4621
...
0cdd4b07
2018-10-16 17:13:39 +02:00
moneromooo-monero
0cdd4b074e
wallet2_api: fix generating new wallet in the GUI
...
It was creating a new wallet without a password first (this should
be fixed), then not changing the password correctly
2018-10-16 14:46:17 +00:00
moneromooo-monero
3ffbec1556
rpc: init m_rpc_version in Message ctor
...
Coverity 182501
2018-10-16 11:58:54 +00:00
moneromooo-monero
bfa2dce171
rpc: remove unused ctors
...
Also prevents coverity from moaning about them not initializing fields
2018-10-16 11:58:52 +00:00
moneromooo-monero
7cc39845be
account: init creation timestamp to 0
...
Never actually used uninitialized
Coverity 136615
2018-10-16 11:58:50 +00:00
moneromooo-monero
3212378912
wallet2: initialize some scalar fields in ctor where appropriate
...
Coverity 188336
2018-10-16 11:58:48 +00:00
moneromooo-monero
4eca42b241
blockchain_db: initialize m_hardfork in ctor just in case
...
Coverity 136568
2018-10-16 11:58:46 +00:00
mmitkevich
a7960542a9
WalletAPI: rescanBlockchain, rescanBlockchainAsync
2018-10-16 14:58:22 +03:00
moneromooo-monero
2d48861db7
p2p: only deinitialize what's been initialized in offline mode
2018-10-16 09:20:05 +00:00
Lee Clagett
9b6dd9348c
Providing user supplied default constructor for expect<void>
2018-10-15 23:42:29 -04:00
iDunk5400
e7f24850d5
Fix Windows build after epee dependency change
2018-10-15 23:08:17 +00:00
moneromooo-monero
0fbbb065d4
p2p: a negative result from UPNP_GetValidIGD is an error
...
as per the source documentation
2018-10-15 22:41:00 +00:00
