nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,741 Commits 10 Branches 68 Tags 223 MiB
5b9c3df5c1
Commit Graph

1640 Commits

Author SHA1 Message Date
Riccardo Spagni
2371a814cf
Merge pull request #4387 
6e6ffc06 wallet2_api: bring up to latest wallet api (moneromooo-monero)
 2018-09-18 17:59:44 +02:00
Riccardo Spagni
535bd0eb7e
Merge pull request #4361 
26971d46 WalletAPI: 'hasMultisigPartialKeyImages' function added (naughtyfox)
 2018-09-18 17:58:53 +02:00
Riccardo Spagni
08f0c60ffc
Merge pull request #4360 
7a76354c wallet2: import_multisig forward refresh exception (naughtyfox)
 2018-09-18 17:58:14 +02:00
Riccardo Spagni
580497d5f9
Merge pull request #4306 
56b50faa wallet: use wipeable_string in more places where a secret is used (moneromooo-monero)
07ec748c wipeable_string: add hex_to_pod function (moneromooo-monero)
 2018-09-18 17:32:11 +02:00
Riccardo Spagni
b174527f1d
Merge pull request #4302 
ba8dd347 api/wallet: properly disable key encryption (stoffu)
 2018-09-18 17:31:35 +02:00
Riccardo Spagni
b4a9ebad6c
Merge pull request #4299 
f9b22a7b hw_device: support for multiple devices added [for review] (Dusan Klinec)
 2018-09-18 17:29:26 +02:00
whythat
4ed30bab50
wallet: implement coin splitting for sweep_* 'outputs' option 
Implemented strategy splits total amount into N equal parts,
where N is a specified number of outputs. If N > 1, dummy
change output is NOT created.

rebased by moneromooo
 2018-09-18 11:02:03 +00:00
whythat
24f5239693
wallet: add 'outputs' option for sweep_* commands 
'outputs' option allows to specify the number of
separate outputs of smaller denomination that will
be created by sweep operation.

rebased by moneromooo
 2018-09-18 11:01:59 +00:00
stoffu
ba8dd3479d
api/wallet: properly disable key encryption 2018-09-17 22:15:29 +09:00
moneromooo-monero
b766014933
node_rpc_proxy: return a non empty error string on connection failure 
This makes it easier to avoid bugs on the caller side if errors are
represented by non empty strings.

This fixes the refresh height setting in new wallets when no daemon
is running.
 2018-09-17 11:03:46 +00:00
moneromooo-monero
6e6ffc0650
wallet2_api: bring up to latest wallet api 2018-09-16 13:24:48 +00:00
jcktm
c336d0f217 add daemonizer to rpc wallet 2018-09-15 06:24:27 +10:00
Dusan Klinec
f9b22a7b01
hw_device: support for multiple devices added [for review] 
- device name is a new wallet property
- full device name is now a bit more structured so we can address particular device vendor + device path. Example: 'Ledger', 'Trezor:udp', 'Trezor:udp:127.0.0.1:21324', 'Trezor:bridge:usb01'. The part before ':' identifies HW device implementation, the optional part after ':' is device path to look for.
- new --hw-device parameter added to the wallet, can name the hardware device
- device reconnect added
 2018-09-14 16:02:00 +02:00
Riccardo Spagni
d743994086
Merge pull request #4324 
44259e56 wallet: ask-password can now ask without encrypting the secret spend key (moneromooo-monero)
 2018-09-14 13:15:41 +02:00
moneromooo-monero
44259e560e
wallet: ask-password can now ask without encrypting the secret spend key 2018-09-14 11:14:21 +00:00
Riccardo Spagni
fd194aaa4d
Merge pull request #4347 
df0e7c2f wallet2: fix secondary partially signed multisig txes (moneromooo-monero)
 2018-09-14 13:06:38 +02:00
Riccardo Spagni
7850541074
Merge pull request #4337 
97764bae wallet_rpc_server: error out if wallet-file and wallet-dir are both used (moneromooo-monero)
 2018-09-14 13:06:22 +02:00
Riccardo Spagni
b182dc8262
Merge pull request #4336 
5f8f5631 wallet2.get_reserve_proof: throw when specified amount is zero (stoffu)
 2018-09-14 13:06:06 +02:00
Riccardo Spagni
dd2fc3afe3
Merge pull request #4332 
20171746 wallet2: factor the creation of a new wallet keys file (moneromooo-monero)
be6acfd5 wallet2: factor new blockchain setup (moneromooo-monero)
 2018-09-14 13:05:43 +02:00
Riccardo Spagni
1396b65bbc
Merge pull request #4331 
88fbc4a5 wallet2: fill in v2 height for stagenet (moneromooo-monero)
 2018-09-14 13:05:02 +02:00
Riccardo Spagni
5f9374c735
Merge pull request #4329 
45c85c89 remove unused fields from relay_tx RPC (el00ruobuob)
 2018-09-14 13:03:46 +02:00
Riccardo Spagni
239a7e10ff
Merge pull request #4253 
be001326 remove obsolete daemon selection of fake outs and old tx construction (moneromooo-monero)
 2018-09-14 12:54:25 +02:00
moneromooo-monero
be001326d1
remove obsolete daemon selection of fake outs and old tx construction 2018-09-14 10:51:45 +00:00
Riccardo Spagni
c74d9057f8
Merge pull request #4260 
a54dbaee blockchain_blackball: add --force-chain-reaction-pass flag (moneromooo-monero)
44439c32 record blackballs as amount/offset, and add export ability (moneromooo-monero)
4bce935b blockchain_blackball: more optimizations (moneromooo-monero)
b66ba783 blockchain_blackball: do not process duplicate blockchains parts (moneromooo-monero)
639a3c01 blockchain_blackball: make it clear secondary passes are not incremental (moneromooo-monero)
eb8a51be blockchain_blackball: detect spent outputs by partial ring reuse (moneromooo-monero)
d6d276c6 blockchain_blackball: fix chain reaction phase in incremental mode (moneromooo-monero)
2b2a681b blockchain_blackball: avoid false positives for different amounts (moneromooo-monero)
80e4fef3 blockchain_blackball: set transaction looping txn to read only (moneromooo-monero)
4801d6b5 blockchain_blackball: add stats (moneromooo-monero)
846190fd blockchain_blackball: support pre-v2 databases (moneromooo-monero)
daa6cc7d blockchain_blackball: use LMDB for the cache (moneromooo-monero)
50cb370d ringdb: allow blackballing many outputs at once (moneromooo-monero)
 2018-09-14 12:45:18 +02:00
Riccardo Spagni
438781afc4
Merge pull request #4221 
62511df6 wallet2: fix refresh retry when a block/tx fails to parse (moneromooo-monero)
b219c24c wallet2: trim hash chain after fast refresh of hashes (moneromooo-monero)
5b6bcca3 wallet2: fix checking the wrong vector when adding hashes (moneromooo-monero)
 2018-09-14 12:38:36 +02:00
moneromooo-monero
56b50faab2
wallet: use wipeable_string in more places where a secret is used 2018-09-12 09:26:11 +00:00
Riccardo Spagni
157690caaa
Merge pull request #4352 
0664a984 wallet_rpc_server: remove some unused code (moneroexamples)
 2018-09-11 21:26:50 +02:00
moneromooo-monero
ac4f71c200
wallet2: bump testnet rollback to account for coming reorg 2018-09-11 13:38:35 +00:00
moneromooo-monero
a1359ad43c
Check inputs to addKeys are in range 
Reported by QuarksLab.
 2018-09-11 13:38:09 +00:00
moneromooo-monero
5ffb2ff9b7
v8: per byte fee, pad bulletproofs, fixed 11 ring size 2018-09-11 13:38:07 +00:00
moneromooo-monero
2a8fcb421b
Bulletproof aggregated verification and tests 
Also constrains bulletproofs to simple rct, for simplicity
 2018-09-11 13:37:37 +00:00
moneromooo-monero
9ce9f8caf6
bulletproofs: add multi output bulletproofs to rct 2018-09-11 13:37:28 +00:00
naughtyfox
26971d46fc WalletAPI: 'hasMultisigPartialKeyImages' function added 2018-09-10 19:33:08 +03:00
naughtyfox
7a76354c8b wallet2: import_multisig forward refresh exception 2018-09-10 18:45:37 +03:00
moneromooo-monero
44439c3208
record blackballs as amount/offset, and add export ability 2018-09-10 09:04:18 +00:00
moneroexamples
0664a98421
wallet_rpc_server: remove some unused code 2018-09-09 12:37:01 +00:00
moneromooo-monero
50cb370d5b
ringdb: allow blackballing many outputs at once 
It cuts down on txn commits, and speeds up blackballing substantially
 2018-09-09 12:01:43 +00:00
moneromooo-monero
df0e7c2feb
wallet2: fix secondary partially signed multisig txes 2018-09-08 23:12:06 +00:00
moneromooo-monero
97764bae3a
wallet_rpc_server: error out if wallet-file and wallet-dir are both used 2018-09-08 20:54:14 +00:00
Guillaume LE VAILLANT
54b859bea5 wallet rpc: Add close_wallet RPC 
And close the current wallet automatically if necessary when opening another
wallet.
 2018-09-05 16:52:16 +02:00
luigi1111
77ed11e627
Merge pull request #4270 
29dea03 epee: resize vectors where possible in serialization (moneromooo-monero)
76affd9 epee: some speedup in parsing (moneromooo-monero)
dc6c069 db_lmdb: speedup the get_output_distribution common case (moneromooo-monero)
76ac5a8 wallet2: ask for a binary output distribution, for speed (moneromooo-monero)
 2018-09-04 13:19:58 -05:00
luigi1111
59e6fb06f9
Merge pull request #4269 
3d5abbe [#4027] add change_wallet_password wallet rpc command (artyomsol)
 2018-09-04 13:17:40 -05:00
luigi1111
5f1bbe3bce
Merge pull request #4268 
1f2409e Do memwipe for critical secret keys copied to rct::key (stoffu)
 2018-09-04 13:16:04 -05:00
luigi1111
085b6ba98e
Merge pull request #4263 
5ed6669 wallet_rpc_server: remove unused amount_keys field in transfer RPC (moneromooo-monero)
 2018-09-04 13:12:48 -05:00
luigi1111
6d4d4ddb68
Merge pull request #4252 
ac09cfa wallet2: remove obsolete pruned/unpruned case (moneromooo-monero)
 2018-09-04 13:05:12 -05:00
stoffu
5f8f56315c
wallet2.get_reserve_proof: throw when specified amount is zero 2018-09-04 13:00:38 +09:00
moneromooo-monero
20171746de
wallet2: factor the creation of a new wallet keys file 2018-09-03 11:27:46 +00:00
moneromooo-monero
be6acfd5be
wallet2: factor new blockchain setup 2018-09-03 11:27:43 +00:00
moneromooo-monero
88fbc4a567
wallet2: fill in v2 height for stagenet 2018-09-03 11:26:28 +00:00
el00ruobuob
45c85c89de
remove unused fields from relay_tx RPC 2018-09-02 23:50:31 +02:00
stoffu
8ca1215f25
wallet: store trusted-daemon flag in wallet2 2018-08-23 14:55:09 +09:00
luigi1111
1db7a29e12
Merge pull request #4247 
10475ab node_rpc_proxy: fix fork earliest height caching [RYO backport] (fireice-uk)
 2018-08-22 21:04:34 -05:00
luigi1111
2e7bfd0de5
Merge pull request #4242 
6fcdc9e rpc-wallet: refresh command added (ph4r05)
 2018-08-22 21:00:10 -05:00
luigi1111
6e8e4fb3b7
Merge pull request #4202 
8439306 wallet2: do not divide by 0 on invalid daemon response (moneromooo-monero)
 2018-08-22 20:42:20 -05:00
Dusan Klinec
6fcdc9e0b2
rpc-wallet: refresh command added 2018-08-22 16:57:55 +02:00
moneromooo-monero
62511df622
wallet2: fix refresh retry when a block/tx fails to parse 
It would switch to a new set of blocks and fail, getting out of sync
with the hash chain in the process
 2018-08-22 09:57:46 +00:00
moneromooo-monero
b219c24c3a
wallet2: trim hash chain after fast refresh of hashes 
This ensures it can't end up filled with the actual placeholders
 2018-08-22 09:57:42 +00:00
moneromooo-monero
5b6bcca32a
wallet2: fix checking the wrong vector when adding hashes 
The two vectors should be the same size anyway, so add an assert
to catch any case where they aren't
 2018-08-22 09:57:39 +00:00
moneromooo-monero
76ac5a8fbe
wallet2: ask for a binary output distribution, for speed 2018-08-19 15:58:25 +00:00
artyomsol
3d5abbe86b [#4027] add change_wallet_password wallet rpc command 2018-08-17 09:54:26 +03:00
stoffu
1f2409e9e2
Do memwipe for critical secret keys copied to rct::key 2018-08-16 22:26:30 +09:00
moneromooo-monero
ab74dc277a
crypto: make secret_key automatically mlock 2018-08-16 11:57:49 +00:00
moneromooo-monero
e9ffa91257
store secret keys encrypted where possible 
The secret spend key is kept encrypted in memory, and
decrypted on the fly when needed.

Both spend and view secret keys are kept encrypted in a JSON
field in the keys file. This avoids leaving the keys in
memory due to being manipulated by the JSON I/O API.
 2018-08-16 11:57:43 +00:00
moneromooo-monero
ea37614efe
wallet: wipe seed from memory where appropriate 2018-08-16 09:17:52 +00:00
stoffu
a64f57fe42
wallet2: make --restricted-rpc available for wallet RPC only 2018-08-16 09:54:23 +09:00
luigi1111
e69e0e9e34
Merge pull request #4194 
0f75717 wallet2: avoid using arbitrary random values when unknown (moneromooo-monero)
 2018-08-15 17:56:23 -05:00
luigi1111
1c55a3756b
Merge pull request #4193 
4520cfd wallet2: guard against bad outputs in import_outputs (moneromooo-monero)
 2018-08-15 17:54:49 -05:00
luigi1111
8d2e454929
Merge pull request #4188 
a3fe1c5 simplewallet: add set_tx_key for importing tx keys from 3rd party wallets (stoffu)
 2018-08-15 17:47:05 -05:00
luigi1111
7aa2030cee
Merge pull request #4174 
ff37bd0 wallet2: fix O(n^2) behaviour in import_key_images (moneromooo-monero)
 2018-08-15 17:40:55 -05:00
luigi1111
a68143bc52
Merge pull request #4171 
9127a8b wallet-rpc: filter getbalance response by address index (stoffu)
 2018-08-15 17:37:23 -05:00
luigi1111
564e9c3b5f
Merge pull request #4170 
1c6cfd3 wallet-rpc: add get_address_index command (stoffu)
 2018-08-15 17:35:49 -05:00
luigi1111
e7328ed5b7
Merge pull request #4158 
7db7ec8 wallet rpc: support making integrated address of given standard address (stoffu)
 2018-08-15 17:25:19 -05:00
luigi1111
5e795ee7af
Merge pull request #4153 
37f0799 wallet: distinguish coinbase from other txes in show_transfers (moneromooo-monero)
 2018-08-15 17:23:56 -05:00
luigi1111
2a44c2defd
Merge pull request #4150 
f2e65c6 wallet2: consider minimum fee when testing if balance is sufficient (stoffu)
 2018-08-15 17:22:36 -05:00
luigi1111
1d2c08610b
Merge pull request #4136 
4307489 wallet: disable core dumps on startup in release mode (moneromooo-monero)
 2018-08-15 17:15:49 -05:00
luigi1111
017e07a035
Merge pull request #4103 
bcab579 wallet: allow adjusting number of rounds for the key derivation function (stoffu)
 2018-08-15 17:09:52 -05:00
luigi1111
4cde4cb946
Merge pull request #3528 
34d4b79 wallet2: use a gamma distribution to pick fake outs (moneromooo-monero)
 2018-08-15 17:00:32 -05:00
moneromooo-monero
5ed6669130
wallet_rpc_server: remove unused amount_keys field in transfer RPC 2018-08-15 12:47:33 +00:00
fireice-uk
10475ab23f node_rpc_proxy: fix fork earliest height caching [RYO backport] 
xref https://github.com/ryo-currency/ryo-currency/pull/86
 2018-08-13 22:16:17 +02:00
moneromooo-monero
ac09cfa6be
wallet2: remove obsolete pruned/unpruned case 
All daemons will not support pruned blocks
 2018-08-13 13:17:27 +00:00
moneromooo-monero
4307489147
wallet: disable core dumps on startup in release mode 2018-08-12 16:28:10 +00:00
stoffu
bcab579864
wallet: allow adjusting number of rounds for the key derivation function 2018-08-08 01:56:54 +09:00
moneromooo-monero
37f0799284
wallet: distinguish coinbase from other txes in show_transfers 2018-08-03 12:48:16 +00:00
moneromooo-monero
8439306212
wallet2: do not divide by 0 on invalid daemon response 2018-07-31 14:26:00 +00:00
stoffu
1c6cfd34f4
wallet-rpc: add get_address_index command 2018-07-31 21:36:12 +09:00
stoffu
9127a8b79f
wallet-rpc: filter getbalance response by address index 2018-07-31 20:45:41 +09:00
moneromooo-monero
0f757177fe
wallet2: avoid using arbitrary random values when unknown 2018-07-30 13:34:15 +01:00
moneromooo-monero
4520cfd978
wallet2: guard against bad outputs in import_outputs 
also some minor speedup
 2018-07-30 13:21:58 +01:00
stoffu
a3fe1c56ee
simplewallet: add set_tx_key for importing tx keys from 3rd party wallets 2018-07-30 20:50:05 +09:00
luigi1111
f739a3cbb8
Merge pull request #4109 
2951436 wallet: warn when payment IDs are used (moneromooo-monero)
 2018-07-27 14:27:47 -05:00
luigi1111
92b5d6c204
Merge pull request #4091 
a4272de wallet2: unlock keys file before calling verify_password (needed for Windows) (stoffu)
 2018-07-27 14:22:34 -05:00
moneromooo-monero
ff37bd00bc
wallet2: fix O(n^2) behaviour in import_key_images 
That takes a lot of time for even not so large wallets
 2018-07-24 14:34:19 +01:00
stoffu
7db7ec8591
wallet rpc: support making integrated address of given standard address 2018-07-20 21:33:36 +09:00
luigi1111
702a41034d
Merge pull request #4088 
8c4db68 node_rpc_proxy: factor a few RPC calls using get_info (moneromooo-monero)
 2018-07-19 14:15:16 -05:00
luigi1111
5c102c60dc
Merge pull request #4087 
d6440ab wallet2: recover from index out of hashchain bounds error (moneromooo-monero)
 2018-07-19 14:14:10 -05:00
luigi1111
f6d7e87b67
Merge pull request #4075 
438d52d remove epee from link lines where it's redundant (moneromooo-monero)
 2018-07-19 14:10:20 -05:00
luigi1111
be81a27fa4
Merge pull request #4071 
d6d78f1 Allow fractional outputs to be ignored (stoffu)
 2018-07-19 14:06:54 -05:00
luigi1111
9315e12d34
Merge pull request #4033 
3e46db9 rpc: add a non binary get_transaction_pool_hashes RPC (moneromooo-monero)
 2018-07-19 13:55:37 -05:00
stoffu
f2e65c6e50
wallet2: consider minimum fee when testing if balance is sufficient 2018-07-19 20:31:07 +09:00
moneromooo-monero
d6440ab319
wallet2: recover from index out of hashchain bounds error 
This can happen when there's a very large reorg on the daemon
(ie, on testnet)
 2018-07-16 23:13:56 +01:00
moneromooo-monero
2951436704
wallet: warn when payment IDs are used 
Subaddresses are better for privacy
 2018-07-12 19:37:29 +01:00
moneromooo-monero
fc39d3b23c
wallet2: ensure outputs are processed only once 
This should be proof against any way one might get to multiple
processing, such as generating the same derivation from the
same pubkey, etc
 2018-07-08 12:56:51 +01:00
moneromooo-monero
34d4b798d4
wallet2: use a gamma distribution to pick fake outs 
as per "An Empirical Analysis of Linkability in the Monero
Blockchain", by Miller et al.
 2018-07-03 18:10:48 +01:00
Riccardo Spagni
40f85f478e
Merge pull request #3985 
58cceaad wallet2: fix double counting outs if the tx pubkey is duplicated (moneromooo-monero)
 2018-07-03 15:51:41 +02:00
Riccardo Spagni
f449dbe8eb
Merge pull request #4041 
df9d50a8 wallet2: fix read buffer overflow in import_key_images (moneromooo-monero)
 2018-07-03 15:20:42 +02:00
Riccardo Spagni
94803bad01
Merge pull request #4035 
66df13a5 wallet-rpc.getaddress: throw if index is out of bound (stoffu)
 2018-07-03 15:19:54 +02:00
Riccardo Spagni
97f5a130d6
Merge pull request #4028 
2a19697b wallet2: fix double header in unsigned transfer file (moneromooo-monero)
 2018-07-03 15:19:24 +02:00
Riccardo Spagni
e451c76181
Merge pull request #4005 
b85acb4c Fix RPC crashes that didn't check for an open wallet (Howard Chu)
 2018-07-03 15:18:05 +02:00
Riccardo Spagni
27ca6ca594
Merge pull request #4004 
bc443494 wallet2: fix out of sync account tag cache (moneromooo-monero)
 2018-07-03 15:16:37 +02:00
moneromooo-monero
58cceaad71
wallet2: fix double counting outs if the tx pubkey is duplicated 2018-07-03 14:16:30 +01:00
stoffu
a4272de797
wallet2: unlock keys file before calling verify_password (needed for Windows) 
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused
by anyone at the moment) regarding the need to unlock the keys file beforehand.
 2018-07-03 18:07:20 +09:00
stoffu
d6d78f157b
Allow fractional outputs to be ignored 2018-07-03 18:04:31 +09:00
moneromooo-monero
8c4db68ff7
node_rpc_proxy: factor a few RPC calls using get_info 
Takes advantage of caching
 2018-07-02 17:59:44 +01:00
moneromooo-monero
438d52deaf
remove epee from link lines where it's redundant 
For some reason, this confuses and kills ASAN on startup
as it thinks const uint8_t ipv4_network_address::ID is
defined multiple times.
 2018-06-28 16:45:22 +01:00
luigi1111
a9b83f5a6e
Merge pull request #4067 
9a39b7d wallet2: fix build for windows (std::max again) (moneromooo-monero)
 2018-06-27 21:28:34 -05:00
stoffu
29254fc06e
api/wallet: add missing arg to wallet2::refresh() 2018-06-28 10:24:05 +09:00
luigi1111
ba0a7294d0
Merge pull request #4000 
4510f41 Wallet API: add some missing override keyword (stoffu)
 2018-06-27 20:18:41 -05:00
luigi1111
4c6de54ee2
Merge pull request #3994 
1d17647 epee.string_tools: add conversion between UTF-8 and UTF-16 (stoffu)
59de6f8 util: add file_locker class (stoffu)
3d623a8 wallet: prevent the same wallet file from being opened by multiple processes (stoffu)
 2018-06-27 20:17:25 -05:00
stoffu
4510f417f9
Wallet API: add some missing override keyword 
Also remove dust() from UnsignedTransactionImpl (already in PendingTransactionImpl)
 2018-06-28 09:59:09 +09:00
stoffu
3d623a86d1
wallet: prevent the same wallet file from being opened by multiple processes 2018-06-28 09:41:43 +09:00
moneromooo-monero
9a39b7dd7f
wallet2: fix build for windows (std::max again) 2018-06-28 00:47:48 +01:00
moneromooo-monero
9b38551c3c
wallet_rpc_server: fix build - forgot to build rpc version 2018-06-27 23:34:02 +01:00
luigi1111
2329d2f4c8
Merge pull request #3907 
dcbc17e wallet: include a suggested number of confirmations based on amount (moneromooo-monero)
 2018-06-27 16:32:33 -05:00
luigi1111
8a27caeb22
Merge pull request #3998 
8db23df wallet: on first refresh, start off with a quantized height (moneromooo-monero)
 2018-06-27 16:30:38 -05:00
luigi1111
9453573581
Merge pull request #3995 
0a5292c wallet2: use decoded amount when reporting repeated output key (stoffu)
 2018-06-27 16:28:57 -05:00
luigi1111
c28a2b0d7d
Merge pull request #3992 
25c15dc wallet2: use correct fee for split txes (stoffu)
 2018-06-27 16:26:23 -05:00
luigi1111
5eb2e01216
Merge pull request #3991 
798dfcf wallet: allow unspendable unmixable outputs to be discarded (stoffu)
 2018-06-27 16:25:03 -05:00
luigi1111
3ad4ecd4ff
Merge pull request #3982 
08b85a8 cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X (stoffu)
0cf80ba net_node: resolve host for node addresses given via command line flags (stoffu)
 2018-06-27 15:38:23 -05:00
moneromooo-monero
dcbc17e97e
wallet: include a suggested number of confirmations based on amount 
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
 2018-06-27 21:38:21 +01:00
luigi1111
a844844cda
Merge pull request #3716 
a2b557f 6795bd0 209ec96 ed2c81e a830db2 57ea902 31a895e ba8331c f7f1917 41be339 f025ae9 ef2cb63 dcfd299 5d3e702 2704624 2771a18 0e4c7d0 (moneromooo-monero)
 2018-06-27 15:33:01 -05:00
moneromooo-monero
0e4c7d0fae
wallet2: cache ringdb key while refreshing 
Speeds up syncing with a lot of outgoing outputs as key generation
runs Cryptonight.
 2018-06-26 22:15:38 +01:00
moneromooo-monero
2771a18e85
threadpool: allow leaf functions to run concurrently 
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
 2018-06-26 22:15:22 +01:00
moneromooo-monero
2704624eae
wallet2: remove unneeded divisions 2018-06-26 22:15:20 +01:00
moneromooo-monero
5d3e70229e
wallet2: remove old blockchain size cache hack 2018-06-26 22:15:18 +01:00
moneromooo-monero
dcfd299239
wallet2: speedup refresh 
key derivation and checking for incoming outputs are threaded
in batch before adding blocks to the local blockchain. Other
minor bits and bobs are also cached.
 2018-06-26 22:15:16 +01:00
moneromooo-monero
f025ae9760
wallet2: avoid re-parsing blocks when refreshing in a loop 2018-06-26 22:15:12 +01:00
moneromooo-monero
41be339655
wallet2: avoid duplicate parsing of tx extra 2018-06-26 22:15:10 +01:00
moneromooo-monero
f7f1917ed4
wallet2: remove useless device locking 2018-06-26 22:14:35 +01:00
moneromooo-monero
ba8331ce41
wallet2: parse blocks in the RPC thread, not the processing thread 
Processing typically is the bottleneck
 2018-06-26 22:14:33 +01:00
moneromooo-monero
31a895e876
wallet2: simplify/speedup process_blocks 2018-06-26 22:14:31 +01:00
moneromooo-monero
57ea90285c
wallet: don't process miner tx if we're refreshing with no-coinbase 2018-06-26 22:14:26 +01:00
moneromooo-monero
ed2c81ed95
replace std::list with std::vector on some hot paths 
also use reserve where appropriate
 2018-06-26 22:14:21 +01:00
moneromooo-monero
6795bd0d4e
rpc: add option to skip coinbase info in get_blocks.bin 2018-06-26 22:14:16 +01:00
moneromooo-monero
a2b557fe5c
wallet2: use std::move on containers where appropriate 2018-06-26 22:14:14 +01:00
luigi1111
506be80601
Merge pull request #3955 
d7a6b72 wallet2: fix bulletproof cold signing (moneromooo-monero)
 2018-06-25 15:09:48 -05:00
luigi1111
26562e9f3c
Merge pull request #3941 
bf26920 wallet2: fix get_approximate_blockchain_height for stagenet (stoffu)
 2018-06-25 14:54:54 -05:00
moneromooo-monero
df9d50a8a4
wallet2: fix read buffer overflow in import_key_images 2018-06-23 09:22:20 +01:00
moneromooo-monero
3e46db97e5
rpc: add a non binary get_transaction_pool_hashes RPC 2018-06-21 09:02:42 +01:00
stoffu
46e90b7780
Wallet API: add support for wallet creation from hardware device 2018-06-21 12:36:27 +09:00
stoffu
8fc0cdb96f
wallet2: lower default for subaddress lookahead when restoring with hardware 2018-06-21 12:35:23 +09:00
stoffu
66df13a58b
wallet-rpc.getaddress: throw if index is out of bound 2018-06-21 10:49:03 +09:00
luigi1111
9a3712541e
Merge pull request #3939 
62c8c07 wallet: do not log by default if we're not asked to log to console (moneromooo-monero)
 2018-06-20 14:52:55 -05:00
luigi1111
51cdd76bbd
Merge pull request #3897 
63d0ab0 mlog: --max-log-files to set the max number of rotated log files (stoffu)
 2018-06-20 14:19:30 -05:00
moneromooo-monero
2a19697bd4
wallet2: fix double header in unsigned transfer file 2018-06-19 22:30:02 +01:00
luigi1111
896512b2b6
Merge pull request #3878 
5a412b7 disable file size sanity check when loading the wallet cache (moneromooo-monero)
 2018-06-19 12:57:59 -05:00
luigi1111
d841339b09
Merge pull request #3829 
4764929 use deterministic viewkey if not supplied (cryptochangements34)
 2018-06-19 12:43:10 -05:00
luigi1111
9226acca4b
Merge pull request #3804 
89e51ec simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet (jcktm)
 2018-06-16 14:15:52 -05:00
luigi1111
4e7897e57c
Merge pull request #3780 
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
 2018-06-16 14:12:57 -05:00
luigi1111
e3012444fb
Merge pull request #3762 
eb9f3a3 check_spend_proof (itssteven)
 2018-06-16 14:10:11 -05:00
luigi1111
7af0b7fffc
Merge pull request #3735 
4812c06 add .load() to make Boost 1.67 happy with its new is_integral check (Teutone)
 2018-06-16 14:07:25 -05:00
Howard Chu
b85acb4cb8
Fix RPC crashes that didn't check for an open wallet 2018-06-15 20:18:41 +01:00
moneromooo-monero
bc443494f3
wallet2: fix out of sync account tag cache 
This would cause crashes when trying to tag an account that was
just created
 2018-06-15 20:18:12 +01:00
moneromooo-monero
8db23df581
wallet: on first refresh, start off with a quantized height 
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
 2018-06-13 22:44:27 +01:00
stoffu
63d0ab09b5
mlog: --max-log-files to set the max number of rotated log files 2018-06-13 12:44:27 +09:00
stoffu
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded 2018-06-13 11:56:40 +09:00
stoffu
0a5292c339
wallet2: use decoded amount when reporting repeated output key 2018-06-13 01:06:44 +09:00
stoffu
25c15dca5c
wallet2: use correct fee for split txes 2018-06-12 12:06:51 +09:00
stoffu
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X 2018-06-11 20:17:02 +09:00
luigi1111
6884db7b31
Merge pull request #3599 
8787fd8 WalletApi: publicMultisigSignerKey method (naughtyfox)
 2018-06-08 14:45:46 -05:00
luigi1111
00635bd68b
Merge pull request #3598 
b21bc00 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) (naughtyfox)
 2018-06-08 14:40:06 -05:00
luigi1111
1af890287b
Merge pull request #3890 
f80b157 wallet2: don't ask for pruned txes yet, we still parse the entire tx (moneromooo-monero)
 2018-06-07 12:12:28 -05:00
moneromooo-monero
d7a6b72c15
wallet2: fix bulletproof cold signing 
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
 2018-06-07 12:29:30 +01:00
stoffu
bf26920f27
wallet2: fix get_approximate_blockchain_height for stagenet 2018-06-06 20:33:01 +09:00
moneromooo-monero
62c8c07c47
wallet: do not log by default if we're not asked to log to console 
This means monero-wallet-rpc still does, but the user level program
does not.
 2018-06-06 10:15:13 +01:00
cryptochangements34
4764929ecb use deterministic viewkey if not supplied 2018-06-05 19:32:03 -04:00
Dusan Klinec
9c2a7b4638 wallet-rpc: watch-only and cold wallet features added 
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs

Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx

- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
 2018-06-03 13:21:00 +02:00
luigi1111
503d2693fd
Merge pull request #3640 
f36132a wallet cli/rpc: terminate execution with code 0 when --help or --version is given (stoffu)
 2018-05-31 14:44:54 -05:00
luigi1111
3ee6a1b706
Merge pull request #3635 
c1bda09 wallet_rpc_server: add a get_version RPC (moneromooo-monero)
 2018-05-31 14:43:18 -05:00
luigi1111
b6eb7484d1
Merge pull request #3592 
90a16b1 crypto: fix initialization order issue with random mutex (moneromooo-monero)
6a61f52 unit_tests: add ringdb unit tests (moneromooo-monero)
 2018-05-31 14:41:17 -05:00
luigi1111
3a373c3d3a
Merge pull request #3489 
47fdb74 WalletApi: getMultisigInfo entry for gui wallets... (naughtyfox)
47fdb74 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings (naughtyfox)
 2018-05-31 14:34:34 -05:00
moneromooo-monero
f80b1571c6
wallet2: don't ask for pruned txes yet, we still parse the entire tx 2018-05-31 16:46:58 +01:00
stoffu
0da5d37bf3
wallet: fix shared ring db path 2018-05-31 08:16:45 +09:00
luigi1111
5b189ce2a8
Merge pull request #3405 
80d2f80 wallet2: Update function parameter documentation (leonklingele)
 2018-05-29 12:52:43 -05:00
moneromooo-monero
5a412b7a3f
disable file size sanity check when loading the wallet cache 2018-05-28 14:58:22 +01:00
Riccardo Spagni
709658d166
Merge pull request #3832 
cb9c7972 Fix output shuffling for multisig (stoffu)
 2018-05-21 20:57:52 +02:00
Riccardo Spagni
d6cefbd1b8
Merge pull request #3745 
b13bddc3 Wallet API: allow log path to be non-default & console output to be configurable (stoffu)
 2018-05-21 20:56:20 +02:00
stoffu
cb9c7972b6
Fix output shuffling for multisig 2018-05-20 09:38:41 +09:00
jcktm
89e51ecd38 simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet 2018-05-15 15:28:42 +10:00
moneromooo-monero
a58d9738c9
wallet2: consider 6 outputs or less to be unmixable from v7 2018-05-10 21:19:33 +01:00
itssteven
eb9f3a3294
check_spend_proof 
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
 2018-05-06 17:42:27 +01:00
Teutone
4812c062c5 add .load() to make Boost 1.67 happy with its new is_integral check 2018-05-05 21:44:28 +02:00
stoffu
b13bddc3c9
Wallet API: allow log path to be non-default & console output to be configurable 2018-05-04 10:21:25 +09:00
Riccardo Spagni
93e76e14a2
Merge pull request #3685 
ffeeefde speedup get_output_histogram for all amounts when min_count > 0 (moneromooo-monero)
2dae0f20 wallet2: add missing parameters to get_output_histogram (moneromooo-monero)
 2018-04-28 16:56:22 +02:00
Riccardo Spagni
35299644b2
Merge pull request #3650 
5bd7f760 import_multisig_info: fix sanity check crash in detach_blockchain (Mikhail Mitkevichl)
 2018-04-28 16:54:37 +02:00
naughtyfox
b21bc00704 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) 2018-04-25 17:55:54 +03:00
moneromooo-monero
2dae0f203a
wallet2: add missing parameters to get_output_histogram 2018-04-23 10:54:25 +01:00
stoffu
f36132a837
wallet cli/rpc: terminate execution with code 0 when --help or --version is given 2018-04-22 11:48:44 +09:00
Mikhail Mitkevichl
5bd7f760e9 import_multisig_info: fix sanity check crash in detach_blockchain 2018-04-21 23:25:01 +03:00
Riccardo Spagni
a3a617f35f
Merge pull request #3576 
f82c10dc WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time (stoffu)
 2018-04-21 21:58:10 +02:00
Riccardo Spagni
03ff3be10e
Merge pull request #3672 
875c1cab wallet2: increase rpc timeout for get_output_distribution (moneromooo-monero)
70f23217 add top height to get_output_distribution, and cache it for rct (moneromooo-monero)
8c7363fb rpc: add missing perf timer for get_output_distribution (moneromooo-monero)
 2018-04-21 21:54:08 +02:00
moneromooo-monero
875c1cabb9
wallet2: increase rpc timeout for get_output_distribution 2018-04-19 16:06:26 +01:00
moneromooo-monero
70f2321763
add top height to get_output_distribution, and cache it for rct 
This should cache the vast majority of calls for long running wallets
 2018-04-19 16:06:22 +01:00
moneromooo-monero
c1bda097c1
wallet_rpc_server: add a get_version RPC 2018-04-14 13:34:05 +01:00
naughtyfox
8787fd899b WalletApi: publicMultisigSignerKey method 2018-04-13 13:15:20 +03:00
stoffu
b5d6c723e9
wallet2: store subaddress lookahead settings 2018-04-12 22:23:53 +09:00
cslashm
94b899db26 Use 'boost' mutex instead of 'std' mutex 2018-04-12 13:58:57 +02:00
cslashm
2c274e05fe Fix sub-address tx scan. 
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.

Moreover this patch avoid perf decreasing when not using HW device.
 2018-04-12 13:58:57 +02:00
Riccardo Spagni
5e08fd89ea
Merge pull request #3549 
73951cbd wallet2: request transactions in slices when scanning for known rings (moneromooo-monero)
25fe67e4 rpc: allow getting pruned blocks from gettransactions (moneromooo-monero)
 2018-04-12 13:49:33 +02:00
Riccardo Spagni
14c870ee5f
Merge pull request #3615 
24acb66e wallet2: fix misc issues when the ringdb can't be initialized (moneromooo-monero)
 2018-04-12 13:47:54 +02:00
Riccardo Spagni
3b8704b0fa
Merge pull request #3555 
0b26c4d5 wallet2: move segregation height to v7 (moneromooo-monero)
 2018-04-12 13:47:39 +02:00
Riccardo Spagni
5d8439e310
Merge pull request #3534 
eecfb57d wallet: warn if not using the default ring size (moneromooo-monero)
 2018-04-12 13:47:20 +02:00
Riccardo Spagni
8703f1d80e
Merge pull request #3516 
1e0958c0 wallet: fix default mixin (4 -> 6) (sneurlax)
 2018-04-12 13:46:18 +02:00
moneromooo-monero
24acb66eac
wallet2: fix misc issues when the ringdb can't be initialized 2018-04-12 11:07:07 +01:00
Riccardo Spagni
5053f8f40b
Merge pull request #3502 
11c933e1 fix lambda compile error on openbsd (moneromooo-monero)
 2018-04-12 11:14:43 +02:00
Riccardo Spagni
96b2fee721
Merge pull request #3536 
c77d2bfa Add the possibility to export private view key for fast scan. (cslashm)
100b7bc1 Change mutex lock model to avoid dead lock and ensure locks are always released. (cslashm)
641dfc99 Automatic height setup when creating/restoring hw device. (cslashm)
 2018-04-12 11:12:33 +02:00
Riccardo Spagni
1b4dc46129
Merge pull request #3473 
eaa8bfe7 wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly The previous expression (stoffu)
0a619f78 wallet2: enable the mitigation only after the fork height (stoffu)
 2018-04-12 11:05:31 +02:00
Riccardo Spagni
ebb55f797b
Merge pull request #3468 
0098ed33 wallet2: fix for loading settings of key reuse mitigation (stoffu)
 2018-04-12 11:00:47 +02:00
moneromooo-monero
6a61f520e2
unit_tests: add ringdb unit tests 2018-04-11 11:43:39 +01:00
moneromooo-monero
73951cbd39
wallet2: request transactions in slices when scanning for known rings 
This avoid massive memory consumption for huge wallets
 2018-04-07 08:31:46 +01:00
moneromooo-monero
25fe67e4cf
rpc: allow getting pruned blocks from gettransactions 
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.

Also set decode_to_json to false where missing, we don't need this
either.
 2018-04-07 08:29:11 +01:00
stoffu
f82c10dc96
WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time 2018-04-07 14:06:29 +09:00
moneromooo-monero
0b26c4d57c
wallet2: move segregation height to v7 
since people seem to really want to use things the wrong way.
 2018-04-05 12:49:38 +01:00
cslashm
c77d2bfaa0 Add the possibility to export private view key for fast scan. 
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
 2018-03-31 18:00:33 +02:00
moneromooo-monero
eecfb57df9
wallet: warn if not using the default ring size 2018-03-31 15:47:02 +01:00
sneurlax
1e0958c083 wallet: fix default mixin (4 -> 6) 2018-03-28 09:30:11 -07:00
naughtyfox
5a96056600 WalletApi: getMultisigInfo entry for gui wallets 
WalletApi: makeMultisig call introduced

WalletApi: finalizeMultisig call introduced

WalletApi: new calls exportMultisigImages and importMultisigImages

WalletApi: method to return multisig wallet creation state

WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added

WalletApi: identation and style fixes
 2018-03-28 18:22:13 +03:00
naughtyfox
47fdb74273 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings 
WalletApi: added method statusWithErrorString to atomically retrieve error with error string
 2018-03-28 16:11:16 +03:00
moneromooo-monero
11c933e137
fix lambda compile error on openbsd 2018-03-27 14:48:36 +01:00
stoffu
eaa8bfe7c0
wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly 
The previous expression

    req_t.from_height = X ? Y >= Z : 0;

forces the parameter to take the value of either 0 or 1.
 2018-03-22 20:02:25 +09:00
stoffu
0a619f789b
wallet2: enable the mitigation only after the fork height 2018-03-22 20:02:14 +09:00
stoffu
0098ed338c
wallet2: fix for loading settings of key reuse mitigation 2018-03-22 12:10:46 +09:00
moneromooo-monero
5730049178
wallet: catch exceptions dealing with ringdb and warn 2018-03-21 14:29:49 +00:00
moneromooo-monero
1e393f4bb7
wallet: make the segregation height settable 
via user setting first, then DNS TXT record, hardcoded fallback
 2018-03-17 14:56:31 +00:00
Riccardo Spagni
5cd36e48bf
Merge pull request #3421 
9732a37e wallet_rpc_server: add sweep_unmixable as alias for sweep_dust (moneromooo-monero)
 2018-03-17 16:52:46 +02:00
moneromooo-monero
9732a37e9a
wallet_rpc_server: add sweep_unmixable as alias for sweep_dust 2018-03-17 11:22:58 +00:00
stoffu
b86f1e5dad Add command line option allowing to restrict the default sub-address lookahead in order to avoid 
so looooong time of set-up when creating a HW based wallet.
 2018-03-16 18:00:28 +01:00
Riccardo Spagni
0f27fc57ac
Merge pull request #3336 
57c0b1ed Fix typos in various files (Dimitris Apostolou)
 2018-03-16 18:08:07 +02:00
moneromooo-monero
eac3a11ed3
wallet: more user friendly print_ring 
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
 2018-03-16 12:07:45 +00:00
moneromooo-monero
798535149d
wallet2_api: add key reuse mitigations API 2018-03-16 12:07:42 +00:00
moneromooo-monero
b057a21d56
wallet2_api: add ring api 2018-03-16 10:33:05 +00:00
moneromooo-monero
d32ef7b0f2
ringdb: factor ring addition code 2018-03-16 10:33:02 +00:00
moneromooo-monero
a7da8208f5
wallet2_api: add blackball api 2018-03-16 10:32:59 +00:00
moneromooo-monero
504428ab4a
ringdb: use the genesis block as a db name 
This will avoid careless forkers polluting the shared database
even if they make their own chain. They'll then automatically
start using another subdb, and any key-reusing fork of those
forks will reuse their subdbs.
 2018-03-16 10:32:54 +00:00
moneromooo-monero
b09e5181cc
wallet: add a set_ring command 
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
 2018-03-16 10:32:51 +00:00
moneromooo-monero
db10dd6d83
wallet: make ringdb an object with database state 2018-03-16 10:32:42 +00:00
moneromooo-monero
d29ea0455a
wallet: add an output blackball list to avoid using those in rings 2018-03-16 10:32:37 +00:00
moneromooo-monero
18eaf19489
wallet: key reuse mitigation options 
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.

The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.

This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).

If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.

If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
 2018-03-16 10:32:34 +00:00
moneromooo-monero
5f146873c5
wallet: add shared ring database 
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
 2018-03-16 10:32:29 +00:00
moneromooo-monero
41f727ce42
add RPC to get a histogram of outputs of a given amount 2018-03-16 10:32:26 +00:00
Dimitris Apostolou
57c0b1ed9f Fix typos in various files 2018-03-15 18:25:38 +02:00