nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,110 Commits 10 Branches 68 Tags 223 MiB
46c477ab30
Commit Graph

5706 Commits

Author SHA1 Message Date
Riccardo Spagni
689758d691
Merge pull request #4435 
c39ad0cd tx_pool: fix tx removal at startup keeping references (moneromooo-monero)
 2018-09-25 13:11:05 +02:00
Riccardo Spagni
295bae10ba
Merge pull request #4412 
4d0a8db0 device: fix warnings about overridden functions (moneromooo-monero)
 2018-09-25 12:13:51 +02:00
Riccardo Spagni
e67789d075
Merge pull request #4422 
6e270fbd wallet2_api: fix for latest code changes (moneromooo-monero)
 2018-09-25 12:13:34 +02:00
Riccardo Spagni
0d206dccda
Merge pull request #4430 
50981c40 blockchain: add stagenet v8 and v9, two weeks before mainnet (moneromooo-monero)
 2018-09-25 12:12:29 +02:00
Riccardo Spagni
cd8c7f6e78
Merge pull request #4433 
b35beaa8 wallet_rpc_server: include account index in incoming_transfers RPC (moneromooo-monero)
 2018-09-25 12:12:14 +02:00
Riccardo Spagni
78fd2599c2
Merge pull request #4414 
83907f88 wallet_rpc_server: fix --run-as-service on Windows (moneromooo-monero)
 2018-09-25 12:04:52 +02:00
moneromooo-monero
c39ad0cd72
tx_pool: fix tx removal at startup keeping references 2018-09-25 09:58:37 +00:00
Riccardo Spagni
357441a2fa
add checkpoints for testnet and mainnet 2018-09-25 10:02:05 +02:00
moneromooo-monero
50981c40ce
blockchain: add stagenet v8 and v9, two weeks before mainnet 2018-09-24 20:43:39 +00:00
cslashm
bb6e3bbc0f Replace USB-CCID (smartcard) by USB-HID 
Remove PCSC dependencies which is a bit hard (not user friendly) to install on linux and Mac

Split Ledger logic and device IO
 2018-09-24 21:57:42 +02:00
moneromooo-monero
b35beaa8d6
wallet_rpc_server: include account index in incoming_transfers RPC 2018-09-24 19:42:26 +00:00
moneromooo-monero
1dd5c73f62
bulletproofs: multiply points by 8 first thing in verification 
instead of merging that with other scalar multiplications
where possible for speed, since this is not actually safe
 2018-09-24 14:02:51 +00:00
Riccardo Spagni
d9f666d78c
update checkpoints.dat 2018-09-23 09:51:15 +02:00
moneromooo-monero
6e270fbd29
wallet2_api: fix for latest code changes 2018-09-22 23:00:34 +00:00
oneiric
a21da9058b
Wallet: use unique_ptr for WalletImpl members 
Use unique_ptr to manage WalletImpl internals, rather than raw
pointers.
 2018-09-22 22:03:36 +00:00
Riccardo Spagni
6b1b4e83dd
update version to 13.0 2018-09-22 21:36:11 +02:00
Riccardo Spagni
fb47963e09
Merge pull request #4404 
f3cd51a1 cryptonote tweak v2.2 (Lee Clagett)
 2018-09-22 20:32:40 +02:00
moneromooo-monero
7964d4f8ea
wallet2: handle corner case in picking fake outputs 
If we originally think we have enough outputs on the blockchain
to pick random fake outputs, we might end up with not enough of
them if enough are actually blackballed.
 2018-09-22 15:57:47 +00:00
moneromooo-monero
83907f8829
wallet_rpc_server: fix --run-as-service on Windows 
Thanks iDunk for the windows testing
 2018-09-22 11:56:30 +00:00
Lee Clagett
f3cd51a12b cryptonote tweak v2.2 2018-09-22 03:47:50 +00:00
moneromooo-monero
4d0a8db06d
device: fix warnings about overridden functions 2018-09-21 19:33:15 +00:00
moneromooo-monero
e03402b0c7
wallet_rpc_server: fix build for windows 
Thanks iDunk for building patches on windows
 2018-09-21 18:50:05 +00:00
Riccardo Spagni
b65e236fda
Merge pull request #4405 
8db2d8d4 simplewallet: fix --generate-from-json setting wrong wallet filename (moneromooo-monero)
 2018-09-21 20:46:54 +02:00
Riccardo Spagni
85110b42ab
Merge pull request #4401 
66901901 README: harmonize command formatting inside README.md (Andrea)
8cd98408 disable AES on s390x architecture (Tuan M. Hoang)
4ed30bab wallet: implement coin splitting for sweep_* 'outputs' option (whythat)
24f52396 wallet: add 'outputs' option for sweep_* commands (whythat)
52e19d69 README: Compile boost with cxxflags=-fPIC cflags=-fPIC (Italocoin Project)
0c77523d README: fill in libsodium package name for Arch (phloatingman)
 2018-09-21 20:46:22 +02:00
Riccardo Spagni
fd74815f65
Merge pull request #4399 
f77ce675 rpc: allow pruning of json encoded txs (cryptochangements34)
 2018-09-21 20:46:00 +02:00
Riccardo Spagni
aa1d321e5f
Merge pull request #4395 
9bf0105e Fixed Keccak implementation on big-endian platforms (Alexandro Sanchez)
 2018-09-21 20:45:23 +02:00
Riccardo Spagni
63eeb9df80
Merge pull request #4394 
b7660149 node_rpc_proxy: return a non empty error string on connection failure (moneromooo-monero)
 2018-09-21 20:44:48 +02:00
Riccardo Spagni
37a306370d
Merge pull request #4388 
05edc969 simplewallet: remove obsolete transfer_original command (moneromooo-monero)
 2018-09-21 20:44:19 +02:00
Riccardo Spagni
4a652d6b52
Merge pull request #4379 
607301bf rct: avoid repeated unnecessary conversions when accummulating (moneromooo-monero)
 2018-09-21 20:42:41 +02:00
Riccardo Spagni
0645dcdbdb
Merge pull request #4378 
ac934663 rpc: add a "is an update available" flag in get_info (moneromooo-monero)
 2018-09-21 20:41:53 +02:00
Riccardo Spagni
dc9a69d980
Merge pull request #4376 
2ace509a simplewallet: print reason why refresh+password is needed (moneromooo-monero)
 2018-09-21 20:40:46 +02:00
Riccardo Spagni
629db71593
Merge pull request #4373 
4f81cd3a rpc: add cumulative difficulty in block header data (moneromooo-monero)
 2018-09-21 20:40:23 +02:00
Riccardo Spagni
a059bcd74e
Merge pull request #4371 
55c7cd14 Adding expect<T> - a value-or-error implementation (Lee Clagett)
 2018-09-21 20:31:47 +02:00
Riccardo Spagni
d6893aedf6
Merge pull request #4369 
b2bb9312 blockchain: simplify output distribution code (moneromooo-monero)
befdcbf4 db_lmdb: do not use base for cumulative distribution (moneromooo-monero)
 2018-09-21 20:31:21 +02:00
naughtyfox
7a056f4425 WalletAPI: multisigSignData bug fixed 2018-09-21 14:40:37 +03:00
moneromooo-monero
341b3931ed
cryptonote_core: warn when the block rate deviates from expectations 
The warning threshold is set to allow a false positive every
ten days on average.
 2018-09-20 14:01:52 +00:00
moneromooo-monero
43a06350cf
ringdb: use cursors to be a bit faster 2018-09-20 12:21:57 +00:00
moneromooo-monero
8db2d8d416
simplewallet: fix --generate-from-json setting wrong wallet filename 2018-09-19 20:22:46 +00:00
m2049r
bce474be7d
query backing device 2018-09-19 18:25:38 +02:00
fireice-uk
579383c26b simplewallet: Add Unicode input_line [Ryo backport] 2018-09-19 13:39:01 +01:00
Riccardo Spagni
2371a814cf
Merge pull request #4387 
6e6ffc06 wallet2_api: bring up to latest wallet api (moneromooo-monero)
 2018-09-18 17:59:44 +02:00
Riccardo Spagni
68dcf73de2
Merge pull request #4366 
67a56a9f rctTypes: fix incorrect serialization (stoffu)
 2018-09-18 17:59:20 +02:00
Riccardo Spagni
535bd0eb7e
Merge pull request #4361 
26971d46 WalletAPI: 'hasMultisigPartialKeyImages' function added (naughtyfox)
 2018-09-18 17:58:53 +02:00
Riccardo Spagni
08f0c60ffc
Merge pull request #4360 
7a76354c wallet2: import_multisig forward refresh exception (naughtyfox)
 2018-09-18 17:58:14 +02:00
Riccardo Spagni
df98bc50a6
Merge pull request #4357 
8501b8df crypto_ops_builder: link to EdDSA/Ed25519 draft RFC (moneromooo-monero)
 2018-09-18 17:57:45 +02:00
Riccardo Spagni
9d0565615c
Merge pull request #4354 
03c07b16 rpc: return "already mining" in start_mining if already mining (moneromooo-monero)
 2018-09-18 17:56:51 +02:00
Riccardo Spagni
0ff0850545
Merge pull request #4344 
cd647612 rpc: don't include start time if restricted (moneromooo-monero)
 2018-09-18 17:54:25 +02:00
Riccardo Spagni
7ab49f96ad
Merge pull request #4341 
e6117282 daemon: request no PoW hashes we don't need when asking for blocks (moneromooo-monero)
 2018-09-18 17:39:56 +02:00
Riccardo Spagni
22a6591a70
Merge pull request #4325 
4e1e9a60 blockchain: add mainnet v8 height targetting 18 october (moneromooo-monero)
 2018-09-18 17:39:16 +02:00
Riccardo Spagni
3cfa45cc7d
Merge pull request #4317 
76f95f05 rpc: allow to pass RPC login via RPC_LOGIN env var (Dusan Klinec)
 2018-09-18 17:36:43 +02:00
Riccardo Spagni
e468d541b4
Merge pull request #4311 
f0bc684c mnemonics: fix outrageous compile time with CLANG in release (moneromooo-monero)
 2018-09-18 17:36:13 +02:00
Riccardo Spagni
580497d5f9
Merge pull request #4306 
56b50faa wallet: use wipeable_string in more places where a secret is used (moneromooo-monero)
07ec748c wipeable_string: add hex_to_pod function (moneromooo-monero)
 2018-09-18 17:32:11 +02:00
Riccardo Spagni
b174527f1d
Merge pull request #4302 
ba8dd347 api/wallet: properly disable key encryption (stoffu)
 2018-09-18 17:31:35 +02:00
Riccardo Spagni
b4a9ebad6c
Merge pull request #4299 
f9b22a7b hw_device: support for multiple devices added [for review] (Dusan Klinec)
 2018-09-18 17:29:26 +02:00
Riccardo Spagni
728a947646
Merge pull request #4273 
c336d0f2 add daemonizer to rpc wallet (jcktm)
 2018-09-18 16:40:04 +02:00
Riccardo Spagni
9c40bc62fc
Merge pull request #3430 
42397359 Fixup 32bit arm build (TheCharlatan)
a06d2581 Fix Windows build (TheCharlatan)
ecaf5b3f Add libsodium to the packages, the arm build was complaining about it. (TheCharlatan)
cbbf4d24 Adapt translations to upstream changes (TheCharlatan)
db571546 Updated pcsc url (TheCharlatan)
f0ba19fd Add lrelease to the depends (TheCharlatan)
cfb30462 Add Miniupnp submodule (TheCharlatan)
5f7da005 Unbound is now a submodule. Adapt depends for this. (TheCharlatan)
d6b9bdd3 Update readmes to reflect the usage of depends (TheCharlatan)
56b6e41e Add support for apple and arm building (TheCharlatan)
29311fd1 Disable stack unwinding for mingw32 depends build. (TheCharlatan)
8db3d573 Modify depends for monero's dependencies (TheCharlatan)
0806a23a Initial depends addition (TheCharlatan)
 2018-09-18 16:33:21 +02:00
whythat
4ed30bab50
wallet: implement coin splitting for sweep_* 'outputs' option 
Implemented strategy splits total amount into N equal parts,
where N is a specified number of outputs. If N > 1, dummy
change output is NOT created.

rebased by moneromooo
 2018-09-18 11:02:03 +00:00
whythat
24f5239693
wallet: add 'outputs' option for sweep_* commands 
'outputs' option allows to specify the number of
separate outputs of smaller denomination that will
be created by sweep operation.

rebased by moneromooo
 2018-09-18 11:01:59 +00:00
cryptochangements34
f77ce675cb rpc: allow pruning of json encoded txs 2018-09-17 20:38:40 -04:00
Alexandro Sanchez
9bf0105e25 Fixed Keccak implementation on big-endian platforms 2018-09-17 18:24:20 +02:00
stoffu
ba8dd3479d
api/wallet: properly disable key encryption 2018-09-17 22:15:29 +09:00
moneromooo-monero
b766014933
node_rpc_proxy: return a non empty error string on connection failure 
This makes it easier to avoid bugs on the caller side if errors are
represented by non empty strings.

This fixes the refresh height setting in new wallets when no daemon
is running.
 2018-09-17 11:03:46 +00:00
moneromooo-monero
05edc969c0
simplewallet: remove obsolete transfer_original command 2018-09-16 14:29:41 +00:00
moneromooo-monero
6e6ffc0650
wallet2_api: bring up to latest wallet api 2018-09-16 13:24:48 +00:00
jcktm
c336d0f217 add daemonizer to rpc wallet 2018-09-15 06:24:27 +10:00
moneromooo-monero
4cb1d879f6
blockchain_blackball: s/return false;/return 0;/ 2018-09-14 20:08:52 +00:00
moneromooo-monero
9bdc9109fb
blockchain_blackball: use %zu for size_t 2018-09-14 17:16:08 +00:00
moneromooo-monero
db3db0930e
blockchain_blackball: use mdb_size_t where appropriate 2018-09-14 17:11:11 +00:00
moneromooo-monero
b1f05f589e
blockchain_blackball: error out on fgets error 2018-09-14 16:31:24 +00:00
Dusan Klinec
f9b22a7b01
hw_device: support for multiple devices added [for review] 
- device name is a new wallet property
- full device name is now a bit more structured so we can address particular device vendor + device path. Example: 'Ledger', 'Trezor:udp', 'Trezor:udp:127.0.0.1:21324', 'Trezor:bridge:usb01'. The part before ':' identifies HW device implementation, the optional part after ':' is device path to look for.
- new --hw-device parameter added to the wallet, can name the hardware device
- device reconnect added
 2018-09-14 16:02:00 +02:00
Riccardo Spagni
d743994086
Merge pull request #4324 
44259e56 wallet: ask-password can now ask without encrypting the secret spend key (moneromooo-monero)
 2018-09-14 13:15:41 +02:00
moneromooo-monero
44259e560e
wallet: ask-password can now ask without encrypting the secret spend key 2018-09-14 11:14:21 +00:00
Riccardo Spagni
fd194aaa4d
Merge pull request #4347 
df0e7c2f wallet2: fix secondary partially signed multisig txes (moneromooo-monero)
 2018-09-14 13:06:38 +02:00
Riccardo Spagni
7850541074
Merge pull request #4337 
97764bae wallet_rpc_server: error out if wallet-file and wallet-dir are both used (moneromooo-monero)
 2018-09-14 13:06:22 +02:00
Riccardo Spagni
b182dc8262
Merge pull request #4336 
5f8f5631 wallet2.get_reserve_proof: throw when specified amount is zero (stoffu)
 2018-09-14 13:06:06 +02:00
Riccardo Spagni
dd2fc3afe3
Merge pull request #4332 
20171746 wallet2: factor the creation of a new wallet keys file (moneromooo-monero)
be6acfd5 wallet2: factor new blockchain setup (moneromooo-monero)
 2018-09-14 13:05:43 +02:00
Riccardo Spagni
1396b65bbc
Merge pull request #4331 
88fbc4a5 wallet2: fill in v2 height for stagenet (moneromooo-monero)
 2018-09-14 13:05:02 +02:00
Riccardo Spagni
7addabce8f
Merge pull request #4330 
93e7627d cryptonote_format_utils: do not early out on invalid tx pubkeys (moneromooo-monero)
 2018-09-14 13:04:40 +02:00
Riccardo Spagni
5f9374c735
Merge pull request #4329 
45c85c89 remove unused fields from relay_tx RPC (el00ruobuob)
 2018-09-14 13:03:46 +02:00
Riccardo Spagni
9f24e57dc2
Merge pull request #4326 
bcda7adc NetBSD support (thomasvaughan)
 2018-09-14 13:02:58 +02:00
Riccardo Spagni
15570f9a8f
Merge pull request #4380 
53a99ca1 cn_deserialize: comment out pruned tx case (moneromooo-monero)
 2018-09-14 13:01:41 +02:00
Riccardo Spagni
3584a852a3
Merge pull request #4372 
1660b0e7 tx_pool: make the max tx size a consensus rule from v8 (moneromooo-monero)
 2018-09-14 12:56:01 +02:00
moneromooo-monero
53a99ca112
cn_deserialize: comment out pruned tx case 
it's not merged yet
 2018-09-14 10:55:50 +00:00
Riccardo Spagni
239a7e10ff
Merge pull request #4253 
be001326 remove obsolete daemon selection of fake outs and old tx construction (moneromooo-monero)
 2018-09-14 12:54:25 +02:00
moneromooo-monero
be001326d1
remove obsolete daemon selection of fake outs and old tx construction 2018-09-14 10:51:45 +00:00
Riccardo Spagni
1c36fcf886
Merge pull request #4309 
5083614f dns_util: add new DNSSEC trust anchor for rollover (moneromooo-monero)
 2018-09-14 12:46:56 +02:00
Riccardo Spagni
c74d9057f8
Merge pull request #4260 
a54dbaee blockchain_blackball: add --force-chain-reaction-pass flag (moneromooo-monero)
44439c32 record blackballs as amount/offset, and add export ability (moneromooo-monero)
4bce935b blockchain_blackball: more optimizations (moneromooo-monero)
b66ba783 blockchain_blackball: do not process duplicate blockchains parts (moneromooo-monero)
639a3c01 blockchain_blackball: make it clear secondary passes are not incremental (moneromooo-monero)
eb8a51be blockchain_blackball: detect spent outputs by partial ring reuse (moneromooo-monero)
d6d276c6 blockchain_blackball: fix chain reaction phase in incremental mode (moneromooo-monero)
2b2a681b blockchain_blackball: avoid false positives for different amounts (moneromooo-monero)
80e4fef3 blockchain_blackball: set transaction looping txn to read only (moneromooo-monero)
4801d6b5 blockchain_blackball: add stats (moneromooo-monero)
846190fd blockchain_blackball: support pre-v2 databases (moneromooo-monero)
daa6cc7d blockchain_blackball: use LMDB for the cache (moneromooo-monero)
50cb370d ringdb: allow blackballing many outputs at once (moneromooo-monero)
 2018-09-14 12:45:18 +02:00
Riccardo Spagni
fa53b76129
Merge pull request #4251 
cd236aeb Add bulletproof support (cslashm)
 2018-09-14 12:39:40 +02:00
Riccardo Spagni
438781afc4
Merge pull request #4221 
62511df6 wallet2: fix refresh retry when a block/tx fails to parse (moneromooo-monero)
b219c24c wallet2: trim hash chain after fast refresh of hashes (moneromooo-monero)
5b6bcca3 wallet2: fix checking the wrong vector when adding hashes (moneromooo-monero)
 2018-09-14 12:38:36 +02:00
Riccardo Spagni
d794abb8c5
Merge pull request #4208 
2c636e45 simplewallet: handle transfers using a monero: URI (moneromooo-monero)
 2018-09-14 12:36:27 +02:00
Riccardo Spagni
5fe6aa19f6
Merge pull request #4154 
5019852a cn_deserialize: extract payment ids from extra nonce (moneromooo-monero)
2af1ec3a cn_deserialize: support pruned transactions (moneromooo-monero)
 2018-09-14 12:20:10 +02:00
Riccardo Spagni
249feda4e1
Merge pull request #4147 
a4d2d842 blockchain_depth: add average min depth (moneromooo-monero)
289880d8 blockchain_depth: get the average min depth of a set of txes (moneromooo-monero)
628428a0 blockchain_ancestry: faster and uses less memory (moneromooo-monero)
2382484d blockchain_ancestry: add an incremental mode (moneromooo-monero)
888324fa blockchain_ancestry: finds all ancestors of a tx, block, or chain (moneromooo-monero)
 2018-09-14 12:19:44 +02:00
moneromooo-monero
607301bf6d
rct: avoid repeated unnecessary conversions when accummulating 2018-09-14 10:18:01 +00:00
moneromooo-monero
ac9346637a
rpc: add a "is an update available" flag in get_info 
Make it easier for a user to be told when to update
 2018-09-14 09:28:03 +00:00
moneromooo-monero
2ace509a78
simplewallet: print reason why refresh+password is needed 2018-09-14 08:26:36 +00:00
moneromooo-monero
4f81cd3a3c
rpc: add cumulative difficulty in block header data 2018-09-13 12:41:59 +00:00
moneromooo-monero
1660b0e72c
tx_pool: make the max tx size a consensus rule from v8 2018-09-13 09:43:29 +00:00
cslashm
cd236aebca Add bulletproof support 2018-09-13 09:50:43 +02:00
Lee Clagett
55c7cd1458 Adding expect<T> - a value-or-error implementation 2018-09-12 22:44:34 +00:00
moneromooo-monero
b2bb9312a7
blockchain: simplify output distribution code 2018-09-12 19:20:16 +00:00
moneromooo-monero
befdcbf4be
db_lmdb: do not use base for cumulative distribution 
it's confusing and needlessly complicated
 2018-09-12 19:20:13 +00:00
stoffu
67a56a9f8b
rctTypes: fix incorrect serialization 2018-09-12 20:33:10 +09:00
moneromooo-monero
56b50faab2
wallet: use wipeable_string in more places where a secret is used 2018-09-12 09:26:11 +00:00
Riccardo Spagni
157690caaa
Merge pull request #4352 
0664a984 wallet_rpc_server: remove some unused code (moneroexamples)
 2018-09-11 21:26:50 +02:00
thomasvaughan
bcda7adcd4 NetBSD support 2018-09-11 14:32:33 +00:00
Riccardo Spagni
e6d36c1701
Merge pull request #4219 
9137ad2c blockchain: add a testnet v9 a day after v8 (moneromooo-monero)
ac4f71c2 wallet2: bump testnet rollback to account for coming reorg (moneromooo-monero)
8f418a6d bulletproofs: #include <openssl/bn.h> (moneromooo-monero)
2bf63650 bulletproofs: speed up the latest changes a bit (moneromooo-monero)
044dff5a bulletproofs: scale points by 8 to ensure subgroup validity (moneromooo-monero)
c83012c4 bulletproofs: match aggregated verification to sarang's latest prototype (moneromooo-monero)
ce0c7432 performance_tests: add padded bulletproof construction (moneromooo-monero)
1224e53b core_tests: add a test for 4-aggregated BP verification (moneromooo-monero)
0e6ed559 fuzz_tests: add a bulletproof fuzz test (moneromooo-monero)
463434d1 more comprehensive test for ge_p3 comparison to identity/point at infinity (moneromooo-monero)
d0a0565f unit_tests: add a few more multiexp unit tests (moneromooo-monero)
6526d87f core_tests: add a test for a tx with empty bulletproof (moneromooo-monero)
a129bbd9 multiexp: fix maxscalar off by one (moneromooo-monero)
7ed496cc ringct: error out when hashToPoint* returns the point at infinity (moneromooo-monero)
d1591853 cryptonote_basic: check output type before using it (moneromooo-monero)
61632dc1 ringct: prevent a potential very large allocation (moneromooo-monero)
a4317e61 crypto: some paranoid checks in generate_signature/check_signature (moneromooo-monero)
7434df1c crypto: never return zero in random32_unbiased (moneromooo-monero)
0825e974 multiexp: fix wrong Bos-Coster result for 1 non trivial input (moneromooo-monero)
a1359ad4 Check inputs to addKeys are in range (moneromooo-monero)
fe0fa3b9 bulletproofs: reject x, y, z, or w[i] being zero (moneromooo-monero)
5ffb2ff9 v8: per byte fee, pad bulletproofs, fixed 11 ring size (moneromooo-monero)
869b3bf8 bulletproofs: a few fixes from the Kudelski review (moneromooo-monero)
c4291762 bulletproofs: reject points not in the main subgroup (moneromooo-monero)
15697177 bulletproofs: speed up a few multiplies using existing Hi cache (moneromooo-monero)
0b05a0fa Add Pippenger cache and limit Straus cache size (moneromooo-monero)
51eb3bdc add pippenger unit tests (moneromooo-monero)
b17b8db3 performance_tests: add stats and loop count multiplier options (moneromooo-monero)
7314d919 perf_timer: split timer class into a base one and a logging one (moneromooo-monero)
d126a02b performance_tests: add aggregated bulletproof tx verification (moneromooo-monero)
263431c4 Pippenger multiexp (moneromooo-monero)
1ed0ed4d multiexp: cut down on memory allocations (moneromooo-monero)
1b867e7f precalc the ge_p3 representation of H (moneromooo-monero)
ef56529f performance_tests: document the tested bulletproof layouts (moneromooo-monero)
30111780 unit_tests: a couple more bulletproof unit tests for gamma (moneromooo-monero)
c444b1b2 require canonical multi output bulletproof layout (moneromooo-monero)
7e67c52f Add a define for the max number of bulletproof multi-outputs (moneromooo-monero)
2a8fcb42 Bulletproof aggregated verification and tests (moneromooo-monero)
126196b0 multiexp: some speedups (moneromooo-monero)
71d67bda aligned: aligned memory alloc/realloc/free (moneromooo-monero)
cb9ecab1 performance_tests: add signature generation/verification (moneromooo-monero)
bacf0a1e bulletproofs: add aggregated verification (moneromooo-monero)
e895c3de make straus cached mode thread safe, and add tests for it (moneromooo-monero)
7f48bf05 multiexp: bos coster now works for just one point (moneromooo-monero)
9ce9f8ca bulletproofs: add multi output bulletproofs to rct (moneromooo-monero)
f34e2e20 performance_tests: add tx checking tests with more than 2 outputs (moneromooo-monero)
0793184b performance_tests: add a --verbose flag, and default to terse (moneromooo-monero)
939bc223 add Straus multiexp (moneromooo-monero)
9ff6e6a0 ringct: add bos coster multiexp (moneromooo-monero)
e9164bb3 bulletproofs: misc optimizations (moneromooo-monero)
112f32f0 performance_tests: add crypto ops (moneromooo-monero)
f5d7b993 performance_tests: add bulletproofs (moneromooo-monero)
8f4ce989 performance_tests: add RingCT MLSAG gen/ver tests (moneromooo-monero)
1aa10c43 performance_tests: add (Borromean) range proofs (moneromooo-monero)
aacfd6e3 bulletproofs: multi-output bulletproofs (moneromooo-monero)
cb1cc757 performance_tests: don't override log level to 0 (moneromooo-monero)
 2018-09-11 15:45:56 +02:00
moneromooo-monero
9137ad2c63
blockchain: add a testnet v9 a day after v8 
So that bulletproofs become mandatory
 2018-09-11 13:38:36 +00:00
moneromooo-monero
ac4f71c200
wallet2: bump testnet rollback to account for coming reorg 2018-09-11 13:38:35 +00:00
moneromooo-monero
8f418a6db0
bulletproofs: #include <openssl/bn.h> 
Apparently needed for openssl 1.1.x
 2018-09-11 13:38:34 +00:00
moneromooo-monero
2bf636503f
bulletproofs: speed up the latest changes a bit 2018-09-11 13:38:32 +00:00
moneromooo-monero
044dff5a30
bulletproofs: scale points by 8 to ensure subgroup validity 2018-09-11 13:38:31 +00:00
moneromooo-monero
c83012c476
bulletproofs: match aggregated verification to sarang's latest prototype 2018-09-11 13:38:30 +00:00
moneromooo-monero
463434d1f7
more comprehensive test for ge_p3 comparison to identity/point at infinity 
Reported by QuarksLab.
 2018-09-11 13:38:20 +00:00
moneromooo-monero
a129bbd944
multiexp: fix maxscalar off by one 
Reported by QuarksLab.
 2018-09-11 13:38:17 +00:00
moneromooo-monero
7ed496cc78
ringct: error out when hashToPoint* returns the point at infinity 
Reported by QuarksLab.
 2018-09-11 13:38:16 +00:00
moneromooo-monero
d1591853bf
cryptonote_basic: check output type before using it 
Reported by QuarksLab.
 2018-09-11 13:38:15 +00:00
moneromooo-monero
61632dc166
ringct: prevent a potential very large allocation 
Reported by QuarksLab.
 2018-09-11 13:38:14 +00:00
moneromooo-monero
a4317e61b5
crypto: some paranoid checks in generate_signature/check_signature 
Reported by QuarksLab.
 2018-09-11 13:38:12 +00:00
moneromooo-monero
7434df1cc6
crypto: never return zero in random32_unbiased 
This avoids problems when the caller can't deal with a zero
walue, which happens often enough that it's worth nipping the
problem in the bud.
 2018-09-11 13:38:12 +00:00
moneromooo-monero
0825e97436
multiexp: fix wrong Bos-Coster result for 1 non trivial input 
Reported by QuarksLab.
 2018-09-11 13:38:10 +00:00
moneromooo-monero
a1359ad43c
Check inputs to addKeys are in range 
Reported by QuarksLab.
 2018-09-11 13:38:09 +00:00
moneromooo-monero
fe0fa3b9c5
bulletproofs: reject x, y, z, or w[i] being zero 
Also try again when we're generate a proof with those characteristics

Reported by QuarksLab.
 2018-09-11 13:38:08 +00:00
moneromooo-monero
5ffb2ff9b7
v8: per byte fee, pad bulletproofs, fixed 11 ring size 2018-09-11 13:38:07 +00:00
moneromooo-monero
869b3bf824
bulletproofs: a few fixes from the Kudelski review 
- fix integer overflow in n_bulletproof_amounts
- check input scalars are in range
- remove use of environment variable to tweak straus performance
- do not use implementation defined signed shift for signum
 2018-09-11 13:38:05 +00:00
moneromooo-monero
c429176248
bulletproofs: reject points not in the main subgroup 2018-09-11 13:38:04 +00:00
moneromooo-monero
1569717718
bulletproofs: speed up a few multiplies using existing Hi cache 2018-09-11 13:38:03 +00:00
moneromooo-monero
0b05a0fa74
Add Pippenger cache and limit Straus cache size 2018-09-11 13:38:02 +00:00
moneromooo-monero
7314d919e7
perf_timer: split timer class into a base one and a logging one 2018-09-11 13:37:47 +00:00
moneromooo-monero
263431c486
Pippenger multiexp 
Based on sarang's python code
 2018-09-11 13:37:45 +00:00
moneromooo-monero
1ed0ed4de4
multiexp: cut down on memory allocations 2018-09-11 13:37:44 +00:00
moneromooo-monero
1b867e7f40
precalc the ge_p3 representation of H 2018-09-11 13:37:42 +00:00
moneromooo-monero
c444b1b229
require canonical multi output bulletproof layout 2018-09-11 13:37:39 +00:00
moneromooo-monero
7e67c52fa2
Add a define for the max number of bulletproof multi-outputs 2018-09-11 13:37:38 +00:00
moneromooo-monero
2a8fcb421b
Bulletproof aggregated verification and tests 
Also constrains bulletproofs to simple rct, for simplicity
 2018-09-11 13:37:37 +00:00
moneromooo-monero
126196b017
multiexp: some speedups 
- use a raw memory block to store cache
- use aligned memory
- use doubling API where appropriate
- calculate straus in bands
 2018-09-11 13:37:35 +00:00
moneromooo-monero
71d67bda74
aligned: aligned memory alloc/realloc/free 2018-09-11 13:37:34 +00:00
moneromooo-monero
bacf0a1e2f
bulletproofs: add aggregated verification 
Ported from sarang's java code
 2018-09-11 13:37:32 +00:00
moneromooo-monero
e895c3def1
make straus cached mode thread safe, and add tests for it 2018-09-11 13:37:31 +00:00
moneromooo-monero
7f48bf05d7
multiexp: bos coster now works for just one point 2018-09-11 13:37:30 +00:00
moneromooo-monero
9ce9f8caf6
bulletproofs: add multi output bulletproofs to rct 2018-09-11 13:37:28 +00:00
moneromooo-monero
939bc22332
add Straus multiexp 2018-09-11 13:37:25 +00:00
moneromooo-monero
9ff6e6a0a7
ringct: add bos coster multiexp 2018-09-11 13:37:24 +00:00
moneromooo-monero
e9164bb38b
bulletproofs: misc optimizations 
Use double mults where possible, avoid conversions, simplify
 2018-09-11 13:37:23 +00:00
moneromooo-monero
aacfd6e370
bulletproofs: multi-output bulletproofs 2018-09-11 13:37:17 +00:00
Riccardo Spagni
f0ab4dc7b2
Merge pull request #4218 
5fd83c13 Cryptonight variant 2 (SChernykh)
 2018-09-11 15:22:25 +02:00
luigi1111
ab85b924c9
Merge pull request #4293 
9d65399 is_hdd update (p8p)
 2018-09-10 15:07:02 -05:00
TheCharlatan
56b6e41ea7 Add support for apple and arm building 
Add pcsc-lite to linux builds
Fixup windows icu4c linking with depends, the static libraries have an 's' appended to them
Compiling depends arm-linux-gnueabihf will allow you to compile armv6zk monero binaries
 2018-09-10 22:05:36 +02:00
luigi1111
46bcd91db4
Merge pull request #4256 
d6fc870 db_lmdb: resize blockchain database when 90% filled (moneromooo-monero)
 2018-09-10 15:04:50 -05:00
naughtyfox
26971d46fc WalletAPI: 'hasMultisigPartialKeyImages' function added 2018-09-10 19:33:08 +03:00
naughtyfox
7a76354c8b wallet2: import_multisig forward refresh exception 2018-09-10 18:45:37 +03:00
moneromooo-monero
a54dbaee08
blockchain_blackball: add --force-chain-reaction-pass flag 2018-09-10 09:04:21 +00:00
moneromooo-monero
44439c3208
record blackballs as amount/offset, and add export ability 2018-09-10 09:04:18 +00:00
SChernykh
5fd83c13fb Cryptonight variant 2 
Contains two modifications to improve ASIC resistance: shuffle and integer math.

Shuffle makes use of the whole 64-byte cache line instead of 16 bytes only, making Cryptonight 4 times more demanding for memory bandwidth.

Integer math adds 64:32 bit integer division followed by 64 bit integer square root, adding large and unavoidable computational latency to the main loop.

More details and performance numbers: https://github.com/SChernykh/xmr-stak-cpu/blob/master/README.md
 2018-09-09 20:43:01 +02:00
moneromooo-monero
8501b8dffb
crypto_ops_builder: link to EdDSA/Ed25519 draft RFC 
instead of including the text, as it's not fully free to redistribute
 2018-09-09 16:18:49 +00:00
moneromooo-monero
03c07b167d
rpc: return "already mining" in start_mining if already mining 2018-09-09 15:27:30 +00:00
moneroexamples
0664a98421
wallet_rpc_server: remove some unused code 2018-09-09 12:37:01 +00:00
moneromooo-monero
4bce935b40
blockchain_blackball: more optimizations 2018-09-09 12:03:02 +00:00
moneromooo-monero
b66ba78306
blockchain_blackball: do not process duplicate blockchains parts 2018-09-09 12:02:48 +00:00
moneromooo-monero
639a3c019c
blockchain_blackball: make it clear secondary passes are not incremental 
yet
 2018-09-09 12:02:42 +00:00
moneromooo-monero
eb8a51be68
blockchain_blackball: detect spent outputs by partial ring reuse 2018-09-09 12:02:39 +00:00
moneromooo-monero
d6d276c604
blockchain_blackball: fix chain reaction phase in incremental mode 
It makes it a lot slower, unfortunately
 2018-09-09 12:02:36 +00:00
moneromooo-monero
2b2a681b01
blockchain_blackball: avoid false positives for different amounts 
Identical offset based rings may not actually be identical rings
since they represent different outputs
 2018-09-09 12:02:32 +00:00
moneromooo-monero
80e4fef3c6
blockchain_blackball: set transaction looping txn to read only 2018-09-09 12:02:25 +00:00
moneromooo-monero
4801d6b514
blockchain_blackball: add stats 2018-09-09 12:02:02 +00:00
moneromooo-monero
846190fd18
blockchain_blackball: support pre-v2 databases 2018-09-09 12:01:59 +00:00
moneromooo-monero
daa6cc7d73
blockchain_blackball: use LMDB for the cache 
This uses less memory and makes it faster to load/save, though
makes it slower to run (which is actually faster since it would
previously start swapping anyway).
 2018-09-09 12:01:49 +00:00
moneromooo-monero
50cb370d5b
ringdb: allow blackballing many outputs at once 
It cuts down on txn commits, and speeds up blackballing substantially
 2018-09-09 12:01:43 +00:00
moneromooo-monero
df0e7c2feb
wallet2: fix secondary partially signed multisig txes 2018-09-08 23:12:06 +00:00
moneromooo-monero
97764bae3a
wallet_rpc_server: error out if wallet-file and wallet-dir are both used 2018-09-08 20:54:14 +00:00
moneromooo-monero
cd647612b0
rpc: don't include start time if restricted 2018-09-07 13:28:40 +00:00
Guillaume LE VAILLANT
54b859bea5 wallet rpc: Add close_wallet RPC 
And close the current wallet automatically if necessary when opening another
wallet.
 2018-09-05 16:52:16 +02:00
moneromooo-monero
e611728228
daemon: request no PoW hashes we don't need when asking for blocks 
This fixes the horrendous slowdown in bc_dyn_stats
 2018-09-05 09:43:44 +00:00
moneromooo-monero
7c8f95d3e2
ringct: make conversion functions return const refs 
This might avoid unnecessary copies.

Reported by stoffu
 2018-09-04 18:28:20 +00:00
luigi1111
03738fdde1
Merge pull request #4276 
48a7bc4 tx_pool: fix infinite loop when failing to find a meta record (moneromooo-monero)
 2018-09-04 13:25:44 -05:00
luigi1111
b2038e24f0
Merge pull request #4274 
11c6718 util: remove unused <ustat.h> (moneromooo-monero)
 2018-09-04 13:21:53 -05:00
luigi1111
77ed11e627
Merge pull request #4270 
29dea03 epee: resize vectors where possible in serialization (moneromooo-monero)
76affd9 epee: some speedup in parsing (moneromooo-monero)
dc6c069 db_lmdb: speedup the get_output_distribution common case (moneromooo-monero)
76ac5a8 wallet2: ask for a binary output distribution, for speed (moneromooo-monero)
 2018-09-04 13:19:58 -05:00
luigi1111
59e6fb06f9
Merge pull request #4269 
3d5abbe [#4027] add change_wallet_password wallet rpc command (artyomsol)
 2018-09-04 13:17:40 -05:00
luigi1111
5f1bbe3bce
Merge pull request #4268 
1f2409e Do memwipe for critical secret keys copied to rct::key (stoffu)
 2018-09-04 13:16:04 -05:00
luigi1111
085b6ba98e
Merge pull request #4263 
5ed6669 wallet_rpc_server: remove unused amount_keys field in transfer RPC (moneromooo-monero)
 2018-09-04 13:12:48 -05:00
luigi1111
8bbae77134
Merge pull request #4262 
c3c14f3 simplewallet: allow named priority levels for default-priority (moneromooo-monero)
 2018-09-04 13:11:18 -05:00
luigi1111
e4378ed8aa
Merge pull request #4259 
4e08100 Incremental Keccak API added (pr4r05)
 2018-09-04 13:09:48 -05:00
luigi1111
6d4d4ddb68
Merge pull request #4252 
ac09cfa wallet2: remove obsolete pruned/unpruned case (moneromooo-monero)
 2018-09-04 13:05:12 -05:00
luigi1111
88e5ed0072
Merge pull request #4245 
8ca1215 wallet: store trusted-daemon flag in wallet2 (stoffu)
 2018-09-04 13:03:37 -05:00
luigi1111
46d8bc2a33
Merge pull request #4160 
704b60c block_queue: faster check whether a block was requested (moneromooo-monero)
 2018-09-04 13:02:09 -05:00
stoffu
5f8f56315c
wallet2.get_reserve_proof: throw when specified amount is zero 2018-09-04 13:00:38 +09:00
moneromooo-monero
20171746de
wallet2: factor the creation of a new wallet keys file 2018-09-03 11:27:46 +00:00
moneromooo-monero
be6acfd5be
wallet2: factor new blockchain setup 2018-09-03 11:27:43 +00:00
moneromooo-monero
88fbc4a567
wallet2: fill in v2 height for stagenet 2018-09-03 11:26:28 +00:00
moneromooo-monero
93e7627d5a
cryptonote_format_utils: do not early out on invalid tx pubkeys 
Another such pubkey might be valid
 2018-09-02 23:00:44 +00:00
el00ruobuob
45c85c89de
remove unused fields from relay_tx RPC 2018-09-02 23:50:31 +02:00
moneromooo-monero
4e1e9a607e
blockchain: add mainnet v8 height targetting 18 october 
and v9 a day later
 2018-09-02 16:02:17 +00:00
Dusan Klinec
76f95f052e
rpc: allow to pass RPC login via RPC_LOGIN env var 
- passing by parameter is insecure as it is shown in the process list
 2018-08-31 15:51:59 +02:00
moneromooo-monero
f0bc684ccd
mnemonics: fix outrageous compile time with CLANG in release 
from several minutes to 10-15 seconds
 2018-08-29 09:53:48 +00:00
moneromooo-monero
2c636e45f2
simplewallet: handle transfers using a monero: URI 2018-08-28 19:55:49 +00:00
moneromooo-monero
5083614ffa
dns_util: add new DNSSEC trust anchor for rollover 
It should be useful from the 11th of october 2018.

The old key is still trusted for now.

https://www.icann.org/resources/pages/ksk-rollover
 2018-08-28 11:29:51 +00:00
moneromooo-monero
5019852adc
cn_deserialize: extract payment ids from extra nonce 2018-08-25 18:39:48 +00:00
moneromooo-monero
2af1ec3af7
cn_deserialize: support pruned transactions 2018-08-25 18:39:45 +00:00
p8p
9d6539923e
is_hdd update 2018-08-25 04:31:22 -07:00
luigi1111
91c7d68b2d
Merge pull request #4223 
c955257 electrum-words: fix bytes_to_words on big endian (moneromooo-monero)
 2018-08-23 14:04:26 -05:00
moneromooo-monero
c955257c4a
electrum-words: fix bytes_to_words on big endian 
Reported by cslashm
 2018-08-23 07:58:23 +00:00
moneromooo-monero
d2e26c23f3
add and use constant time 32 byte equality function 2018-08-23 07:56:51 +00:00
stoffu
8ca1215f25
wallet: store trusted-daemon flag in wallet2 2018-08-23 14:55:09 +09:00
luigi1111
510dbf3329
Merge pull request #4249 
77655b0 simplewallet: Simplify LOCK_IDLE_SCOPE macro (rbrunner7)
 2018-08-22 21:07:00 -05:00
luigi1111
1db7a29e12
Merge pull request #4247 
10475ab node_rpc_proxy: fix fork earliest height caching [RYO backport] (fireice-uk)
 2018-08-22 21:04:34 -05:00
luigi1111
2e7bfd0de5
Merge pull request #4242 
6fcdc9e rpc-wallet: refresh command added (ph4r05)
 2018-08-22 21:00:10 -05:00
luigi1111
ec6982f8eb
Merge pull request #4240 
83f5587 blockchain: use uint64_t for height, not size_t (moneromooo-monero)
 2018-08-22 20:58:55 -05:00
luigi1111
b0c00b0752
Merge pull request #4231 
3e914ad simplewallet: add a warning and prompt on rescan_blockchain (moneromooo-monero)
 2018-08-22 20:55:00 -05:00
luigi1111
3f662876e6
Merge pull request #4225 
2fd9be1 simplewallet: correct number of human-readable months (rbrunner7)
 2018-08-22 20:52:43 -05:00
luigi1111
4e6187faf3
Merge pull request #4224 
c5e2aee updates: fix hash sanity checking (moneromooo-monero)
 2018-08-22 20:51:32 -05:00
luigi1111
a5d21be843
Merge pull request #4210 
4616cf2 Fixed ZMQ-RPC for transactions and GET_BLOCKS_FAST (vtnerd)
 2018-08-22 20:47:28 -05:00
luigi1111
0d415ff638
Merge pull request #4207 
ce9457a cryptonote_protocol: don't serialize an unneeded new block message (moneromooo-monero)
 2018-08-22 20:45:09 -05:00
luigi1111
4a4ea78ecd
Merge pull request #4204 
b278b83 core: sync database based on bytes added, not blocks added (moneromooo-monero)
 2018-08-22 20:43:51 -05:00
luigi1111
6e8e4fb3b7
Merge pull request #4202 
8439306 wallet2: do not divide by 0 on invalid daemon response (moneromooo-monero)
 2018-08-22 20:42:20 -05:00
luigi1111
7e4507a048
Merge pull request #4200 
43f7110 blockchain_db: remove unused get_output_key variant (moneromooo-monero)
 2018-08-22 20:40:37 -05:00
luigi1111
1eebb3d8fc
Merge pull request #4146 
82d1b74 core: cache block template where possible (moneromooo-monero)
 2018-08-22 20:37:06 -05:00
Dusan Klinec
6fcdc9e0b2
rpc-wallet: refresh command added 2018-08-22 16:57:55 +02:00
moneromooo-monero
62511df622
wallet2: fix refresh retry when a block/tx fails to parse 
It would switch to a new set of blocks and fail, getting out of sync
with the hash chain in the process
 2018-08-22 09:57:46 +00:00
moneromooo-monero
b219c24c3a
wallet2: trim hash chain after fast refresh of hashes 
This ensures it can't end up filled with the actual placeholders
 2018-08-22 09:57:42 +00:00
moneromooo-monero
5b6bcca32a
wallet2: fix checking the wrong vector when adding hashes 
The two vectors should be the same size anyway, so add an assert
to catch any case where they aren't
 2018-08-22 09:57:39 +00:00
moneromooo-monero
48a7bc4280
tx_pool: fix infinite loop when failing to find a meta record 2018-08-19 17:47:05 +00:00
moneromooo-monero
76ac5a8fbe
wallet2: ask for a binary output distribution, for speed 2018-08-19 15:58:25 +00:00
moneromooo-monero
dc6c0696fd
db_lmdb: speedup the get_output_distribution common case 2018-08-19 15:58:21 +00:00
moneromooo-monero
11c6718865
util: remove unused <ustat.h> 
It's obsolete and removed from at least Arch Linux 8.2

Reported by moneroexamples
 2018-08-17 13:06:38 +00:00
artyomsol
3d5abbe86b [#4027] add change_wallet_password wallet rpc command 2018-08-17 09:54:26 +03:00
stoffu
1f2409e9e2
Do memwipe for critical secret keys copied to rct::key 2018-08-16 22:26:30 +09:00
moneromooo-monero
82d1b74500
core: cache block template where possible 
This avoids constant rechecking of the same things each time
a miner asks for the block template. The tx pool maintains
a cookie to allow users to detect when the pool state changed,
which means the block template needs rebuilding.
 2018-08-16 12:44:33 +00:00
moneromooo-monero
ab74dc277a
crypto: make secret_key automatically mlock 2018-08-16 11:57:49 +00:00
moneromooo-monero
e9ffa91257
store secret keys encrypted where possible 
The secret spend key is kept encrypted in memory, and
decrypted on the fly when needed.

Both spend and view secret keys are kept encrypted in a JSON
field in the keys file. This avoids leaving the keys in
memory due to being manipulated by the JSON I/O API.
 2018-08-16 11:57:43 +00:00
moneromooo-monero
ea37614efe
wallet: wipe seed from memory where appropriate 2018-08-16 09:17:52 +00:00
stoffu
a64f57fe42
wallet2: make --restricted-rpc available for wallet RPC only 2018-08-16 09:54:23 +09:00
luigi1111
4d66939791
Merge pull request #4196 
361513a blockchain_blackball: use a bit less memory (moneromooo-monero)
 2018-08-15 18:13:08 -05:00
luigi1111
41e583b0a2
Merge pull request #4195 
f13c7a8 simplewallet: make sure wallet config is stored right after creation (stoffu)
 2018-08-15 17:58:24 -05:00
luigi1111
e69e0e9e34
Merge pull request #4194 
0f75717 wallet2: avoid using arbitrary random values when unknown (moneromooo-monero)
 2018-08-15 17:56:23 -05:00
luigi1111
1c55a3756b
Merge pull request #4193 
4520cfd wallet2: guard against bad outputs in import_outputs (moneromooo-monero)
 2018-08-15 17:54:49 -05:00
luigi1111
05485bd1c5
Merge pull request #4192 
5860611 blockchain_blackball: allow resumable interrupt with ^C (moneromooo-monero)
 2018-08-15 17:53:42 -05:00
luigi1111
8d2e454929
Merge pull request #4188 
a3fe1c5 simplewallet: add set_tx_key for importing tx keys from 3rd party wallets (stoffu)
 2018-08-15 17:47:05 -05:00
luigi1111
7aa2030cee
Merge pull request #4174 
ff37bd0 wallet2: fix O(n^2) behaviour in import_key_images (moneromooo-monero)
 2018-08-15 17:40:55 -05:00
luigi1111
b531858c02
Merge pull request #4173 
3940e12 daemon.print_bc: don't print difficulty twice (stoffu)
 2018-08-15 17:39:35 -05:00
luigi1111
2102e6c738
Merge pull request #4172 
3a4c3ac simplewallet.unspent_outputs: fix wrong logic for parsing (stoffu)
 2018-08-15 17:38:36 -05:00
luigi1111
a68143bc52
Merge pull request #4171 
9127a8b wallet-rpc: filter getbalance response by address index (stoffu)
 2018-08-15 17:37:23 -05:00
luigi1111
564e9c3b5f
Merge pull request #4170 
1c6cfd3 wallet-rpc: add get_address_index command (stoffu)
 2018-08-15 17:35:49 -05:00
luigi1111
8c4b3f3736
Merge pull request #4166 
5e675de simplewallet: fix language detection when using --use-english-language-names (moneromooo-monero)
 2018-08-15 17:34:29 -05:00
luigi1111
fd3b71129b
Merge pull request #4164 
8e24533 blockchain: some batch tx scanning speedup (moneromooo-monero)
 2018-08-15 17:31:24 -05:00
luigi1111
2530dc6710
Merge pull request #4161 
be02eb9 db_lmdb: demote the 'batch already enabled' log, it's harmless (moneromooo-monero)
 2018-08-15 17:27:48 -05:00
luigi1111
e7328ed5b7
Merge pull request #4158 
7db7ec8 wallet rpc: support making integrated address of given standard address (stoffu)
 2018-08-15 17:25:19 -05:00
luigi1111
5e795ee7af
Merge pull request #4153 
37f0799 wallet: distinguish coinbase from other txes in show_transfers (moneromooo-monero)
 2018-08-15 17:23:56 -05:00
luigi1111
2a44c2defd
Merge pull request #4150 
f2e65c6 wallet2: consider minimum fee when testing if balance is sufficient (stoffu)
 2018-08-15 17:22:36 -05:00
luigi1111
88369c6685
Merge pull request #4138 
7f8bdeb easylogging++: make the logger handle early/late logging (moneromooo-monero)
bc8cbdb stack_trace: print stack traces on stdout if the logger isn't live (moneromooo-monero)
 2018-08-15 17:19:04 -05:00
luigi1111
5295e4eb82
Merge pull request #4137 
63e342b crypto: move null_pkey/null_skey to the cpp file (moneromooo-monero)
0496c7c crypto: do not use boost::value_initialized to init null skey/pkey (moneromooo-monero)
 2018-08-15 17:17:34 -05:00
luigi1111
1d2c08610b
Merge pull request #4136 
4307489 wallet: disable core dumps on startup in release mode (moneromooo-monero)
 2018-08-15 17:15:49 -05:00
luigi1111
ad13b6d25a
Merge pull request #4106 
20eb192 simplewallet: reword 'seed encryption' to 'seed offset' (moneromooo-monero)
 2018-08-15 17:12:12 -05:00
luigi1111
017e07a035
Merge pull request #4103 
bcab579 wallet: allow adjusting number of rounds for the key derivation function (stoffu)
 2018-08-15 17:09:52 -05:00
luigi1111
b586ae1310
Merge pull request #4089 
909398e p2p: connect via the bound ip, if any (moneromooo-monero)
 2018-08-15 17:06:17 -05:00
luigi1111
dd8354aa08
Merge pull request #4024 
5a2864c simplewallet: fix delay when setting auto-refresh off (moneromooo-monero)
 2018-08-15 17:05:14 -05:00
luigi1111
4745e3be22
Merge pull request #4020 
c24a0af [monerod] Added blocks remaining count during syncronisation. (Jorropo)
 2018-08-15 17:03:35 -05:00
luigi1111
4cde4cb946
Merge pull request #3528 
34d4b79 wallet2: use a gamma distribution to pick fake outs (moneromooo-monero)
 2018-08-15 17:00:32 -05:00
Dusan Klinec
4e081001c0
Incremental Keccak API added 
- needed for TREZOR integration
 2018-08-15 18:20:22 +02:00
moneromooo-monero
5ed6669130
wallet_rpc_server: remove unused amount_keys field in transfer RPC 2018-08-15 12:47:33 +00:00
moneromooo-monero
c3c14f3083
simplewallet: allow named priority levels for default-priority 
to match those used by the various transfer functions
 2018-08-15 12:16:17 +00:00
moneromooo-monero
d6fc870d04
db_lmdb: resize blockchain database when 90% filled 
instead of a random ratio from 60% to 90%.
 2018-08-14 08:55:49 +00:00
fireice-uk
10475ab23f node_rpc_proxy: fix fork earliest height caching [RYO backport] 
xref https://github.com/ryo-currency/ryo-currency/pull/86
 2018-08-13 22:16:17 +02:00
rbrunner7
77655b0a0e simplewallet: Simplify LOCK_IDLE_SCOPE macro 2018-08-13 21:21:24 +02:00
moneromooo-monero
ac09cfa6be
wallet2: remove obsolete pruned/unpruned case 
All daemons will not support pruned blocks
 2018-08-13 13:17:27 +00:00
moneromooo-monero
4307489147
wallet: disable core dumps on startup in release mode 2018-08-12 16:28:10 +00:00
moneromooo-monero
bc8cbdb25d
stack_trace: print stack traces on stdout if the logger isn't live 2018-08-12 16:18:07 +00:00
moneromooo-monero
b278b83860
core: sync database based on bytes added, not blocks added 
Blocks have a very wide range, whereas actual size is the relevant
quantity to consider when syncing
 2018-08-12 16:13:46 +00:00
moneromooo-monero
83f5587167
blockchain: use uint64_t for height, not size_t 2018-08-09 17:09:26 +00:00
moneromooo-monero
361513ac81
blockchain_blackball: use a bit less memory 2018-08-09 14:50:20 +00:00
moneromooo-monero
ce9457a379
cryptonote_protocol: don't serialize an unneeded new block message 
Non fluffy block nodes should now be very rare
 2018-08-09 14:45:31 +00:00
moneromooo-monero
a4d2d84209
blockchain_depth: add average min depth 2018-08-07 21:20:54 +00:00
moneromooo-monero
289880d82d
blockchain_depth: get the average min depth of a set of txes 2018-08-07 21:20:49 +00:00
stoffu
bcab579864
wallet: allow adjusting number of rounds for the key derivation function 2018-08-08 01:56:54 +09:00
moneromooo-monero
3e914ad831
simplewallet: add a warning and prompt on rescan_blockchain 
Many people are using this as a "let's see what this does" command
when something doesn't work as they thought it should, and thus
destroying info that they might still need.
 2018-08-07 12:49:23 +00:00
rbrunner7
2fd9be1646 simplewallet: correct number of human-readable months 2018-08-05 09:58:33 +02:00
moneromooo-monero
c5e2aee961
updates: fix hash sanity checking 2018-08-05 00:19:45 +00:00
moneromooo-monero
37f0799284
wallet: distinguish coinbase from other txes in show_transfers 2018-08-03 12:48:16 +00:00
Lee Clagett
4616cf2641 Fixed ZMQ-RPC for transactions and GET_BLOCKS_FAST 2018-08-02 07:30:20 +00:00
moneromooo-monero
8439306212
wallet2: do not divide by 0 on invalid daemon response 2018-07-31 14:26:00 +00:00
stoffu
1c6cfd34f4
wallet-rpc: add get_address_index command 2018-07-31 21:36:12 +09:00
stoffu
9127a8b79f
wallet-rpc: filter getbalance response by address index 2018-07-31 20:45:41 +09:00
moneromooo-monero
43f71100bc
blockchain_db: remove unused get_output_key variant 
It was actually incorrect, as it would not return commitment
 2018-07-30 21:57:47 +00:00
moneromooo-monero
628428a0df
blockchain_ancestry: faster and uses less memory 2018-07-30 21:39:25 +01:00
moneromooo-monero
2382484dcd
blockchain_ancestry: add an incremental mode 2018-07-30 21:39:22 +01:00
moneromooo-monero
888324fa57
blockchain_ancestry: finds all ancestors of a tx, block, or chain 2018-07-30 21:39:18 +01:00
moneromooo-monero
0f757177fe
wallet2: avoid using arbitrary random values when unknown 2018-07-30 13:34:15 +01:00
moneromooo-monero
4520cfd978
wallet2: guard against bad outputs in import_outputs 
also some minor speedup
 2018-07-30 13:21:58 +01:00
stoffu
a3fe1c56ee
simplewallet: add set_tx_key for importing tx keys from 3rd party wallets 2018-07-30 20:50:05 +09:00
stoffu
f13c7a8263
simplewallet: make sure wallet config is stored right after creation 2018-07-30 20:39:05 +09:00
moneromooo-monero
5860611afa
blockchain_blackball: allow resumable interrupt with ^C 2018-07-30 11:14:45 +01:00
luigi1111
0dddfeacc9
Merge pull request #4129 
ee31383 db_lmdb: don't sync a read only DB (moneromooo-monero)
 2018-07-27 14:30:57 -05:00
luigi1111
ff01c3ade4
Merge pull request #4110 
639ca3b core_tests: add --filter to select which tests to run (moneromooo-monero)
 2018-07-27 14:28:49 -05:00
luigi1111
f739a3cbb8
Merge pull request #4109 
2951436 wallet: warn when payment IDs are used (moneromooo-monero)
 2018-07-27 14:27:47 -05:00
luigi1111
dda05f357a
Merge pull request #4108 
8c05237 blockchain: cache next block difficulty after adding a block (moneromooo-monero)
 2018-07-27 14:26:01 -05:00
luigi1111
3fde902394
Merge pull request #4097 
61caab8 crypto: remove slight bias in key generation due to modulo (moneromooo-monero)
 2018-07-27 14:23:54 -05:00
luigi1111
92b5d6c204
Merge pull request #4091 
a4272de wallet2: unlock keys file before calling verify_password (needed for Windows) (stoffu)
 2018-07-27 14:22:34 -05:00
Jorropo
c24a0af9f1 [monerod] Added blocks remaining count during syncronisation. 
And percent if usefull (% < 99)
 2018-07-25 10:16:01 +02:00
moneromooo-monero
ff37bd00bc
wallet2: fix O(n^2) behaviour in import_key_images 
That takes a lot of time for even not so large wallets
 2018-07-24 14:34:19 +01:00
stoffu
3940e12933
daemon.print_bc: don't print difficulty twice 2018-07-24 16:17:49 +09:00
stoffu
3a4c3ac891
simplewallet.unspent_outputs: fix wrong logic for parsing 2018-07-24 13:32:58 +09:00
jcktm
ed7825dc0c monero-wallet-cli: added locked_sweep_all command 2018-07-23 10:35:58 +10:00
moneromooo-monero
5e675de7c2
simplewallet: fix language detection when using --use-english-language-names 2018-07-22 14:26:38 +01:00
moneromooo-monero
8e24533a7f
blockchain: some batch tx scanning speedup 2018-07-21 12:05:12 +01:00
moneromooo-monero
be02eb9389
db_lmdb: demote the "batch already enabled" log, it's harmless 2018-07-20 23:41:40 +01:00
moneromooo-monero
0496c7c91a
crypto: do not use boost::value_initialized to init null skey/pkey 2018-07-20 23:06:22 +01:00
moneromooo-monero
704b60caf0
block_queue: faster check whether a block was requested 2018-07-20 16:05:56 +01:00
stoffu
7db7ec8591
wallet rpc: support making integrated address of given standard address 2018-07-20 21:33:36 +09:00
luigi1111
702a41034d
Merge pull request #4088 
8c4db68 node_rpc_proxy: factor a few RPC calls using get_info (moneromooo-monero)
 2018-07-19 14:15:16 -05:00
luigi1111
5c102c60dc
Merge pull request #4087 
d6440ab wallet2: recover from index out of hashchain bounds error (moneromooo-monero)
 2018-07-19 14:14:10 -05:00
luigi1111
61eea83978
Merge pull request #4081 
d95bc44 blockchain: fix getting invalid block data on failure (moneromooo-monero)
 2018-07-19 14:12:30 -05:00
luigi1111
9474567d76
Merge pull request #4076 
aa0ea0a blockchain: set the m_verifivation_failed flag in a couple more places (moneromooo-monero)
 2018-07-19 14:11:24 -05:00
luigi1111
f6d7e87b67
Merge pull request #4075 
438d52d remove epee from link lines where it's redundant (moneromooo-monero)
 2018-07-19 14:10:20 -05:00
luigi1111
326437c5ff
Merge pull request #4074 
ef649f9 crypto: remove unused unsafe random scalar generator (moneromooo-monero)
 2018-07-19 14:08:56 -05:00
luigi1111
be81a27fa4
Merge pull request #4071 
d6d78f1 Allow fractional outputs to be ignored (stoffu)
 2018-07-19 14:06:54 -05:00
luigi1111
173f7b8f42
Merge pull request #4064 
80d7c6c blockchain_utilities: report file offset where a read error occurs (moneromooo-monero)
 2018-07-19 14:05:51 -05:00
luigi1111
69502c4040
Merge pull request #4062 
13851b2 simplewallet.sweep_all: show usage when parsing fails (stoffu)
 2018-07-19 14:04:42 -05:00
luigi1111
5cade94189
Merge pull request #4047 
41b4bf9 tx_pool: cache check_tx_inputs results (moneromooo-monero)
 2018-07-19 14:02:20 -05:00
luigi1111
94ed562148
Merge pull request #4045 
7cdd147 Changed URLs to HTTPS (einsteinsfool)
 2018-07-19 13:56:38 -05:00
luigi1111
9315e12d34
Merge pull request #4033 
3e46db9 rpc: add a non binary get_transaction_pool_hashes RPC (moneromooo-monero)
 2018-07-19 13:55:37 -05:00
luigi1111
cff15e4123
Merge pull request #4032 
87e158b device_ledger: factor the prologue code (moneromooo-monero)
 2018-07-19 13:54:39 -05:00
luigi1111
3235abc184
Merge pull request #4030 
0c41488 miner: show id and height when a block is found (stoffu)
 2018-07-19 13:53:36 -05:00
luigi1111
138aefd0e7
Merge pull request #4029 
bd9e4e3 daemon: show a bit more info with print_block (stoffu)
 2018-07-19 13:52:41 -05:00
luigi1111
2e4653c077
Merge pull request #4023 
6cb9707 simplewallet: remove leftover global debug trace (moneromooo-monero)
 2018-07-19 13:51:44 -05:00
luigi1111
d14a074055
Merge pull request #4021 
09f43b9 crypto: add a README pointing to the SUPERCOP licence (moneromooo-monero)
 2018-07-19 13:50:37 -05:00
luigi1111
3e026ff6ed
Merge pull request #4013 
e5592c4 rpc: add blockchain disk size to getinfo (moneromooo-monero)
 2018-07-19 13:40:42 -05:00
luigi1111
21afa71ba6
Merge pull request #3981 
45e419b db: store cumulative rct output distribution in the db for speed (moneromooo-monero)
 2018-07-19 13:39:24 -05:00
luigi1111
d518dae4bf
Merge pull request #3973 
50af357 alt_chain_info can now give more info about a particular alt chain (moneromooo-monero)
 2018-07-19 13:37:10 -05:00
luigi1111
025187e6c9
Merge pull request #3854 
149da42 db_lmdb: enable batch transactions by default (stoffu)
34cb6b4 add --regtest and --fixed-difficulty for regression testing (vicsn)
9e1403e update get_info RPC and bump RPC version (vicsn)
207b66e first new functional tests (vicsn)
 2018-07-19 13:35:25 -05:00
stoffu
f2e65c6e50
wallet2: consider minimum fee when testing if balance is sufficient 2018-07-19 20:31:07 +09:00
moneromooo-monero
d6440ab319
wallet2: recover from index out of hashchain bounds error 
This can happen when there's a very large reorg on the daemon
(ie, on testnet)
 2018-07-16 23:13:56 +01:00
moneromooo-monero
63e342be84
crypto: move null_pkey/null_skey to the cpp file 2018-07-15 19:09:36 +01:00
moneromooo-monero
45e419bd5c
db: store cumulative rct output distribution in the db for speed 
This gets rid of the temporary precalc cache.

Also make the RPC able to send data back in binary or JSON,
since there can be a lot of data

This bumps the LMDB database format to v3, with migration.
 2018-07-13 11:37:04 +01:00
moneromooo-monero
2951436704
wallet: warn when payment IDs are used 
Subaddresses are better for privacy
 2018-07-12 19:37:29 +01:00
moneromooo-monero
ee31383a52
db_lmdb: don't sync a read only DB 
This would only throw
 2018-07-11 18:14:22 +01:00
Riccardo Spagni
7d2d8055ac
Merge pull request #4117 
fc39d3b2 wallet2: ensure outputs are processed only once (moneromooo-monero)
 2018-07-10 12:59:01 +02:00
Riccardo Spagni
2790ebc9f0
Merge pull request #4060 
22411149 blockchain_import: make sleep compile on Windows (iDunk5400)
 2018-07-10 09:34:41 +02:00
moneromooo-monero
fc39d3b23c
wallet2: ensure outputs are processed only once 
This should be proof against any way one might get to multiple
processing, such as generating the same derivation from the
same pubkey, etc
 2018-07-08 12:56:51 +01:00
moneromooo-monero
8c0523771f
blockchain: cache next block difficulty after adding a block 
It's not 100% certain it'll be needed, but it avoids getinfo
needing the blockchain lock and potentially blocking
 2018-07-07 19:34:21 +01:00
moneromooo-monero
639ca3b1fa
core_tests: add --filter to select which tests to run 2018-07-07 19:33:35 +01:00
moneromooo-monero
20eb192162
simplewallet: reword "seed encryption" to "seed offset" 
avoids people thinking it's somehow a generic AE system
 2018-07-07 11:35:41 +01:00
Riccardo Spagni
e647922080
bump version to 12.3 2018-07-06 07:57:00 +02:00
moneromooo-monero
61caab8a8c
crypto: remove slight bias in key generation due to modulo 2018-07-05 09:18:01 +01:00
iDunk5400
2241114965
blockchain_import: make sleep compile on Windows 2018-07-03 20:33:18 +02:00
moneromooo-monero
34d4b798d4
wallet2: use a gamma distribution to pick fake outs 
as per "An Empirical Analysis of Linkability in the Monero
Blockchain", by Miller et al.
 2018-07-03 18:10:48 +01:00
Riccardo Spagni
40f85f478e
Merge pull request #3985 
58cceaad wallet2: fix double counting outs if the tx pubkey is duplicated (moneromooo-monero)
 2018-07-03 15:51:41 +02:00
Riccardo Spagni
d1f102626c
Merge pull request #4043 
34de7bc2 device_ledger: fix buffer underflow on bad data from device (moneromooo-monero)
41e9cab4 device: misc cleanup (moneromooo-monero)
3b4dec2d device_ledger: fix potential buffer overflow from bad size calc (moneromooo-monero)
 2018-07-03 15:21:56 +02:00
Riccardo Spagni
82c39355ac
Merge pull request #4042 
9d7f6e60 simplewallet: init trusted daemon flag to false when autodetecting (moneromooo-monero)
 2018-07-03 15:21:27 +02:00
Riccardo Spagni
f449dbe8eb
Merge pull request #4041 
df9d50a8 wallet2: fix read buffer overflow in import_key_images (moneromooo-monero)
 2018-07-03 15:20:42 +02:00
Riccardo Spagni
94803bad01
Merge pull request #4035 
66df13a5 wallet-rpc.getaddress: throw if index is out of bound (stoffu)
 2018-07-03 15:19:54 +02:00
Riccardo Spagni
97f5a130d6
Merge pull request #4028 
2a19697b wallet2: fix double header in unsigned transfer file (moneromooo-monero)
 2018-07-03 15:19:24 +02:00
Riccardo Spagni
21807217e2
Merge pull request #4012 
5b5828fc zmq_server: fix bind call when address and/or port are empty (moneromooo-monero)
 2018-07-03 15:18:40 +02:00
Riccardo Spagni
e451c76181
Merge pull request #4005 
b85acb4c Fix RPC crashes that didn't check for an open wallet (Howard Chu)
 2018-07-03 15:18:05 +02:00
Riccardo Spagni
27ca6ca594
Merge pull request #4004 
bc443494 wallet2: fix out of sync account tag cache (moneromooo-monero)
 2018-07-03 15:16:37 +02:00
moneromooo-monero
58cceaad71
wallet2: fix double counting outs if the tx pubkey is duplicated 2018-07-03 14:16:30 +01:00
stoffu
a4272de797
wallet2: unlock keys file before calling verify_password (needed for Windows) 
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused
by anyone at the moment) regarding the need to unlock the keys file beforehand.
 2018-07-03 18:07:20 +09:00
stoffu
d6d78f157b
Allow fractional outputs to be ignored 2018-07-03 18:04:31 +09:00
moneromooo-monero
909398efc7
p2p: connect via the bound ip, if any 2018-07-02 18:06:04 +01:00
moneromooo-monero
8c4db68ff7
node_rpc_proxy: factor a few RPC calls using get_info 
Takes advantage of caching
 2018-07-02 17:59:44 +01:00
moneromooo-monero
d95bc44c6b
blockchain: fix getting invalid block data on failure 2018-06-29 15:50:34 +01:00
victorsintnicolaas
9e1403e155 update get_info RPC and bump RPC version 2018-06-29 10:06:18 +02:00
victorsintnicolaas
34cb6b4b70 add --regtest and --fixed-difficulty for regression testing 
on_generateblocks RPC call combines functionality from the on_getblocktemplate and on_submitblock RPC calls to allow rapid block creation. Difficulty is set permanently to 1 for regtest.
Makes use of FAKECHAIN network type, but takes hard fork heights from mainchain
Default reserve_size in generate_blocks RPC call is now 1. If it is 0, the following error occurs 'Failed to calculate offset for'.
Queries hard fork heights info of other network types
 2018-06-29 10:06:11 +02:00
moneromooo-monero
aa0ea0aafc
blockchain: set the m_verifivation_failed flag in a couple more places 
when a block being added to the main chain is invalid.

This ensures the peer is banned after a number of these.
 2018-06-28 16:57:22 +01:00
moneromooo-monero
438d52deaf
remove epee from link lines where it's redundant 
For some reason, this confuses and kills ASAN on startup
as it thinks const uint8_t ipv4_network_address::ID is
defined multiple times.
 2018-06-28 16:45:22 +01:00
moneromooo-monero
ef649f998d
crypto: remove unused unsafe random scalar generator 2018-06-28 16:44:13 +01:00
luigi1111
a9b83f5a6e
Merge pull request #4067 
9a39b7d wallet2: fix build for windows (std::max again) (moneromooo-monero)
 2018-06-27 21:28:34 -05:00
luigi1111
65c09beaf7
Merge pull request #4069 
49dc78d util: fix mistakes made in #3994 (stoffu)
 2018-06-27 21:25:00 -05:00
stoffu
49dc78d99b
util: fix mistakes made in #3994 2018-06-28 10:39:04 +09:00
stoffu
29254fc06e
api/wallet: add missing arg to wallet2::refresh() 2018-06-28 10:24:05 +09:00
luigi1111
ba0a7294d0
Merge pull request #4000 
4510f41 Wallet API: add some missing override keyword (stoffu)
 2018-06-27 20:18:41 -05:00
luigi1111
4c6de54ee2
Merge pull request #3994 
1d17647 epee.string_tools: add conversion between UTF-8 and UTF-16 (stoffu)
59de6f8 util: add file_locker class (stoffu)
3d623a8 wallet: prevent the same wallet file from being opened by multiple processes (stoffu)
 2018-06-27 20:17:25 -05:00
luigi1111
008b9036a3
Merge pull request #4066 
84d9e7f blockchain: fix build after waiter::wait prototype change (moneromooo-monero)
 2018-06-27 20:15:10 -05:00
stoffu
4510f417f9
Wallet API: add some missing override keyword 
Also remove dust() from UnsignedTransactionImpl (already in PendingTransactionImpl)
 2018-06-28 09:59:09 +09:00
stoffu
3d623a86d1
wallet: prevent the same wallet file from being opened by multiple processes 2018-06-28 09:41:43 +09:00
stoffu
59de6f8d99
util: add file_locker class 2018-06-28 09:40:31 +09:00
stoffu
1d176473e9
epee.string_tools: add conversion between UTF-8 and UTF-16 2018-06-28 09:40:26 +09:00
moneromooo-monero
9a39b7dd7f
wallet2: fix build for windows (std::max again) 2018-06-28 00:47:48 +01:00
moneromooo-monero
84d9e7faec
blockchain: fix build after waiter::wait prototype change 2018-06-28 00:24:39 +01:00
moneromooo-monero
9b38551c3c
wallet_rpc_server: fix build - forgot to build rpc version 2018-06-27 23:34:02 +01:00
luigi1111
2329d2f4c8
Merge pull request #3907 
dcbc17e wallet: include a suggested number of confirmations based on amount (moneromooo-monero)
 2018-06-27 16:32:33 -05:00
luigi1111
8a27caeb22
Merge pull request #3998 
8db23df wallet: on first refresh, start off with a quantized height (moneromooo-monero)
 2018-06-27 16:30:38 -05:00
luigi1111
9453573581
Merge pull request #3995 
0a5292c wallet2: use decoded amount when reporting repeated output key (stoffu)
 2018-06-27 16:28:57 -05:00
luigi1111
c28a2b0d7d
Merge pull request #3992 
25c15dc wallet2: use correct fee for split txes (stoffu)
 2018-06-27 16:26:23 -05:00
luigi1111
5eb2e01216
Merge pull request #3991 
798dfcf wallet: allow unspendable unmixable outputs to be discarded (stoffu)
 2018-06-27 16:25:03 -05:00
luigi1111
cbfa0a2a7e
Merge pull request #3987 
2d10830 db_ldmb: print db version when complaining about incompatibility (moneromooo-monero)
 2018-06-27 16:23:17 -05:00
luigi1111
87d7612311
Merge pull request #3986 
b628503 Remove old logic saved in comments. (jeandudey)
 2018-06-27 16:22:03 -05:00
luigi1111
3ad4ecd4ff
Merge pull request #3982 
08b85a8 cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X (stoffu)
0cf80ba net_node: resolve host for node addresses given via command line flags (stoffu)
 2018-06-27 15:38:23 -05:00
moneromooo-monero
dcbc17e97e
wallet: include a suggested number of confirmations based on amount 
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
 2018-06-27 21:38:21 +01:00
luigi1111
2d92fa5d69
Merge pull request #3979 
362f5e6 simplewallet: don't confirm missing payment ID when sending to only subaddresses (stoffu)
 2018-06-27 15:36:54 -05:00
luigi1111
a844844cda
Merge pull request #3716 
a2b557f 6795bd0 209ec96 ed2c81e a830db2 57ea902 31a895e ba8331c f7f1917 41be339 f025ae9 ef2cb63 dcfd299 5d3e702 2704624 2771a18 0e4c7d0 (moneromooo-monero)
 2018-06-27 15:33:01 -05:00
stoffu
13851b28c7
simplewallet.sweep_all: show usage when parsing fails 2018-06-27 22:54:10 +09:00
moneromooo-monero
80d7c6c730
blockchain_utilities: report file offset where a read error occurs 2018-06-27 14:11:35 +01:00
moneromooo-monero
0e4c7d0fae
wallet2: cache ringdb key while refreshing 
Speeds up syncing with a lot of outgoing outputs as key generation
runs Cryptonight.
 2018-06-26 22:15:38 +01:00
moneromooo-monero
2771a18e85
threadpool: allow leaf functions to run concurrently 
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
 2018-06-26 22:15:22 +01:00
moneromooo-monero
2704624eae
wallet2: remove unneeded divisions 2018-06-26 22:15:20 +01:00
moneromooo-monero
5d3e70229e
wallet2: remove old blockchain size cache hack 2018-06-26 22:15:18 +01:00
moneromooo-monero
dcfd299239
wallet2: speedup refresh 
key derivation and checking for incoming outputs are threaded
in batch before adding blocks to the local blockchain. Other
minor bits and bobs are also cached.
 2018-06-26 22:15:16 +01:00
moneromooo-monero
ef2cb63287
blockchain: simplify/speedup handle_get_objects 2018-06-26 22:15:14 +01:00
moneromooo-monero
f025ae9760
wallet2: avoid re-parsing blocks when refreshing in a loop 2018-06-26 22:15:12 +01:00
moneromooo-monero
41be339655
wallet2: avoid duplicate parsing of tx extra 2018-06-26 22:15:10 +01:00
moneromooo-monero
f7f1917ed4
wallet2: remove useless device locking 2018-06-26 22:14:35 +01:00
moneromooo-monero
ba8331ce41
wallet2: parse blocks in the RPC thread, not the processing thread 
Processing typically is the bottleneck
 2018-06-26 22:14:33 +01:00
moneromooo-monero
31a895e876
wallet2: simplify/speedup process_blocks 2018-06-26 22:14:31 +01:00
moneromooo-monero
57ea90285c
wallet: don't process miner tx if we're refreshing with no-coinbase 2018-06-26 22:14:26 +01:00
moneromooo-monero
a830db2577
rpc: rework to avoid repeated calculations in get_blocks.bin 2018-06-26 22:14:23 +01:00
moneromooo-monero
ed2c81ed95
replace std::list with std::vector on some hot paths 
also use reserve where appropriate
 2018-06-26 22:14:21 +01:00
moneromooo-monero
209ec963b5
rpc: sanity check on number of txes in a block 2018-06-26 22:14:18 +01:00
moneromooo-monero
6795bd0d4e
rpc: add option to skip coinbase info in get_blocks.bin 2018-06-26 22:14:16 +01:00
moneromooo-monero
a2b557fe5c
wallet2: use std::move on containers where appropriate 2018-06-26 22:14:14 +01:00
moneromooo-monero
50af3579ee
alt_chain_info can now give more info about a particular alt chain 2018-06-26 08:19:51 +01:00
luigi1111
31f47d72fe
Merge pull request #3977 
0309615 device_ledger: fix bad memory access on connect error (moneromooo-monero)
 2018-06-25 15:26:23 -05:00
luigi1111
14372ca95a
Merge pull request #3975 
2d5921e blockchain: avoid duplicate db query for height (moneromooo-monero)
 2018-06-25 15:24:45 -05:00
luigi1111
ab7ab29fc0
Merge pull request #3974 
1789b76 cryptonote_protocol_handler: log when dropping a peer (moneromooo-monero)
 2018-06-25 15:23:31 -05:00
luigi1111
b1be364f08
Merge pull request #3966 
948c482 simplewallet: grammar fix in warning message (moneromooo-monero)
 2018-06-25 15:16:38 -05:00
luigi1111
66212837ab
Merge pull request #3957 
2bb2c1b password: flush cout when prompting for password without newline (moneromooo-monero)
 2018-06-25 15:10:54 -05:00
luigi1111
506be80601
Merge pull request #3955 
d7a6b72 wallet2: fix bulletproof cold signing (moneromooo-monero)
 2018-06-25 15:09:48 -05:00
luigi1111
741a773025
Merge pull request #3948 
c367609 blockchain_import: warn+delay about using --dangerous-unverified-import (moneromooo-monero)
 2018-06-25 14:58:19 -05:00
luigi1111
26562e9f3c
Merge pull request #3941 
bf26920 wallet2: fix get_approximate_blockchain_height for stagenet (stoffu)
 2018-06-25 14:54:54 -05:00
luigi1111
c3ec5373b3
Merge pull request #3936 
d81e042 tx_pool: initialize bitflags padding since it gets written to storage (moneromooo-monero)
 2018-06-25 14:53:27 -05:00
luigi1111
473d984d88
Merge pull request #3921 
8fc0cdb wallet2: lower default for subaddress lookahead when restoring with hardware (stoffu)
248310d Move parse_subaddress_lookahead() from simplewallet.cpp to util.cpp (stoffu)
46e90b7 Wallet API: add support for wallet creation from hardware device (stoffu)
 2018-06-25 14:49:30 -05:00
luigi1111
1eddabf0a4
Merge pull request #3677 
d45cd37 fix typos in language files and rpc_args.cpp (ordtrogen)
 2018-06-25 14:41:48 -05:00
luigi1111
ff7dc087ae
Merge pull request #3407 
7bf99a2 fix string handling for donation message (cryptochangements34)
 2018-06-25 14:39:01 -05:00
moneromooo-monero
87e158b5b9
device_ledger: factor the prologue code 2018-06-25 12:35:10 +01:00
moneromooo-monero
41b4bf9d6d
tx_pool: cache check_tx_inputs results 
This is called a lot when creating a block template, and
does not change until the blockchain changes.
This also avoids tx parsing when cached.
 2018-06-24 11:22:26 +01:00
einsteinsfool
7cdd147da5 Changed URLs to HTTPS 2018-06-23 21:15:29 +02:00
moneromooo-monero
34de7bc267
device_ledger: fix buffer underflow on bad data from device 2018-06-23 15:43:31 +01:00
moneromooo-monero
41e9cab4e1
device: misc cleanup 
use snprintf "just in case" where appropriate
consistently use unsigned for temp values
pass std::string by const ref rather than by value
add length check (which can't happen in practice) for memcpy
 2018-06-23 15:28:48 +01:00
moneromooo-monero
3b4dec2d12
device_ledger: fix potential buffer overflow from bad size calc 2018-06-23 15:28:45 +01:00
moneromooo-monero
9d7f6e6089
simplewallet: init trusted daemon flag to false when autodetecting 2018-06-23 09:53:50 +01:00
moneromooo-monero
df9d50a8a4
wallet2: fix read buffer overflow in import_key_images 2018-06-23 09:22:20 +01:00
ordtrogen
d45cd37c53 fix typos in language files and rpc_args.cpp 2018-06-21 19:14:14 +02:00
moneromooo-monero
3e46db97e5
rpc: add a non binary get_transaction_pool_hashes RPC 2018-06-21 09:02:42 +01:00
stoffu
46e90b7780
Wallet API: add support for wallet creation from hardware device 2018-06-21 12:36:27 +09:00
stoffu
248310de06
Move parse_subaddress_lookahead() from simplewallet.cpp to util.cpp 2018-06-21 12:36:17 +09:00
stoffu
8fc0cdb96f
wallet2: lower default for subaddress lookahead when restoring with hardware 2018-06-21 12:35:23 +09:00
stoffu
66df13a58b
wallet-rpc.getaddress: throw if index is out of bound 2018-06-21 10:49:03 +09:00
moneromooo-monero
e5592c4bab
rpc: add blockchain disk size to getinfo 
This should help new nodes predict how much disk space will be
needed for a full sync
 2018-06-20 23:48:37 +01:00
luigi1111
ffab67004c
Merge pull request #3784 
261ee56 don't limit miner threads in wallet (cryptochangements34)
 2018-06-20 15:15:19 -05:00
cryptochangements34
7bf99a2376 fix string handling for donation message 2018-06-20 15:57:23 -04:00
luigi1111
9a3712541e
Merge pull request #3939 
62c8c07 wallet: do not log by default if we're not asked to log to console (moneromooo-monero)
 2018-06-20 14:52:55 -05:00
luigi1111
34c57d071f
Merge pull request #3938 
01cc978 ringct: remove an unnecessary scalarmultBase in zeroCommit (moneromooo-monero)
 2018-06-20 14:51:31 -05:00
luigi1111
3721298cf6
Merge pull request #3932 
8962f00 simplewallet: add optional trusted/untrusted argument to set_daemon (moneromooo-monero)
941a608 util: consider Tor/I2P addresses to be non local (moneromooo-monero)
2b3357e README: mention --untrusted-daemon (moneromooo-monero)
 2018-06-20 14:44:54 -05:00
luigi1111
7935bc5f6b
Merge pull request #3924 
afed978 Fixes #3645: error on freebsd lambda return values forced to std::string (rockhouse)
 2018-06-20 14:41:05 -05:00
luigi1111
9eb51887b0
Merge pull request #3919 
ace2eda blockchain: pop forked blocks only when DB is not read-only (stoffu)
 2018-06-20 14:39:09 -05:00
luigi1111
5a221c0e48
Merge pull request #3904 
4f3a4fb blockchain: return error when requesting non existent output (moneromooo-monero)
 2018-06-20 14:33:08 -05:00
luigi1111
81a2ff768b
Merge pull request #3903 
2b0c632 tx_pool: hold off parsing a tx blob till we actually need it (moneromooo-monero)
 2018-06-20 14:31:33 -05:00
luigi1111
51cdd76bbd
Merge pull request #3897 
63d0ab0 mlog: --max-log-files to set the max number of rotated log files (stoffu)
 2018-06-20 14:19:30 -05:00
luigi1111
034b0c7adb
Merge pull request #3896 
6b8568e simplewallet.sign_transfer: rename export to export_raw, add help message (stoffu)
 2018-06-20 14:13:59 -05:00
luigi1111
17fd575fe4
Merge pull request #3888 
1aae39d daemon: fix readline interfering with std::cerr usage (moneromooo-monero)
 2018-06-20 14:12:18 -05:00
luigi1111
36aeaa7545
Merge pull request #3757 
6f9260e handle optional miner params better (cryptochangements34)
 2018-06-20 14:09:42 -05:00
stoffu
0c4148845b
miner: show id and height when a block is found 2018-06-20 12:08:40 +09:00
stoffu
bd9e4e3149
daemon: show a bit more info with print_block 2018-06-20 12:04:03 +09:00
moneromooo-monero
2a19697bd4
wallet2: fix double header in unsigned transfer file 2018-06-19 22:30:02 +01:00
luigi1111
896512b2b6
Merge pull request #3878 
5a412b7 disable file size sanity check when loading the wallet cache (moneromooo-monero)
 2018-06-19 12:57:59 -05:00
luigi1111
cb130c7590
Merge pull request #3861 
de1ffe0 p2p: warn when no incoming connections are seen for a while (moneromooo-monero)
 2018-06-19 12:56:31 -05:00
luigi1111
9a3bd88b9f
Merge pull request #3851 
a87980f fix build with GCC 8.1.0 (moneromooo-monero)
 2018-06-19 12:51:13 -05:00
luigi1111
61f3916b4a
Merge pull request #3844 
bdf5a3a Fix PCSC compilation under windows (cslashm)
f17383a Fix CMAKE config for PCSC in order to avoid msys DLL dependencies (cslashm)
 2018-06-19 12:49:30 -05:00
luigi1111
d841339b09
Merge pull request #3829 
4764929 use deterministic viewkey if not supplied (cryptochangements34)
 2018-06-19 12:43:10 -05:00
luigi1111
50bc95519e
Merge pull request #3828 
16e209e core: lock incoming tx lock when checking the txpool and chain (moneromooo-monero)
 2018-06-19 12:41:07 -05:00
luigi1111
f62399b88d
Merge pull request #3821 
558d05b epee: log type name when a container size check fails (moneromooo-monero)
a2566db object_sizes: add a few useful types (moneromooo-monero)
 2018-06-19 12:39:12 -05:00
moneromooo-monero
09f43b9a6b
crypto: add a README pointing to the SUPERCOP licence 2018-06-18 21:28:08 +01:00
moneromooo-monero
5a2864c1fb
simplewallet: fix delay when setting auto-refresh off 2018-06-18 21:05:42 +01:00
moneromooo-monero
6cb97076ce
simplewallet: remove leftover global debug trace 2018-06-18 21:05:13 +01:00
luigi1111
cfd66dae4b
Merge pull request #3691 
db55263 threadpool: allow constructing an object, and misc tweaks (moneromooo-monero)
ce173cb core: remove threadpool dependency from header (moneromooo-monero)
3147468 unit_tests: add threadpool unit test (moneromooo-monero)
 2018-06-17 22:04:39 -05:00
moneromooo-monero
5b5828fcec
zmq_server: fix bind call when address and/or port are empty 2018-06-17 21:25:11 +01:00
luigi1111
9226acca4b
Merge pull request #3804 
89e51ec simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet (jcktm)
 2018-06-16 14:15:52 -05:00
luigi1111
fceb774344
Merge pull request #3798 
f357210 Fix Typo (Rafficer)
 2018-06-16 14:14:19 -05:00
luigi1111
4e7897e57c
Merge pull request #3780 
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
 2018-06-16 14:12:57 -05:00
luigi1111
e3012444fb
Merge pull request #3762 
eb9f3a3 check_spend_proof (itssteven)
 2018-06-16 14:10:11 -05:00
luigi1111
7af0b7fffc
Merge pull request #3735 
4812c06 add .load() to make Boost 1.67 happy with its new is_integral check (Teutone)
 2018-06-16 14:07:25 -05:00
luigi1111
fb2b16f10a
Merge pull request #3732 
fa0839f Ensure m_timestamps has the correct number for computing difficulty. (thaerkh)
 2018-06-16 14:05:53 -05:00
luigi1111
abfff766e5
Merge pull request #3737 
1590183 p2p: fix fallback seed node usage (moneromooo-monero)
 2018-06-16 14:04:01 -05:00
luigi1111
b3363e8e0a
Merge pull request #3726 
b5cb1bc blockchain: avoid exception if asked for a block we do not have (moneromooo-monero)
 2018-06-16 14:02:56 -05:00
luigi1111
42e7f31613
Merge pull request #3725 
9cc0d42 connection_context: remove state_ prefix from state names (moneromooo-monero)
d9d002c daemon: print peer state in sync_info (moneromooo-monero)
 2018-06-16 14:01:12 -05:00
luigi1111
aada0670ba
Merge pull request #3538 
f4e3295 simplewallet: set_ring can now take a file with rings (moneromooo-monero)
 2018-06-16 13:51:57 -05:00
Howard Chu
b85acb4cb8
Fix RPC crashes that didn't check for an open wallet 2018-06-15 20:18:41 +01:00
moneromooo-monero
bc443494f3
wallet2: fix out of sync account tag cache 
This would cause crashes when trying to tag an account that was
just created
 2018-06-15 20:18:12 +01:00
stoffu
149da420e9 db_lmdb: enable batch transactions by default 2018-06-14 20:56:11 +02:00
moneromooo-monero
8db23df581
wallet: on first refresh, start off with a quantized height 
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
 2018-06-13 22:44:27 +01:00
stoffu
63d0ab09b5
mlog: --max-log-files to set the max number of rotated log files 2018-06-13 12:44:27 +09:00
stoffu
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded 2018-06-13 11:56:40 +09:00
luigi1111
62f3f0480a
Merge pull request #3701 
3ca267b cn_deserialize: dump additional tx pubkeys (moneromooo-monero)
 2018-06-12 12:24:20 -05:00
luigi1111
a915d49307
Merge pull request #3700 
efcecb4 mnemonics: add some logs to help debug failures (moneromooo-monero)
 2018-06-12 12:23:12 -05:00
luigi1111
6be2516140
Merge pull request #3687 
6b13976 blockchain: log in DEBUG when a block is found, and where (moneromooo-monero)
 2018-06-12 12:22:12 -05:00
luigi1111
41d04a87b2
Merge pull request #3648 
6f36cf0 Improve 'show_transfers' date formatting (ryan-ronnander)
 2018-06-12 12:18:17 -05:00
luigi1111
ed139efc5d
Merge pull request #3643 
e2b7558 handle improper log levels (cryptochangements34)
 2018-06-12 12:13:07 -05:00
stoffu
0a5292c339
wallet2: use decoded amount when reporting repeated output key 2018-06-13 01:06:44 +09:00
stoffu
25c15dca5c
wallet2: use correct fee for split txes 2018-06-12 12:06:51 +09:00
moneromooo-monero
2d10830cfb
db_ldmb: print db version when complaining about incompatibility 2018-06-11 17:57:02 +01:00
Jean Pierre Dudey
b628503bad Remove old logic saved in comments. 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
 2018-06-11 09:36:05 -04:00
stoffu
0cf80baea4
net_node: resolve host for node addresses given via command line flags 2018-06-11 20:17:13 +09:00
stoffu
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X 2018-06-11 20:17:02 +09:00
stoffu
362f5e6eb8
simplewallet: don't confirm missing payment ID when sending to only subaddresses 2018-06-10 20:00:59 +09:00
moneromooo-monero
03096150c6
device_ledger: fix bad memory access on connect error 2018-06-09 20:52:34 +01:00
moneromooo-monero
2d5921eefa
blockchain: avoid duplicate db query for height 2018-06-09 19:51:27 +01:00
moneromooo-monero
1789b76b5d
cryptonote_protocol_handler: log when dropping a peer 2018-06-09 19:27:21 +01:00
moneromooo-monero
f4e329583e
simplewallet: set_ring can now take a file with rings 2018-06-09 00:28:31 +01:00
moneromooo-monero
948c48271a
simplewallet: grammar fix in warning message 2018-06-08 21:28:11 +01:00
moneromooo-monero
284fe6438d
db_lmdb: warn about slowness when running off a spinning disk 2018-06-08 20:59:02 +01:00
luigi1111
2619d966c6
Merge pull request #3908 
827ca3f bump version for 0.12.2 point release (fluffypony)
95ccf50 update checkpoints.dat for point release (fluffypony)
 2018-06-08 14:53:54 -05:00
luigi1111
6884db7b31
Merge pull request #3599 
8787fd8 WalletApi: publicMultisigSignerKey method (naughtyfox)
 2018-06-08 14:45:46 -05:00
luigi1111
00635bd68b
Merge pull request #3598 
b21bc00 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) (naughtyfox)
 2018-06-08 14:40:06 -05:00
luigi1111
22c8730261
Merge pull request #3450 
3b941be core: add get_earliest_ideal_height_for_version() (stoffu)
 2018-06-08 14:31:49 -05:00
luigi1111
5321769b65
Merge pull request #3444 
a79fc21 hardfork: fix get_earliest_ideal_height_for_version() to support non-existent versions (stoffu)
7e30ead unit_tests/hardfork: add tests for check_for_height() (stoffu)
98cf62c hardfork: fix get_next_version() (stoffu)
0321d1a unit_tests/hardfork: add tests for get_voting_info() (stoffu)
 2018-06-08 14:29:38 -05:00
luigi1111
9e5f2738fd
Merge pull request #3428 
b26cd26 blockchain_utilities: do not link against unneeded p2p lib (moneromooo-monero)
66f4700 blockchain_blackball: add incremental mode (moneromooo-monero)
e09710f blockchain_blackball: also blackball N N-sized duplicate rings (moneromooo-monero)
 2018-06-08 14:26:38 -05:00
luigi1111
03b4cca6c2
Merge pull request #3910 
f2cb56a protocol: drop (and increase fails) if most blocks hashes are invalid (moneromooo-monero)
 2018-06-07 12:24:02 -05:00
luigi1111
5bfe03804c
Merge pull request #3892 
d344736 rpc: convert distribution to cumulative after caching (moneromooo-monero)
 2018-06-07 12:22:04 -05:00
luigi1111
8a1f0d7d13
Merge pull request #3940 
f24cbc5 blockchain: fix deadlock with the difficulty cache (moneromooo-monero)
 2018-06-07 12:19:43 -05:00
luigi1111
48fcf76be9
Merge pull request #3911 
f0322a0 blockchain: demote a hash-of-hashes validation warning to debug (moneromooo-monero)
 2018-06-07 12:17:06 -05:00
luigi1111
e1a940806a
Merge pull request #3899 
ab87e7f rpc: the cache is still for non cumulative on that branch (moneromooo-monero)
 2018-06-07 12:15:13 -05:00
luigi1111
1af890287b
Merge pull request #3890 
f80b157 wallet2: don't ask for pruned txes yet, we still parse the entire tx (moneromooo-monero)
 2018-06-07 12:12:28 -05:00
moneromooo-monero
2bb2c1b9d7
password: flush cout when prompting for password without newline 2018-06-07 13:48:30 +01:00
moneromooo-monero
d7a6b72c15
wallet2: fix bulletproof cold signing 
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
 2018-06-07 12:29:30 +01:00
moneromooo-monero
c367609447
blockchain_import: warn+delay about using --dangerous-unverified-import 
This is the new name for --guard-against-pwnage 0
 2018-06-07 06:47:00 +01:00
stoffu
bf26920f27
wallet2: fix get_approximate_blockchain_height for stagenet 2018-06-06 20:33:01 +09:00
moneromooo-monero
f24cbc5245
blockchain: fix deadlock with the difficulty cache 2018-06-06 10:37:51 +01:00
moneromooo-monero
62c8c07c47
wallet: do not log by default if we're not asked to log to console 
This means monero-wallet-rpc still does, but the user level program
does not.
 2018-06-06 10:15:13 +01:00
moneromooo-monero
01cc978722
ringct: remove an unnecessary scalarmultBase in zeroCommit 2018-06-06 10:14:36 +01:00
cryptochangements34
4764929ecb use deterministic viewkey if not supplied 2018-06-05 19:32:03 -04:00
moneromooo-monero
d81e042306
tx_pool: initialize bitflags padding since it gets written to storage 
Avoids valgrind reporting uninitialized data usage
 2018-06-05 20:26:44 +01:00
moneromooo-monero
941a608d52
util: consider Tor/I2P addresses to be non local 2018-06-05 16:55:23 +01:00
moneromooo-monero
8962f0032f
simplewallet: add optional trusted/untrusted argument to set_daemon 
Otherwise the previous daemon's trustedness would carry over.
If not specified, the local address check is performed again.
 2018-06-05 16:55:20 +01:00
stoffu
ace2edacb6
blockchain: pop forked blocks only when DB is not read-only 2018-06-04 20:59:50 +09:00
S
afed9787cd Fixes #3645: error on freebsd lambda return values forced to std::string 2018-06-04 13:44:17 +02:00
moneromooo-monero
f2cb56a2eb
protocol: drop (and increase fails) if most blocks hashes are invalid 2018-06-03 17:34:08 +01:00
Dusan Klinec
9c2a7b4638 wallet-rpc: watch-only and cold wallet features added 
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs

Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx

- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
 2018-06-03 13:21:00 +02:00
moneromooo-monero
f0322a083a
blockchain: demote a hash-of-hashes validation warning to debug 
This data comes from untrusted peers, and validation failures
are therefore normal.
 2018-06-02 23:48:12 +01:00
Riccardo Spagni
95ccf508cd update checkpoints.dat for point release 2018-06-02 14:31:37 +02:00
Riccardo Spagni
827ca3fd3b bump version for 0.12.2 point release 2018-06-02 14:31:33 +02:00
moneromooo-monero
2b0c632f32
tx_pool: hold off parsing a tx blob till we actually need it 2018-06-02 09:17:41 +01:00
moneromooo-monero
4f3a4fb701
blockchain: return error when requesting non existent output 
avoids RPC thread dying, causing the wallet to timeout
 2018-06-01 21:52:04 +01:00
moneromooo-monero
ab87e7fdae
rpc: the cache is still for non cumulative on that branch 2018-06-01 09:05:47 +01:00
stoffu
6b8568e9a1
simplewallet.sign_transfer: rename export to export_raw, add help message 2018-06-01 09:38:14 +09:00
luigi1111
503d2693fd
Merge pull request #3640 
f36132a wallet cli/rpc: terminate execution with code 0 when --help or --version is given (stoffu)
 2018-05-31 14:44:54 -05:00
luigi1111
3ee6a1b706
Merge pull request #3635 
c1bda09 wallet_rpc_server: add a get_version RPC (moneromooo-monero)
 2018-05-31 14:43:18 -05:00
luigi1111
b6eb7484d1
Merge pull request #3592 
90a16b1 crypto: fix initialization order issue with random mutex (moneromooo-monero)
6a61f52 unit_tests: add ringdb unit tests (moneromooo-monero)
 2018-05-31 14:41:17 -05:00
luigi1111
40dd59fb8e
Merge pull request #3583 
372ffeb Add a space in mining to testnet/stagenet string (cryptochangements34)
 2018-05-31 14:39:28 -05:00
luigi1111
737712c0c6
Merge pull request #3561 
353e9c0 Core RPC: optionally add POW hash to block_header_response (stoffu)
 2018-05-31 14:38:01 -05:00
luigi1111
c8378933ae
Merge pull request #3543 
6fc97c9 blockchain_usage: don't divide by 0 when there is nothing to process (moneromooo-monero)
 2018-05-31 14:36:33 -05:00
luigi1111
3a373c3d3a
Merge pull request #3489 
47fdb74 WalletApi: getMultisigInfo entry for gui wallets... (naughtyfox)
47fdb74 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings (naughtyfox)
 2018-05-31 14:34:34 -05:00
luigi1111
64adb566e5
Merge pull request #3499 
0da5d37 wallet: fix shared ring db path (stoffu)
 2018-05-31 14:27:13 -05:00
luigi1111
9fde7aafe8
Merge pull request #3882 
b665bab rpc: fix get_output_distribution cache for the cumulative case (moneromooo-monero)
 2018-05-31 14:25:57 -05:00
moneromooo-monero
d3447364d0
rpc: convert distribution to cumulative after caching 
This avoids double conversion on a later cache hit
 2018-05-31 16:54:57 +01:00
moneromooo-monero
f80b1571c6
wallet2: don't ask for pruned txes yet, we still parse the entire tx 2018-05-31 16:46:58 +01:00
moneromooo-monero
1aae39dff2
daemon: fix readline interfering with std::cerr usage 
Once readline is initialized, std::cerr's operator<< will
output a 0xff byte for unknown reasons.
 2018-05-31 12:15:06 +01:00
stoffu
0da5d37bf3
wallet: fix shared ring db path 2018-05-31 08:16:45 +09:00
luigi1111
9bc8f76924
Merge pull request #3525 
66a659b blockchain: add scope guard to waiter for threaded txv1 verification (stoffu)
 2018-05-30 16:08:50 -05:00
luigi1111
f03bf36c85
Merge pull request #3491 
c8cb5fc exit if specified wallet file doesn't exist (cryptochangements34)
 2018-05-30 15:55:37 -05:00
luigi1111
a7ea14dc6a
Merge pull request #3876 
740da1b core: fix automatic safe db sync mode switching (moneromooo-monero)
e942d34 protocol: do not switch to unsafe sync mode for just a few blocks (moneromooo-monero)
 2018-05-30 15:46:13 -05:00
luigi1111
4267a0bb51
Merge pull request #3731 
a66f152 Use median timestamp if current time renders a block invalid. (thaerkh)
 2018-05-30 15:44:25 -05:00
moneromooo-monero
b665bab1d6
rpc: fix get_output_distribution cache for the cumulative case 
The distribution was not converted to cumulative after a cache hit
 2018-05-30 15:03:36 +01:00
moneromooo-monero
e09710f76e
blockchain_blackball: also blackball N N-sized duplicate rings 
These are unlikely to happen at random, but Wijaya et al made
a paper about it, so people might try it on purpose now (and it
turns out it's easy to add anyway)
 2018-05-30 11:45:20 +01:00
moneromooo-monero
66f4700f57
blockchain_blackball: add incremental mode 2018-05-30 11:45:16 +01:00
moneromooo-monero
b26cd26333
blockchain_utilities: do not link against unneeded p2p lib 2018-05-30 11:45:13 +01:00
stoffu
98cf62cc45
hardfork: fix get_next_version() 2018-05-30 09:49:57 +09:00
stoffu
a79fc219b7
hardfork: fix get_earliest_ideal_height_for_version() to support non-existent versions 2018-05-30 09:49:52 +09:00
luigi1111
c534fe8d19
Merge pull request #3251 
b9389e5 db_lmdb: save pruned and prunable tx data separately (moneromooo-monero)
 2018-05-29 17:56:26 -05:00
luigi1111
c4907d24cb
Merge pull request #3477 
3f5fb6f simplewallet: add --untrusted-daemon option (moneromooo-monero)
 2018-05-29 13:01:50 -05:00
luigi1111
8e1b322a15
Merge pull request #3470 
ad19f86 don't show error twice when starting simplewallet (cryptochangements34)
 2018-05-29 12:59:58 -05:00
luigi1111
ed72f35e9a
Merge pull request #3446 
a6b8d3f tx_pool: remove old comment from fill_block_template() (stoffu)
 2018-05-29 12:57:43 -05:00
luigi1111
764340d112
Merge pull request #3420 
a6a54fa blockchain: cache difficulty for next block (moneromooo-monero)
 2018-05-29 12:55:19 -05:00
luigi1111
5b189ce2a8
Merge pull request #3405 
80d2f80 wallet2: Update function parameter documentation (leonklingele)
 2018-05-29 12:52:43 -05:00
moneromooo-monero
5a412b7a3f
disable file size sanity check when loading the wallet cache 2018-05-28 14:58:22 +01:00
moneromooo-monero
e942d34d54
protocol: do not switch to unsafe sync mode for just a few blocks 2018-05-28 14:36:12 +01:00
moneromooo-monero
740da1ba95
core: fix automatic safe db sync mode switching 2018-05-28 12:14:04 +01:00
stoffu
a6b8d3fee1
tx_pool: remove old comment from fill_block_template() 2018-05-28 13:41:39 +09:00
moneromooo-monero
a87980f6c2
fix build with GCC 8.1.0 2018-05-26 14:54:10 +01:00
moneromooo-monero
de1ffe07b1
p2p: warn when no incoming connections are seen for a while 2018-05-26 14:37:07 +01:00
moneromooo-monero
b9389e582e
db_lmdb: save pruned and prunable tx data separately 
This bumps DB version to 2, migration code will run for v1 DBs
 2018-05-23 22:48:12 +01:00
Riccardo Spagni
45975fd8eb update checkpoints 2018-05-23 21:20:15 +02:00
Riccardo Spagni
6715c90667 update checkpoints for point release 2018-05-23 21:20:10 +02:00
Riccardo Spagni
49f4645f1d bump version for point release 2018-05-23 21:20:05 +02:00
cslashm
bdf5a3ad3f Fix PCSC compilation under windows 
PR3843 based on release-v0.12 => rebased on master
 2018-05-23 10:22:55 +02:00
Riccardo Spagni
a2cef8cba4
Merge pull request #3800 
9317bce9 crypto: more places needing fixing for GCC 8.1 (moneroexamples)
4a72d595 chacha: fix build with GCC 8.1 (moneromooo-monero)
 2018-05-21 21:58:49 +02:00
Riccardo Spagni
f794d3b3df
Merge pull request #3787 
ce63ab09 blockchain: invalidate misc caches when popping blocks (moneromooo-monero)
 2018-05-21 21:36:38 +02:00
Riccardo Spagni
709658d166
Merge pull request #3832 
cb9c7972 Fix output shuffling for multisig (stoffu)
 2018-05-21 20:57:52 +02:00
Riccardo Spagni
4dae04dde2
Merge pull request #3837 
18761b37 simplewallet: use correct unit for fee command (stoffu)
 2018-05-21 20:57:07 +02:00
Riccardo Spagni
d6cefbd1b8
Merge pull request #3745 
b13bddc3 Wallet API: allow log path to be non-default & console output to be configurable (stoffu)
 2018-05-21 20:56:20 +02:00
moneromooo-monero
5f8ffca34d
speed up get_output_distribution (and precalc common case) 2018-05-21 19:51:58 +01:00
Riccardo Spagni
2f5506daf8
Merge pull request #3830 
29fbaeaa daemon: request unpruned transactions for print_tx (moneromooo-monero)
 2018-05-21 20:46:57 +02:00
Riccardo Spagni
791da4343c
Merge pull request #3749 
872cb4ef blockchain: pop top if block version disagrees with the ideal fork version (stoffu)
 2018-05-21 20:45:35 +02:00
stoffu
18761b372f
simplewallet: use correct unit for fee command 2018-05-20 23:16:31 +09:00
moneromooo-monero
ce173cbb5b
core: remove threadpool dependency from header 2018-05-20 12:06:07 +01:00
moneromooo-monero
db55263b4c
threadpool: allow constructing an object, and misc tweaks 
use unsigned int to avoid having to range check negative numbers,
use const where possible, don't needlessly create empty objects,
use std::move where possible
 2018-05-20 12:06:03 +01:00
stoffu
cb9c7972b6
Fix output shuffling for multisig 2018-05-20 09:38:41 +09:00
moneromooo-monero
29fbaeaae5
daemon: request unpruned transactions for print_tx 
instead of uninitialized
 2018-05-19 00:04:46 +01:00
moneromooo-monero
16e209e08d
core: lock incoming tx lock when checking the txpool and chain 
This gets rid of an innocuous race trying to add the same tx
twice to the txpool
 2018-05-18 09:39:56 +01:00
moneromooo-monero
a2566db09e
object_sizes: add a few useful types 2018-05-17 10:40:11 +01:00
jcktm
89e51ecd38 simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet 2018-05-15 15:28:42 +10:00
Thaer Khawaja
a66f152f75 Use median timestamp if current time renders a block invalid. 2018-05-13 11:58:05 -07:00
moneroexamples
9317bce9ca
crypto: more places needing fixing for GCC 8.1 2018-05-13 18:17:13 +01:00
moneromooo-monero
4a72d595a6
chacha: fix build with GCC 8.1 2018-05-13 18:17:11 +01:00
Rafficer
f357210c00
Fix Typo 2018-05-12 20:18:21 +02:00
moneromooo-monero
a58d9738c9
wallet2: consider 6 outputs or less to be unmixable from v7 2018-05-10 21:19:33 +01:00
moneromooo-monero
b5cb1bc403
blockchain: avoid exception if asked for a block we do not have 
This can happen if a peer tries to obtain the next span from other
peers if that span is needed for not downloaded yet. Also if the
peer maliciously requests a non existent block hash.
 2018-05-09 14:03:07 +01:00
moneromooo-monero
ce63ab09db
blockchain: invalidate misc caches when popping blocks 
Might be a bit heavy handed, but conservative.
 2018-05-09 09:10:56 +01:00
cryptochangements34
261ee5628b don't limit miner threads in wallet 2018-05-08 19:09:14 -04:00
Riccardo Spagni
52f6b33890
Merge pull request #3775 
6f859e43 cryptonote: make sure outPk setup always happens (moneromooo-monero)
 2018-05-08 09:59:28 +02:00
moneromooo-monero
6f859e4328
cryptonote: make sure outPk setup always happens 2018-05-07 19:21:52 +01:00
itssteven
eb9f3a3294
check_spend_proof 
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
 2018-05-06 17:42:27 +01:00
cryptochangements34
6f9260e38e handle optional miner params better 2018-05-06 12:28:57 -04:00
stoffu
872cb4efd8
blockchain: pop top if block version disagrees with the ideal fork version 2018-05-06 20:50:46 +09:00
Teutone
4812c062c5 add .load() to make Boost 1.67 happy with its new is_integral check 2018-05-05 21:44:28 +02:00
moneromooo-monero
5f19384729
ringct: do not show verification errors with default settings 2018-05-04 08:27:55 +01:00
stoffu
b13bddc3c9
Wallet API: allow log path to be non-default & console output to be configurable 2018-05-04 10:21:25 +09:00
Thaer Khawaja
fa0839f2f5 Ensure m_timestamps has the correct number for computing difficulty. 2018-04-29 19:50:55 -07:00
Riccardo Spagni
6b9d9f56a1
Merge pull request #3719 
3880bf39 cryptonote_protocol_handler.inl: remove span read just now that failed to pass some basic tests (stoffu)
da249fd5 cryptonote_protocol_handler.inl: fix return type mismatches (int vs bool) (stoffu)
 2018-04-29 21:38:22 +02:00
moneromooo-monero
1590183965
p2p: fix fallback seed node usage 
Those were added to the seed nodes list even when they had already
been added. Moreover, the current index was not reset after they
were added, typically causing previous seeds to be used, and some
of those fallback seeds to not be tried.
 2018-04-29 14:58:42 +01:00
moneromooo-monero
d9d002c3c1
daemon: print peer state in sync_info 
It's often relevant
 2018-04-28 19:56:39 +01:00
moneromooo-monero
9cc0d4220f
connection_context: remove "state_" prefix from state names 
It's redundant and makes it easier to print them in columns
 2018-04-28 19:56:28 +01:00
Riccardo Spagni
cd22cb807a
Merge pull request #3709 
82b05d50 Adding required library (dependency of boost::this_thread::sleep_for) (Gene Peters)
 2018-04-28 17:02:22 +02:00
Riccardo Spagni
69b6f5b6a6
Merge pull request #3705 
f9d0827b Fix broken interactive daemon 'limit' commands plus RPC calls (rbrunner7)
 2018-04-28 17:02:08 +02:00
Riccardo Spagni
26cae8f4f1
Merge pull request #3695 
b1a9e97b slow-hash: fix memory leak for Windows /karbowanec#41 (aivve)
 2018-04-28 16:59:02 +02:00
Riccardo Spagni
2ab5b1a21f
Merge pull request #3683 
dad10775 Only log an error if fork version is higher AND is not known. (Thaer Khawaja)
 2018-04-28 16:57:36 +02:00
Riccardo Spagni
93e76e14a2
Merge pull request #3685 
ffeeefde speedup get_output_histogram for all amounts when min_count > 0 (moneromooo-monero)
2dae0f20 wallet2: add missing parameters to get_output_histogram (moneromooo-monero)
 2018-04-28 16:56:22 +02:00
Riccardo Spagni
35299644b2
Merge pull request #3650 
5bd7f760 import_multisig_info: fix sanity check crash in detach_blockchain (Mikhail Mitkevichl)
 2018-04-28 16:54:37 +02:00
stoffu
3880bf396a
cryptonote_protocol_handler.inl: remove span read just now that failed to pass some basic tests 2018-04-28 11:10:59 +09:00
stoffu
da249fd5ba
cryptonote_protocol_handler.inl: fix return type mismatches (int vs bool) 2018-04-28 11:07:51 +09:00
Gene Peters
82b05d5054 Adding required library (dependency of boost::this_thread::sleep_for) 2018-04-25 21:02:54 -07:00
rbrunner7
f9d0827bba Fix broken interactive daemon 'limit' commands plus RPC calls 2018-04-25 21:37:10 +02:00
naughtyfox
b21bc00704 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) 2018-04-25 17:55:54 +03:00
moneromooo-monero
3ca267b546
cn_deserialize: dump additional tx pubkeys 2018-04-25 14:28:39 +01:00
moneromooo-monero
efcecb42f3
mnemonics: add some logs to help debug failures 2018-04-25 14:27:24 +01:00
aivve
b1a9e97b2d
slow-hash: fix memory leak for Windows /karbowanec#41 2018-04-24 20:47:29 +09:00
moneromooo-monero
6b13976330
blockchain: log in DEBUG when a block is found, and where 
Eases up debugging
 2018-04-23 11:43:12 +01:00
moneromooo-monero
ffeeefde60
speedup get_output_histogram for all amounts when min_count > 0 
This skips the vast majority of "dust" output amounts with just
one instance on the chain. Clocks in at 0.15% of the original
time on testnet.
 2018-04-23 10:54:28 +01:00
moneromooo-monero
2dae0f203a
wallet2: add missing parameters to get_output_histogram 2018-04-23 10:54:25 +01:00
Thaer Khawaja
dad1077577 Only log an error if fork version is higher AND is not known. 2018-04-22 17:26:44 -07:00
stoffu
f36132a837
wallet cli/rpc: terminate execution with code 0 when --help or --version is given 2018-04-22 11:48:44 +09:00
Mikhail Mitkevichl
5bd7f760e9 import_multisig_info: fix sanity check crash in detach_blockchain 2018-04-21 23:25:01 +03:00
Riccardo Spagni
8fdf645397
Merge pull request #3670 
19e01378 Build: remove UPnP definition from snap (anonimal)
6b853980 Build: update CMake and p2p for in-tree miniupnp (anonimal)
859db52f CMake: update new location of in-tree miniupnpc (anonimal)
f21df05c Build: add miniupnp submodule (anonimal)
10685648 Build: remove in-tree miniupnpc (anonimal)
 2018-04-21 22:01:54 +02:00
Riccardo Spagni
a429f06b18
Merge pull request #3579 
0b88fff3 simplewallet: fix help message of sign_transfer (stoffu)
 2018-04-21 21:58:52 +02:00
Riccardo Spagni
a3a617f35f
Merge pull request #3576 
f82c10dc WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time (stoffu)
 2018-04-21 21:58:10 +02:00
Riccardo Spagni
6189a775b0
Merge pull request #3636 
998c1461 daemon: read config file before reading any other args (stoffu)
 2018-04-21 21:57:31 +02:00
Riccardo Spagni
bcb71797c8
Merge pull request #3633 
f914df84 device: add a one off override keyword where appropriate (moneromooo-monero)
 2018-04-21 21:55:44 +02:00
Riccardo Spagni
7e98e9d7ce
Merge pull request #3630 
51b511be simplewallet: add version command (moneromooo-monero)
35d1269f daemon: add a version command (moneromooo-monero)
 2018-04-21 21:55:28 +02:00
Riccardo Spagni
e6cf9c06fc
Merge pull request #3624 
d8584fc8 util: log stack trace on crash (moneromooo-monero)
 2018-04-21 21:55:02 +02:00
Riccardo Spagni
03ff3be10e
Merge pull request #3672 
875c1cab wallet2: increase rpc timeout for get_output_distribution (moneromooo-monero)
70f23217 add top height to get_output_distribution, and cache it for rct (moneromooo-monero)
8c7363fb rpc: add missing perf timer for get_output_distribution (moneromooo-monero)
 2018-04-21 21:54:08 +02:00
anonimal
6b85398031
Build: update CMake and p2p for in-tree miniupnp 
(cherry picked from commit a7366b5feeffaeb65b217b2d6f138e0ab1c90192)
 2018-04-21 09:43:23 +00:00
moneromooo-monero
875c1cabb9
wallet2: increase rpc timeout for get_output_distribution 2018-04-19 16:06:26 +01:00
moneromooo-monero
70f2321763
add top height to get_output_distribution, and cache it for rct 
This should cache the vast majority of calls for long running wallets
 2018-04-19 16:06:22 +01:00
moneromooo-monero
8c7363fbef
rpc: add missing perf timer for get_output_distribution 2018-04-19 16:06:20 +01:00
anonimal
859db52fda
CMake: update new location of in-tree miniupnpc 
(cherry picked from commit b16a282f97d8f6c967e8a0b1ecfd75110f095182)
 2018-04-19 10:56:09 +00:00
Ryan Ronnander
6f36cf02e7
Improve 'show_transfers' date formatting 
Change the wallet's 'show_transfers' command to always output the transaction date with timestamp (24 hour UTC).
 2018-04-15 19:23:15 -07:00
cryptochangements34
e2b75586fb handle improper log levels 2018-04-15 11:33:22 -04:00
stoffu
998c1461c3
daemon: read config file before reading any other args 2018-04-14 22:05:24 +09:00
moneromooo-monero
c1bda097c1
wallet_rpc_server: add a get_version RPC 2018-04-14 13:34:05 +01:00
moneromooo-monero
f914df8494
device: add a one off override keyword where appropriate 2018-04-14 10:59:38 +01:00
moneromooo-monero
51b511be4c
simplewallet: add version command 2018-04-13 18:47:33 +01:00
moneromooo-monero
35d1269fac
daemon: add a version command 2018-04-13 18:47:30 +01:00
naughtyfox
8787fd899b WalletApi: publicMultisigSignerKey method 2018-04-13 13:15:20 +03:00
moneromooo-monero
d8584fc8d7
util: log stack trace on crash 2018-04-12 20:36:16 +01:00
stoffu
b5d6c723e9
wallet2: store subaddress lookahead settings 2018-04-12 22:23:53 +09:00
Riccardo Spagni
1f96755ddc
Merge pull request #3618 
3367ed86 blockchain_blackball: fix build with CLANG 5 (moneromooo-monero)
 2018-04-12 15:10:21 +02:00
moneromooo-monero
3367ed863c
blockchain_blackball: fix build with CLANG 5 
It doesn't like the explicit NULL dereference (which is fine, honest)
 2018-04-12 13:51:26 +01:00
cslashm
94b899db26 Use 'boost' mutex instead of 'std' mutex 2018-04-12 13:58:57 +02:00
cslashm
2c274e05fe Fix sub-address tx scan. 
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.

Moreover this patch avoid perf decreasing when not using HW device.
 2018-04-12 13:58:57 +02:00
Riccardo Spagni
5e08fd89ea
Merge pull request #3549 
73951cbd wallet2: request transactions in slices when scanning for known rings (moneromooo-monero)
25fe67e4 rpc: allow getting pruned blocks from gettransactions (moneromooo-monero)
 2018-04-12 13:49:33 +02:00
Riccardo Spagni
a95461e76d
Merge pull request #3609 
08343aba tx_pool: fix loading with colliding key images (moneromooo-monero)
 2018-04-12 13:48:44 +02:00
Riccardo Spagni
1e9cc3e43e
Merge pull request #3602 
a9cc88ee common: make this build with unbound 1.4.20 (moneromooo-monero)
 2018-04-12 13:48:12 +02:00
Riccardo Spagni
14c870ee5f
Merge pull request #3615 
24acb66e wallet2: fix misc issues when the ringdb can't be initialized (moneromooo-monero)
 2018-04-12 13:47:54 +02:00
Riccardo Spagni
3b8704b0fa
Merge pull request #3555 
0b26c4d5 wallet2: move segregation height to v7 (moneromooo-monero)
 2018-04-12 13:47:39 +02:00
Riccardo Spagni
5d8439e310
Merge pull request #3534 
eecfb57d wallet: warn if not using the default ring size (moneromooo-monero)
 2018-04-12 13:47:20 +02:00
Riccardo Spagni
f6094bb225
Merge pull request #3532 
aa5c2e01 simplewallet: warn about key reuse on startup (moneromooo-monero)
 2018-04-12 13:46:50 +02:00
Riccardo Spagni
226de8e928
Merge pull request #3530 
eb59f7c5 cryptonote_tx_util: make destinations properly shuffled (stoffu)
 2018-04-12 13:46:34 +02:00
Riccardo Spagni
8703f1d80e
Merge pull request #3516 
1e0958c0 wallet: fix default mixin (4 -> 6) (sneurlax)
 2018-04-12 13:46:18 +02:00
moneromooo-monero
24acb66eac
wallet2: fix misc issues when the ringdb can't be initialized 2018-04-12 11:07:07 +01:00
Riccardo Spagni
3a9290ba6f
Merge pull request #3511 
0beb94f3 device: fix endianess dependence on subaddress secret key generation (moneromooo-monero)
 2018-04-12 11:15:27 +02:00
Riccardo Spagni
5053f8f40b
Merge pull request #3502 
11c933e1 fix lambda compile error on openbsd (moneromooo-monero)
 2018-04-12 11:14:43 +02:00
Riccardo Spagni
96b2fee721
Merge pull request #3536 
c77d2bfa Add the possibility to export private view key for fast scan. (cslashm)
100b7bc1 Change mutex lock model to avoid dead lock and ensure locks are always released. (cslashm)
641dfc99 Automatic height setup when creating/restoring hw device. (cslashm)
 2018-04-12 11:12:33 +02:00
Riccardo Spagni
60b18cdd1f
Merge pull request #3492 
dac3895a update block hashes for checkpoints.dat (Riccardo Spagni)
 2018-04-12 11:07:16 +02:00
Riccardo Spagni
93047ce762
Merge pull request #3485 
1834127c rpc: make get_output_distribution a non-restricted RPC (moneromooo-monero)
 2018-04-12 11:06:26 +02:00
Riccardo Spagni
1b4dc46129
Merge pull request #3473 
eaa8bfe7 wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly The previous expression (stoffu)
0a619f78 wallet2: enable the mitigation only after the fork height (stoffu)
 2018-04-12 11:05:31 +02:00
Riccardo Spagni
3d6636e79c
Merge pull request #3471 
5f664793 p2p: correct port number for seed nodes (stoffu)
 2018-04-12 11:02:46 +02:00
Riccardo Spagni
ebb55f797b
Merge pull request #3468 
0098ed33 wallet2: fix for loading settings of key reuse mitigation (stoffu)
 2018-04-12 11:00:47 +02:00
Riccardo Spagni
959f6ed9a5
Merge pull request #3461 
57300491 wallet: catch exceptions dealing with ringdb and warn (moneromooo-monero)
 2018-04-12 10:57:50 +02:00
moneromooo-monero
08343abaf4
tx_pool: fix loading with colliding key images 
A key image may be present more than once if all but one of the
txes spending that key image are coming from blocks. When loading
a txpool from storage, we must load the one that's not from a
block first to avoid rejection
 2018-04-11 15:27:56 +01:00
moneromooo-monero
6a61f520e2
unit_tests: add ringdb unit tests 2018-04-11 11:43:39 +01:00
moneromooo-monero
a9cc88ee76
common: make this build with unbound 1.4.20 
Common on currently used distros
 2018-04-10 23:46:18 +01:00
moneromooo-monero
90a16b119f
crypto: fix initialization order issue with random mutex 2018-04-10 12:30:48 +01:00
cryptochangements34
372ffeba21
Add a space in mining to testnet/stagenet string 2018-04-08 00:23:59 -04:00
stoffu
0b88fff3a5
simplewallet: fix help message of sign_transfer 2018-04-07 22:51:03 +09:00
moneromooo-monero
73951cbd39
wallet2: request transactions in slices when scanning for known rings 
This avoid massive memory consumption for huge wallets
 2018-04-07 08:31:46 +01:00
moneromooo-monero
25fe67e4cf
rpc: allow getting pruned blocks from gettransactions 
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.

Also set decode_to_json to false where missing, we don't need this
either.
 2018-04-07 08:29:11 +01:00
stoffu
f82c10dc96
WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time 2018-04-07 14:06:29 +09:00
stoffu
353e9c0c90
Core RPC: optionally add POW hash to block_header_response 2018-04-05 23:15:15 +09:00
moneromooo-monero
0b26c4d57c
wallet2: move segregation height to v7 
since people seem to really want to use things the wrong way.
 2018-04-05 12:49:38 +01:00
moneromooo-monero
6fc97c97eb
blockchain_usage: don't divide by 0 when there is nothing to process 
Coverity 184942
 2018-04-03 11:16:38 +01:00
cslashm
c77d2bfaa0 Add the possibility to export private view key for fast scan. 
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
 2018-03-31 18:00:33 +02:00
cslashm
100b7bc10d Change mutex lock model to avoid dead lock and ensure locks are always released. 
Additional cosmetic fixes:
 move 'name' as protected
 remove unnecessary local var
 Fix debug log
 2018-03-31 18:00:33 +02:00
cslashm
641dfc991f Automatic height setup when creating/restoring hw device. 
When creating/restoring wallet, if --restore-height option is not used the current estimate
height is used for starting the scan. In other words it is assume we are creating a new account.
 2018-03-31 18:00:33 +02:00
moneromooo-monero
eecfb57df9
wallet: warn if not using the default ring size 2018-03-31 15:47:02 +01:00
moneromooo-monero
aa5c2e01e7
simplewallet: warn about key reuse on startup 2018-03-31 10:52:10 +01:00
stoffu
eb59f7c563
cryptonote_tx_util: make destinations properly shuffled 2018-03-31 18:37:46 +09:00
stoffu
66a659bb03
blockchain: add scope guard to waiter for threaded txv1 verification 2018-03-30 19:22:32 +09:00
sneurlax
1e0958c083 wallet: fix default mixin (4 -> 6) 2018-03-28 09:30:11 -07:00
naughtyfox
5a96056600 WalletApi: getMultisigInfo entry for gui wallets 
WalletApi: makeMultisig call introduced

WalletApi: finalizeMultisig call introduced

WalletApi: new calls exportMultisigImages and importMultisigImages

WalletApi: method to return multisig wallet creation state

WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added

WalletApi: identation and style fixes
 2018-03-28 18:22:13 +03:00
naughtyfox
47fdb74273 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings 
WalletApi: added method statusWithErrorString to atomically retrieve error with error string
 2018-03-28 16:11:16 +03:00
moneromooo-monero
0beb94f323
device: fix endianess dependence on subaddress secret key generation 
We now force little endianness
 2018-03-28 11:14:25 +01:00
moneromooo-monero
11c933e137
fix lambda compile error on openbsd 2018-03-27 14:48:36 +01:00
cryptochangements34
c8cb5fca5e exit if specified wallet file doesn't exist 2018-03-24 11:13:21 -04:00
Riccardo Spagni
dac3895ac1
update block hashes for checkpoints.dat 2018-03-24 08:36:10 +02:00
moneromooo-monero
1834127c82
rpc: make get_output_distribution a non-restricted RPC 
so that those nodes can still be used for sending transactions
 2018-03-23 10:56:55 +00:00
moneromooo-monero
3f5fb6fe6d
simplewallet: add --untrusted-daemon option 2018-03-22 14:20:55 +00:00
stoffu
eaa8bfe7c0
wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly 
The previous expression

    req_t.from_height = X ? Y >= Z : 0;

forces the parameter to take the value of either 0 or 1.
 2018-03-22 20:02:25 +09:00
stoffu
0a619f789b
wallet2: enable the mitigation only after the fork height 2018-03-22 20:02:14 +09:00
stoffu
5f6647934b
p2p: correct port number for seed nodes 2018-03-22 14:56:35 +09:00
stoffu
0098ed338c
wallet2: fix for loading settings of key reuse mitigation 2018-03-22 12:10:46 +09:00
cryptochangements34
ad19f8679e don't show error twice when starting simplewallet 2018-03-21 22:56:04 -04:00
moneromooo-monero
5730049178
wallet: catch exceptions dealing with ringdb and warn 2018-03-21 14:29:49 +00:00
stoffu
3b941befae
core: add get_earliest_ideal_height_for_version() 2018-03-21 01:53:24 +09:00
moneromooo-monero
a6a54fa883
blockchain: cache difficulty for next block 
Takes about 10 ms, which takes pretty much all of the get_info
RPC, which is called pretty often from wallets.

Also add a new lock so we don't need to lock the blockchain lock,
which will avoid blocking for a long time when calling the getinfo
RPC while syncing. Users of get_difficulty_for_next_block who need
the lock will have locked it already.
 2018-03-19 09:05:40 +00:00
moneromooo-monero
b1398fff40
core: fix use of uninitialised data 2018-03-18 23:37:00 +00:00
Riccardo Spagni
428fb45f68
update checkpoints 2018-03-18 16:44:36 +02:00
Riccardo Spagni
3fedd51d26
update checkpoints.dat to block 1532400 2018-03-18 16:42:20 +02:00
Riccardo Spagni
83dbc5be76
update version to 0.12 Lithium Luna 2018-03-18 16:15:50 +02:00
Riccardo Spagni
df91d7bcbd
Merge pull request #3426 
8ea3c4d5 simplewallet: new --use-english-language-names flag (moneromooo-monero)
 2018-03-18 15:58:12 +02:00
Riccardo Spagni
b8ccd47b9f
Merge pull request #3419 
1e393f4b wallet: make the segregation height settable (moneromooo-monero)
 2018-03-18 15:57:58 +02:00
moneromooo-monero
bb20f104ba
Move v7 fork to 1546000 to give more update time 2018-03-18 09:29:31 +00:00
moneromooo-monero
8ea3c4d544
simplewallet: new --use-english-language-names flag 
On some Windows systems, displaying language names in their own
languages freezes the display.
 2018-03-17 22:46:41 +00:00
moneromooo-monero
1e393f4bb7
wallet: make the segregation height settable 
via user setting first, then DNS TXT record, hardcoded fallback
 2018-03-17 14:56:31 +00:00
Riccardo Spagni
5cd36e48bf
Merge pull request #3421 
9732a37e wallet_rpc_server: add sweep_unmixable as alias for sweep_dust (moneromooo-monero)
 2018-03-17 16:52:46 +02:00
Riccardo Spagni
83651630bc
Merge pull request #3418 
20a00266 blockchain: forbid bulletproof types before v8 (moneromooo-monero)
 2018-03-17 16:51:47 +02:00
moneromooo-monero
9732a37e9a
wallet_rpc_server: add sweep_unmixable as alias for sweep_dust 2018-03-17 11:22:58 +00:00
moneromooo-monero
20a002667c
blockchain: forbid bulletproof types before v8 
They were already forbidden implicitely, but let's make that
explicit for robustness
 2018-03-16 18:18:34 +00:00
stoffu
b86f1e5dad Add command line option allowing to restrict the default sub-address lookahead in order to avoid 
so looooong time of set-up when creating a HW based wallet.
 2018-03-16 18:00:28 +01:00
Riccardo Spagni
a14eabc043
Merge pull request #3416 
6f54c910 simplewallet: fix restore height prompt that got disabled by #3175 (stoffu)
 2018-03-16 18:10:20 +02:00
Riccardo Spagni
432480fa42
Merge pull request #3414 
524cbdc1 blockchain: fix log message about per-kB fee (stoffu)
 2018-03-16 18:09:34 +02:00
Riccardo Spagni
2a9839cc3e
Merge pull request #3376 
833f9fcf show '<Not set>' for empty wallet description (cryptochangements34)
 2018-03-16 18:08:52 +02:00
Riccardo Spagni
0f27fc57ac
Merge pull request #3336 
57c0b1ed Fix typos in various files (Dimitris Apostolou)
 2018-03-16 18:08:07 +02:00
moneromooo-monero
eac3a11ed3
wallet: more user friendly print_ring 
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
 2018-03-16 12:07:45 +00:00
moneromooo-monero
798535149d
wallet2_api: add key reuse mitigations API 2018-03-16 12:07:42 +00:00
moneromooo-monero
b057a21d56
wallet2_api: add ring api 2018-03-16 10:33:05 +00:00
moneromooo-monero
d32ef7b0f2
ringdb: factor ring addition code 2018-03-16 10:33:02 +00:00
moneromooo-monero
a7da8208f5
wallet2_api: add blackball api 2018-03-16 10:32:59 +00:00
moneromooo-monero
504428ab4a
ringdb: use the genesis block as a db name 
This will avoid careless forkers polluting the shared database
even if they make their own chain. They'll then automatically
start using another subdb, and any key-reusing fork of those
forks will reuse their subdbs.
 2018-03-16 10:32:54 +00:00
moneromooo-monero
b09e5181cc
wallet: add a set_ring command 
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
 2018-03-16 10:32:51 +00:00
moneromooo-monero
0590f62ab6
new blockchain_usage tool, reports on output usage 2018-03-16 10:32:46 +00:00
moneromooo-monero
db10dd6d83
wallet: make ringdb an object with database state 2018-03-16 10:32:42 +00:00
moneromooo-monero
df6fad4c62
blockchain_utilities: new blockchain_blackball tool 
It scans for known spent outputs and stores their public keys
in a database which can then be read by the wallet, which can
then avoid using those as fake outs in new transactions.

Usage: monero-blockchain-blackball db1 db2...

This uses the shared database in ~/.shared-ringdb
 2018-03-16 10:32:39 +00:00
moneromooo-monero
d29ea0455a
wallet: add an output blackball list to avoid using those in rings 2018-03-16 10:32:37 +00:00
moneromooo-monero
18eaf19489
wallet: key reuse mitigation options 
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.

The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.

This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).

If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.

If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
 2018-03-16 10:32:34 +00:00
moneromooo-monero
5f146873c5
wallet: add shared ring database 
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
 2018-03-16 10:32:29 +00:00
moneromooo-monero
41f727ce42
add RPC to get a histogram of outputs of a given amount 2018-03-16 10:32:26 +00:00
cryptochangements34
833f9fcfe9 show '<Not set>' for empty wallet description 2018-03-15 23:22:45 -04:00
stoffu
6f54c910f7
simplewallet: fix restore height prompt that got disabled by #3175 2018-03-16 11:55:31 +09:00
stoffu
524cbdc1e2
blockchain: fix log message about per-kB fee 2018-03-16 10:43:19 +09:00
Dimitris Apostolou
57c0b1ed9f Fix typos in various files 2018-03-15 18:25:38 +02:00
Riccardo Spagni
51bb7fafac
Merge pull request #3410 
c5024c5b simplewallet: add a warning when getting a daemon error in transfer (moneromooo-monero)
 2018-03-15 17:10:01 +02:00
Riccardo Spagni
60af9d689b
Merge pull request #3408 
e1b526b3 Remove the `Blockchain::get_all_known_block_ids` function. (Jean Pierre Dudey)
 2018-03-15 17:09:13 +02:00
moneromooo-monero
c5024c5b73
simplewallet: add a warning when getting a daemon error in transfer 
A malicious daemon (or MITM) could attempt to add spurious errors
so the wallet tries again, sending another set of fake outs.
 2018-03-15 13:33:19 +00:00
stoffu
a7266d6d7b
wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate calls to wallet2 2018-03-15 22:01:51 +09:00
Jean Pierre Dudey
e1b526b371 Remove the Blockchain::get_all_known_block_ids function. 
This function isn't used in the codebase.

Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
 2018-03-14 21:56:19 -04:00
Leon Klingele
80d2f8007c
wallet2: Update function parameter documentation 
This completes and fixes various parameters docs
 2018-03-14 16:41:24 +01:00
stoffu
71d186566e
replace invoke_http_json("/json_rpc",...) with invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate 2018-03-14 23:23:59 +09:00
Riccardo Spagni
a69c713f8e
Merge pull request #3398 
c577abab wallet: fix auto low priority so that it takes effect only when saved default is 0 (stoffu)
 2018-03-14 16:18:15 +02:00
Riccardo Spagni
2fe1504c03
Merge pull request #3399 
1d39b265 wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet (stoffu)
 2018-03-14 16:17:59 +02:00
Riccardo Spagni
f9f2d182da
Merge pull request #3395 
523371c0 p2p: fix network ID being uninitialised when using exclusive peers (moneromooo-monero)
 2018-03-14 16:10:42 +02:00
Riccardo Spagni
8b90e3141a
Merge pull request #3386 
9abeff59 wallet2: handle no blocks returned in refresh to mean no new blocks (moneromooo-monero)
 2018-03-14 16:10:00 +02:00
Riccardo Spagni
7a44301675
Merge pull request #3385 
ec41006c node_rpc_proxy: fix target height caching (moneromooo-monero)
 2018-03-14 16:09:40 +02:00
Riccardo Spagni
534369eece
Merge pull request #3384 
b63ea060 simplewallet: do not call a RPC when displaying the prompt (moneromooo-monero)
 2018-03-14 16:08:14 +02:00
Riccardo Spagni
cb72b85bbf
Merge pull request #3372 
c3e23b2d ringct: 17% improvement in Borromean signature verification (moneromooo-monero)
 2018-03-14 16:06:16 +02:00
stoffu
4405e4fc73
wallet2: check_tx_key() shouldn't require hardware encryption 2018-03-14 21:00:18 +09:00
stoffu
7dfa5e9e6e
chacha: call prehashed version explicitly as generate_chacha_key_prehashed 
hash: add prehashed version cn_slow_hash_prehashed
slow-hash: let cn_slow_hash take 4th parameter for deciding prehashed or not
slow-hash: add support for prehashed version for the other 3 platforms
 2018-03-14 21:00:17 +09:00
stoffu
b2d23b189e
crypto: revert odd namespace changes made in #3303 2018-03-14 21:00:17 +09:00
stoffu
8705beaf51
keypair::generate: always require hw::device to avoid possible mistake 2018-03-14 21:00:16 +09:00
stoffu
27a196b126
device: untangle cyclic depenency 
When #3303 was merged, a cyclic dependency chain was generated:

    libdevice <- libcncrypto <- libringct <- libdevice

This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:

    libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct

This eliminates the need for crypto_device.cpp and rctOps_device.cpp.

Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
 2018-03-14 21:00:15 +09:00
stoffu
c9b38b4765
device: made function prototypes consistent with pre-#3303 codebase 2018-03-14 21:00:06 +09:00
Riccardo Spagni
f2e8e8d23c
Merge pull request #3377 
aa8bef0c fix error message typo in wallet2.cpp (cryptochangements34)
 2018-03-14 13:38:50 +02:00
Riccardo Spagni
9a63fbcf83
Merge pull request #3371 
84decbea core: add v7 for 1539500 on mainnet (moneromooo-monero)
 2018-03-14 13:37:25 +02:00
Riccardo Spagni
3bc2537f5a
Merge pull request #3369 
1979d53d wallet: fixes and tweaks to the save_watch_only command (moneromooo-monero)
 2018-03-14 13:37:14 +02:00
Riccardo Spagni
0f2d6d40b4
Merge pull request #3360 
1ff35fda Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable) (stoffu)
 2018-03-14 13:37:00 +02:00
Riccardo Spagni
2e074e2ae7
Merge pull request #3358 
978663d4 Stagenet: successive forks up to v7 (stoffu)
 2018-03-14 13:36:47 +02:00
Riccardo Spagni
117cf12509
Merge pull request #3355 
0bbd521f libwallet_merged: added missing libdevice (stoffu)
 2018-03-14 13:36:36 +02:00
Riccardo Spagni
33158f089d
Merge pull request #3354 
ffe70b8f Make mixin optional with default for rpc transfer (cryptochangements34)
 2018-03-14 13:36:25 +02:00
Riccardo Spagni
2dfb4f098e
Merge pull request #3353 
73dd883d Ledger HW Bug fixes (Cédric)
 2018-03-14 13:36:14 +02:00
Riccardo Spagni
cfc5a3d4d4
Merge pull request #3345 
e0cda74a wallet2_api: add info/error/warning entry points (moneromooo-monero)
 2018-03-14 13:35:53 +02:00
Riccardo Spagni
67978b78ce
Merge pull request #3337 
91d97dd4 fuzz_tests: set small subaddress lookahead for speed (moneromooo-monero)
5f85cc7e wallet2: guard against overflowing of subaddress indices (moneromooo-monero)
 2018-03-14 13:35:41 +02:00
Riccardo Spagni
3fed788603
Merge pull request #3315 
649a1b7a wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets (Leon Klingele)
 2018-03-14 13:35:11 +02:00
moneromooo-monero
5f85cc7e3d
wallet2: guard against overflowing of subaddress indices 2018-03-14 11:34:06 +00:00
stoffu
1d39b26556
wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet 2018-03-14 19:02:21 +09:00
stoffu
c577abab61
wallet: fix auto low priority so that it takes effect only when saved default is 0 2018-03-14 18:33:43 +09:00
moneromooo-monero
523371c042
p2p: fix network ID being uninitialised when using exclusive peers 2018-03-13 11:20:49 +00:00
Cédric
73dd883d51 Ledger HW Bug fixes 
Fix the way the REAL mode is handle:
  Let create_transactions_2 and create_transactions_from construct the vector of transactions.
  Then iterate on it and resign.
  We just need to add 'outs' list in the TX struct for that.

Fix default secret keys value when DEBUG_HWDEVICE mode is off
  The magic value (00...00 for view key and FF..FF for spend key) was not correctly set
  when DEBUG_HWDEVICE was off. Both was set to 00...00.

Add sub-address info in ABP map in order to correctly display destination sub-address on device

Fix DEBUG_HWDEVICE mode:
   - Fix compilation errors.
   - Fix control device init in ledger device.
   - Add more log.

Fix sub addr control

Fix debug Info
 2018-03-12 10:43:06 +01:00
moneromooo-monero
9abeff5911
wallet2: handle no blocks returned in refresh to mean no new blocks 
This is not a possible return from the daemon, but I want this in
now so all wallets handle this when the daemon starts doing so.
 2018-03-11 21:16:15 +00:00
moneromooo-monero
ec41006cad
node_rpc_proxy: fix target height caching 2018-03-11 13:11:49 +00:00
moneromooo-monero
b63ea060de
simplewallet: do not call a RPC when displaying the prompt 
Speeds up refresh when you have a lot of in/out transactions
 2018-03-11 10:23:45 +00:00
Leon Klingele
649a1b7ae6
wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets 
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing

    --create-address-file
 2018-03-10 16:28:23 +01:00
cryptochangements34
aa8bef0cb3 fix error message typo in wallet2.cpp 2018-03-09 17:22:26 -05:00
stoffu
978663d461
Stagenet: successive forks up to v7 2018-03-09 13:59:11 +09:00
Riccardo Spagni
e9f41e405f
Merge pull request #3368 
38657fd0 Bump min ring size from 5 to 7 from v7 (moneromooo-monero)
 2018-03-08 18:47:41 +02:00
Riccardo Spagni
546e380cab
Merge pull request #3370 
04a0cc89 slow-hash: fix uint64 type typo (moneromooo-monero)
 2018-03-08 18:44:47 +02:00
Riccardo Spagni
3a12f2588a
Merge pull request #3365 
55a65f32 Wallet API: corrected testnet/mainnet ordering (stoffu)
 2018-03-08 18:44:18 +02:00
Riccardo Spagni
f4cf613e34
Merge pull request #3362 
49c70962 device: remove dependency on readline (stoffu)
 2018-03-08 18:43:37 +02:00
Riccardo Spagni
220cb62ca4
Merge pull request #3357 
557a6fb6 cn_deserialize: link with device and ringct (moneromooo-monero)
 2018-03-08 18:43:20 +02:00
Riccardo Spagni
60c8544e77
Merge pull request #3347 
9a6be3da wallet_manager: fixed typo deviuce/device.hpp (stoffu)
 2018-03-08 18:42:24 +02:00
moneromooo-monero
c3e23b2dce
ringct: 17% improvement in Borromean signature verification 2018-03-08 00:41:54 +00:00
moneromooo-monero
84decbea48
core: add v7 for 1539500 on mainnet 2018-03-07 17:19:50 +00:00
moneromooo-monero
1979d53d78
wallet: fixes and tweaks to the save_watch_only command 
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
 2018-03-07 14:24:14 +00:00
moneromooo-monero
38657fd0e9
Bump min ring size from 5 to 7 from v7 2018-03-07 13:19:04 +00:00
moneromooo-monero
04a0cc89cf
slow-hash: fix uint64 type typo 2018-03-07 09:48:58 +00:00
stoffu
55a65f3269
Wallet API: corrected testnet/mainnet ordering 2018-03-07 13:56:17 +09:00
stoffu
49c70962ee
device: remove dependency on readline 2018-03-07 07:42:28 +09:00
stoffu
1ff35fda7c
Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable) 2018-03-06 21:14:52 +09:00
moneromooo-monero
557a6fb6ea
cn_deserialize: link with device and ringct 2018-03-05 20:52:18 +00:00
Lee Clagett
e136bc6b8a
tweaks to the monerov1 cryptonight algorithm 2018-03-05 18:18:45 +00:00
SChernykh
d58c9ec99c
slow-hash: optimized version 2018-03-05 18:18:43 +00:00
moneromooo-monero
608fd6f14a
Monero Cryptonight variants, and add one for v7 
This is the first variant of many, with the intent to improve
Monero's resistance to ASICs and encourage mining decentralization.
 2018-03-05 18:18:39 +00:00
stoffu
0bbd521fa2
libwallet_merged: added missing libdevice 2018-03-06 02:36:37 +09:00
cryptochangements34
ffe70b8f61
Make mixin optional with default for rpc transfer 2018-03-05 12:27:22 -05:00
Riccardo Spagni
a21c927d7d
Merge pull request #3298 
f2bb8085 Fix #3297 use the password_prompter helper (Howard Chu)
 2018-03-05 19:17:51 +02:00
Riccardo Spagni
0c2b25204e
Merge pull request #3312 
399120dd simplewallet: set seed language when restoring from english-old seed (stoffu)
 2018-03-05 19:16:52 +02:00
Riccardo Spagni
237f0179b7
Merge pull request #3313 
43026822 Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows (rbrunner7)
 2018-03-05 19:15:54 +02:00
Riccardo Spagni
baf640887d
Merge pull request #3343 
3d452367 allow using ring size instead of mixin for rpc transfer (cryptochangements34)
 2018-03-05 19:14:03 +02:00
Riccardo Spagni
98acbe83fc
Merge pull request #3348 
c95dddd2 remove unused function keyImageV (h908714124)
 2018-03-05 19:13:52 +02:00
Riccardo Spagni
05f0762dc5
Merge pull request #3346 
25ea307d Fix invalid device unique_ptr cast (MoroccanMalinois)
 2018-03-05 19:13:40 +02:00
Riccardo Spagni
9841a452e5
Merge pull request #3338 
51219457 core: fix sending to the source address with a short payment id (moneromooo-monero)
 2018-03-05 19:13:28 +02:00
Riccardo Spagni
61ac5b0471
Merge pull request #3332 
6b40ea93 simplewallet: fix print_ring_members printing wrong heights (moneromooo-monero)
 2018-03-05 19:12:59 +02:00
Riccardo Spagni
5b25cbb5a7
Merge pull request #3314 
71bff546 wallet api: when restoring from EnglishOld, set language to English (stoffu)
 2018-03-05 19:12:24 +02:00
Riccardo Spagni
abcdb7b5c4
Merge pull request #3308 
6f8779d2 blockchain: fix random sync failures (moneromooo-monero)
 2018-03-05 19:12:05 +02:00
Riccardo Spagni
0e5c006207
Merge pull request #3307 
223d7d0c db_lmdb: fix free space reporting (moneromooo-monero)
 2018-03-05 19:11:52 +02:00
Riccardo Spagni
5950d356b6
Merge pull request #3301 
34a2a085 rctSigs - loop invariant code removed from the loop (Dusan Klinec)
 2018-03-05 19:11:35 +02:00
Riccardo Spagni
4f93f74528
Merge pull request #3277 
0e7ad2e2 Wallet API: generalize 'bool testnet' to 'NetworkType nettype' (stoffu)
af773211 Stagenet (stoffu)
cc9a0bee command_line: allow args to depend on more than one args (stoffu)
55f8d917 command_line::get_arg: remove 'required' for dependent args as they're always optional (stoffu)
450306a0 command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 (stoffu)
9f9e095a Use `genesis_tx` parameter in `generate_genesis_block`. #3261 (Jean Pierre Dudey)
 2018-03-05 19:11:20 +02:00
Riccardo Spagni
033ead4bad
Merge pull request #3273 
f3b74e75 Fix refresh height estimation (Howard Chu)
 2018-03-05 19:11:07 +02:00
Riccardo Spagni
b54587d7b3
Merge pull request #3259 
6d900a40 removed systemd private tempdir (ston1th)
496055d1 monerod: do not log to tmpdir in daemon mode (ston1th)
 2018-03-05 19:10:51 +02:00
Edward Betts
fbcc91c2a4 Correct spelling mistakes. 2018-03-05 17:00:40 +00:00
cryptochangements34
3d452367b0 allow using ring size instead of mixin for rpc transfer 2018-03-05 10:10:35 -05:00
stoffu
0e7ad2e2c9
Wallet API: generalize 'bool testnet' to 'NetworkType nettype' 2018-03-05 23:59:16 +09:00
h908714124
c95dddd2d2 remove unused function keyImageV 2018-03-05 09:21:44 +01:00
stoffu
9a6be3da25
wallet_manager: fixed typo deviuce/device.hpp 2018-03-05 11:57:30 +09:00
stoffu
af773211cb
Stagenet 2018-03-05 11:55:05 +09:00
stoffu
cc9a0bee04
command_line: allow args to depend on more than one args 2018-03-05 11:19:08 +09:00
stoffu
55f8d917fd
command_line::get_arg: remove 'required' for dependent args as they're always optional 2018-03-05 11:19:06 +09:00
stoffu
450306a01c
command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 2018-03-05 11:19:04 +09:00
Jean Pierre Dudey
9f9e095a8c
Use genesis_tx parameter in generate_genesis_block. #3261 
* src/cryptnote_config.h: The constant `config::testnet::GENESIS_TX` was
changed to be the same as `config::GENESIS_TX` (the mainnet's transaction)
because the mainnet's transaction was being used for both networks.

* src/cryptonote_core/cryptonote_tx_utils.cpp: The `generate_genesis_block` function
was ignoring the  `genesis_tx` parameter, and instead it was using the `config::GENESIS_TX`
constant. That's why the testnet genesis transaction was changed. Also five lines of unused
code were removed.

Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
 2018-03-05 11:19:01 +09:00
MoroccanMalinois
25ea307d67
Fix invalid device unique_ptr cast 2018-03-04 18:56:48 +00:00
moneromooo-monero
e0cda74ace
wallet2_api: add info/error/warning entry points 2018-03-04 18:07:30 +00:00
cslashm
e745c1e38d Code modifications to integrate Ledger HW device into monero-wallet-cli. 
The basic approach it to delegate all sensitive data (master key, secret
ephemeral key, key derivation, ....) and related operations to the device.
As device has low memory, it does not keep itself the values
(except for view/spend keys) but once computed there are encrypted (with AES
are equivalent) and return back to monero-wallet-cli. When they need to be
manipulated by the device, they are decrypted on receive.

Moreover, using the client for storing the value in encrypted form limits
the modification in the client code. Those values are transfered from one
C-structure to another one as previously.

The code modification has been done with the wishes to be open to any
other hardware wallet. To achieve that a C++ class hw::Device has been
introduced. Two initial implementations are provided: the "default", which
remaps all calls to initial Monero code, and  the "Ledger", which delegates
all calls to Ledger device.
 2018-03-04 12:54:53 +01:00
moneromooo-monero
51219457b1
core: fix sending to the source address with a short payment id 
It would fail to send, thinking it needs a destination address,
since the destination matches the change address in this case.
 2018-03-02 23:27:57 +00:00
moneromooo-monero
6b40ea937a
simplewallet: fix print_ring_members printing wrong heights 
And also use uint64_t instead of int for heights where appropriate
 2018-03-02 00:25:16 +00:00
stoffu
71bff546d3
wallet api: when restoring from EnglishOld, set language to English 2018-02-25 22:04:36 +09:00
rbrunner7
430268224d Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows 2018-02-25 12:57:58 +01:00
stoffu
399120ddad
simplewallet: set seed language when restoring from english-old seed 2018-02-25 12:44:10 +09:00
ston1th
496055d128 monerod: do not log to tmpdir in daemon mode 
The logging to /tmp/bitmonero.daemon.stdout.stderr caused segfaults
if the /tmp mount was full (#2851).
Now the daemon is only logging to /tmp/bitmonero.daemon.stdout.stderr
in the debug builds.
 2018-02-23 21:27:14 +01:00
moneromooo-monero
6f8779d282
blockchain: fix random sync failures 
When a block is added as part of a chunk (when syncing historical
blocks), a block may end up already in the blockchain if it was
added to the queue before being added to the chain (though it's
not clear how that could happen, but it's an implementation detail)
and thus may not be added to the chain when add_block is called.
This would cause m_blocks_txs_check to not be cleared, causing it
to get out of sync at next call, and thus wrongfully reject the
next block.
 2018-02-23 19:47:17 +00:00
moneromooo-monero
223d7d0c7a
db_lmdb: fix free space reporting 
reported by Brad Richards
 2018-02-23 09:06:10 +00:00
Dusan Klinec
34a2a08530 rctSigs - loop invariant code removed from the loop 2018-02-21 16:35:06 +01:00
Riccardo Spagni
2ac3da1251
Merge pull request #3256 
df5273de wallet2: fix auto_low_priority field name typo on load (moneromooo-monero)
 2018-02-20 17:53:38 +02:00
Riccardo Spagni
0d530bd04e
Merge pull request #3295 
6514f0ed db_lmdb: fix return code mixup in for_all_* (moneromooo-monero)
 2018-02-20 17:49:16 +02:00
Riccardo Spagni
46903ec26a
Merge pull request #3294 
fd57e13a simplewallet: typo in generate-from-multisig-keys (stoffu)
 2018-02-20 17:49:05 +02:00
Riccardo Spagni
21335e5c6b
Merge pull request #3293 
4a78a99f cryptonote_core: change wording of fork warning message (moneromooo-monero)
 2018-02-20 17:48:54 +02:00
Riccardo Spagni
299af8e43e
Merge pull request #3290 
1d28c0d8 p2p: restore m_testnet assignment lost during rebase (whythat)
 2018-02-20 17:48:29 +02:00
Riccardo Spagni
ea9ddcac7f
Merge pull request #3288 
10f78f63 p2p: need libcryptonote_core due to arg_testnet_on being used (stoffu)
 2018-02-20 17:48:05 +02:00
Riccardo Spagni
fc57e0ef2d
Merge pull request #3263 
d4e728c9 simplewallet: reword donate command message for clarity (Serhack)
 2018-02-20 17:47:42 +02:00
Riccardo Spagni
c9aa9370f9
Merge pull request #3260 
b2d4bb9b Remove `voting_version` parameter documentation. (Jean Pierre Dudey)
 2018-02-20 17:47:31 +02:00
Riccardo Spagni
4e9de94565
Merge pull request #3257 
da25757b simplewallet: do nothing in on_skip_transaction (wallet2 already logs warnings) (stoffu)
 2018-02-20 17:47:20 +02:00
Riccardo Spagni
ff36fd93fd
Merge pull request #3255 
3962bcb2 Closes #2886: really ignore battery checking (Timothy D. Prime)
 2018-02-20 17:47:03 +02:00
Riccardo Spagni
cfa3af4078
Merge pull request #3247 
89ad162a wallet2: remove unused m_subaddresses_inv (moneromooo-monero)
f2c4c399 wallet2: speed up subaddress generation (by about a third) (moneromooo-monero)
 2018-02-20 17:46:40 +02:00
Riccardo Spagni
6920fdaf4f
Merge pull request #3246 
3c33e131 wallet2: don't store invalid key image when watch-only (stoffu)
0133b348 wallet2: don't throw when spent amount is inconsistent (stoffu)
 2018-02-20 17:46:29 +02:00
Riccardo Spagni
0fc5eec9cd
Merge pull request #3235 
6866ed46 Add default value to max_height, otherwise it's 0 (Michał Sałaban)
 2018-02-20 17:46:00 +02:00
Howard Chu
f2bb8085ec
Fix #3297 use the password_prompter helper 2018-02-20 02:25:20 +00:00
moneromooo-monero
6514f0ed7b
db_lmdb: fix return code mixup in for_all_* 2018-02-19 14:55:58 +00:00
stoffu
fd57e13a84
simplewallet: typo in generate-from-multisig-keys 2018-02-19 09:51:30 +09:00
moneromooo-monero
4a78a99f96
cryptonote_core: change wording of fork warning message 
An udpate may or may not be available now, but should be soon if not.
This will prevent too many people freaking out.
 2018-02-18 23:44:59 +00:00
whythat
1d28c0d8a9 p2p: restore m_testnet assignment lost during rebase 2018-02-18 17:09:39 +02:00
stoffu
10f78f63f1
p2p: need libcryptonote_core due to arg_testnet_on being used 2018-02-18 16:40:43 +09:00
Riccardo Spagni
8154df778a
Merge pull request #3276 
ed6c68db crypto: add missing include (WIN32) (iDunk5400)
 2018-02-17 21:48:59 +01:00
Riccardo Spagni
5a8e7fd0e5
Merge pull request #3249 
a4b50a6f handle ^D and ^C while password prompting (Jethro Grassie)
 2018-02-17 21:48:30 +01:00
Riccardo Spagni
6198c816b1
Merge pull request #3170 
b3b2d4d2 options: add testnet option dependencies (whythat)
c5f55bb4 common: implement dynamic option dependencies mechanism (whythat)
05a12ccc options: remove testnet-* options (whythat)
c33cb60e common: implement dependent option descriptor (whythat)
 2018-02-17 11:51:57 +01:00
Riccardo Spagni
a2cbedd29f
Merge pull request #3191 
3607d467 core: add --no-fluffy-blocks, and enable fluffy blocks by default (moneromooo-monero)
 2018-02-17 11:48:31 +01:00
whythat
b3b2d4d20c options: add testnet option dependencies 2018-02-16 22:32:01 +02:00
whythat
c5f55bb4c0 common: implement dynamic option dependencies mechanism 2018-02-16 22:32:01 +02:00
whythat
05a12ccc2d options: remove testnet-* options 2018-02-16 22:32:01 +02:00
iDunk5400
ed6c68db1b
crypto: add missing include (WIN32) 2018-02-16 19:35:31 +01:00
moneromooo-monero
89ad162a3f
wallet2: remove unused m_subaddresses_inv 2018-02-16 17:13:09 +00:00
moneromooo-monero
f2c4c39971
wallet2: speed up subaddress generation (by about a third) 2018-02-16 17:13:06 +00:00
Leon Klingele
7c1a607c40
txpool: Don't bail out when blob_size == tx_size_limit 
Previously, when blob_size == tx_size_limit, the "m_too_big" property was set
and the transaction was rejected. This should not have been the case.
 2018-02-16 16:27:08 +01:00
whythat
c33cb60eb6 common: implement dependent option descriptor 2018-02-16 16:44:40 +02:00
Howard Chu
f3b74e75b0
Fix refresh height estimation 
Since commit b0426d4c refresh height for a newly created wallet
connected to a sync'd daemon was off by a month. Now we only use
the 1 month safety margin if we're unable to talk to a daemon.
 2018-02-16 14:17:36 +00:00
moneromooo-monero
3607d467f3
core: add --no-fluffy-blocks, and enable fluffy blocks by default 2018-02-16 13:46:46 +00:00
Riccardo Spagni
ef91d6e61e
Merge pull request #3196 
eda9fb5b p2p: fix testnet/mainnet port mixup (moneromooo-monero)
 2018-02-16 14:31:16 +01:00
Riccardo Spagni
6b1382b6b6
Merge pull request #3199 
30ce8c59 cn_deserialize: check for raw tx_extra (moneromooo-monero)
 2018-02-16 14:29:51 +01:00
Riccardo Spagni
f4a6bc79d9
Merge pull request #3226 
e4646379 keccak: fix mdlen bounds sanity checking (moneromooo-monero)
2e3e90ac pass large parameters by const ref, not value (moneromooo-monero)
61defd89 blockchain: sanity check number of precomputed hash of hash blocks (moneromooo-monero)
9af6b2d1 ringct: fix infinite loop in unused h2b function (moneromooo-monero)
8cea8d0c simplewallet: double check a new multisig wallet is multisig (moneromooo-monero)
9b98a6ac threadpool: catch exceptions in dtor, to avoid terminate (moneromooo-monero)
24803ed9 blockchain_export: fix buffer overflow in exporter (moneromooo-monero)
f3f7da62 perf_timer: rewrite to make it clear there is no division by zero (moneromooo-monero)
c6ea3df0 performance_tests: remove add_arg call stray extra param (moneromooo-monero)
fa6b4566 fuzz_tests: fix an uninitialized var in setup (moneromooo-monero)
03887f11 keccak: fix sanity check bounds test (moneromooo-monero)
ad11db91 blockchain_db: initialize m_open in base class ctor (moneromooo-monero)
bece67f9 miner: restore std::cout precision after modification (moneromooo-monero)
1aabd14c db_lmdb: check hard fork info drop succeeded (moneromooo-monero)
 2018-02-16 14:26:58 +01:00
Riccardo Spagni
24d8f9237f
Merge pull request #3248 
d6a0ae96 blockchain: don't try to use hash check array after it's freed (moneromooo-monero)
 2018-02-16 14:24:22 +01:00
Riccardo Spagni
853dd2d4f7
Merge pull request #3232 
b81e276c connection_context: initialize m_last_request_time to current time (moneromooo-monero)
 2018-02-16 14:24:12 +01:00
Riccardo Spagni
260d666cf4
Merge pull request #3231 
84a8b2da Don't create readtxn until after txn_safe gate check (Howard Chu)
 2018-02-16 14:24:01 +01:00
Riccardo Spagni
ef47ba95c8
Merge pull request #3229 
928c1825 cryptonote_protocol: guard against all threads in standby (moneromooo-monero)
 2018-02-16 14:23:53 +01:00
Riccardo Spagni
b5b88c2747
Merge pull request #3225 
71806327 dns: change default DNS to a worldwide selection (moneromooo-monero)
 2018-02-16 14:23:34 +01:00
Riccardo Spagni
a54247b993
Merge pull request #3221 
2e584dcb p2p: do not try to connect to peers in offline mode (moneromooo-monero)
 2018-02-16 14:23:22 +01:00
Riccardo Spagni
0c71197892
Merge pull request #3217 
fde4489e wipeable_string: call memwipe directly (moneromooo-monero)
 2018-02-16 14:23:08 +01:00
Riccardo Spagni
9c4428e583
Merge pull request #3214 
214d251c wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown (stoffu)
 2018-02-16 14:22:41 +01:00
Riccardo Spagni
bfddb2283b
Merge pull request #3210 
39992134 txpool: Properly bail out when outputs_amount == inputs_amount (Leon Klingele)
 2018-02-16 14:22:10 +01:00
Riccardo Spagni
9681a885d1
Merge pull request #3207 
a99ef176 wallet-rpc: take subaddress account as arg for get_transfer_by_txid (stoffu)
77125096 wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDS (stoffu)
 2018-02-16 14:21:59 +01:00
Riccardo Spagni
079eea7b70
Merge pull request #3205 
bc61ae69 tx_pool: add a max pool size, settable with --max-txpool-size (moneromooo-monero)
3b4e6b35 txpool: increase unmined tx expiry to three days (moneromooo-monero)
 2018-02-16 14:21:50 +01:00
Riccardo Spagni
b23578e473
Merge pull request #3197 
f90c76be Return appropriate error code when there's no connection to daemon (Michał Sałaban)
3cb65b3f Return appropriate error code when not enough money for tx (Michał Sałaban)
 2018-02-16 14:21:00 +01:00
Riccardo Spagni
666a76652b
Merge pull request #3187 
851bd057 call _exit instead of abort in release mode (moneromooo-monero)
 2018-02-16 14:20:31 +01:00
Riccardo Spagni
bdf0339dda
Merge pull request #3181 
e3f0980a daemon: don't drop RPC with busy error when running offline (moneromooo-monero)
 2018-02-16 14:19:54 +01:00
Riccardo Spagni
ba22928d4b
Merge pull request #3180 
1dfed567 Fixed #if instead of #ifdef (Matt Little)
7c442453 Support building cncrypto lib with msvc (Matt Little)
 2018-02-16 14:19:42 +01:00
Riccardo Spagni
82599ef0e3
Merge pull request #3175 
3be98036 wallet-cli: Do not ask for scan_from_height if it explicitly is set to zero. (Maximilian Lupke)
 2018-02-16 14:19:24 +01:00
Riccardo Spagni
a43be404c7
Merge pull request #3171 
402c9eef cryptonote_tx_utils: fixed logic bug in get_destination_view_key_pub (stoffu)
 2018-02-16 14:19:10 +01:00
Riccardo Spagni
04a676397f
Merge pull request #3165 
7539603f Bootstrap daemon (stoffu)
 2018-02-16 14:18:50 +01:00
Riccardo Spagni
381faf06c7
Merge pull request #3163 
628b78ae Fix in_peers/out_peers RPC operations (Erik de Castro Lopo)
ece9bcf5 rpc_client: Fix error handling (Erik de Castro Lopo)
8f30350d Fix method name in invoke_http_json_rpc (Erik de Castro Lopo)
32c0f908 Allow the number of incoming connections to be limited (Erik de Castro Lopo)
d609a2c1 Rename delete_connections to delete_out_connections (Erik de Castro Lopo)
b927c0fc Rename connections_count to max_out_connection_count (Erik de Castro Lopo)
 2018-02-16 14:18:38 +01:00
Riccardo Spagni
0bffd2ec64
Merge pull request #3161 
78a2e15b daemon: exit with 0 when successful (moneromooo-monero)
 2018-02-16 14:18:29 +01:00
Riccardo Spagni
5d36ed6613
Merge pull request #3094 
a85dbb3f Fixed typos and wording tweaks (Maxithi)
 2018-02-16 14:17:46 +01:00
stoffu
da25757b42
simplewallet: do nothing in on_skip_transaction (wallet2 already logs warnings) 2018-02-15 17:20:39 +09:00
Serhack
d4e728c995 simplewallet: reword donate command message for clarity 2018-02-14 08:28:22 -05:00
Riccardo Spagni
370b43d12b
Merge pull request #3138 
19ff243f wallets: reorg 61 more days on testnet (moneromooo-monero)
c70f03ca blockchain: move bulletproofs to v8 (moneromooo-monero)
 2018-02-14 12:49:57 +01:00
Riccardo Spagni
589a53f479
Merge pull request #2959 
3f1a3fac bulletproofs: more robust challenge computation (moneromooo-monero)
 2018-02-14 12:08:52 +01:00
Jean Pierre Dudey
b2d4bb9b64 Remove voting_version parameter documentation. 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
 2018-02-13 15:04:12 -04:00
moneromooo-monero
df5273def5
wallet2: fix auto_low_priority field name typo on load 2018-02-13 00:33:55 +00:00
Timothy D. Prime
3962bcb2a2 Closes #2886: really ignore battery checking 
Move option test first.
 2018-02-12 10:29:22 -08:00
stoffu
3c33e1317b
wallet2: don't store invalid key image when watch-only 2018-02-12 20:36:15 +09:00
Jethro Grassie
a4b50a6f51
handle ^D and ^C while password prompting 2018-02-10 18:29:49 -05:00
moneromooo-monero
d6a0ae96c6
blockchain: don't try to use hash check array after it's freed 
It's freed when we've synced past its end, but we might still
find an old chain somewhere
 2018-02-10 11:26:06 +00:00
stoffu
0133b3481a
wallet2: don't throw when spent amount is inconsistent 2018-02-10 12:59:25 +09:00
moneromooo-monero
71806327f5
dns: change default DNS to a worldwide selection 
DNSSEC aware servers picked from https://wiki.ipfire.org/dns/public-servers
 2018-02-08 09:46:16 +00:00
stoffu
214d251c48
wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown 2018-02-08 08:02:12 +09:00
moneromooo-monero
bc61ae69bf
tx_pool: add a max pool size, settable with --max-txpool-size 2018-02-07 13:42:12 +00:00
moneromooo-monero
e4646379a6
keccak: fix mdlen bounds sanity checking 
found by h908714124
 2018-02-07 13:39:32 +00:00
Michał Sałaban
6866ed469a Add default value to max_height, otherwise it's 0 2018-02-05 23:39:37 +01:00
moneromooo-monero
b81e276cab
connection_context: initialize m_last_request_time to current time 
This prevents spurious early peer drops
 2018-02-04 13:13:08 +00:00
moneromooo-monero
928c1825f0
cryptonote_protocol: guard against all threads in standby 2018-02-02 22:33:53 +00:00
moneromooo-monero
2e3e90acbe
pass large parameters by const ref, not value 
Coverity 136394 136397 136409 136526 136529 136533 175302
 2018-02-02 19:36:09 +00:00
moneromooo-monero
61defd89e3
blockchain: sanity check number of precomputed hash of hash blocks 
Coverity 142951
 2018-02-02 17:10:13 +00:00
moneromooo-monero
9af6b2d1b8
ringct: fix infinite loop in unused h2b function 
Coverity 146775
 2018-02-02 16:44:28 +00:00
moneromooo-monero
8cea8d0cef
simplewallet: double check a new multisig wallet is multisig 
Coverity 182493
 2018-02-02 16:41:16 +00:00
moneromooo-monero
9b98a6ac8f
threadpool: catch exceptions in dtor, to avoid terminate 
If an exception is thrown, it is ignored. While this may hide
a bug, this should only be system exceptions in boost, which
is pretty unlikely. Morever, wait should be called manually
before the dtor anyway. Add an error message if the dtor has
to wait in case some such cases creep in so they get fixed.

Coverity 182538
 2018-02-02 16:27:39 +00:00
moneromooo-monero
24803ed91f
blockchain_export: fix buffer overflow in exporter 
Coverity 182550
 2018-02-02 16:11:15 +00:00
moneromooo-monero
f3f7da624d
perf_timer: rewrite to make it clear there is no division by zero 
It could have happened if epee::misc_utils::get_ns_count
is buggy, at a push

Coverity 182561
 2018-02-02 16:06:36 +00:00
moneromooo-monero
03887f1140
keccak: fix sanity check bounds test 
Nothing calls this with those inputs
 2018-02-02 15:48:06 +00:00
moneromooo-monero
ad11db9144
blockchain_db: initialize m_open in base class ctor 
It's cleaner this way, since it's a base class field

Coverity 136568
 2018-02-02 15:21:39 +00:00
moneromooo-monero
bece67f9e8
miner: restore std::cout precision after modification 
Coverity 136462
 2018-02-02 15:15:21 +00:00
moneromooo-monero
1aabd14c21
db_lmdb: check hard fork info drop succeeded 
Coverity 136364
 2018-02-02 15:08:22 +00:00
moneromooo-monero
3b4e6b35b3
txpool: increase unmined tx expiry to three days 2018-02-01 22:48:52 +00:00
moneromooo-monero
2e584dcb1f
p2p: do not try to connect to peers in offline mode 2018-02-01 20:18:30 +00:00
moneromooo-monero
851bd057ec
call _exit instead of abort in release mode 
Avoids cores being created, as they're nowadays often piped
to some call home system
 2018-02-01 13:32:46 +00:00
Leon Klingele
399921347f
txpool: Properly bail out when outputs_amount == inputs_amount 
Previously, when outputs_amount == inputs_amount, the "m_overspend" property
was set, whereas "m_fee_too_low" would have been the correct property to set.

This is unlikely to ever occur and just something I've noticed while reading
through the code.
 2018-02-01 00:48:45 +01:00
Howard Chu
84a8b2da14
Don't create readtxn until after txn_safe gate check 2018-01-31 18:18:01 +00:00
moneromooo-monero
3f1a3fac00
bulletproofs: more robust challenge computation 
Changes from sarang, from a recommendation by an anonymous reviewer
 2018-01-31 15:57:01 +00:00
moneromooo-monero
b809058993
ringct: pseudoOuts moved to prunable in the simple bulletproof case 
Saves 64 bytes non prunable data per typical tx

This breaks v7 consensus, will require a testnet reorg from v6
 2018-01-31 15:56:26 +00:00
moneromooo-monero
19ff243f52
wallets: reorg 61 more days on testnet 2018-01-31 15:52:43 +00:00
moneromooo-monero
c70f03cacf
blockchain: move bulletproofs to v8 
and set v7 height to 1057027 on testnet (one block earlier)
This is to easily dump current nodes since we're going to change
the v7 rules with this.
 2018-01-31 15:52:39 +00:00
moneromooo-monero
fde4489e1d
wipeable_string: call memwipe directly 
since the original reason for the indirect call (that memwipe
was not in contrib) is now gone
 2018-01-31 12:25:30 +00:00
stoffu
a99ef17695
wallet-rpc: take subaddress account as arg for get_transfer_by_txid 2018-01-31 17:53:02 +09:00
stoffu
7712509644
wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDS 2018-01-31 17:52:31 +09:00
stoffu
7539603f94
Bootstrap daemon 2018-01-30 20:15:47 +09:00
Maxithi
a85dbb3f2f
Fixed typos and wording tweaks 2018-01-29 12:13:23 +01:00
stoffu
402c9eef0e
cryptonote_tx_utils: fixed logic bug in get_destination_view_key_pub 2018-01-29 17:05:07 +09:00
Michał Sałaban
f90c76beb4 Return appropriate error code when there's no connection to daemon 2018-01-29 08:28:25 +01:00
Erik de Castro Lopo
628b78ae8a Fix in_peers/out_peers RPC operations 
Original implementations could never have worked.
 2018-01-29 11:54:57 +11:00
Erik de Castro Lopo
ece9bcf5c6 rpc_client: Fix error handling 
Previous code was unable to distingush between a connection error
and a communication error.
 2018-01-29 11:54:57 +11:00
Erik de Castro Lopo
32c0f908cd Allow the number of incoming connections to be limited 
It was already possible to limit outgoing connections. One might want
to do this on home network connections with high bandwidth but low
usage caps.
 2018-01-29 11:14:02 +11:00
Erik de Castro Lopo
d609a2c164 Rename delete_connections to delete_out_connections 
This rename is needed so that delete_in_connections can be added.
 2018-01-29 07:06:08 +11:00
Erik de Castro Lopo
b927c0fc7a Rename connections_count to max_out_connection_count 
This is needed so that a max_in_connection_count can be added.
 2018-01-29 07:06:08 +11:00
Riccardo Spagni
4fcf609942
Merge pull request #3186 
7ed62e63 cryptonote_protocol: fix std::move usage on different types (moneromooo-monero)
 2018-01-28 09:54:17 -08:00
moneromooo-monero
30ce8c5926
cn_deserialize: check for raw tx_extra 2018-01-28 15:23:05 +00:00
Michał Sałaban
3cb65b3f69 Return appropriate error code when not enough money for tx 2018-01-28 12:52:05 +01:00
moneromooo-monero
eda9fb5b98
p2p: fix testnet/mainnet port mixup 2018-01-28 09:44:04 +00:00
Riccardo Spagni
6ed314854c
Merge pull request #3188 
fbc0a6dd Bugfix : Missing i18n import in simplewallet (Neozaru)
 2018-01-27 18:21:55 -08:00
stoffu
30c44bce06
wallet: automatically use low priority if safe (no backlog & recent blocks not full) 2018-01-28 11:04:52 +09:00
stoffu
c903df5ece
simplewallet: bug fix for backlog estimate 2018-01-28 10:52:25 +09:00
moneromooo-monero
2f5a9b6bb3
wallet2: split estimate_backlog to allow for raw fee levels 2018-01-28 10:52:16 +09:00
Riccardo Spagni
d061c312fb
Merge pull request #3116 
269ba252 wallet2::import_blockchain fix import loop (Jaquee)
 2018-01-27 17:27:07 -08:00
Riccardo Spagni
a4ae78a335
Merge pull request #3145 
fd1dfac5 p2p: don't lookup seed IPs if using an exclusive peer (moneromooo-monero)
b50182ae p2p: don't connect to seeds if using an exclusive peer (moneromooo-monero)
 2018-01-27 17:25:47 -08:00
Riccardo Spagni
f7dcb730cb
Merge pull request #3144 
42f86624 rpc: expose recent median block size in getinfo (moneromooo-monero)
 2018-01-27 17:25:40 -08:00
Riccardo Spagni
e93ff8f22d
Merge pull request #3143 
ba6d2975 cryptonote_core: add --disable-dns-checkpoints flag (moneromooo-monero)
 2018-01-27 17:25:33 -08:00
Riccardo Spagni
1506f33075
Merge pull request #3142 
a9cae0ab Wallet API: remove unused enum Priority from UnsignedTransaction (stoffu)
 2018-01-27 17:25:25 -08:00
Riccardo Spagni
5603d5aaea
Merge pull request #3141 
3160a930 wallet2: remove {set|get}_default_decimal_point and use the same funcs under cryptonote:: instead (stoffu)
7d1088d3 wallet2: make scan_output const and omit keys arg (stoffu)
bc1ee2c2 wallet2: make member functions const when possible (stoffu)
 2018-01-27 17:25:15 -08:00
Riccardo Spagni
6d48bddffd
Merge pull request #3136 
e0404d35 rpc: default do_not_relay to false in sendrawtransaction (moneromooo-monero)
 2018-01-27 17:25:07 -08:00
Riccardo Spagni
d3e1244466
Merge pull request #3121 
6fbb0b06 cmake: set API header install path to what Qt wallet expects (redfish)
 2018-01-27 17:24:57 -08:00
Riccardo Spagni
4c302c6385
Merge pull request #3120 
6cf56682 perf_timer: add faster x86_64 timers, and pause/resume (moneromooo-monero)
411da337 perf_timer: use std::unique_ptr instead of new/delete (moneromooo-monero)
 2018-01-27 17:24:49 -08:00
Riccardo Spagni
7de1685bd8
Merge pull request #3119 
c4f43779 crypto: add a ge_p3_identity constant (moneromooo-monero)
13b4c90e crypto: add scalar mult functions returning ge_p3 instead of ge_p2 (moneromooo-monero)
 2018-01-27 17:24:42 -08:00
Riccardo Spagni
e1ba5b95c1
Merge pull request #3118 
ca336c62 simplewallet: check file overwrite when exporting stuff (stoffu)
 2018-01-27 17:24:34 -08:00
Riccardo Spagni
92ea8af34d
Merge pull request #3114 
fb5c971c Allow retrieving spend key via RPC (Michał Sałaban)
 2018-01-27 17:24:26 -08:00
Riccardo Spagni
73a19e0b06
Merge pull request #3113 
ffc2e570 wallet rpc: show fees when querying incoming transfers (stoffu)
 2018-01-27 17:24:15 -08:00
Riccardo Spagni
087a773247
Merge pull request #3104 
939629e8 Wallet API: all recover options with password (m2049r)
 2018-01-27 17:24:08 -08:00
Riccardo Spagni
0d328cffda
Merge pull request #3102 
3050a4f0 simplewallet: fix typo get_tx_proof_out to get_tx_proof (stoffu)
 2018-01-27 17:24:00 -08:00
Matt Little
1dfed567e2 Fixed #if instead of #ifdef 2018-01-27 13:33:11 -07:00
xmr-eric
84a7f6a482 Readd copyright starting date 2018-01-26 10:03:20 -05:00
xmr-eric
18216f19dd Update 2018 copyright 2018-01-26 10:03:20 -05:00
Neozaru
fbc0a6dd23 Bugfix : Missing i18n import in simplewallet 2018-01-26 13:58:49 +01:00
moneromooo-monero
7ed62e63e5
cryptonote_protocol: fix std::move usage on different types 2018-01-26 10:13:06 +00:00
stoffu
a9cae0abe7
Wallet API: remove unused enum Priority from UnsignedTransaction 2018-01-26 10:59:49 +09:00
stoffu
3160a93027
wallet2: remove {set|get}_default_decimal_point and use the same funcs under cryptonote:: instead 2018-01-26 10:59:32 +09:00
stoffu
7d1088d337
wallet2: make scan_output const and omit keys arg 2018-01-26 10:59:31 +09:00
stoffu
bc1ee2c2ee
wallet2: make member functions const when possible 2018-01-26 10:59:30 +09:00
stoffu
3050a4f05b
simplewallet: fix typo get_tx_proof_out to get_tx_proof 2018-01-26 10:59:15 +09:00
stoffu
ffc2e5705d
wallet rpc: show fees when querying incoming transfers 2018-01-26 10:58:23 +09:00
stoffu
ca336c62e3
simplewallet: check file overwrite when exporting stuff 2018-01-26 10:57:13 +09:00
Riccardo Spagni
09d19c9139
Merge pull request #3130 
5ae617d5 simplewallet: single out 0 amount destinations as dummy ones (moneromooo-monero)
c1d19f3c wallet2: fix sweep_all sending an atomic unit (moneromooo-monero)
 2018-01-25 16:57:03 -08:00
Riccardo Spagni
700b3193f8
Merge pull request #3084 
5f5a51a6 util: warn if unbound was not built with threads (moneromooo-monero)
 2018-01-25 16:56:28 -08:00
Riccardo Spagni
ea75e71dd2
Merge pull request #3052 
d507167f Removed unused mac-specific output folder path (Maxithi)
 2018-01-25 16:54:45 -08:00
Riccardo Spagni
5a15a8322e
Merge pull request #3153 
ab58b150 p2p: fix picking peers off an empty gray list (moneromooo-monero)
 2018-01-25 16:51:50 -08:00
Riccardo Spagni
ef4b69f8bb
Merge pull request #3126 
ff5626d7 ringct: handle exceptions verifying bulletproofs in worker threads (moneromooo-monero)
 2018-01-25 16:50:47 -08:00
Riccardo Spagni
d25217f058
Merge pull request #3105 
b56f4645 cryptonote_protocol: fix size_t used in wire format (moneromooo-monero)
 2018-01-25 16:50:18 -08:00
Riccardo Spagni
f31f5c9a3e
Merge pull request #3093 
d188840c Improved terminology from create to generate (Maxithi)
 2018-01-25 16:49:54 -08:00
Riccardo Spagni
39bd6c6815
Merge pull request #3072 
0811b924 fix some confirmation dialog, add missing symbols (AJIekceu4)
 2018-01-25 16:48:00 -08:00
Riccardo Spagni
c222b6485e
Merge pull request #3068 
301ec15c Change cryptonote::COMMAND_RPC_SET_LIMIT::response to use int64_t (Nick Johnson)
 2018-01-25 16:47:29 -08:00
Riccardo Spagni
66a2751d68
Merge pull request #3065 
3e635a3c wallet2: allow failing parse_tx_extra (moneromooo-monero)
 2018-01-25 16:47:08 -08:00
Riccardo Spagni
ede4e1c54c
Merge pull request #3057 
9ffa97fe Factor the monero donation address (Maxithi)
 2018-01-25 16:46:18 -08:00
Riccardo Spagni
008b492963
Merge pull request #3047 
fa5c0bab Implement #3045, fixing RPC snakecases (Nick Johnson)
 2018-01-25 16:45:45 -08:00
Riccardo Spagni
5a312752af
Merge pull request #3040 
69f9a075 cryptonote_protocol: fix missing space in version mismatch message (moneromooo-monero)
 2018-01-25 16:44:51 -08:00