nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6,659 Commits 10 Branches 68 Tags 223 MiB
0ff0850545
Commit Graph

4691 Commits

Author SHA1 Message Date
luigi1111
4e7897e57c
Merge pull request #3780 
9c2a7b4 wallet-rpc: watch-only and cold wallet features added (ph4r05)
 2018-06-16 14:12:57 -05:00
luigi1111
e3012444fb
Merge pull request #3762 
eb9f3a3 check_spend_proof (itssteven)
 2018-06-16 14:10:11 -05:00
luigi1111
7af0b7fffc
Merge pull request #3735 
4812c06 add .load() to make Boost 1.67 happy with its new is_integral check (Teutone)
 2018-06-16 14:07:25 -05:00
luigi1111
fb2b16f10a
Merge pull request #3732 
fa0839f Ensure m_timestamps has the correct number for computing difficulty. (thaerkh)
 2018-06-16 14:05:53 -05:00
luigi1111
abfff766e5
Merge pull request #3737 
1590183 p2p: fix fallback seed node usage (moneromooo-monero)
 2018-06-16 14:04:01 -05:00
luigi1111
b3363e8e0a
Merge pull request #3726 
b5cb1bc blockchain: avoid exception if asked for a block we do not have (moneromooo-monero)
 2018-06-16 14:02:56 -05:00
luigi1111
42e7f31613
Merge pull request #3725 
9cc0d42 connection_context: remove state_ prefix from state names (moneromooo-monero)
d9d002c daemon: print peer state in sync_info (moneromooo-monero)
 2018-06-16 14:01:12 -05:00
luigi1111
aada0670ba
Merge pull request #3538 
f4e3295 simplewallet: set_ring can now take a file with rings (moneromooo-monero)
 2018-06-16 13:51:57 -05:00
Howard Chu
b85acb4cb8
Fix RPC crashes that didn't check for an open wallet 2018-06-15 20:18:41 +01:00
moneromooo-monero
bc443494f3
wallet2: fix out of sync account tag cache 
This would cause crashes when trying to tag an account that was
just created
 2018-06-15 20:18:12 +01:00
stoffu
149da420e9 db_lmdb: enable batch transactions by default 2018-06-14 20:56:11 +02:00
moneromooo-monero
8db23df581
wallet: on first refresh, start off with a quantized height 
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
 2018-06-13 22:44:27 +01:00
stoffu
63d0ab09b5
mlog: --max-log-files to set the max number of rotated log files 2018-06-13 12:44:27 +09:00
stoffu
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded 2018-06-13 11:56:40 +09:00
luigi1111
62f3f0480a
Merge pull request #3701 
3ca267b cn_deserialize: dump additional tx pubkeys (moneromooo-monero)
 2018-06-12 12:24:20 -05:00
luigi1111
a915d49307
Merge pull request #3700 
efcecb4 mnemonics: add some logs to help debug failures (moneromooo-monero)
 2018-06-12 12:23:12 -05:00
luigi1111
6be2516140
Merge pull request #3687 
6b13976 blockchain: log in DEBUG when a block is found, and where (moneromooo-monero)
 2018-06-12 12:22:12 -05:00
luigi1111
41d04a87b2
Merge pull request #3648 
6f36cf0 Improve 'show_transfers' date formatting (ryan-ronnander)
 2018-06-12 12:18:17 -05:00
luigi1111
ed139efc5d
Merge pull request #3643 
e2b7558 handle improper log levels (cryptochangements34)
 2018-06-12 12:13:07 -05:00
stoffu
0a5292c339
wallet2: use decoded amount when reporting repeated output key 2018-06-13 01:06:44 +09:00
stoffu
25c15dca5c
wallet2: use correct fee for split txes 2018-06-12 12:06:51 +09:00
moneromooo-monero
2d10830cfb
db_ldmb: print db version when complaining about incompatibility 2018-06-11 17:57:02 +01:00
Jean Pierre Dudey
b628503bad Remove old logic saved in comments. 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
 2018-06-11 09:36:05 -04:00
stoffu
0cf80baea4
net_node: resolve host for node addresses given via command line flags 2018-06-11 20:17:13 +09:00
stoffu
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X 2018-06-11 20:17:02 +09:00
stoffu
362f5e6eb8
simplewallet: don't confirm missing payment ID when sending to only subaddresses 2018-06-10 20:00:59 +09:00
moneromooo-monero
03096150c6
device_ledger: fix bad memory access on connect error 2018-06-09 20:52:34 +01:00
moneromooo-monero
2d5921eefa
blockchain: avoid duplicate db query for height 2018-06-09 19:51:27 +01:00
moneromooo-monero
1789b76b5d
cryptonote_protocol_handler: log when dropping a peer 2018-06-09 19:27:21 +01:00
moneromooo-monero
f4e329583e
simplewallet: set_ring can now take a file with rings 2018-06-09 00:28:31 +01:00
moneromooo-monero
948c48271a
simplewallet: grammar fix in warning message 2018-06-08 21:28:11 +01:00
moneromooo-monero
284fe6438d
db_lmdb: warn about slowness when running off a spinning disk 2018-06-08 20:59:02 +01:00
luigi1111
2619d966c6
Merge pull request #3908 
827ca3f bump version for 0.12.2 point release (fluffypony)
95ccf50 update checkpoints.dat for point release (fluffypony)
 2018-06-08 14:53:54 -05:00
luigi1111
6884db7b31
Merge pull request #3599 
8787fd8 WalletApi: publicMultisigSignerKey method (naughtyfox)
 2018-06-08 14:45:46 -05:00
luigi1111
00635bd68b
Merge pull request #3598 
b21bc00 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) (naughtyfox)
 2018-06-08 14:40:06 -05:00
luigi1111
22c8730261
Merge pull request #3450 
3b941be core: add get_earliest_ideal_height_for_version() (stoffu)
 2018-06-08 14:31:49 -05:00
luigi1111
5321769b65
Merge pull request #3444 
a79fc21 hardfork: fix get_earliest_ideal_height_for_version() to support non-existent versions (stoffu)
7e30ead unit_tests/hardfork: add tests for check_for_height() (stoffu)
98cf62c hardfork: fix get_next_version() (stoffu)
0321d1a unit_tests/hardfork: add tests for get_voting_info() (stoffu)
 2018-06-08 14:29:38 -05:00
luigi1111
9e5f2738fd
Merge pull request #3428 
b26cd26 blockchain_utilities: do not link against unneeded p2p lib (moneromooo-monero)
66f4700 blockchain_blackball: add incremental mode (moneromooo-monero)
e09710f blockchain_blackball: also blackball N N-sized duplicate rings (moneromooo-monero)
 2018-06-08 14:26:38 -05:00
luigi1111
03b4cca6c2
Merge pull request #3910 
f2cb56a protocol: drop (and increase fails) if most blocks hashes are invalid (moneromooo-monero)
 2018-06-07 12:24:02 -05:00
luigi1111
5bfe03804c
Merge pull request #3892 
d344736 rpc: convert distribution to cumulative after caching (moneromooo-monero)
 2018-06-07 12:22:04 -05:00
luigi1111
8a1f0d7d13
Merge pull request #3940 
f24cbc5 blockchain: fix deadlock with the difficulty cache (moneromooo-monero)
 2018-06-07 12:19:43 -05:00
luigi1111
48fcf76be9
Merge pull request #3911 
f0322a0 blockchain: demote a hash-of-hashes validation warning to debug (moneromooo-monero)
 2018-06-07 12:17:06 -05:00
luigi1111
e1a940806a
Merge pull request #3899 
ab87e7f rpc: the cache is still for non cumulative on that branch (moneromooo-monero)
 2018-06-07 12:15:13 -05:00
luigi1111
1af890287b
Merge pull request #3890 
f80b157 wallet2: don't ask for pruned txes yet, we still parse the entire tx (moneromooo-monero)
 2018-06-07 12:12:28 -05:00
moneromooo-monero
2bb2c1b9d7
password: flush cout when prompting for password without newline 2018-06-07 13:48:30 +01:00
moneromooo-monero
d7a6b72c15
wallet2: fix bulletproof cold signing 
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
 2018-06-07 12:29:30 +01:00
moneromooo-monero
c367609447
blockchain_import: warn+delay about using --dangerous-unverified-import 
This is the new name for --guard-against-pwnage 0
 2018-06-07 06:47:00 +01:00
stoffu
bf26920f27
wallet2: fix get_approximate_blockchain_height for stagenet 2018-06-06 20:33:01 +09:00
moneromooo-monero
f24cbc5245
blockchain: fix deadlock with the difficulty cache 2018-06-06 10:37:51 +01:00
moneromooo-monero
62c8c07c47
wallet: do not log by default if we're not asked to log to console 
This means monero-wallet-rpc still does, but the user level program
does not.
 2018-06-06 10:15:13 +01:00
moneromooo-monero
01cc978722
ringct: remove an unnecessary scalarmultBase in zeroCommit 2018-06-06 10:14:36 +01:00
cryptochangements34
4764929ecb use deterministic viewkey if not supplied 2018-06-05 19:32:03 -04:00
moneromooo-monero
d81e042306
tx_pool: initialize bitflags padding since it gets written to storage 
Avoids valgrind reporting uninitialized data usage
 2018-06-05 20:26:44 +01:00
moneromooo-monero
941a608d52
util: consider Tor/I2P addresses to be non local 2018-06-05 16:55:23 +01:00
moneromooo-monero
8962f0032f
simplewallet: add optional trusted/untrusted argument to set_daemon 
Otherwise the previous daemon's trustedness would carry over.
If not specified, the local address check is performed again.
 2018-06-05 16:55:20 +01:00
stoffu
ace2edacb6
blockchain: pop forked blocks only when DB is not read-only 2018-06-04 20:59:50 +09:00
S
afed9787cd Fixes #3645: error on freebsd lambda return values forced to std::string 2018-06-04 13:44:17 +02:00
moneromooo-monero
f2cb56a2eb
protocol: drop (and increase fails) if most blocks hashes are invalid 2018-06-03 17:34:08 +01:00
Dusan Klinec
9c2a7b4638 wallet-rpc: watch-only and cold wallet features added 
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs

Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx

- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
 2018-06-03 13:21:00 +02:00
moneromooo-monero
f0322a083a
blockchain: demote a hash-of-hashes validation warning to debug 
This data comes from untrusted peers, and validation failures
are therefore normal.
 2018-06-02 23:48:12 +01:00
Riccardo Spagni
95ccf508cd update checkpoints.dat for point release 2018-06-02 14:31:37 +02:00
Riccardo Spagni
827ca3fd3b bump version for 0.12.2 point release 2018-06-02 14:31:33 +02:00
moneromooo-monero
2b0c632f32
tx_pool: hold off parsing a tx blob till we actually need it 2018-06-02 09:17:41 +01:00
moneromooo-monero
4f3a4fb701
blockchain: return error when requesting non existent output 
avoids RPC thread dying, causing the wallet to timeout
 2018-06-01 21:52:04 +01:00
moneromooo-monero
ab87e7fdae
rpc: the cache is still for non cumulative on that branch 2018-06-01 09:05:47 +01:00
stoffu
6b8568e9a1
simplewallet.sign_transfer: rename export to export_raw, add help message 2018-06-01 09:38:14 +09:00
luigi1111
503d2693fd
Merge pull request #3640 
f36132a wallet cli/rpc: terminate execution with code 0 when --help or --version is given (stoffu)
 2018-05-31 14:44:54 -05:00
luigi1111
3ee6a1b706
Merge pull request #3635 
c1bda09 wallet_rpc_server: add a get_version RPC (moneromooo-monero)
 2018-05-31 14:43:18 -05:00
luigi1111
b6eb7484d1
Merge pull request #3592 
90a16b1 crypto: fix initialization order issue with random mutex (moneromooo-monero)
6a61f52 unit_tests: add ringdb unit tests (moneromooo-monero)
 2018-05-31 14:41:17 -05:00
luigi1111
40dd59fb8e
Merge pull request #3583 
372ffeb Add a space in mining to testnet/stagenet string (cryptochangements34)
 2018-05-31 14:39:28 -05:00
luigi1111
737712c0c6
Merge pull request #3561 
353e9c0 Core RPC: optionally add POW hash to block_header_response (stoffu)
 2018-05-31 14:38:01 -05:00
luigi1111
c8378933ae
Merge pull request #3543 
6fc97c9 blockchain_usage: don't divide by 0 when there is nothing to process (moneromooo-monero)
 2018-05-31 14:36:33 -05:00
luigi1111
3a373c3d3a
Merge pull request #3489 
47fdb74 WalletApi: getMultisigInfo entry for gui wallets... (naughtyfox)
47fdb74 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings (naughtyfox)
 2018-05-31 14:34:34 -05:00
luigi1111
64adb566e5
Merge pull request #3499 
0da5d37 wallet: fix shared ring db path (stoffu)
 2018-05-31 14:27:13 -05:00
luigi1111
9fde7aafe8
Merge pull request #3882 
b665bab rpc: fix get_output_distribution cache for the cumulative case (moneromooo-monero)
 2018-05-31 14:25:57 -05:00
moneromooo-monero
d3447364d0
rpc: convert distribution to cumulative after caching 
This avoids double conversion on a later cache hit
 2018-05-31 16:54:57 +01:00
moneromooo-monero
f80b1571c6
wallet2: don't ask for pruned txes yet, we still parse the entire tx 2018-05-31 16:46:58 +01:00
moneromooo-monero
1aae39dff2
daemon: fix readline interfering with std::cerr usage 
Once readline is initialized, std::cerr's operator<< will
output a 0xff byte for unknown reasons.
 2018-05-31 12:15:06 +01:00
stoffu
0da5d37bf3
wallet: fix shared ring db path 2018-05-31 08:16:45 +09:00
luigi1111
9bc8f76924
Merge pull request #3525 
66a659b blockchain: add scope guard to waiter for threaded txv1 verification (stoffu)
 2018-05-30 16:08:50 -05:00
luigi1111
f03bf36c85
Merge pull request #3491 
c8cb5fc exit if specified wallet file doesn't exist (cryptochangements34)
 2018-05-30 15:55:37 -05:00
luigi1111
a7ea14dc6a
Merge pull request #3876 
740da1b core: fix automatic safe db sync mode switching (moneromooo-monero)
e942d34 protocol: do not switch to unsafe sync mode for just a few blocks (moneromooo-monero)
 2018-05-30 15:46:13 -05:00
luigi1111
4267a0bb51
Merge pull request #3731 
a66f152 Use median timestamp if current time renders a block invalid. (thaerkh)
 2018-05-30 15:44:25 -05:00
moneromooo-monero
b665bab1d6
rpc: fix get_output_distribution cache for the cumulative case 
The distribution was not converted to cumulative after a cache hit
 2018-05-30 15:03:36 +01:00
moneromooo-monero
e09710f76e
blockchain_blackball: also blackball N N-sized duplicate rings 
These are unlikely to happen at random, but Wijaya et al made
a paper about it, so people might try it on purpose now (and it
turns out it's easy to add anyway)
 2018-05-30 11:45:20 +01:00
moneromooo-monero
66f4700f57
blockchain_blackball: add incremental mode 2018-05-30 11:45:16 +01:00
moneromooo-monero
b26cd26333
blockchain_utilities: do not link against unneeded p2p lib 2018-05-30 11:45:13 +01:00
stoffu
98cf62cc45
hardfork: fix get_next_version() 2018-05-30 09:49:57 +09:00
stoffu
a79fc219b7
hardfork: fix get_earliest_ideal_height_for_version() to support non-existent versions 2018-05-30 09:49:52 +09:00
luigi1111
c534fe8d19
Merge pull request #3251 
b9389e5 db_lmdb: save pruned and prunable tx data separately (moneromooo-monero)
 2018-05-29 17:56:26 -05:00
luigi1111
c4907d24cb
Merge pull request #3477 
3f5fb6f simplewallet: add --untrusted-daemon option (moneromooo-monero)
 2018-05-29 13:01:50 -05:00
luigi1111
8e1b322a15
Merge pull request #3470 
ad19f86 don't show error twice when starting simplewallet (cryptochangements34)
 2018-05-29 12:59:58 -05:00
luigi1111
ed72f35e9a
Merge pull request #3446 
a6b8d3f tx_pool: remove old comment from fill_block_template() (stoffu)
 2018-05-29 12:57:43 -05:00
luigi1111
764340d112
Merge pull request #3420 
a6a54fa blockchain: cache difficulty for next block (moneromooo-monero)
 2018-05-29 12:55:19 -05:00
luigi1111
5b189ce2a8
Merge pull request #3405 
80d2f80 wallet2: Update function parameter documentation (leonklingele)
 2018-05-29 12:52:43 -05:00
moneromooo-monero
5a412b7a3f
disable file size sanity check when loading the wallet cache 2018-05-28 14:58:22 +01:00
moneromooo-monero
e942d34d54
protocol: do not switch to unsafe sync mode for just a few blocks 2018-05-28 14:36:12 +01:00
moneromooo-monero
740da1ba95
core: fix automatic safe db sync mode switching 2018-05-28 12:14:04 +01:00
stoffu
a6b8d3fee1
tx_pool: remove old comment from fill_block_template() 2018-05-28 13:41:39 +09:00
moneromooo-monero
a87980f6c2
fix build with GCC 8.1.0 2018-05-26 14:54:10 +01:00
moneromooo-monero
de1ffe07b1
p2p: warn when no incoming connections are seen for a while 2018-05-26 14:37:07 +01:00
moneromooo-monero
b9389e582e
db_lmdb: save pruned and prunable tx data separately 
This bumps DB version to 2, migration code will run for v1 DBs
 2018-05-23 22:48:12 +01:00
Riccardo Spagni
45975fd8eb update checkpoints 2018-05-23 21:20:15 +02:00
Riccardo Spagni
6715c90667 update checkpoints for point release 2018-05-23 21:20:10 +02:00
Riccardo Spagni
49f4645f1d bump version for point release 2018-05-23 21:20:05 +02:00
cslashm
bdf5a3ad3f Fix PCSC compilation under windows 
PR3843 based on release-v0.12 => rebased on master
 2018-05-23 10:22:55 +02:00
Riccardo Spagni
a2cef8cba4
Merge pull request #3800 
9317bce9 crypto: more places needing fixing for GCC 8.1 (moneroexamples)
4a72d595 chacha: fix build with GCC 8.1 (moneromooo-monero)
 2018-05-21 21:58:49 +02:00
Riccardo Spagni
f794d3b3df
Merge pull request #3787 
ce63ab09 blockchain: invalidate misc caches when popping blocks (moneromooo-monero)
 2018-05-21 21:36:38 +02:00
Riccardo Spagni
709658d166
Merge pull request #3832 
cb9c7972 Fix output shuffling for multisig (stoffu)
 2018-05-21 20:57:52 +02:00
Riccardo Spagni
4dae04dde2
Merge pull request #3837 
18761b37 simplewallet: use correct unit for fee command (stoffu)
 2018-05-21 20:57:07 +02:00
Riccardo Spagni
d6cefbd1b8
Merge pull request #3745 
b13bddc3 Wallet API: allow log path to be non-default & console output to be configurable (stoffu)
 2018-05-21 20:56:20 +02:00
moneromooo-monero
5f8ffca34d
speed up get_output_distribution (and precalc common case) 2018-05-21 19:51:58 +01:00
Riccardo Spagni
2f5506daf8
Merge pull request #3830 
29fbaeaa daemon: request unpruned transactions for print_tx (moneromooo-monero)
 2018-05-21 20:46:57 +02:00
Riccardo Spagni
791da4343c
Merge pull request #3749 
872cb4ef blockchain: pop top if block version disagrees with the ideal fork version (stoffu)
 2018-05-21 20:45:35 +02:00
stoffu
18761b372f
simplewallet: use correct unit for fee command 2018-05-20 23:16:31 +09:00
moneromooo-monero
ce173cbb5b
core: remove threadpool dependency from header 2018-05-20 12:06:07 +01:00
moneromooo-monero
db55263b4c
threadpool: allow constructing an object, and misc tweaks 
use unsigned int to avoid having to range check negative numbers,
use const where possible, don't needlessly create empty objects,
use std::move where possible
 2018-05-20 12:06:03 +01:00
stoffu
cb9c7972b6
Fix output shuffling for multisig 2018-05-20 09:38:41 +09:00
moneromooo-monero
29fbaeaae5
daemon: request unpruned transactions for print_tx 
instead of uninitialized
 2018-05-19 00:04:46 +01:00
moneromooo-monero
16e209e08d
core: lock incoming tx lock when checking the txpool and chain 
This gets rid of an innocuous race trying to add the same tx
twice to the txpool
 2018-05-18 09:39:56 +01:00
moneromooo-monero
a2566db09e
object_sizes: add a few useful types 2018-05-17 10:40:11 +01:00
jcktm
89e51ecd38 simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet 2018-05-15 15:28:42 +10:00
Thaer Khawaja
a66f152f75 Use median timestamp if current time renders a block invalid. 2018-05-13 11:58:05 -07:00
moneroexamples
9317bce9ca
crypto: more places needing fixing for GCC 8.1 2018-05-13 18:17:13 +01:00
moneromooo-monero
4a72d595a6
chacha: fix build with GCC 8.1 2018-05-13 18:17:11 +01:00
Rafficer
f357210c00
Fix Typo 2018-05-12 20:18:21 +02:00
moneromooo-monero
a58d9738c9
wallet2: consider 6 outputs or less to be unmixable from v7 2018-05-10 21:19:33 +01:00
moneromooo-monero
b5cb1bc403
blockchain: avoid exception if asked for a block we do not have 
This can happen if a peer tries to obtain the next span from other
peers if that span is needed for not downloaded yet. Also if the
peer maliciously requests a non existent block hash.
 2018-05-09 14:03:07 +01:00
moneromooo-monero
ce63ab09db
blockchain: invalidate misc caches when popping blocks 
Might be a bit heavy handed, but conservative.
 2018-05-09 09:10:56 +01:00
cryptochangements34
261ee5628b don't limit miner threads in wallet 2018-05-08 19:09:14 -04:00
Riccardo Spagni
52f6b33890
Merge pull request #3775 
6f859e43 cryptonote: make sure outPk setup always happens (moneromooo-monero)
 2018-05-08 09:59:28 +02:00
moneromooo-monero
6f859e4328
cryptonote: make sure outPk setup always happens 2018-05-07 19:21:52 +01:00
itssteven
eb9f3a3294
check_spend_proof 
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
 2018-05-06 17:42:27 +01:00
cryptochangements34
6f9260e38e handle optional miner params better 2018-05-06 12:28:57 -04:00
stoffu
872cb4efd8
blockchain: pop top if block version disagrees with the ideal fork version 2018-05-06 20:50:46 +09:00
Teutone
4812c062c5 add .load() to make Boost 1.67 happy with its new is_integral check 2018-05-05 21:44:28 +02:00
moneromooo-monero
5f19384729
ringct: do not show verification errors with default settings 2018-05-04 08:27:55 +01:00
stoffu
b13bddc3c9
Wallet API: allow log path to be non-default & console output to be configurable 2018-05-04 10:21:25 +09:00
Thaer Khawaja
fa0839f2f5 Ensure m_timestamps has the correct number for computing difficulty. 2018-04-29 19:50:55 -07:00
Riccardo Spagni
6b9d9f56a1
Merge pull request #3719 
3880bf39 cryptonote_protocol_handler.inl: remove span read just now that failed to pass some basic tests (stoffu)
da249fd5 cryptonote_protocol_handler.inl: fix return type mismatches (int vs bool) (stoffu)
 2018-04-29 21:38:22 +02:00
moneromooo-monero
1590183965
p2p: fix fallback seed node usage 
Those were added to the seed nodes list even when they had already
been added. Moreover, the current index was not reset after they
were added, typically causing previous seeds to be used, and some
of those fallback seeds to not be tried.
 2018-04-29 14:58:42 +01:00
moneromooo-monero
d9d002c3c1
daemon: print peer state in sync_info 
It's often relevant
 2018-04-28 19:56:39 +01:00
moneromooo-monero
9cc0d4220f
connection_context: remove "state_" prefix from state names 
It's redundant and makes it easier to print them in columns
 2018-04-28 19:56:28 +01:00
Riccardo Spagni
cd22cb807a
Merge pull request #3709 
82b05d50 Adding required library (dependency of boost::this_thread::sleep_for) (Gene Peters)
 2018-04-28 17:02:22 +02:00
Riccardo Spagni
69b6f5b6a6
Merge pull request #3705 
f9d0827b Fix broken interactive daemon 'limit' commands plus RPC calls (rbrunner7)
 2018-04-28 17:02:08 +02:00
Riccardo Spagni
26cae8f4f1
Merge pull request #3695 
b1a9e97b slow-hash: fix memory leak for Windows /karbowanec#41 (aivve)
 2018-04-28 16:59:02 +02:00
Riccardo Spagni
2ab5b1a21f
Merge pull request #3683 
dad10775 Only log an error if fork version is higher AND is not known. (Thaer Khawaja)
 2018-04-28 16:57:36 +02:00
Riccardo Spagni
93e76e14a2
Merge pull request #3685 
ffeeefde speedup get_output_histogram for all amounts when min_count > 0 (moneromooo-monero)
2dae0f20 wallet2: add missing parameters to get_output_histogram (moneromooo-monero)
 2018-04-28 16:56:22 +02:00
Riccardo Spagni
35299644b2
Merge pull request #3650 
5bd7f760 import_multisig_info: fix sanity check crash in detach_blockchain (Mikhail Mitkevichl)
 2018-04-28 16:54:37 +02:00
stoffu
3880bf396a
cryptonote_protocol_handler.inl: remove span read just now that failed to pass some basic tests 2018-04-28 11:10:59 +09:00
stoffu
da249fd5ba
cryptonote_protocol_handler.inl: fix return type mismatches (int vs bool) 2018-04-28 11:07:51 +09:00
Gene Peters
82b05d5054 Adding required library (dependency of boost::this_thread::sleep_for) 2018-04-25 21:02:54 -07:00
rbrunner7
f9d0827bba Fix broken interactive daemon 'limit' commands plus RPC calls 2018-04-25 21:37:10 +02:00
naughtyfox
b21bc00704 Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api) 2018-04-25 17:55:54 +03:00
moneromooo-monero
3ca267b546
cn_deserialize: dump additional tx pubkeys 2018-04-25 14:28:39 +01:00
moneromooo-monero
efcecb42f3
mnemonics: add some logs to help debug failures 2018-04-25 14:27:24 +01:00
aivve
b1a9e97b2d
slow-hash: fix memory leak for Windows /karbowanec#41 2018-04-24 20:47:29 +09:00
moneromooo-monero
6b13976330
blockchain: log in DEBUG when a block is found, and where 
Eases up debugging
 2018-04-23 11:43:12 +01:00
moneromooo-monero
ffeeefde60
speedup get_output_histogram for all amounts when min_count > 0 
This skips the vast majority of "dust" output amounts with just
one instance on the chain. Clocks in at 0.15% of the original
time on testnet.
 2018-04-23 10:54:28 +01:00
moneromooo-monero
2dae0f203a
wallet2: add missing parameters to get_output_histogram 2018-04-23 10:54:25 +01:00
Thaer Khawaja
dad1077577 Only log an error if fork version is higher AND is not known. 2018-04-22 17:26:44 -07:00
stoffu
f36132a837
wallet cli/rpc: terminate execution with code 0 when --help or --version is given 2018-04-22 11:48:44 +09:00
Mikhail Mitkevichl
5bd7f760e9 import_multisig_info: fix sanity check crash in detach_blockchain 2018-04-21 23:25:01 +03:00
Riccardo Spagni
8fdf645397
Merge pull request #3670 
19e01378 Build: remove UPnP definition from snap (anonimal)
6b853980 Build: update CMake and p2p for in-tree miniupnp (anonimal)
859db52f CMake: update new location of in-tree miniupnpc (anonimal)
f21df05c Build: add miniupnp submodule (anonimal)
10685648 Build: remove in-tree miniupnpc (anonimal)
 2018-04-21 22:01:54 +02:00
Riccardo Spagni
a429f06b18
Merge pull request #3579 
0b88fff3 simplewallet: fix help message of sign_transfer (stoffu)
 2018-04-21 21:58:52 +02:00
Riccardo Spagni
a3a617f35f
Merge pull request #3576 
f82c10dc WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time (stoffu)
 2018-04-21 21:58:10 +02:00
Riccardo Spagni
6189a775b0
Merge pull request #3636 
998c1461 daemon: read config file before reading any other args (stoffu)
 2018-04-21 21:57:31 +02:00
Riccardo Spagni
bcb71797c8
Merge pull request #3633 
f914df84 device: add a one off override keyword where appropriate (moneromooo-monero)
 2018-04-21 21:55:44 +02:00
Riccardo Spagni
7e98e9d7ce
Merge pull request #3630 
51b511be simplewallet: add version command (moneromooo-monero)
35d1269f daemon: add a version command (moneromooo-monero)
 2018-04-21 21:55:28 +02:00
Riccardo Spagni
e6cf9c06fc
Merge pull request #3624 
d8584fc8 util: log stack trace on crash (moneromooo-monero)
 2018-04-21 21:55:02 +02:00
Riccardo Spagni
03ff3be10e
Merge pull request #3672 
875c1cab wallet2: increase rpc timeout for get_output_distribution (moneromooo-monero)
70f23217 add top height to get_output_distribution, and cache it for rct (moneromooo-monero)
8c7363fb rpc: add missing perf timer for get_output_distribution (moneromooo-monero)
 2018-04-21 21:54:08 +02:00
anonimal
6b85398031
Build: update CMake and p2p for in-tree miniupnp 
(cherry picked from commit a7366b5feeffaeb65b217b2d6f138e0ab1c90192)
 2018-04-21 09:43:23 +00:00
moneromooo-monero
875c1cabb9
wallet2: increase rpc timeout for get_output_distribution 2018-04-19 16:06:26 +01:00
moneromooo-monero
70f2321763
add top height to get_output_distribution, and cache it for rct 
This should cache the vast majority of calls for long running wallets
 2018-04-19 16:06:22 +01:00
moneromooo-monero
8c7363fbef
rpc: add missing perf timer for get_output_distribution 2018-04-19 16:06:20 +01:00
anonimal
859db52fda
CMake: update new location of in-tree miniupnpc 
(cherry picked from commit b16a282f97d8f6c967e8a0b1ecfd75110f095182)
 2018-04-19 10:56:09 +00:00
Ryan Ronnander
6f36cf02e7
Improve 'show_transfers' date formatting 
Change the wallet's 'show_transfers' command to always output the transaction date with timestamp (24 hour UTC).
 2018-04-15 19:23:15 -07:00
cryptochangements34
e2b75586fb handle improper log levels 2018-04-15 11:33:22 -04:00
stoffu
998c1461c3
daemon: read config file before reading any other args 2018-04-14 22:05:24 +09:00
moneromooo-monero
c1bda097c1
wallet_rpc_server: add a get_version RPC 2018-04-14 13:34:05 +01:00
moneromooo-monero
f914df8494
device: add a one off override keyword where appropriate 2018-04-14 10:59:38 +01:00
moneromooo-monero
51b511be4c
simplewallet: add version command 2018-04-13 18:47:33 +01:00
moneromooo-monero
35d1269fac
daemon: add a version command 2018-04-13 18:47:30 +01:00
naughtyfox
8787fd899b WalletApi: publicMultisigSignerKey method 2018-04-13 13:15:20 +03:00
moneromooo-monero
d8584fc8d7
util: log stack trace on crash 2018-04-12 20:36:16 +01:00
stoffu
b5d6c723e9
wallet2: store subaddress lookahead settings 2018-04-12 22:23:53 +09:00
Riccardo Spagni
1f96755ddc
Merge pull request #3618 
3367ed86 blockchain_blackball: fix build with CLANG 5 (moneromooo-monero)
 2018-04-12 15:10:21 +02:00
moneromooo-monero
3367ed863c
blockchain_blackball: fix build with CLANG 5 
It doesn't like the explicit NULL dereference (which is fine, honest)
 2018-04-12 13:51:26 +01:00
cslashm
94b899db26 Use 'boost' mutex instead of 'std' mutex 2018-04-12 13:58:57 +02:00
cslashm
2c274e05fe Fix sub-address tx scan. 
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.

Moreover this patch avoid perf decreasing when not using HW device.
 2018-04-12 13:58:57 +02:00
Riccardo Spagni
5e08fd89ea
Merge pull request #3549 
73951cbd wallet2: request transactions in slices when scanning for known rings (moneromooo-monero)
25fe67e4 rpc: allow getting pruned blocks from gettransactions (moneromooo-monero)
 2018-04-12 13:49:33 +02:00
Riccardo Spagni
a95461e76d
Merge pull request #3609 
08343aba tx_pool: fix loading with colliding key images (moneromooo-monero)
 2018-04-12 13:48:44 +02:00
Riccardo Spagni
1e9cc3e43e
Merge pull request #3602 
a9cc88ee common: make this build with unbound 1.4.20 (moneromooo-monero)
 2018-04-12 13:48:12 +02:00
Riccardo Spagni
14c870ee5f
Merge pull request #3615 
24acb66e wallet2: fix misc issues when the ringdb can't be initialized (moneromooo-monero)
 2018-04-12 13:47:54 +02:00
Riccardo Spagni
3b8704b0fa
Merge pull request #3555 
0b26c4d5 wallet2: move segregation height to v7 (moneromooo-monero)
 2018-04-12 13:47:39 +02:00
Riccardo Spagni
5d8439e310
Merge pull request #3534 
eecfb57d wallet: warn if not using the default ring size (moneromooo-monero)
 2018-04-12 13:47:20 +02:00
Riccardo Spagni
f6094bb225
Merge pull request #3532 
aa5c2e01 simplewallet: warn about key reuse on startup (moneromooo-monero)
 2018-04-12 13:46:50 +02:00
Riccardo Spagni
226de8e928
Merge pull request #3530 
eb59f7c5 cryptonote_tx_util: make destinations properly shuffled (stoffu)
 2018-04-12 13:46:34 +02:00
Riccardo Spagni
8703f1d80e
Merge pull request #3516 
1e0958c0 wallet: fix default mixin (4 -> 6) (sneurlax)
 2018-04-12 13:46:18 +02:00
moneromooo-monero
24acb66eac
wallet2: fix misc issues when the ringdb can't be initialized 2018-04-12 11:07:07 +01:00
Riccardo Spagni
3a9290ba6f
Merge pull request #3511 
0beb94f3 device: fix endianess dependence on subaddress secret key generation (moneromooo-monero)
 2018-04-12 11:15:27 +02:00
Riccardo Spagni
5053f8f40b
Merge pull request #3502 
11c933e1 fix lambda compile error on openbsd (moneromooo-monero)
 2018-04-12 11:14:43 +02:00
Riccardo Spagni
96b2fee721
Merge pull request #3536 
c77d2bfa Add the possibility to export private view key for fast scan. (cslashm)
100b7bc1 Change mutex lock model to avoid dead lock and ensure locks are always released. (cslashm)
641dfc99 Automatic height setup when creating/restoring hw device. (cslashm)
 2018-04-12 11:12:33 +02:00
Riccardo Spagni
60b18cdd1f
Merge pull request #3492 
dac3895a update block hashes for checkpoints.dat (Riccardo Spagni)
 2018-04-12 11:07:16 +02:00
Riccardo Spagni
93047ce762
Merge pull request #3485 
1834127c rpc: make get_output_distribution a non-restricted RPC (moneromooo-monero)
 2018-04-12 11:06:26 +02:00
Riccardo Spagni
1b4dc46129
Merge pull request #3473 
eaa8bfe7 wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly The previous expression (stoffu)
0a619f78 wallet2: enable the mitigation only after the fork height (stoffu)
 2018-04-12 11:05:31 +02:00
Riccardo Spagni
3d6636e79c
Merge pull request #3471 
5f664793 p2p: correct port number for seed nodes (stoffu)
 2018-04-12 11:02:46 +02:00
Riccardo Spagni
ebb55f797b
Merge pull request #3468 
0098ed33 wallet2: fix for loading settings of key reuse mitigation (stoffu)
 2018-04-12 11:00:47 +02:00
Riccardo Spagni
959f6ed9a5
Merge pull request #3461 
57300491 wallet: catch exceptions dealing with ringdb and warn (moneromooo-monero)
 2018-04-12 10:57:50 +02:00
moneromooo-monero
08343abaf4
tx_pool: fix loading with colliding key images 
A key image may be present more than once if all but one of the
txes spending that key image are coming from blocks. When loading
a txpool from storage, we must load the one that's not from a
block first to avoid rejection
 2018-04-11 15:27:56 +01:00
moneromooo-monero
6a61f520e2
unit_tests: add ringdb unit tests 2018-04-11 11:43:39 +01:00
moneromooo-monero
a9cc88ee76
common: make this build with unbound 1.4.20 
Common on currently used distros
 2018-04-10 23:46:18 +01:00
moneromooo-monero
90a16b119f
crypto: fix initialization order issue with random mutex 2018-04-10 12:30:48 +01:00
cryptochangements34
372ffeba21
Add a space in mining to testnet/stagenet string 2018-04-08 00:23:59 -04:00
stoffu
0b88fff3a5
simplewallet: fix help message of sign_transfer 2018-04-07 22:51:03 +09:00
moneromooo-monero
73951cbd39
wallet2: request transactions in slices when scanning for known rings 
This avoid massive memory consumption for huge wallets
 2018-04-07 08:31:46 +01:00
moneromooo-monero
25fe67e4cf
rpc: allow getting pruned blocks from gettransactions 
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.

Also set decode_to_json to false where missing, we don't need this
either.
 2018-04-07 08:29:11 +01:00
stoffu
f82c10dc96
WalletManagerImpl: reuse existing connection to daemon instead of reconnectivng every time 2018-04-07 14:06:29 +09:00
stoffu
353e9c0c90
Core RPC: optionally add POW hash to block_header_response 2018-04-05 23:15:15 +09:00
moneromooo-monero
0b26c4d57c
wallet2: move segregation height to v7 
since people seem to really want to use things the wrong way.
 2018-04-05 12:49:38 +01:00
moneromooo-monero
6fc97c97eb
blockchain_usage: don't divide by 0 when there is nothing to process 
Coverity 184942
 2018-04-03 11:16:38 +01:00
cslashm
c77d2bfaa0 Add the possibility to export private view key for fast scan. 
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
 2018-03-31 18:00:33 +02:00
cslashm
100b7bc10d Change mutex lock model to avoid dead lock and ensure locks are always released. 
Additional cosmetic fixes:
 move 'name' as protected
 remove unnecessary local var
 Fix debug log
 2018-03-31 18:00:33 +02:00
cslashm
641dfc991f Automatic height setup when creating/restoring hw device. 
When creating/restoring wallet, if --restore-height option is not used the current estimate
height is used for starting the scan. In other words it is assume we are creating a new account.
 2018-03-31 18:00:33 +02:00
moneromooo-monero
eecfb57df9
wallet: warn if not using the default ring size 2018-03-31 15:47:02 +01:00
moneromooo-monero
aa5c2e01e7
simplewallet: warn about key reuse on startup 2018-03-31 10:52:10 +01:00
stoffu
eb59f7c563
cryptonote_tx_util: make destinations properly shuffled 2018-03-31 18:37:46 +09:00
stoffu
66a659bb03
blockchain: add scope guard to waiter for threaded txv1 verification 2018-03-30 19:22:32 +09:00
sneurlax
1e0958c083 wallet: fix default mixin (4 -> 6) 2018-03-28 09:30:11 -07:00
naughtyfox
5a96056600 WalletApi: getMultisigInfo entry for gui wallets 
WalletApi: makeMultisig call introduced

WalletApi: finalizeMultisig call introduced

WalletApi: new calls exportMultisigImages and importMultisigImages

WalletApi: method to return multisig wallet creation state

WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added

WalletApi: identation and style fixes
 2018-03-28 18:22:13 +03:00
naughtyfox
47fdb74273 Refactored: work with wallet api statuses to make setting and getting operations atomic along with error strings 
WalletApi: added method statusWithErrorString to atomically retrieve error with error string
 2018-03-28 16:11:16 +03:00
moneromooo-monero
0beb94f323
device: fix endianess dependence on subaddress secret key generation 
We now force little endianness
 2018-03-28 11:14:25 +01:00
moneromooo-monero
11c933e137
fix lambda compile error on openbsd 2018-03-27 14:48:36 +01:00
cryptochangements34
c8cb5fca5e exit if specified wallet file doesn't exist 2018-03-24 11:13:21 -04:00
Riccardo Spagni
dac3895ac1
update block hashes for checkpoints.dat 2018-03-24 08:36:10 +02:00
moneromooo-monero
1834127c82
rpc: make get_output_distribution a non-restricted RPC 
so that those nodes can still be used for sending transactions
 2018-03-23 10:56:55 +00:00
moneromooo-monero
3f5fb6fe6d
simplewallet: add --untrusted-daemon option 2018-03-22 14:20:55 +00:00
stoffu
eaa8bfe7c0
wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly 
The previous expression

    req_t.from_height = X ? Y >= Z : 0;

forces the parameter to take the value of either 0 or 1.
 2018-03-22 20:02:25 +09:00
stoffu
0a619f789b
wallet2: enable the mitigation only after the fork height 2018-03-22 20:02:14 +09:00
stoffu
5f6647934b
p2p: correct port number for seed nodes 2018-03-22 14:56:35 +09:00
stoffu
0098ed338c
wallet2: fix for loading settings of key reuse mitigation 2018-03-22 12:10:46 +09:00
cryptochangements34
ad19f8679e don't show error twice when starting simplewallet 2018-03-21 22:56:04 -04:00
moneromooo-monero
5730049178
wallet: catch exceptions dealing with ringdb and warn 2018-03-21 14:29:49 +00:00
stoffu
3b941befae
core: add get_earliest_ideal_height_for_version() 2018-03-21 01:53:24 +09:00
moneromooo-monero
a6a54fa883
blockchain: cache difficulty for next block 
Takes about 10 ms, which takes pretty much all of the get_info
RPC, which is called pretty often from wallets.

Also add a new lock so we don't need to lock the blockchain lock,
which will avoid blocking for a long time when calling the getinfo
RPC while syncing. Users of get_difficulty_for_next_block who need
the lock will have locked it already.
 2018-03-19 09:05:40 +00:00
moneromooo-monero
b1398fff40
core: fix use of uninitialised data 2018-03-18 23:37:00 +00:00
Riccardo Spagni
428fb45f68
update checkpoints 2018-03-18 16:44:36 +02:00
Riccardo Spagni
3fedd51d26
update checkpoints.dat to block 1532400 2018-03-18 16:42:20 +02:00
Riccardo Spagni
83dbc5be76
update version to 0.12 Lithium Luna 2018-03-18 16:15:50 +02:00
Riccardo Spagni
df91d7bcbd
Merge pull request #3426 
8ea3c4d5 simplewallet: new --use-english-language-names flag (moneromooo-monero)
 2018-03-18 15:58:12 +02:00
Riccardo Spagni
b8ccd47b9f
Merge pull request #3419 
1e393f4b wallet: make the segregation height settable (moneromooo-monero)
 2018-03-18 15:57:58 +02:00
moneromooo-monero
bb20f104ba
Move v7 fork to 1546000 to give more update time 2018-03-18 09:29:31 +00:00
moneromooo-monero
8ea3c4d544
simplewallet: new --use-english-language-names flag 
On some Windows systems, displaying language names in their own
languages freezes the display.
 2018-03-17 22:46:41 +00:00
moneromooo-monero
1e393f4bb7
wallet: make the segregation height settable 
via user setting first, then DNS TXT record, hardcoded fallback
 2018-03-17 14:56:31 +00:00
Riccardo Spagni
5cd36e48bf
Merge pull request #3421 
9732a37e wallet_rpc_server: add sweep_unmixable as alias for sweep_dust (moneromooo-monero)
 2018-03-17 16:52:46 +02:00
Riccardo Spagni
83651630bc
Merge pull request #3418 
20a00266 blockchain: forbid bulletproof types before v8 (moneromooo-monero)
 2018-03-17 16:51:47 +02:00
moneromooo-monero
9732a37e9a
wallet_rpc_server: add sweep_unmixable as alias for sweep_dust 2018-03-17 11:22:58 +00:00
moneromooo-monero
20a002667c
blockchain: forbid bulletproof types before v8 
They were already forbidden implicitely, but let's make that
explicit for robustness
 2018-03-16 18:18:34 +00:00
stoffu
b86f1e5dad Add command line option allowing to restrict the default sub-address lookahead in order to avoid 
so looooong time of set-up when creating a HW based wallet.
 2018-03-16 18:00:28 +01:00
Riccardo Spagni
a14eabc043
Merge pull request #3416 
6f54c910 simplewallet: fix restore height prompt that got disabled by #3175 (stoffu)
 2018-03-16 18:10:20 +02:00
Riccardo Spagni
432480fa42
Merge pull request #3414 
524cbdc1 blockchain: fix log message about per-kB fee (stoffu)
 2018-03-16 18:09:34 +02:00
Riccardo Spagni
2a9839cc3e
Merge pull request #3376 
833f9fcf show '<Not set>' for empty wallet description (cryptochangements34)
 2018-03-16 18:08:52 +02:00
Riccardo Spagni
0f27fc57ac
Merge pull request #3336 
57c0b1ed Fix typos in various files (Dimitris Apostolou)
 2018-03-16 18:08:07 +02:00
moneromooo-monero
eac3a11ed3
wallet: more user friendly print_ring 
It can now take a txid (to display rings for all its inputs),
and will print rings in a format that set_ring understands
 2018-03-16 12:07:45 +00:00
moneromooo-monero
798535149d
wallet2_api: add key reuse mitigations API 2018-03-16 12:07:42 +00:00
moneromooo-monero
b057a21d56
wallet2_api: add ring api 2018-03-16 10:33:05 +00:00
moneromooo-monero
d32ef7b0f2
ringdb: factor ring addition code 2018-03-16 10:33:02 +00:00
moneromooo-monero
a7da8208f5
wallet2_api: add blackball api 2018-03-16 10:32:59 +00:00
moneromooo-monero
504428ab4a
ringdb: use the genesis block as a db name 
This will avoid careless forkers polluting the shared database
even if they make their own chain. They'll then automatically
start using another subdb, and any key-reusing fork of those
forks will reuse their subdbs.
 2018-03-16 10:32:54 +00:00
moneromooo-monero
b09e5181cc
wallet: add a set_ring command 
This is so one can set rings for spent key images in case the
attackers don't merge the ring matching patch set.
 2018-03-16 10:32:51 +00:00
moneromooo-monero
0590f62ab6
new blockchain_usage tool, reports on output usage 2018-03-16 10:32:46 +00:00
moneromooo-monero
db10dd6d83
wallet: make ringdb an object with database state 2018-03-16 10:32:42 +00:00
moneromooo-monero
df6fad4c62
blockchain_utilities: new blockchain_blackball tool 
It scans for known spent outputs and stores their public keys
in a database which can then be read by the wallet, which can
then avoid using those as fake outs in new transactions.

Usage: monero-blockchain-blackball db1 db2...

This uses the shared database in ~/.shared-ringdb
 2018-03-16 10:32:39 +00:00
moneromooo-monero
d29ea0455a
wallet: add an output blackball list to avoid using those in rings 2018-03-16 10:32:37 +00:00
moneromooo-monero
18eaf19489
wallet: key reuse mitigation options 
If a pre-fork output is spent on both Monero and attack chain,
any post-fork output can be deduced to be a fake output, thereby
decreasing the effective ring size.

The segregate-per-fork-outputs option, on by default, allows
selecting only pre-fork outputs in this case, so that the same
ring can be used when spending it on the other side, which does
not decrease the effective ring size.

This is intended to be SET when intending to spend Monero on the
attack fork, and to be UNSET if not intending to spend Monero
on the attack fork (since it leaks the fact that the output being
spent is pre-fork).

If the user is not certain yet whether they will spend pre-fork
outputs on a key reusing fork, the key-reuse-mitigation2 option
should be SET instead.

If you use this option and intend to spend Monero on both forks,
then spend real Monero first.
 2018-03-16 10:32:34 +00:00
moneromooo-monero
5f146873c5
wallet: add shared ring database 
This maps key images to rings, so that different forks can reuse
the rings by key image. This avoids revealing the real inputs like
would happen if two forks spent the same outputs with different
rings. This database is meant to be shared with all Monero forks
which don't bother making a new chain, putting users' privacy at
risk in the process. It is placed in a shared data directory by
default ($HOME/.shared-ringdb on UNIX like systems). You may
use --shared-ringdb-dir to override this location, and should
then do so for all Monero forks for them to share the database.
 2018-03-16 10:32:29 +00:00
moneromooo-monero
41f727ce42
add RPC to get a histogram of outputs of a given amount 2018-03-16 10:32:26 +00:00
cryptochangements34
833f9fcfe9 show '<Not set>' for empty wallet description 2018-03-15 23:22:45 -04:00
stoffu
6f54c910f7
simplewallet: fix restore height prompt that got disabled by #3175 2018-03-16 11:55:31 +09:00
stoffu
524cbdc1e2
blockchain: fix log message about per-kB fee 2018-03-16 10:43:19 +09:00
Dimitris Apostolou
57c0b1ed9f Fix typos in various files 2018-03-15 18:25:38 +02:00
Riccardo Spagni
51bb7fafac
Merge pull request #3410 
c5024c5b simplewallet: add a warning when getting a daemon error in transfer (moneromooo-monero)
 2018-03-15 17:10:01 +02:00
Riccardo Spagni
60af9d689b
Merge pull request #3408 
e1b526b3 Remove the `Blockchain::get_all_known_block_ids` function. (Jean Pierre Dudey)
 2018-03-15 17:09:13 +02:00
moneromooo-monero
c5024c5b73
simplewallet: add a warning when getting a daemon error in transfer 
A malicious daemon (or MITM) could attempt to add spurious errors
so the wallet tries again, sending another set of fake outs.
 2018-03-15 13:33:19 +00:00
stoffu
a7266d6d7b
wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate calls to wallet2 2018-03-15 22:01:51 +09:00
Jean Pierre Dudey
e1b526b371 Remove the Blockchain::get_all_known_block_ids function. 
This function isn't used in the codebase.

Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
 2018-03-14 21:56:19 -04:00
Leon Klingele
80d2f8007c
wallet2: Update function parameter documentation 
This completes and fixes various parameters docs
 2018-03-14 16:41:24 +01:00
stoffu
71d186566e
replace invoke_http_json("/json_rpc",...) with invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate 2018-03-14 23:23:59 +09:00
Riccardo Spagni
a69c713f8e
Merge pull request #3398 
c577abab wallet: fix auto low priority so that it takes effect only when saved default is 0 (stoffu)
 2018-03-14 16:18:15 +02:00
Riccardo Spagni
2fe1504c03
Merge pull request #3399 
1d39b265 wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet (stoffu)
 2018-03-14 16:17:59 +02:00
Riccardo Spagni
f9f2d182da
Merge pull request #3395 
523371c0 p2p: fix network ID being uninitialised when using exclusive peers (moneromooo-monero)
 2018-03-14 16:10:42 +02:00
Riccardo Spagni
8b90e3141a
Merge pull request #3386 
9abeff59 wallet2: handle no blocks returned in refresh to mean no new blocks (moneromooo-monero)
 2018-03-14 16:10:00 +02:00
Riccardo Spagni
7a44301675
Merge pull request #3385 
ec41006c node_rpc_proxy: fix target height caching (moneromooo-monero)
 2018-03-14 16:09:40 +02:00
Riccardo Spagni
534369eece
Merge pull request #3384 
b63ea060 simplewallet: do not call a RPC when displaying the prompt (moneromooo-monero)
 2018-03-14 16:08:14 +02:00
Riccardo Spagni
cb72b85bbf
Merge pull request #3372 
c3e23b2d ringct: 17% improvement in Borromean signature verification (moneromooo-monero)
 2018-03-14 16:06:16 +02:00
stoffu
4405e4fc73
wallet2: check_tx_key() shouldn't require hardware encryption 2018-03-14 21:00:18 +09:00
stoffu
7dfa5e9e6e
chacha: call prehashed version explicitly as generate_chacha_key_prehashed 
hash: add prehashed version cn_slow_hash_prehashed
slow-hash: let cn_slow_hash take 4th parameter for deciding prehashed or not
slow-hash: add support for prehashed version for the other 3 platforms
 2018-03-14 21:00:17 +09:00
stoffu
b2d23b189e
crypto: revert odd namespace changes made in #3303 2018-03-14 21:00:17 +09:00
stoffu
8705beaf51
keypair::generate: always require hw::device to avoid possible mistake 2018-03-14 21:00:16 +09:00
stoffu
27a196b126
device: untangle cyclic depenency 
When #3303 was merged, a cyclic dependency chain was generated:

    libdevice <- libcncrypto <- libringct <- libdevice

This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:

    libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct

This eliminates the need for crypto_device.cpp and rctOps_device.cpp.

Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
 2018-03-14 21:00:15 +09:00
stoffu
c9b38b4765
device: made function prototypes consistent with pre-#3303 codebase 2018-03-14 21:00:06 +09:00
Riccardo Spagni
f2e8e8d23c
Merge pull request #3377 
aa8bef0c fix error message typo in wallet2.cpp (cryptochangements34)
 2018-03-14 13:38:50 +02:00
Riccardo Spagni
9a63fbcf83
Merge pull request #3371 
84decbea core: add v7 for 1539500 on mainnet (moneromooo-monero)
 2018-03-14 13:37:25 +02:00
Riccardo Spagni
3bc2537f5a
Merge pull request #3369 
1979d53d wallet: fixes and tweaks to the save_watch_only command (moneromooo-monero)
 2018-03-14 13:37:14 +02:00
Riccardo Spagni
0f2d6d40b4
Merge pull request #3360 
1ff35fda Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable) (stoffu)
 2018-03-14 13:37:00 +02:00
Riccardo Spagni
2e074e2ae7
Merge pull request #3358 
978663d4 Stagenet: successive forks up to v7 (stoffu)
 2018-03-14 13:36:47 +02:00
Riccardo Spagni
117cf12509
Merge pull request #3355 
0bbd521f libwallet_merged: added missing libdevice (stoffu)
 2018-03-14 13:36:36 +02:00
Riccardo Spagni
33158f089d
Merge pull request #3354 
ffe70b8f Make mixin optional with default for rpc transfer (cryptochangements34)
 2018-03-14 13:36:25 +02:00
Riccardo Spagni
2dfb4f098e
Merge pull request #3353 
73dd883d Ledger HW Bug fixes (Cédric)
 2018-03-14 13:36:14 +02:00
Riccardo Spagni
cfc5a3d4d4
Merge pull request #3345 
e0cda74a wallet2_api: add info/error/warning entry points (moneromooo-monero)
 2018-03-14 13:35:53 +02:00
Riccardo Spagni
67978b78ce
Merge pull request #3337 
91d97dd4 fuzz_tests: set small subaddress lookahead for speed (moneromooo-monero)
5f85cc7e wallet2: guard against overflowing of subaddress indices (moneromooo-monero)
 2018-03-14 13:35:41 +02:00
Riccardo Spagni
3fed788603
Merge pull request #3315 
649a1b7a wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets (Leon Klingele)
 2018-03-14 13:35:11 +02:00
moneromooo-monero
5f85cc7e3d
wallet2: guard against overflowing of subaddress indices 2018-03-14 11:34:06 +00:00
stoffu
1d39b26556
wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet 2018-03-14 19:02:21 +09:00
stoffu
c577abab61
wallet: fix auto low priority so that it takes effect only when saved default is 0 2018-03-14 18:33:43 +09:00
moneromooo-monero
523371c042
p2p: fix network ID being uninitialised when using exclusive peers 2018-03-13 11:20:49 +00:00
Cédric
73dd883d51 Ledger HW Bug fixes 
Fix the way the REAL mode is handle:
  Let create_transactions_2 and create_transactions_from construct the vector of transactions.
  Then iterate on it and resign.
  We just need to add 'outs' list in the TX struct for that.

Fix default secret keys value when DEBUG_HWDEVICE mode is off
  The magic value (00...00 for view key and FF..FF for spend key) was not correctly set
  when DEBUG_HWDEVICE was off. Both was set to 00...00.

Add sub-address info in ABP map in order to correctly display destination sub-address on device

Fix DEBUG_HWDEVICE mode:
   - Fix compilation errors.
   - Fix control device init in ledger device.
   - Add more log.

Fix sub addr control

Fix debug Info
 2018-03-12 10:43:06 +01:00
moneromooo-monero
9abeff5911
wallet2: handle no blocks returned in refresh to mean no new blocks 
This is not a possible return from the daemon, but I want this in
now so all wallets handle this when the daemon starts doing so.
 2018-03-11 21:16:15 +00:00
moneromooo-monero
ec41006cad
node_rpc_proxy: fix target height caching 2018-03-11 13:11:49 +00:00
moneromooo-monero
b63ea060de
simplewallet: do not call a RPC when displaying the prompt 
Speeds up refresh when you have a lot of in/out transactions
 2018-03-11 10:23:45 +00:00
Leon Klingele
649a1b7ae6
wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets 
Previously, a file containing the unencrypted Monero address was
created by default in the wallet's directory. This file might pose
as a privacy risk. The creation of this file is now opt-in and can
be enabled by providing

    --create-address-file
 2018-03-10 16:28:23 +01:00
cryptochangements34
aa8bef0cb3 fix error message typo in wallet2.cpp 2018-03-09 17:22:26 -05:00
stoffu
978663d461
Stagenet: successive forks up to v7 2018-03-09 13:59:11 +09:00
Riccardo Spagni
e9f41e405f
Merge pull request #3368 
38657fd0 Bump min ring size from 5 to 7 from v7 (moneromooo-monero)
 2018-03-08 18:47:41 +02:00
Riccardo Spagni
546e380cab
Merge pull request #3370 
04a0cc89 slow-hash: fix uint64 type typo (moneromooo-monero)
 2018-03-08 18:44:47 +02:00
Riccardo Spagni
3a12f2588a
Merge pull request #3365 
55a65f32 Wallet API: corrected testnet/mainnet ordering (stoffu)
 2018-03-08 18:44:18 +02:00
Riccardo Spagni
f4cf613e34
Merge pull request #3362 
49c70962 device: remove dependency on readline (stoffu)
 2018-03-08 18:43:37 +02:00
Riccardo Spagni
220cb62ca4
Merge pull request #3357 
557a6fb6 cn_deserialize: link with device and ringct (moneromooo-monero)
 2018-03-08 18:43:20 +02:00
Riccardo Spagni
60c8544e77
Merge pull request #3347 
9a6be3da wallet_manager: fixed typo deviuce/device.hpp (stoffu)
 2018-03-08 18:42:24 +02:00
moneromooo-monero
c3e23b2dce
ringct: 17% improvement in Borromean signature verification 2018-03-08 00:41:54 +00:00
moneromooo-monero
84decbea48
core: add v7 for 1539500 on mainnet 2018-03-07 17:19:50 +00:00
moneromooo-monero
1979d53d78
wallet: fixes and tweaks to the save_watch_only command 
- save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly
- catch any exception (eg, I/O errors) and error out
- print the new keys filename in simplewallet
 2018-03-07 14:24:14 +00:00
moneromooo-monero
38657fd0e9
Bump min ring size from 5 to 7 from v7 2018-03-07 13:19:04 +00:00
moneromooo-monero
04a0cc89cf
slow-hash: fix uint64 type typo 2018-03-07 09:48:58 +00:00
stoffu
55a65f3269
Wallet API: corrected testnet/mainnet ordering 2018-03-07 13:56:17 +09:00
stoffu
49c70962ee
device: remove dependency on readline 2018-03-07 07:42:28 +09:00
stoffu
1ff35fda7c
Wallet API: make nettype non-defaulted to disambiguate from deprecated versions (and make libwallet_api_tests compilable) 2018-03-06 21:14:52 +09:00
moneromooo-monero
557a6fb6ea
cn_deserialize: link with device and ringct 2018-03-05 20:52:18 +00:00
Lee Clagett
e136bc6b8a
tweaks to the monerov1 cryptonight algorithm 2018-03-05 18:18:45 +00:00
SChernykh
d58c9ec99c
slow-hash: optimized version 2018-03-05 18:18:43 +00:00
moneromooo-monero
608fd6f14a
Monero Cryptonight variants, and add one for v7 
This is the first variant of many, with the intent to improve
Monero's resistance to ASICs and encourage mining decentralization.
 2018-03-05 18:18:39 +00:00
stoffu
0bbd521fa2
libwallet_merged: added missing libdevice 2018-03-06 02:36:37 +09:00
cryptochangements34
ffe70b8f61
Make mixin optional with default for rpc transfer 2018-03-05 12:27:22 -05:00
Riccardo Spagni
a21c927d7d
Merge pull request #3298 
f2bb8085 Fix #3297 use the password_prompter helper (Howard Chu)
 2018-03-05 19:17:51 +02:00
Riccardo Spagni
0c2b25204e
Merge pull request #3312 
399120dd simplewallet: set seed language when restoring from english-old seed (stoffu)
 2018-03-05 19:16:52 +02:00
Riccardo Spagni
237f0179b7
Merge pull request #3313 
43026822 Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows (rbrunner7)
 2018-03-05 19:15:54 +02:00
Riccardo Spagni
baf640887d
Merge pull request #3343 
3d452367 allow using ring size instead of mixin for rpc transfer (cryptochangements34)
 2018-03-05 19:14:03 +02:00
Riccardo Spagni
98acbe83fc
Merge pull request #3348 
c95dddd2 remove unused function keyImageV (h908714124)
 2018-03-05 19:13:52 +02:00
Riccardo Spagni
05f0762dc5
Merge pull request #3346 
25ea307d Fix invalid device unique_ptr cast (MoroccanMalinois)
 2018-03-05 19:13:40 +02:00
Riccardo Spagni
9841a452e5
Merge pull request #3338 
51219457 core: fix sending to the source address with a short payment id (moneromooo-monero)
 2018-03-05 19:13:28 +02:00
Riccardo Spagni
61ac5b0471
Merge pull request #3332 
6b40ea93 simplewallet: fix print_ring_members printing wrong heights (moneromooo-monero)
 2018-03-05 19:12:59 +02:00
Riccardo Spagni
5b25cbb5a7
Merge pull request #3314 
71bff546 wallet api: when restoring from EnglishOld, set language to English (stoffu)
 2018-03-05 19:12:24 +02:00
Riccardo Spagni
abcdb7b5c4
Merge pull request #3308 
6f8779d2 blockchain: fix random sync failures (moneromooo-monero)
 2018-03-05 19:12:05 +02:00
Riccardo Spagni
0e5c006207
Merge pull request #3307 
223d7d0c db_lmdb: fix free space reporting (moneromooo-monero)
 2018-03-05 19:11:52 +02:00
Riccardo Spagni
5950d356b6
Merge pull request #3301 
34a2a085 rctSigs - loop invariant code removed from the loop (Dusan Klinec)
 2018-03-05 19:11:35 +02:00
Riccardo Spagni
4f93f74528
Merge pull request #3277 
0e7ad2e2 Wallet API: generalize 'bool testnet' to 'NetworkType nettype' (stoffu)
af773211 Stagenet (stoffu)
cc9a0bee command_line: allow args to depend on more than one args (stoffu)
55f8d917 command_line::get_arg: remove 'required' for dependent args as they're always optional (stoffu)
450306a0 command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 (stoffu)
9f9e095a Use `genesis_tx` parameter in `generate_genesis_block`. #3261 (Jean Pierre Dudey)
 2018-03-05 19:11:20 +02:00
Riccardo Spagni
033ead4bad
Merge pull request #3273 
f3b74e75 Fix refresh height estimation (Howard Chu)
 2018-03-05 19:11:07 +02:00
Riccardo Spagni
b54587d7b3
Merge pull request #3259 
6d900a40 removed systemd private tempdir (ston1th)
496055d1 monerod: do not log to tmpdir in daemon mode (ston1th)
 2018-03-05 19:10:51 +02:00
Edward Betts
fbcc91c2a4 Correct spelling mistakes. 2018-03-05 17:00:40 +00:00
cryptochangements34
3d452367b0 allow using ring size instead of mixin for rpc transfer 2018-03-05 10:10:35 -05:00
stoffu
0e7ad2e2c9
Wallet API: generalize 'bool testnet' to 'NetworkType nettype' 2018-03-05 23:59:16 +09:00
h908714124
c95dddd2d2 remove unused function keyImageV 2018-03-05 09:21:44 +01:00
stoffu
9a6be3da25
wallet_manager: fixed typo deviuce/device.hpp 2018-03-05 11:57:30 +09:00
stoffu
af773211cb
Stagenet 2018-03-05 11:55:05 +09:00
stoffu
cc9a0bee04
command_line: allow args to depend on more than one args 2018-03-05 11:19:08 +09:00
stoffu
55f8d917fd
command_line::get_arg: remove 'required' for dependent args as they're always optional 2018-03-05 11:19:06 +09:00
stoffu
450306a01c
command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 2018-03-05 11:19:04 +09:00
Jean Pierre Dudey
9f9e095a8c
Use genesis_tx parameter in generate_genesis_block. #3261 
* src/cryptnote_config.h: The constant `config::testnet::GENESIS_TX` was
changed to be the same as `config::GENESIS_TX` (the mainnet's transaction)
because the mainnet's transaction was being used for both networks.

* src/cryptonote_core/cryptonote_tx_utils.cpp: The `generate_genesis_block` function
was ignoring the  `genesis_tx` parameter, and instead it was using the `config::GENESIS_TX`
constant. That's why the testnet genesis transaction was changed. Also five lines of unused
code were removed.

Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
 2018-03-05 11:19:01 +09:00
MoroccanMalinois
25ea307d67
Fix invalid device unique_ptr cast 2018-03-04 18:56:48 +00:00
moneromooo-monero
e0cda74ace
wallet2_api: add info/error/warning entry points 2018-03-04 18:07:30 +00:00
cslashm
e745c1e38d Code modifications to integrate Ledger HW device into monero-wallet-cli. 
The basic approach it to delegate all sensitive data (master key, secret
ephemeral key, key derivation, ....) and related operations to the device.
As device has low memory, it does not keep itself the values
(except for view/spend keys) but once computed there are encrypted (with AES
are equivalent) and return back to monero-wallet-cli. When they need to be
manipulated by the device, they are decrypted on receive.

Moreover, using the client for storing the value in encrypted form limits
the modification in the client code. Those values are transfered from one
C-structure to another one as previously.

The code modification has been done with the wishes to be open to any
other hardware wallet. To achieve that a C++ class hw::Device has been
introduced. Two initial implementations are provided: the "default", which
remaps all calls to initial Monero code, and  the "Ledger", which delegates
all calls to Ledger device.
 2018-03-04 12:54:53 +01:00
moneromooo-monero
51219457b1
core: fix sending to the source address with a short payment id 
It would fail to send, thinking it needs a destination address,
since the destination matches the change address in this case.
 2018-03-02 23:27:57 +00:00
moneromooo-monero
6b40ea937a
simplewallet: fix print_ring_members printing wrong heights 
And also use uint64_t instead of int for heights where appropriate
 2018-03-02 00:25:16 +00:00
stoffu
71bff546d3
wallet api: when restoring from EnglishOld, set language to English 2018-02-25 22:04:36 +09:00
rbrunner7
430268224d Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows 2018-02-25 12:57:58 +01:00
stoffu
399120ddad
simplewallet: set seed language when restoring from english-old seed 2018-02-25 12:44:10 +09:00
ston1th
496055d128 monerod: do not log to tmpdir in daemon mode 
The logging to /tmp/bitmonero.daemon.stdout.stderr caused segfaults
if the /tmp mount was full (#2851).
Now the daemon is only logging to /tmp/bitmonero.daemon.stdout.stderr
in the debug builds.
 2018-02-23 21:27:14 +01:00
moneromooo-monero
6f8779d282
blockchain: fix random sync failures 
When a block is added as part of a chunk (when syncing historical
blocks), a block may end up already in the blockchain if it was
added to the queue before being added to the chain (though it's
not clear how that could happen, but it's an implementation detail)
and thus may not be added to the chain when add_block is called.
This would cause m_blocks_txs_check to not be cleared, causing it
to get out of sync at next call, and thus wrongfully reject the
next block.
 2018-02-23 19:47:17 +00:00
moneromooo-monero
223d7d0c7a
db_lmdb: fix free space reporting 
reported by Brad Richards
 2018-02-23 09:06:10 +00:00
Dusan Klinec
34a2a08530 rctSigs - loop invariant code removed from the loop 2018-02-21 16:35:06 +01:00
Riccardo Spagni
2ac3da1251
Merge pull request #3256 
df5273de wallet2: fix auto_low_priority field name typo on load (moneromooo-monero)
 2018-02-20 17:53:38 +02:00
Riccardo Spagni
0d530bd04e
Merge pull request #3295 
6514f0ed db_lmdb: fix return code mixup in for_all_* (moneromooo-monero)
 2018-02-20 17:49:16 +02:00
Riccardo Spagni
46903ec26a
Merge pull request #3294 
fd57e13a simplewallet: typo in generate-from-multisig-keys (stoffu)
 2018-02-20 17:49:05 +02:00
Riccardo Spagni
21335e5c6b
Merge pull request #3293 
4a78a99f cryptonote_core: change wording of fork warning message (moneromooo-monero)
 2018-02-20 17:48:54 +02:00
Riccardo Spagni
299af8e43e
Merge pull request #3290 
1d28c0d8 p2p: restore m_testnet assignment lost during rebase (whythat)
 2018-02-20 17:48:29 +02:00
Riccardo Spagni
ea9ddcac7f
Merge pull request #3288 
10f78f63 p2p: need libcryptonote_core due to arg_testnet_on being used (stoffu)
 2018-02-20 17:48:05 +02:00
Riccardo Spagni
fc57e0ef2d
Merge pull request #3263 
d4e728c9 simplewallet: reword donate command message for clarity (Serhack)
 2018-02-20 17:47:42 +02:00
Riccardo Spagni
c9aa9370f9
Merge pull request #3260 
b2d4bb9b Remove `voting_version` parameter documentation. (Jean Pierre Dudey)
 2018-02-20 17:47:31 +02:00
Riccardo Spagni
4e9de94565
Merge pull request #3257 
da25757b simplewallet: do nothing in on_skip_transaction (wallet2 already logs warnings) (stoffu)
 2018-02-20 17:47:20 +02:00
Riccardo Spagni
ff36fd93fd
Merge pull request #3255 
3962bcb2 Closes #2886: really ignore battery checking (Timothy D. Prime)
 2018-02-20 17:47:03 +02:00
Riccardo Spagni
cfa3af4078
Merge pull request #3247 
89ad162a wallet2: remove unused m_subaddresses_inv (moneromooo-monero)
f2c4c399 wallet2: speed up subaddress generation (by about a third) (moneromooo-monero)
 2018-02-20 17:46:40 +02:00
Riccardo Spagni
6920fdaf4f
Merge pull request #3246 
3c33e131 wallet2: don't store invalid key image when watch-only (stoffu)
0133b348 wallet2: don't throw when spent amount is inconsistent (stoffu)
 2018-02-20 17:46:29 +02:00
Riccardo Spagni
0fc5eec9cd
Merge pull request #3235 
6866ed46 Add default value to max_height, otherwise it's 0 (Michał Sałaban)
 2018-02-20 17:46:00 +02:00
Howard Chu
f2bb8085ec
Fix #3297 use the password_prompter helper 2018-02-20 02:25:20 +00:00
moneromooo-monero
6514f0ed7b
db_lmdb: fix return code mixup in for_all_* 2018-02-19 14:55:58 +00:00
stoffu
fd57e13a84
simplewallet: typo in generate-from-multisig-keys 2018-02-19 09:51:30 +09:00
moneromooo-monero
4a78a99f96
cryptonote_core: change wording of fork warning message 
An udpate may or may not be available now, but should be soon if not.
This will prevent too many people freaking out.
 2018-02-18 23:44:59 +00:00
whythat
1d28c0d8a9 p2p: restore m_testnet assignment lost during rebase 2018-02-18 17:09:39 +02:00
stoffu
10f78f63f1
p2p: need libcryptonote_core due to arg_testnet_on being used 2018-02-18 16:40:43 +09:00
Riccardo Spagni
8154df778a
Merge pull request #3276 
ed6c68db crypto: add missing include (WIN32) (iDunk5400)
 2018-02-17 21:48:59 +01:00
Riccardo Spagni
5a8e7fd0e5
Merge pull request #3249 
a4b50a6f handle ^D and ^C while password prompting (Jethro Grassie)
 2018-02-17 21:48:30 +01:00
Riccardo Spagni
6198c816b1
Merge pull request #3170 
b3b2d4d2 options: add testnet option dependencies (whythat)
c5f55bb4 common: implement dynamic option dependencies mechanism (whythat)
05a12ccc options: remove testnet-* options (whythat)
c33cb60e common: implement dependent option descriptor (whythat)
 2018-02-17 11:51:57 +01:00
Riccardo Spagni
a2cbedd29f
Merge pull request #3191 
3607d467 core: add --no-fluffy-blocks, and enable fluffy blocks by default (moneromooo-monero)
 2018-02-17 11:48:31 +01:00
whythat
b3b2d4d20c options: add testnet option dependencies 2018-02-16 22:32:01 +02:00
whythat
c5f55bb4c0 common: implement dynamic option dependencies mechanism 2018-02-16 22:32:01 +02:00
whythat
05a12ccc2d options: remove testnet-* options 2018-02-16 22:32:01 +02:00
iDunk5400
ed6c68db1b
crypto: add missing include (WIN32) 2018-02-16 19:35:31 +01:00
moneromooo-monero
89ad162a3f
wallet2: remove unused m_subaddresses_inv 2018-02-16 17:13:09 +00:00
moneromooo-monero
f2c4c39971
wallet2: speed up subaddress generation (by about a third) 2018-02-16 17:13:06 +00:00
Leon Klingele
7c1a607c40
txpool: Don't bail out when blob_size == tx_size_limit 
Previously, when blob_size == tx_size_limit, the "m_too_big" property was set
and the transaction was rejected. This should not have been the case.
 2018-02-16 16:27:08 +01:00
whythat
c33cb60eb6 common: implement dependent option descriptor 2018-02-16 16:44:40 +02:00
Howard Chu
f3b74e75b0
Fix refresh height estimation 
Since commit b0426d4c refresh height for a newly created wallet
connected to a sync'd daemon was off by a month. Now we only use
the 1 month safety margin if we're unable to talk to a daemon.
 2018-02-16 14:17:36 +00:00
moneromooo-monero
3607d467f3
core: add --no-fluffy-blocks, and enable fluffy blocks by default 2018-02-16 13:46:46 +00:00
Riccardo Spagni
ef91d6e61e
Merge pull request #3196 
eda9fb5b p2p: fix testnet/mainnet port mixup (moneromooo-monero)
 2018-02-16 14:31:16 +01:00
Riccardo Spagni
6b1382b6b6
Merge pull request #3199 
30ce8c59 cn_deserialize: check for raw tx_extra (moneromooo-monero)
 2018-02-16 14:29:51 +01:00
Riccardo Spagni
f4a6bc79d9
Merge pull request #3226 
e4646379 keccak: fix mdlen bounds sanity checking (moneromooo-monero)
2e3e90ac pass large parameters by const ref, not value (moneromooo-monero)
61defd89 blockchain: sanity check number of precomputed hash of hash blocks (moneromooo-monero)
9af6b2d1 ringct: fix infinite loop in unused h2b function (moneromooo-monero)
8cea8d0c simplewallet: double check a new multisig wallet is multisig (moneromooo-monero)
9b98a6ac threadpool: catch exceptions in dtor, to avoid terminate (moneromooo-monero)
24803ed9 blockchain_export: fix buffer overflow in exporter (moneromooo-monero)
f3f7da62 perf_timer: rewrite to make it clear there is no division by zero (moneromooo-monero)
c6ea3df0 performance_tests: remove add_arg call stray extra param (moneromooo-monero)
fa6b4566 fuzz_tests: fix an uninitialized var in setup (moneromooo-monero)
03887f11 keccak: fix sanity check bounds test (moneromooo-monero)
ad11db91 blockchain_db: initialize m_open in base class ctor (moneromooo-monero)
bece67f9 miner: restore std::cout precision after modification (moneromooo-monero)
1aabd14c db_lmdb: check hard fork info drop succeeded (moneromooo-monero)
 2018-02-16 14:26:58 +01:00
Riccardo Spagni
24d8f9237f
Merge pull request #3248 
d6a0ae96 blockchain: don't try to use hash check array after it's freed (moneromooo-monero)
 2018-02-16 14:24:22 +01:00
Riccardo Spagni
853dd2d4f7
Merge pull request #3232 
b81e276c connection_context: initialize m_last_request_time to current time (moneromooo-monero)
 2018-02-16 14:24:12 +01:00
Riccardo Spagni
260d666cf4
Merge pull request #3231 
84a8b2da Don't create readtxn until after txn_safe gate check (Howard Chu)
 2018-02-16 14:24:01 +01:00
Riccardo Spagni
ef47ba95c8
Merge pull request #3229 
928c1825 cryptonote_protocol: guard against all threads in standby (moneromooo-monero)
 2018-02-16 14:23:53 +01:00
Riccardo Spagni
b5b88c2747
Merge pull request #3225 
71806327 dns: change default DNS to a worldwide selection (moneromooo-monero)
 2018-02-16 14:23:34 +01:00
Riccardo Spagni
a54247b993
Merge pull request #3221 
2e584dcb p2p: do not try to connect to peers in offline mode (moneromooo-monero)
 2018-02-16 14:23:22 +01:00
Riccardo Spagni
0c71197892
Merge pull request #3217 
fde4489e wipeable_string: call memwipe directly (moneromooo-monero)
 2018-02-16 14:23:08 +01:00
Riccardo Spagni
9c4428e583
Merge pull request #3214 
214d251c wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown (stoffu)
 2018-02-16 14:22:41 +01:00
Riccardo Spagni
bfddb2283b
Merge pull request #3210 
39992134 txpool: Properly bail out when outputs_amount == inputs_amount (Leon Klingele)
 2018-02-16 14:22:10 +01:00
Riccardo Spagni
9681a885d1
Merge pull request #3207 
a99ef176 wallet-rpc: take subaddress account as arg for get_transfer_by_txid (stoffu)
77125096 wallet-rpc: rename *_INDEX_OUTOFBOUND into *_INDEX_OUT_OF_BOUNDS (stoffu)
 2018-02-16 14:21:59 +01:00
Riccardo Spagni
079eea7b70
Merge pull request #3205 
bc61ae69 tx_pool: add a max pool size, settable with --max-txpool-size (moneromooo-monero)
3b4e6b35 txpool: increase unmined tx expiry to three days (moneromooo-monero)
 2018-02-16 14:21:50 +01:00
Riccardo Spagni
b23578e473
Merge pull request #3197 
f90c76be Return appropriate error code when there's no connection to daemon (Michał Sałaban)
3cb65b3f Return appropriate error code when not enough money for tx (Michał Sałaban)
 2018-02-16 14:21:00 +01:00
Riccardo Spagni
666a76652b
Merge pull request #3187 
851bd057 call _exit instead of abort in release mode (moneromooo-monero)
 2018-02-16 14:20:31 +01:00
Riccardo Spagni
bdf0339dda
Merge pull request #3181 
e3f0980a daemon: don't drop RPC with busy error when running offline (moneromooo-monero)
 2018-02-16 14:19:54 +01:00
Riccardo Spagni
ba22928d4b
Merge pull request #3180 
1dfed567 Fixed #if instead of #ifdef (Matt Little)
7c442453 Support building cncrypto lib with msvc (Matt Little)
 2018-02-16 14:19:42 +01:00
Riccardo Spagni
82599ef0e3
Merge pull request #3175 
3be98036 wallet-cli: Do not ask for scan_from_height if it explicitly is set to zero. (Maximilian Lupke)
 2018-02-16 14:19:24 +01:00
Riccardo Spagni
a43be404c7
Merge pull request #3171 
402c9eef cryptonote_tx_utils: fixed logic bug in get_destination_view_key_pub (stoffu)
 2018-02-16 14:19:10 +01:00
Riccardo Spagni
04a676397f
Merge pull request #3165 
7539603f Bootstrap daemon (stoffu)
 2018-02-16 14:18:50 +01:00
Riccardo Spagni
381faf06c7
Merge pull request #3163 
628b78ae Fix in_peers/out_peers RPC operations (Erik de Castro Lopo)
ece9bcf5 rpc_client: Fix error handling (Erik de Castro Lopo)
8f30350d Fix method name in invoke_http_json_rpc (Erik de Castro Lopo)
32c0f908 Allow the number of incoming connections to be limited (Erik de Castro Lopo)
d609a2c1 Rename delete_connections to delete_out_connections (Erik de Castro Lopo)
b927c0fc Rename connections_count to max_out_connection_count (Erik de Castro Lopo)
 2018-02-16 14:18:38 +01:00
Riccardo Spagni
0bffd2ec64
Merge pull request #3161 
78a2e15b daemon: exit with 0 when successful (moneromooo-monero)
 2018-02-16 14:18:29 +01:00
Riccardo Spagni
5d36ed6613
Merge pull request #3094 
a85dbb3f Fixed typos and wording tweaks (Maxithi)
 2018-02-16 14:17:46 +01:00
stoffu
da25757b42
simplewallet: do nothing in on_skip_transaction (wallet2 already logs warnings) 2018-02-15 17:20:39 +09:00
Serhack
d4e728c995 simplewallet: reword donate command message for clarity 2018-02-14 08:28:22 -05:00
Riccardo Spagni
370b43d12b
Merge pull request #3138 
19ff243f wallets: reorg 61 more days on testnet (moneromooo-monero)
c70f03ca blockchain: move bulletproofs to v8 (moneromooo-monero)
 2018-02-14 12:49:57 +01:00
Riccardo Spagni
589a53f479
Merge pull request #2959 
3f1a3fac bulletproofs: more robust challenge computation (moneromooo-monero)
 2018-02-14 12:08:52 +01:00
Jean Pierre Dudey
b2d4bb9b64 Remove voting_version parameter documentation. 
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
 2018-02-13 15:04:12 -04:00
moneromooo-monero
df5273def5
wallet2: fix auto_low_priority field name typo on load 2018-02-13 00:33:55 +00:00
Timothy D. Prime
3962bcb2a2 Closes #2886: really ignore battery checking 
Move option test first.
 2018-02-12 10:29:22 -08:00
stoffu
3c33e1317b
wallet2: don't store invalid key image when watch-only 2018-02-12 20:36:15 +09:00
Jethro Grassie
a4b50a6f51
handle ^D and ^C while password prompting 2018-02-10 18:29:49 -05:00
moneromooo-monero
d6a0ae96c6
blockchain: don't try to use hash check array after it's freed 
It's freed when we've synced past its end, but we might still
find an old chain somewhere
 2018-02-10 11:26:06 +00:00
stoffu
0133b3481a
wallet2: don't throw when spent amount is inconsistent 2018-02-10 12:59:25 +09:00
moneromooo-monero
71806327f5
dns: change default DNS to a worldwide selection 
DNSSEC aware servers picked from https://wiki.ipfire.org/dns/public-servers
 2018-02-08 09:46:16 +00:00
stoffu
214d251c48
wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown 2018-02-08 08:02:12 +09:00