nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

unit_tests: use std::shared_ptr to shut coverity up about leaks

Browse Source 
Coverity 188436, 188433, 188428, 188415, 188416, 188410, 188400,
188298, 188299, 188321, 188342, 188343, 188355, 188357, 188361,
188366, 188374
This commit is contained in:
moneromooo-monero 2018-09-27 11:28:34 +00:00
parent 02563bf4b9
commit d8b1ec8b8b
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
1 changed files with 34 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
tests/unit_tests/mlocker.cpp
View File

@ -46,14 +46,14 @@ TEST(mlocker, distinct_1)
const size_t base_pages = epee::mlocker::get_num_locked_pages(); const size_t base_pages = epee::mlocker::get_num_locked_pages();
const size_t base_objects = epee::mlocker::get_num_locked_objects(); const size_t base_objects = epee::mlocker::get_num_locked_objects();
std::unique_ptr<char[]> data{new char[8 * page_size]}; std::unique_ptr<char[]> data{new char[8 * page_size]};
epee::mlocker *m0 = new epee::mlocker(BASE(data), 1); std::shared_ptr<epee::mlocker> m0{new epee::mlocker(BASE(data), 1)};
epee::mlocker *m1 = new epee::mlocker(BASE(data) + 2 * page_size, 1); std::shared_ptr<epee::mlocker> m1{new epee::mlocker(BASE(data) + 2 * page_size, 1)};
epee::mlocker *m2 = new epee::mlocker(BASE(data) + 3 * page_size, 1); std::shared_ptr<epee::mlocker> m2{new epee::mlocker(BASE(data) + 3 * page_size, 1)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 3); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 3);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 3); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 3);
delete m0; m0 = NULL;
delete m1; m1 = NULL;
delete m2; m2 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0);
} }
@ -65,14 +65,14 @@ TEST(mlocker, distinct_full_page)
const size_t base_pages = epee::mlocker::get_num_locked_pages(); const size_t base_pages = epee::mlocker::get_num_locked_pages();
const size_t base_objects = epee::mlocker::get_num_locked_objects(); const size_t base_objects = epee::mlocker::get_num_locked_objects();
std::unique_ptr<char[]> data{new char[8 * page_size]}; std::unique_ptr<char[]> data{new char[8 * page_size]};
epee::mlocker *m0 = new epee::mlocker(BASE(data), page_size); std::shared_ptr<epee::mlocker> m0{new epee::mlocker(BASE(data), page_size)};
epee::mlocker *m1 = new epee::mlocker(BASE(data) + 2 * page_size, page_size); std::shared_ptr<epee::mlocker> m1{new epee::mlocker(BASE(data) + 2 * page_size, page_size)};
epee::mlocker *m2 = new epee::mlocker(BASE(data) + 3 * page_size, page_size); std::shared_ptr<epee::mlocker> m2{new epee::mlocker(BASE(data) + 3 * page_size, page_size)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 3); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 3);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 3); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 3);
delete m0; m0 = NULL;
delete m1; m1 = NULL;
delete m2; m2 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0);
} }
@ -84,16 +84,16 @@ TEST(mlocker, identical)
const size_t base_pages = epee::mlocker::get_num_locked_pages(); const size_t base_pages = epee::mlocker::get_num_locked_pages();
const size_t base_objects = epee::mlocker::get_num_locked_objects(); const size_t base_objects = epee::mlocker::get_num_locked_objects();
std::unique_ptr<char[]> data{new char[8 * page_size]}; std::unique_ptr<char[]> data{new char[8 * page_size]};
epee::mlocker *m0 = new epee::mlocker(BASE(data) + page_size, 32); std::shared_ptr<epee::mlocker> m0{new epee::mlocker(BASE(data) + page_size, 32)};
epee::mlocker *m1 = new epee::mlocker(BASE(data) + page_size, 32); std::shared_ptr<epee::mlocker> m1{new epee::mlocker(BASE(data) + page_size, 32)};
epee::mlocker *m2 = new epee::mlocker(BASE(data) + page_size, 32); std::shared_ptr<epee::mlocker> m2{new epee::mlocker(BASE(data) + page_size, 32)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 3); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 3);
delete m1; m1 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 2); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 2);
delete m0; m0 = NULL;
delete m2; m2 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0);
} }
@ -105,16 +105,16 @@ TEST(mlocker, overlapping_small)
const size_t base_pages = epee::mlocker::get_num_locked_pages(); const size_t base_pages = epee::mlocker::get_num_locked_pages();
const size_t base_objects = epee::mlocker::get_num_locked_objects(); const size_t base_objects = epee::mlocker::get_num_locked_objects();
std::unique_ptr<char[]> data{new char[8 * page_size]}; std::unique_ptr<char[]> data{new char[8 * page_size]};
epee::mlocker *m0 = new epee::mlocker(BASE(data), 32); std::shared_ptr<epee::mlocker> m0{new epee::mlocker(BASE(data), 32)};
epee::mlocker *m1 = new epee::mlocker(BASE(data) + 16, 32); std::shared_ptr<epee::mlocker> m1{new epee::mlocker(BASE(data) + 16, 32)};
epee::mlocker *m2 = new epee::mlocker(BASE(data) + 8, 32); std::shared_ptr<epee::mlocker> m2{new epee::mlocker(BASE(data) + 8, 32)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 3); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 3);
delete m1; m1 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 2); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 2);
delete m2; m2 = NULL;
delete m0; m0 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0);
} }
@ -126,16 +126,16 @@ TEST(mlocker, multi_page)
const size_t base_pages = epee::mlocker::get_num_locked_pages(); const size_t base_pages = epee::mlocker::get_num_locked_pages();
const size_t base_objects = epee::mlocker::get_num_locked_objects(); const size_t base_objects = epee::mlocker::get_num_locked_objects();
std::unique_ptr<char[]> data{new char[8 * page_size]}; std::unique_ptr<char[]> data{new char[8 * page_size]};
epee::mlocker *m0 = new epee::mlocker(BASE(data) + page_size, page_size * 3); std::shared_ptr<epee::mlocker> m0{new epee::mlocker(BASE(data) + page_size, page_size * 3)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 3); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 3);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1);
epee::mlocker *m1 = new epee::mlocker(BASE(data) + page_size * 7, page_size); std::shared_ptr<epee::mlocker> m1{new epee::mlocker(BASE(data) + page_size * 7, page_size)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 4); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 4);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 2); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 2);
delete m0; m0 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1);
delete m1; m1 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0);
} }
@ -147,10 +147,10 @@ TEST(mlocker, cross_page)
const size_t base_pages = epee::mlocker::get_num_locked_pages(); const size_t base_pages = epee::mlocker::get_num_locked_pages();
const size_t base_objects = epee::mlocker::get_num_locked_objects(); const size_t base_objects = epee::mlocker::get_num_locked_objects();
std::unique_ptr<char[]> data{new char[2 * page_size]}; std::unique_ptr<char[]> data{new char[2 * page_size]};
epee::mlocker *m0 = new epee::mlocker(BASE(data) + page_size - 1, 2); std::shared_ptr<epee::mlocker> m0{new epee::mlocker(BASE(data) + page_size - 1, 2)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 2); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 2);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1);
delete m0; m0 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0);
} }
@ -163,16 +163,16 @@ TEST(mlocker, redundant)
std::unique_ptr<char[]> data{new char[2 * page_size]}; std::unique_ptr<char[]> data{new char[2 * page_size]};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0);
epee::mlocker *m0 = new epee::mlocker(BASE(data), 32); std::shared_ptr<epee::mlocker> m0{new epee::mlocker(BASE(data), 32)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1);
epee::mlocker *m1 = new epee::mlocker(BASE(data), 32); std::shared_ptr<epee::mlocker> m1{new epee::mlocker(BASE(data), 32)};
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 2); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 2);
delete m1; m1 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 1);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 1);
delete m0; m0 = NULL;
ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0); ASSERT_EQ(epee::mlocker::get_num_locked_pages(), base_pages + 0);
ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0); ASSERT_EQ(epee::mlocker::get_num_locked_objects(), base_objects + 0);
} }