nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tx_pool: initialize bitflags padding since it gets written to storage

Browse Source 
Avoids valgrind reporting uninitialized data usage
This commit is contained in:
moneromooo-monero 2018-06-05 19:59:45 +01:00
parent 8a7b3ff138
commit d81e042306
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/blockchain_db/blockchain_db.h
View File

@ -148,6 +148,7 @@ struct txpool_tx_meta_t
uint8_t relayed; uint8_t relayed;
uint8_t do_not_relay; uint8_t do_not_relay;
uint8_t double_spend_seen: 1; uint8_t double_spend_seen: 1;
uint8_t bf_padding: 7;
uint8_t padding[76]; // till 192 bytes uint8_t padding[76]; // till 192 bytes
}; };

2
src/cryptonote_core/tx_pool.cpp
View File

@ -239,6 +239,7 @@ namespace cryptonote
meta.relayed = relayed; meta.relayed = relayed;
meta.do_not_relay = do_not_relay; meta.do_not_relay = do_not_relay;
meta.double_spend_seen = have_tx_keyimges_as_spent(tx); meta.double_spend_seen = have_tx_keyimges_as_spent(tx);
meta.bf_padding = 0;
memset(meta.padding, 0, sizeof(meta.padding)); memset(meta.padding, 0, sizeof(meta.padding));
try try
{ {
@ -278,6 +279,7 @@ namespace cryptonote
meta.relayed = relayed; meta.relayed = relayed;
meta.do_not_relay = do_not_relay; meta.do_not_relay = do_not_relay;
meta.double_spend_seen = false; meta.double_spend_seen = false;
meta.bf_padding = 0;
memset(meta.padding, 0, sizeof(meta.padding)); memset(meta.padding, 0, sizeof(meta.padding));
try try