nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4803

Browse Source 
fa3f756b unit_tests: fix leak when the test check fails (moneromooo-monero)
This commit is contained in:
Riccardo Spagni 2018-11-16 11:15:15 +02:00
commit afaff5fb77
No known key found for this signature in database
GPG Key ID: 55432DF31CCD4FCD
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit_tests/notify.cpp
View File

@ -49,7 +49,8 @@ TEST(notify, works)
tmp = "/tmp"; tmp = "/tmp";
static const char *filename = "monero-notify-unit-test-XXXXXX"; static const char *filename = "monero-notify-unit-test-XXXXXX";
const size_t len = strlen(tmp) + 1 + strlen(filename); const size_t len = strlen(tmp) + 1 + strlen(filename);
char *name_template = (char*)malloc(len + 1); std::unique_ptr<char[]> name_template_((char*)malloc(len + 1));
char *name_template = name_template_.get();
ASSERT_TRUE(name_template != NULL); ASSERT_TRUE(name_template != NULL);
snprintf(name_template, len + 1, "%s/%s", tmp, filename); snprintf(name_template, len + 1, "%s/%s", tmp, filename);
int fd = mkstemp(name_template); int fd = mkstemp(name_template);
@ -75,5 +76,4 @@ TEST(notify, works)
ASSERT_TRUE(s == "1111111111111111111111111111111111111111111111111111111111111111"); ASSERT_TRUE(s == "1111111111111111111111111111111111111111111111111111111111111111");
boost::filesystem::remove(name_template); boost::filesystem::remove(name_template);
free(name_template);
} }