Merge pull request #2694

11e0deef cmake: add dep of version lib on version.cpp (redfish)
35340259 .gitignore: do not ignore cmake source files (redfish)

.gitignore

@@ -61,7 +61,6 @@ CMakeCache.txt
 CMakeFiles
 cmake_install.cmake
 install_manifest.txt
-*.cmake
 
 ### Linux ###
 *~

CMakeLists.txt

@@ -703,8 +703,6 @@ if(CMAKE_C_COMPILER_ID STREQUAL "Clang" AND ARCH_WIDTH EQUAL "32" AND NOT IOS)
   list(APPEND EXTRA_LIBRARIES ${ATOMIC})
 endif()
 
-include(version.cmake)
-
 find_path(ZMQ_INCLUDE_PATH zmq.hpp)
 find_library(ZMQ_LIB zmq)
 find_library(PGM_LIBRARY pgm)

cmake/Version.cmake

@@ -41,7 +41,7 @@ elseif (GIT_FOUND OR Git_FOUND)
     COMMAND           "${CMAKE_COMMAND}"
                       "-D" "GIT=${GIT_EXECUTABLE}"
                       "-D" "TO=${CMAKE_BINARY_DIR}/version.cpp"
-                      "-P" "src/version.cmake"
+                      "-P" "cmake/GenVersion.cmake"
     BYPRODUCTS        "${CMAKE_BINARY_DIR}/version.cpp"
     WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}")
 else()

src/CMakeLists.txt

@@ -83,26 +83,30 @@ function (monero_add_executable name)
 endfunction ()
 
 function (monero_add_library name)
-  source_group("${name}"
+    monero_add_library_with_deps(NAME "${name}" SOURCES ${ARGN})
-    FILES
+endfunction()
-      ${ARGN})
+
+function (monero_add_library_with_deps)
+  cmake_parse_arguments(MONERO_ADD_LIBRARY "" "NAME" "DEPENDS;SOURCES" ${ARGN})
+  source_group("${MONERO_ADD_LIBRARY_NAME}" FILES ${MONERO_ADD_LIBRARY_SOURCES})
 
   # Define a ("virtual") object library and an actual library that links those
   # objects together. The virtual libraries can be arbitrarily combined to link
   # any subset of objects into one library archive. This is used for releasing
   # libwallet, which combines multiple components.
-  set(objlib obj_${name})
+  set(objlib obj_${MONERO_ADD_LIBRARY_NAME})
-  add_library(${objlib} OBJECT ${ARGN})
+  add_library(${objlib} OBJECT ${MONERO_ADD_LIBRARY_SOURCES})
-  add_library("${name}" $<TARGET_OBJECTS:${objlib}>)
+  add_library("${MONERO_ADD_LIBRARY_NAME}" $<TARGET_OBJECTS:${objlib}>)
-  set_property(TARGET "${name}"
+  if (MONERO_ADD_LIBRARY_DEPENDS)
-    PROPERTY
+    add_dependencies(${objlib} ${MONERO_ADD_LIBRARY_DEPENDS})
-      FOLDER "libs")
+  endif()
+  set_property(TARGET "${MONERO_ADD_LIBRARY_NAME}" PROPERTY FOLDER "libs")
   target_compile_definitions(${objlib}
-    PRIVATE $<TARGET_PROPERTY:${name},INTERFACE_COMPILE_DEFINITIONS>)
+    PRIVATE $<TARGET_PROPERTY:${MONERO_ADD_LIBRARY_NAME},INTERFACE_COMPILE_DEFINITIONS>)
 endfunction ()
 
-set_source_files_properties(${CMAKE_BINARY_DIR}/version.cpp PROPERTIES GENERATED ON)
+include(Version)
-monero_add_library(version ${CMAKE_BINARY_DIR}/version.cpp)
+monero_add_library(version SOURCES ${CMAKE_BINARY_DIR}/version.cpp DEPENDS genversion)
 
 add_subdirectory(common)
 add_subdirectory(crypto)