From e1b097b99ba5005b9c3a0ec5a4499e3041eb8f7e Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Sun, 14 Apr 2019 09:21:09 +0000 Subject: [PATCH 1/2] core_rpc_server: remove dummy assigning int to bool Coverity 197653 --- src/rpc/core_rpc_server.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/rpc/core_rpc_server.cpp b/src/rpc/core_rpc_server.cpp index 71bfcc950..891b36499 100644 --- a/src/rpc/core_rpc_server.cpp +++ b/src/rpc/core_rpc_server.cpp @@ -1393,11 +1393,9 @@ namespace cryptonote submit_req.push_back(boost::value_initialized()); res.height = m_core.get_blockchain_storage().get_current_blockchain_height(); - bool r = CORE_RPC_STATUS_OK; - for(size_t i = 0; i < req.amount_of_blocks; i++) { - r = on_getblocktemplate(template_req, template_res, error_resp, ctx); + bool r = on_getblocktemplate(template_req, template_res, error_resp, ctx); res.status = template_res.status; template_req.prev_block.clear(); From b3648232869c35963a86210d8e60464f98a1e973 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Sun, 14 Apr 2019 09:24:52 +0000 Subject: [PATCH 2/2] daemon: fix ratio not being floating point Coverity 197648 --- src/daemon/rpc_command_executor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/daemon/rpc_command_executor.cpp b/src/daemon/rpc_command_executor.cpp index 5901be662..47c33b8f9 100644 --- a/src/daemon/rpc_command_executor.cpp +++ b/src/daemon/rpc_command_executor.cpp @@ -553,7 +553,7 @@ bool t_rpc_command_executor::mining_status() { if (!mining_busy && mres.active && mres.speed > 0 && mres.block_target > 0 && mres.difficulty > 0) { - double ratio = mres.speed * mres.block_target / mres.difficulty; + double ratio = mres.speed * mres.block_target / (double)mres.difficulty; uint64_t daily = 86400ull / mres.block_target * mres.block_reward * ratio; uint64_t monthly = 86400ull / mres.block_target * 30.5 * mres.block_reward * ratio; uint64_t yearly = 86400ull / mres.block_target * 356 * mres.block_reward * ratio;