nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wallet: store cache to file without unnecessary memory buffer

Browse Source
This commit is contained in:
moneromooo-monero 2015-12-29 15:46:37 +00:00
parent 90dbae918f
commit 61befc2293
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/wallet/wallet2.cpp
View File

@ -1282,16 +1282,18 @@ void wallet2::store()
crypto::chacha8(cache_file_data.cache_data.data(), cache_file_data.cache_data.size(), key, cache_file_data.iv, &cipher[0]); crypto::chacha8(cache_file_data.cache_data.data(), cache_file_data.cache_data.size(), key, cache_file_data.iv, &cipher[0]);
cache_file_data.cache_data = cipher; cache_file_data.cache_data = cipher;
std::string buf;
bool r = ::serialization::dump_binary(cache_file_data, buf);
THROW_WALLET_EXCEPTION_IF(!r, error::file_save_error, m_wallet_file);
// save to new file, rename main to old, rename new to main // save to new file, rename main to old, rename new to main
// at all times, there should be a valid file on disk // at all times, there should be a valid file on disk
const std::string new_file = m_wallet_file + ".new"; const std::string new_file = m_wallet_file + ".new";
const std::string old_file = m_wallet_file + ".old"; const std::string old_file = m_wallet_file + ".old";
r = epee::file_io_utils::save_string_to_file(new_file, buf);
THROW_WALLET_EXCEPTION_IF(!r, error::file_save_error, new_file); // save to new file
std::ofstream ostr(new_file);
binary_archive<true> oar(ostr);
bool success = ::serialization::serialize(oar, cache_file_data);
THROW_WALLET_EXCEPTION_IF(!success || !ostr.good(), error::file_save_error, new_file);
// rename
boost::filesystem::remove(old_file); // probably does not exist boost::filesystem::remove(old_file); // probably does not exist
if (boost::filesystem::exists(m_wallet_file)) { if (boost::filesystem::exists(m_wallet_file)) {
std::error_code e = tools::replace_file(m_wallet_file, old_file); std::error_code e = tools::replace_file(m_wallet_file, old_file);