nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

p2p: don't forget pruning seed or public RPC port when updating peers

Browse Source 
Older nodes don't pass that information around
This commit is contained in:
moneromooo-monero 2019-06-18 14:38:57 +00:00
parent 6335509727
commit 4237707d3e
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/p2p/net_peerlist.h
View File

@ -344,8 +344,14 @@ namespace nodetool
trim_white_peerlist(); trim_white_peerlist();
}else }else
{ {
//update record in white list //update record in white list
m_peers_white.replace(by_addr_it_wt, ple); peerlist_entry new_ple = ple;
if (by_addr_it_wt->pruning_seed && ple.pruning_seed == 0) // guard against older nodes not passing pruning info around
new_ple.pruning_seed = by_addr_it_wt->pruning_seed;
if (by_addr_it_wt->rpc_port && ple.rpc_port == 0) // guard against older nodes not passing RPC port around
new_ple.rpc_port = by_addr_it_wt->rpc_port;
new_ple.last_seen = by_addr_it_wt->last_seen; // do not overwrite the last seen timestamp, incoming peer list are untrusted
m_peers_white.replace(by_addr_it_wt, new_ple);
} }
//remove from gray list, if need //remove from gray list, if need
auto by_addr_it_gr = m_peers_gray.get<by_addr>().find(ple.adr); auto by_addr_it_gr = m_peers_gray.get<by_addr>().find(ple.adr);
@ -379,8 +385,14 @@ namespace nodetool
trim_gray_peerlist(); trim_gray_peerlist();
}else }else
{ {
//update record in white list //update record in gray list
m_peers_gray.replace(by_addr_it_gr, ple); peerlist_entry new_ple = ple;
if (by_addr_it_gr->pruning_seed && ple.pruning_seed == 0) // guard against older nodes not passing pruning info around
new_ple.pruning_seed = by_addr_it_gr->pruning_seed;
if (by_addr_it_gr->rpc_port && ple.rpc_port == 0) // guard against older nodes not passing RPC port around
new_ple.rpc_port = by_addr_it_gr->rpc_port;
new_ple.last_seen = by_addr_it_gr->last_seen; // do not overwrite the last seen timestamp, incoming peer list are untrusted
m_peers_gray.replace(by_addr_it_gr, new_ple);
} }
return true; return true;
CATCH_ENTRY_L0("peerlist_manager::append_with_peer_gray()", false); CATCH_ENTRY_L0("peerlist_manager::append_with_peer_gray()", false);