nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

p2p: fix race condition accessing a deleted context

Browse Source
This commit is contained in:
moneromooo-monero 2020-12-04 13:32:32 +00:00
parent f83203ecef
commit 281b42a281
No known key found for this signature in database
GPG Key ID: 686F07454D6CEFC3
3 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/p2p/net_node.h
View File

@ -287,7 +287,7 @@ namespace nodetool
uint32_t get_max_out_public_peers() const; uint32_t get_max_out_public_peers() const;
void change_max_in_public_peers(size_t count); void change_max_in_public_peers(size_t count);
uint32_t get_max_in_public_peers() const; uint32_t get_max_in_public_peers() const;
virtual bool block_host(const epee::net_utils::network_address &adress, time_t seconds = P2P_IP_BLOCKTIME); virtual bool block_host(epee::net_utils::network_address address, time_t seconds = P2P_IP_BLOCKTIME);
virtual bool unblock_host(const epee::net_utils::network_address &address); virtual bool unblock_host(const epee::net_utils::network_address &address);
virtual bool block_subnet(const epee::net_utils::ipv4_network_subnet &subnet, time_t seconds = P2P_IP_BLOCKTIME); virtual bool block_subnet(const epee::net_utils::ipv4_network_subnet &subnet, time_t seconds = P2P_IP_BLOCKTIME);
virtual bool unblock_subnet(const epee::net_utils::ipv4_network_subnet &subnet); virtual bool unblock_subnet(const epee::net_utils::ipv4_network_subnet &subnet);

16
src/p2p/net_node.inl
View File

@ -224,7 +224,7 @@ namespace nodetool
} }
//----------------------------------------------------------------------------------- //-----------------------------------------------------------------------------------
template<class t_payload_net_handler> template<class t_payload_net_handler>
bool node_server<t_payload_net_handler>::block_host(const epee::net_utils::network_address &addr, time_t seconds) bool node_server<t_payload_net_handler>::block_host(epee::net_utils::network_address addr, time_t seconds)
{ {
if(!addr.is_blockable()) if(!addr.is_blockable())
return false; return false;
@ -237,7 +237,8 @@ namespace nodetool
limit = std::numeric_limits<time_t>::max(); limit = std::numeric_limits<time_t>::max();
else else
limit = now + seconds; limit = now + seconds;
m_blocked_hosts[addr.host_str()] = limit; const std::string host_str = addr.host_str();
m_blocked_hosts[host_str] = limit;
// drop any connection to that address. This should only have to look into // drop any connection to that address. This should only have to look into
// the zone related to the connection, but really make sure everything is // the zone related to the connection, but really make sure everything is
@ -253,17 +254,18 @@ namespace nodetool
} }
return true; return true;
}); });
for (const auto &c: conns)
zone.second.m_net_server.get_config_object().close(c);
conns.clear();
peerlist_entry pe{}; peerlist_entry pe{};
pe.adr = addr; pe.adr = addr;
zone.second.m_peerlist.remove_from_peer_white(pe); zone.second.m_peerlist.remove_from_peer_white(pe);
for (const auto &c: conns)
zone.second.m_net_server.get_config_object().close(c);
conns.clear();
} }
MCLOG_CYAN(el::Level::Info, "global", "Host " << addr.host_str() << " blocked."); MCLOG_CYAN(el::Level::Info, "global", "Host " << host_str << " blocked.");
return true; return true;
} }
//----------------------------------------------------------------------------------- //-----------------------------------------------------------------------------------

4
src/p2p/net_node_common.h
View File

@ -58,7 +58,7 @@ namespace nodetool
virtual uint64_t get_public_connections_count()=0; virtual uint64_t get_public_connections_count()=0;
virtual void for_each_connection(std::function<bool(t_connection_context&, peerid_type, uint32_t)> f)=0; virtual void for_each_connection(std::function<bool(t_connection_context&, peerid_type, uint32_t)> f)=0;
virtual bool for_connection(const boost::uuids::uuid&, std::function<bool(t_connection_context&, peerid_type, uint32_t)> f)=0; virtual bool for_connection(const boost::uuids::uuid&, std::function<bool(t_connection_context&, peerid_type, uint32_t)> f)=0;
virtual bool block_host(const epee::net_utils::network_address &address, time_t seconds = 0)=0; virtual bool block_host(epee::net_utils::network_address address, time_t seconds = 0)=0;
virtual bool unblock_host(const epee::net_utils::network_address &address)=0; virtual bool unblock_host(const epee::net_utils::network_address &address)=0;
virtual std::map<std::string, time_t> get_blocked_hosts()=0; virtual std::map<std::string, time_t> get_blocked_hosts()=0;
virtual std::map<epee::net_utils::ipv4_network_subnet, time_t> get_blocked_subnets()=0; virtual std::map<epee::net_utils::ipv4_network_subnet, time_t> get_blocked_subnets()=0;
@ -108,7 +108,7 @@ namespace nodetool
{ {
return false; return false;
} }
virtual bool block_host(const epee::net_utils::network_address &address, time_t seconds) virtual bool block_host(epee::net_utils::network_address address, time_t seconds)
{ {
return true; return true;
} }