nihilist/monero
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1313

Browse Source 
1669621 wallet2_api: support for sweeping all (moneromooo-monero)
This commit is contained in:
Riccardo Spagni 2016-11-11 12:35:04 +02:00
commit 0e0bf432a4
No known key found for this signature in database
GPG Key ID: 55432DF31CCD4FCD
3 changed files with 33 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/wallet/api/wallet.cpp
View File

@ -540,15 +540,14 @@ int WalletImpl::autoRefreshInterval() const
// - unconfirmed_transfer_details; // - unconfirmed_transfer_details;
// - confirmed_transfer_details) // - confirmed_transfer_details)
PendingTransaction *WalletImpl::createTransaction(const string &dst_addr, const string &payment_id, uint64_t amount, uint32_t mixin_count, PendingTransaction *WalletImpl::createTransaction(const string &dst_addr, const string &payment_id, optional<uint64_t> amount, uint32_t mixin_count,
PendingTransaction::Priority priority) PendingTransaction::Priority priority)
{ {
clearStatus(); clearStatus();
// Pause refresh thread while creating transaction // Pause refresh thread while creating transaction
pauseRefresh(); pauseRefresh();
vector<cryptonote::tx_destination_entry> dsts; cryptonote::account_public_address addr;
cryptonote::tx_destination_entry de;
// indicates if dst_addr is integrated address (address + payment_id) // indicates if dst_addr is integrated address (address + payment_id)
bool has_payment_id; bool has_payment_id;
@ -561,7 +560,7 @@ PendingTransaction *WalletImpl::createTransaction(const string &dst_addr, const
PendingTransactionImpl * transaction = new PendingTransactionImpl(*this); PendingTransactionImpl * transaction = new PendingTransactionImpl(*this);
do { do {
if(!cryptonote::get_account_integrated_address_from_str(de.addr, has_payment_id, payment_id_short, m_wallet->testnet(), dst_addr)) { if(!cryptonote::get_account_integrated_address_from_str(addr, has_payment_id, payment_id_short, m_wallet->testnet(), dst_addr)) {
// TODO: copy-paste 'if treating as an address fails, try as url' from simplewallet.cpp:1982 // TODO: copy-paste 'if treating as an address fails, try as url' from simplewallet.cpp:1982
m_status = Status_Error; m_status = Status_Error;
m_errorString = "Invalid destination address"; m_errorString = "Invalid destination address";
@ -595,14 +594,23 @@ PendingTransaction *WalletImpl::createTransaction(const string &dst_addr, const
} }
} }
de.amount = amount;
dsts.push_back(de);
//std::vector<tools::wallet2::pending_tx> ptx_vector; //std::vector<tools::wallet2::pending_tx> ptx_vector;
try { try {
transaction->m_pending_tx = m_wallet->create_transactions_2(dsts, fake_outs_count, 0 /* unlock_time */, if (amount) {
static_cast<uint32_t>(priority), vector<cryptonote::tx_destination_entry> dsts;
extra, m_trustedDaemon); cryptonote::tx_destination_entry de;
de.addr = addr;
de.amount = *amount;
dsts.push_back(de);
transaction->m_pending_tx = m_wallet->create_transactions_2(dsts, fake_outs_count, 0 /* unlock_time */,
static_cast<uint32_t>(priority),
extra, m_trustedDaemon);
} else {
transaction->m_pending_tx = m_wallet->create_transactions_all(addr, fake_outs_count, 0 /* unlock_time */,
static_cast<uint32_t>(priority),
extra, m_trustedDaemon);
}
} catch (const tools::error::daemon_busy&) { } catch (const tools::error::daemon_busy&) {
// TODO: make it translatable with "tr"? // TODO: make it translatable with "tr"?

2
src/wallet/api/wallet.h
View File

@ -89,7 +89,7 @@ public:
PendingTransaction * createTransaction(const std::string &dst_addr, const std::string &payment_id, PendingTransaction * createTransaction(const std::string &dst_addr, const std::string &payment_id,
uint64_t amount, uint32_t mixin_count, optional<uint64_t> amount, uint32_t mixin_count,
PendingTransaction::Priority priority = PendingTransaction::Priority_Low); PendingTransaction::Priority priority = PendingTransaction::Priority_Low);
virtual PendingTransaction * createSweepUnmixableTransaction(); virtual PendingTransaction * createSweepUnmixableTransaction();

16
src/wallet/wallet2_api.h
View File

@ -41,6 +41,20 @@ namespace Bitmonero {
namespace Utils { namespace Utils {
bool isAddressLocal(const std::string &hostaddr); bool isAddressLocal(const std::string &hostaddr);
} }
template<typename T>
class optional {
public:
optional(): set(false) {}
optional(const T &t): t(t), set(true) {}
const T &operator*() const { return t; }
T &operator*() { return t; }
operator bool() const { return set; }
private:
T t;
bool set;
};
/** /**
* @brief Transaction-like interface for sending money * @brief Transaction-like interface for sending money
*/ */
@ -332,7 +346,7 @@ struct Wallet
*/ */
virtual PendingTransaction * createTransaction(const std::string &dst_addr, const std::string &payment_id, virtual PendingTransaction * createTransaction(const std::string &dst_addr, const std::string &payment_id,
uint64_t amount, uint32_t mixin_count, optional<uint64_t> amount, uint32_t mixin_count,
PendingTransaction::Priority = PendingTransaction::Priority_Low) = 0; PendingTransaction::Priority = PendingTransaction::Priority_Low) = 0;
/*! /*!