Commit Graph

22 Commits

Author SHA1 Message Date
Frank Wall
9ecd84080b resolve shellcheck offenses
With nsupdate the rule seems to be: filenames need to be wrapped
in double quotes, while all other options must not use double quotes.
Hence there is no way to resolve the shellcheck offense, because
the key requires quotes, but the other options must not use quotes.
2024-09-17 15:27:46 +02:00
Frank Wall
22d260f4e6 fix dns_nsupdate when NSUPDATE_OPT is empty, refs #5224 2024-09-16 16:49:28 +02:00
neil
adff28dade
Merge pull request #5224 from gmanic/master
Add optional cmd line parameter NSUPDATE_OPT to dns_nsupdate api
2024-09-13 14:13:40 +02:00
gmanic
bcb7e5f2c8
Update dns_nsupdate.sh
Corrected required variable double quote
2024-07-24 20:28:39 +00:00
Sergey Ponomarev
6b7b5caf54 DNS provider API: structured description
Instead of using comments declare info in a special variable.
Then the variable can be used to print the DNS API provider usage.
The usage can be parsed on UI and show all needed inputs for options.

The info is stored in plain string that it's both human-readable and easy to parse:

    dns_example_info='API name
     An extended description.
     Multiline.
    Domains: list of alternative domains to find
    Site: the dns provider website e.g. example.com
    Docs: Link to ACME.sh wiki for the provider
    Options:
     VARIABLE1 Title for the option1.
     VARIABLE2 Title for the option2. Default "default value".
     VARIABLE3 Title for the option3. Description to show on UI. Optional.
    Issues: Link to a support ticket on https://github.com/acmesh-official/acme.sh
    Author: First Lastname <authoremail@example.com>, Another Author <https://github.com/example>;
    '

Here:
VARIABLE1 will be required.
VARIABLE2 will be required too but will be populated with a "default value".
VARIABLE3 is optional and can be empty.

A DNS provider may have alternative options like CloudFlare may use API KEY or API Token.
You can use a second section OptionsAlt: section.

Some providers may have alternative names or domains e.g. Aliyun and AlibabaCloud.
Add them to Domains: section.

Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
2024-05-18 12:06:41 +03:00
gmanic
0b0476e196
Update dns_nsupdate.sh 2023-05-14 21:01:51 +00:00
gmanic
f99d6dac08
Push for actions 2023-05-14 20:58:48 +00:00
gmanic
cd2b7cd943
Correct Typo, add -n test
Added a test for non-zero-string, corrected type ZONE instead of OPT
2023-05-14 20:20:22 +00:00
gmanic
af759f2330
Enable additional command line parameters for nsupdate
For being able to use e.g. "-v" to use TCP communication with the NSUPDATE_SERVER -> NSUPDATE_OPT has been added.
NSUPDATE_OPT will be plainly added to the command line of nsupdate.
NSUPDATE_OPT will also be saved to conf respectively read from conf
2023-05-14 20:02:43 +00:00
Peter Dave Hello
ac9f6e3a41 Remove trailing spaces in text files
This issue in the shell scripts will also be detected in the stable
version of shfmt(we are currently using an ancient pre-release of shfmt)
2019-10-05 21:09:24 +08:00
neilpang
9c9fed749a fix https://github.com/Neilpang/acme.sh/issues/2225
make NSUPDATE_SERVER can be overwritten
2019-04-20 12:49:51 +08:00
Daniel F. Dickinson
1a77490969 dnsapi: Add option to set zone for nsupdate
Some DNS servers for which dns_nsupdate.sh is applicable (such
as dyn.com's 'Standard DNS' TSIG update mechanism), require that
the zone be set during the nsupdate transaction.  Therefore we
add a new environment variable NSUPDATE_ZONE which is used to
set the zone for the DNS TSIG transaction.

Signed-off-by: Daniel F. Dickinson <cshored@thecshore.com>
2018-12-13 01:55:43 -05:00
Daniel F. Dickinson
5431d05168 dnsapi nsupdate: Add nsupdate debug option
When debug is enabled, also use nsupdate's debug logging
so that the user can see potential issues with the nsupdate
transaction.

Signed-off-by: Daniel F. Dickinson <cshored@thecshore.com>
2018-12-13 01:55:00 -05:00
AlexeyStolyarov
75b9c39b0e
Update dns_nsupdate.sh 2018-04-05 14:50:55 +05:00
AlexeyStolyarov
5957a1068f
Update dns_nsupdate.sh 2018-04-05 14:45:15 +05:00
AlexeyStolyarov
ed817c81de
#issue with nsupdate on Ubuntu 14.04.1 LTS
on  Ubuntu 14.04.1 LTS if nsupdate runs without port number given it treated argument following server name as port number.
and throws error: 
```
port 'update' is not numeric
syntax error
```
2018-04-05 14:18:53 +05:00
klemens
329174b6d9 spelling fixes 2016-12-14 21:32:24 +01:00
neilpang
ac26f84170 fix shfmt 2016-11-16 22:53:59 +08:00
neilpang
fa574fe833 fix shfmt 2016-11-16 22:44:39 +08:00
Philippe Kueck
243593cdaa
fix warnings and remove unused ${tmp} variable 2016-11-14 14:06:30 +01:00
Philippe Kueck
54d61bdc4a
- get rid of bash-only syntax like ${foo:-bar}
- use sh instead of bash
- remove redundant functions _info, _err, _debug and _debug2
- get rid of mktemp, pipe commands directly to nsupdate
2016-10-26 16:14:47 +02:00
Philippe Kueck
0fb206fe15
add nsupdate script for dns-01 2016-10-26 11:52:26 +02:00